Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

Hi, On 5/30/2018 11:49 PM, Felipe Balbi wrote: > Paul Zimmerman writes: > >> Hi Felipe, >> >> Felipe Balbi writes: >> >> < snip > >> >>> thinking about this a little more. This extra list_empty() check is >>> not wrong at all :-) I've amended this series with the 3 patches >>> below. I'll

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

Hi, Paul Zimmerman writes: > Hi Felipe, > > Felipe Balbi writes: > > < snip > > >> thinking about this a little more. This extra list_empty() check is >> not wrong at all :-) I've amended this series with the 3 patches >> below. I'll resend the series once I've given more time for people to

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

Hi Felipe, Felipe Balbi writes: < snip > > thinking about this a little more. This extra list_empty() check is > not wrong at all :-) I've amended this series with the 3 patches > below. I'll resend the series once I've given more time for people to > test. Patches have been updated to the

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

Hi, Thinh Nguyen writes: >>> Maybe we should return the -EXDEV status every time there's a missed isoc. >> >> you mean like this? > > Yes, this will work. updated to branch -- balbi signature.asc Description: PGP signature

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

Hi, On 4/12/2018 12:18 AM, Felipe Balbi wrote: > > Hi, > > Thinh Nguyen writes: >> Hi, >> >> On 4/11/2018 1:21 AM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Felipe Balbi writes: >> Without XferNotReady, we won't have a reliable way to

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

Hi, Thinh Nguyen writes: > Hi, > > On 4/11/2018 1:21 AM, Felipe Balbi wrote: >> >> Hi, >> >> Felipe Balbi writes: > Without XferNotReady, we won't have a reliable way to know the uFrame > number. Read the Isochronous

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

Hi, On 4/11/2018 1:21 AM, Felipe Balbi wrote: > > Hi, > > Felipe Balbi writes: Without XferNotReady, we won't have a reliable way to know the uFrame number. Read the Isochronous programming sequence from your databook. >>> >>> Right. We need XferNotReady

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

Hi, Felipe Balbi writes: >>> Without XferNotReady, we won't have a reliable way to know the uFrame >>> number. Read the Isochronous programming sequence from your databook. >> >> Right. We need XferNotReady to know when to start isoc transfer. But if >> there are

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

Hi, Thinh Nguyen writes: >>> On 4/9/2018 4:28 AM, Felipe Balbi wrote: In case we get an event with status set to Missed Isoc, this means we have missed an isochronous interval and should issue End Transfer command and wait for the following

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

Hi, On 4/10/2018 12:36 AM, Felipe Balbi wrote: > > Hi, > > Thinh Nguyen writes: >> Hi Felipe, >> >> On 4/9/2018 4:28 AM, Felipe Balbi wrote: >>> In case we get an event with status set to Missed Isoc, this means we >>> have missed an isochronous interval and should

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

Hi, Thinh Nguyen writes: > Hi Felipe, > > On 4/9/2018 4:28 AM, Felipe Balbi wrote: >> In case we get an event with status set to Missed Isoc, this means we >> have missed an isochronous interval and should issue End Transfer >> command and wait for the following

Re: [RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

Hi Felipe, On 4/9/2018 4:28 AM, Felipe Balbi wrote: > In case we get an event with status set to Missed Isoc, this means we > have missed an isochronous interval and should issue End Transfer > command and wait for the following XferNotReady. Why does DWC3 need to issue End Transfer if there are

[RFT/PATCH 18/38] usb: dwc3: gadget: check for Missed Isoc from event status

In case we get an event with status set to Missed Isoc, this means we have missed an isochronous interval and should issue End Transfer command and wait for the following XferNotReady. Let's do that early, rather than late. Signed-off-by: Felipe Balbi ---