Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial Adapters

On Thu, Aug 16, 2018 at 01:28:54AM -0700, Patong Yang wrote: > On Thu, Aug 16, 2018 at 08:34:47AM +0200, Greg KH wrote: > > On Wed, Aug 15, 2018 at 10:56:47PM -0700, Patong Yang wrote: > > > Greg, > > > > > > Please see my response inline below. > > > > > > Patong > > > > > > > But there is a

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial Adapters

On Do, 2018-08-16 at 01:28 -0700, Patong Yang wrote: > Features not supported by the cdc-acm driver are > enabling/disabling flow control, enabling/disabling RS-485 mode, > GPIOs and GPIO modes, etc. Support for these features had to be added in this > new driver. Hi, I am afraid RS-485 in

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial Adapters

On Thu, Aug 16, 2018 at 08:34:47AM +0200, Greg KH wrote: > On Wed, Aug 15, 2018 at 10:56:47PM -0700, Patong Yang wrote: > > Greg, > > > > Please see my response inline below. > > > > Patong > > > > > But there is a bigger problem here: > > > > > > > + xrusb_tty_driver =

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial Adapters

On Wed, Aug 15, 2018 at 10:56:47PM -0700, Patong Yang wrote: > Greg, > > Please see my response inline below. > > Patong > > > But there is a bigger problem here: > > > > > + xrusb_tty_driver = alloc_tty_driver(XRUSB_TTY_MINORS); > > > + if (!xrusb_tty_driver) > > > + return -ENOMEM; >

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial Adapters

On Tue, Jul 24, 2018 at 03:36:36PM -0700, Patong Yang wrote: > The original driver/patch was submitted on April 4, 2018. This is the > second version based on the feedback received on the original patch. > > v2: Removed custom IOCTLs, as suggested by Greg KH > Using standard Linux GPIO APIs,

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial Adapters

On Di, 2018-07-24 at 15:36 -0700, Patong Yang wrote: > +static int xrusb_ctrl_msg(struct xrusb *xrusb, > + int request, int value, void *buf, int len) > +{ > + int rv = usb_control_msg(xrusb->dev, > + usb_sndctrlpipe(xrusb->dev, 0), > + request, > +

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial adapters.

On Thu, Apr 05, 2018 at 08:42:57PM -0700, Patong Yang wrote: > On Wed, Apr 4, 2018 at 11:26 PM, Greg KH wrote: > > > This same customer is designing a new board to support the same > transceiver > > > configurations. Instead of using the BIOS settings, they would like

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial adapters.

Am Donnerstag, den 05.04.2018, 08:26 +0200 schrieb Greg KH: > > The USB device can describe itself properly.  The SMBIOS function is a > > requirement from our customer who designed a board using our device where > > their CPU reads from a specific BIOS location and initializes GPIOs based > > on

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial adapters.

On Wed, Apr 04, 2018 at 12:03:51PM -0700, Patong Yang wrote: > Thanks for the quick reply and feedback. This needs to be a different > driver because although the USB UARTs can work with the CDC-ACM driver, > there are limitations in the CDC-ACM spec and therefore the driver that > prevents it

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial adapters.

On Wed, Apr 04, 2018 at 12:06:34AM -0700, Patong Yang wrote: > - When specific IOCTLs are called by a user-space application, a > port_config file is created for the /dev/ttyXRUSB device at a > specific USB tree location, and some configuration data is stored. > The driver checks for the

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial adapters.

On Wed, Apr 04, 2018 at 12:06:34AM -0700, Patong Yang wrote: > The driver is based on the CDC-ACM driver. In addition to supporting > the features of the MaxLinear/Exar USB UART devices, the driver also > has support for 2 other functions per customer requirements: > > - Specific entries are

Re: [PATCH] Driver for MaxLinear/Exar USB (UART) Serial adapters.

Am Mittwoch, den 04.04.2018, 00:06 -0700 schrieb Patong Yang: > The driver is based on the CDC-ACM driver. In addition to supporting > the features of the MaxLinear/Exar USB UART devices, the driver also Hi, it is rather drastic a measure to duplicate a driver just for a low number of devices.