Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

Just make it an int. The caller also casts it to u32... regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

Hello. On 12/19/2015 11:15 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Sat, 19 Dec 2015 21:10:20 +0100 The return type "u32" was used by the fhci_create_ep() function even though it will eventually return a negative error code. Improve this

Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

On Sat, Dec 19, 2015 at 09:55:02PM +0100, SF Markus Elfring wrote: > > Just make it an int. > > Thanks for your suggestion. > > Will any more software developers prefer this data type > at some source code places? > Use s32 if the hardware spec specifies that you must. Otherwise prefer

Re: [PATCH] USB-FHCI: Use a signed return type for fhci_create_ep()

> Just make it an int. Thanks for your suggestion. Will any more software developers prefer this data type at some source code places? > The caller also casts it to u32... Do you want to get rid of similar casts in affected functions? Regards, Markus -- To unsubscribe from this list: send