Re: [PATCH] usb: increase ohci watchdog delay to 275 msec

[Bryan Paluch]

My Apologies, I never saw my original patch hit the linux-usb mailing
list either, I suspect it may have not been all plain text. (I did not
get a rejection message though). I will resend the original to
linux-usb.

On Mon, Oct 17, 2016 at 5:49 AM, Greg KH  wrote:
> On Sun, Oct 16, 2016 at 10:54:34AM -0400, Alan Stern wrote:
>> On Sat, 15 Oct 2016, Bryan Paluch wrote:
>>
>> > Increase ohci watchout delay to 275 ms. Previous delay was 250 ms
>> > with 20 ms of slack, after removing slack time some ohci controllers don't
>> > respond in time. Logs from systems with controllers that have the
>> > issue would show "HcDoneHead not written back; disabled"
>> >
>> > Signed-off-by: Bryan Paluch 
>> > ---
>> > Reported and discussed:
>> > https://lkml.kernel.org/r/<
>> > pine.lnx.4.44l0.1610151100250.29083-100...@netrider.rowland.org>
>> >  drivers/usb/host/ohci-hcd.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
>> > index 1700908..86612ac 100644
>> > --- a/drivers/usb/host/ohci-hcd.c
>> > +++ b/drivers/usb/host/ohci-hcd.c
>> > @@ -72,7 +72,7 @@
>> >  static const char  hcd_name [] = "ohci_hcd";
>> >
>> >  #defineSTATECHANGE_DELAY   msecs_to_jiffies(300)
>> > -#defineIO_WATCHDOG_DELAY   msecs_to_jiffies(250)
>> > +#defineIO_WATCHDOG_DELAY   msecs_to_jiffies(275)
>> >
>> >  #include "ohci.h"
>> >  #include "pci-quirks.h"
>>
>> Acked-by: Alan Stern 
>>
>> Greg, this should be marked for -stable; the problem was apparently
>> introduced between 4.7 and 4.8.
>
> Ok, I would, but I don't see this patch in my inbox anywhere, was it
> posted publicly?
>
> confused,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: increase ohci watchdog delay to 275 msec

[Greg KH]

On Sun, Oct 16, 2016 at 10:54:34AM -0400, Alan Stern wrote:
> On Sat, 15 Oct 2016, Bryan Paluch wrote:
> 
> > Increase ohci watchout delay to 275 ms. Previous delay was 250 ms
> > with 20 ms of slack, after removing slack time some ohci controllers don't
> > respond in time. Logs from systems with controllers that have the
> > issue would show "HcDoneHead not written back; disabled"
> > 
> > Signed-off-by: Bryan Paluch 
> > ---
> > Reported and discussed:
> > https://lkml.kernel.org/r/<
> > pine.lnx.4.44l0.1610151100250.29083-100...@netrider.rowland.org>
> >  drivers/usb/host/ohci-hcd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
> > index 1700908..86612ac 100644
> > --- a/drivers/usb/host/ohci-hcd.c
> > +++ b/drivers/usb/host/ohci-hcd.c
> > @@ -72,7 +72,7 @@
> >  static const char  hcd_name [] = "ohci_hcd";
> > 
> >  #defineSTATECHANGE_DELAY   msecs_to_jiffies(300)
> > -#defineIO_WATCHDOG_DELAY   msecs_to_jiffies(250)
> > +#defineIO_WATCHDOG_DELAY   msecs_to_jiffies(275)
> > 
> >  #include "ohci.h"
> >  #include "pci-quirks.h"
> 
> Acked-by: Alan Stern 
> 
> Greg, this should be marked for -stable; the problem was apparently
> introduced between 4.7 and 4.8.

Ok, I would, but I don't see this patch in my inbox anywhere, was it
posted publicly?

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: increase ohci watchdog delay to 275 msec

[Alan Stern]

On Sat, 15 Oct 2016, Bryan Paluch wrote:

> Increase ohci watchout delay to 275 ms. Previous delay was 250 ms
> with 20 ms of slack, after removing slack time some ohci controllers don't
> respond in time. Logs from systems with controllers that have the
> issue would show "HcDoneHead not written back; disabled"
> 
> Signed-off-by: Bryan Paluch 
> ---
> Reported and discussed:
> https://lkml.kernel.org/r/<
> pine.lnx.4.44l0.1610151100250.29083-100...@netrider.rowland.org>
>  drivers/usb/host/ohci-hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c
> index 1700908..86612ac 100644
> --- a/drivers/usb/host/ohci-hcd.c
> +++ b/drivers/usb/host/ohci-hcd.c
> @@ -72,7 +72,7 @@
>  static const char  hcd_name [] = "ohci_hcd";
> 
>  #defineSTATECHANGE_DELAY   msecs_to_jiffies(300)
> -#defineIO_WATCHDOG_DELAY   msecs_to_jiffies(250)
> +#defineIO_WATCHDOG_DELAY   msecs_to_jiffies(275)
> 
>  #include "ohci.h"
>  #include "pci-quirks.h"

Acked-by: Alan Stern 

Greg, this should be marked for -stable; the problem was apparently
introduced between 4.7 and 4.8.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html