Re: [PATCH] usb: typec: ucsi: fix tracepoint related build error

2018-04-10 Thread Tobias Regnery
On 09.04.18, Tobias Regnery wrote: > On 09.04.18, Heikki Krogerus wrote: > > On Mon, Apr 09, 2018 at 09:55:17AM +0200, Tobias Regnery wrote: > > > The ucsi driver defines several tracepoints, but the header file with the > > > tracepoint definition trace.h is only conditionally built depending on

Re: [PATCH] usb: typec: ucsi: fix tracepoint related build error

2018-04-10 Thread Heikki Krogerus
Hi Tobias, On Mon, Apr 09, 2018 at 01:40:53PM +0200, Tobias Regnery wrote: > You are right, building a defconfig, enable the UCSI driver and disable > CONFIG_FTRACE indeed builds without problems. So it must be some other > combination of config options. Attached is the randconfig which triggers

Re: [PATCH] usb: typec: ucsi: fix tracepoint related build error

2018-04-09 Thread Tobias Regnery
On 09.04.18, Heikki Krogerus wrote: > On Mon, Apr 09, 2018 at 09:55:17AM +0200, Tobias Regnery wrote: > > The ucsi driver defines several tracepoints, but the header file with the > > tracepoint definition trace.h is only conditionally built depending on > > CONFIG_FTRACE. > > You mean trace.c,

Re: [PATCH] usb: typec: ucsi: fix tracepoint related build error

2018-04-09 Thread Heikki Krogerus
On Mon, Apr 09, 2018 at 09:55:17AM +0200, Tobias Regnery wrote: > The ucsi driver defines several tracepoints, but the header file with the > tracepoint definition trace.h is only conditionally built depending on > CONFIG_FTRACE. You mean trace.c, right? The definitions are indeed in the header,