Re: [PATCH 0/2] Allow xhci-plat using a second clock
Hi Mathias, On jeu., avril 19 2018, Mathias Nyman wrote: > On 18.04.2018 17:20, Gregory CLEMENT wrote: >> Hi Mathias, >> On mer., févr. 14 2018, Gregory CLEMENT >> wrote: >> >>> Hello, >>> >>> The purpose of this series is to allow xhci-plat using a second >>> clock. It is needed on the Armada 7K/8K but could be used by other >>> SoCs. >>> >>> The first patch is just a fix found while I was working on this >>> feature. >> >> I've just realized that this series sent 2 months ago was not merged in >> v4.17. The issue is that now the USB support on the Armada 7K/8K is >> broken, because the clock support part was already merged. >> >> You already had a look on this series one month ago. The issue you had >> was about getting an approval for the extension of the binding [1]. I >> pinged Rob about it [2] one month ago but we didn't get any >> feedback. However, Rob already approved the similar changes I introduced >> in an other for mv_xor_v2: [3]. >> >> So would it be possible to apply this series on v4.17-rc ? > > Patch 2/2 no longer applies due to clk suspend/resume changes in: > > commit d56e57ca030c8b4296944a2ae61ac167bf979c07 > usb: host: xhci-plat: revert "usb: host: xhci-plat: enable clk in resume > timing" > > Not sure how that change affects Armada 7K/8K > Can you rebase and resend the series? It's done! About the suspend/resume part it does not affect Armada 7K/8K because we don't support it yet. However I am a bit surprised by the commit log because reverting a common part because of a specific implementation looks wrong. I expect issues when we will add PM support but we will see that later. Gregory > > -Mathias > -- Gregory Clement, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] Allow xhci-plat using a second clock
On 18.04.2018 17:20, Gregory CLEMENT wrote: Hi Mathias, On mer., févr. 14 2018, Gregory CLEMENT wrote: Hello, The purpose of this series is to allow xhci-plat using a second clock. It is needed on the Armada 7K/8K but could be used by other SoCs. The first patch is just a fix found while I was working on this feature. I've just realized that this series sent 2 months ago was not merged in v4.17. The issue is that now the USB support on the Armada 7K/8K is broken, because the clock support part was already merged. You already had a look on this series one month ago. The issue you had was about getting an approval for the extension of the binding [1]. I pinged Rob about it [2] one month ago but we didn't get any feedback. However, Rob already approved the similar changes I introduced in an other for mv_xor_v2: [3]. So would it be possible to apply this series on v4.17-rc ? Patch 2/2 no longer applies due to clk suspend/resume changes in: commit d56e57ca030c8b4296944a2ae61ac167bf979c07 usb: host: xhci-plat: revert "usb: host: xhci-plat: enable clk in resume timing" Not sure how that change affects Armada 7K/8K Can you rebase and resend the series? -Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] Allow xhci-plat using a second clock
Hi Mathias, On mer., févr. 14 2018, Gregory CLEMENT wrote: > Hello, > > The purpose of this series is to allow xhci-plat using a second > clock. It is needed on the Armada 7K/8K but could be used by other > SoCs. > > The first patch is just a fix found while I was working on this > feature. I've just realized that this series sent 2 months ago was not merged in v4.17. The issue is that now the USB support on the Armada 7K/8K is broken, because the clock support part was already merged. You already had a look on this series one month ago. The issue you had was about getting an approval for the extension of the binding [1]. I pinged Rob about it [2] one month ago but we didn't get any feedback. However, Rob already approved the similar changes I introduced in an other for mv_xor_v2: [3]. So would it be possible to apply this series on v4.17-rc ? Thanks, Gregory [1]: http://lists.infradead.org/pipermail/linux-arm-kernel/2018-February/562739.html [2]: http://lists.infradead.org/pipermail/linux-arm-kernel/2018-March/566076.html [3]: http://lists.infradead.org/pipermail/linux-arm-kernel/2018-March/564594.html > > Thanks, > > Gregory > > > Gregory CLEMENT (2): > usb: host: xhci-plat: Remove useless test before clk_disable_unprepare > usb: host: xhci-plat: Fix clock resource by adding a register clock > > Documentation/devicetree/bindings/usb/usb-xhci.txt | 5 ++- > drivers/usb/host/xhci-plat.c | 39 > -- > drivers/usb/host/xhci.h| 3 +- > 3 files changed, 35 insertions(+), 12 deletions(-) > > -- > 2.15.1 > > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] Allow xhci-plat using a second clock
Hi Mathias, On mer., févr. 14 2018, Gregory CLEMENT wrote: > Hello, > > The purpose of this series is to allow xhci-plat using a second > clock. It is needed on the Armada 7K/8K but could be used by other > SoCs. Do you have some comments on this series and especially on the second patch? Thanks, Gregory > > The first patch is just a fix found while I was working on this > feature. > > Thanks, > > Gregory > > > Gregory CLEMENT (2): > usb: host: xhci-plat: Remove useless test before clk_disable_unprepare > usb: host: xhci-plat: Fix clock resource by adding a register clock > > Documentation/devicetree/bindings/usb/usb-xhci.txt | 5 ++- > drivers/usb/host/xhci-plat.c | 39 > -- > drivers/usb/host/xhci.h| 3 +- > 3 files changed, 35 insertions(+), 12 deletions(-) > > -- > 2.15.1 > -- Gregory Clement, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
