Re: [PATCH 2/2] net: asix: Move declaration of ax88172a_info to shared header

2013-08-09 Thread Fabio Estevam
On Fri, Aug 9, 2013 at 2:31 PM, Mark Brown broo...@kernel.org wrote: From: Mark Brown broo...@linaro.org Ensure that the definition of ax88172a_info matches the declaration seen by users and silence sparse warnings about symbols without declarations in the global namespace by moving the

Re: [PATCH 2/2] net: asix: Move declaration of ax88172a_info to shared header

2013-08-09 Thread Stephen Hemminger
On Fri, 9 Aug 2013 14:39:06 -0300 Fabio Estevam feste...@gmail.com wrote: On Fri, Aug 9, 2013 at 2:31 PM, Mark Brown broo...@kernel.org wrote: From: Mark Brown broo...@linaro.org Ensure that the definition of ax88172a_info matches the declaration seen by users and silence sparse warnings

Re: [PATCH 2/2] net: asix: Move declaration of ax88172a_info to shared header

2013-08-09 Thread Eric Dumazet
On Fri, 2013-08-09 at 10:40 -0700, Stephen Hemminger wrote: On Fri, 9 Aug 2013 14:39:06 -0300 Fabio Estevam feste...@gmail.com wrote: On Fri, Aug 9, 2013 at 2:31 PM, Mark Brown broo...@kernel.org wrote: From: Mark Brown broo...@linaro.org Ensure that the definition of ax88172a_info

Re: [PATCH 2/2] net: asix: Move declaration of ax88172a_info to shared header

2013-08-09 Thread Fabio Estevam
On Fri, Aug 9, 2013 at 2:40 PM, Stephen Hemminger step...@networkplumber.org wrote: +extern const struct driver_info ax88172a_info; You could drop the 'extern' here. All other function prototypes in this header file do not use 'extern'. That is data, not function prototype, so yes extern

Re: [PATCH 2/2] net: asix: Move declaration of ax88172a_info to shared header

2013-08-09 Thread David Miller
From: Eric Dumazet eric.duma...@gmail.com Date: Fri, 09 Aug 2013 10:50:36 -0700 Some compiler folk decided 'extern' were not mandatory for code, but its really adding confusion and endless discussions. I certainly stopped talking about it, you could too :-) -- To unsubscribe from this list: