Re: [PATCH 2/5] arm: dts: am33xx: add USB phy nodes

2013-07-25 Thread Felipe Balbi 
On Fri, Jul 05, 2013 at 04:56:17PM +0200, Sebastian Andrzej Siewior wrote:
 On 07/05/2013 04:41 PM, Ruchika Kharwar wrote:
  
  On 07/05/2013 08:32 AM, Sebastian Andrzej Siewior wrote:
  The memory address contains three pieces that is the reset module which
  is currently the only one used and two other pices which seem
  interresting based on what the register.
  Please fix typos pices.. interresting.. also the description is not
  clear.
 
 Okay. What part is not clear?

Well, this statement:

... which seem interresting based on what the register.

seems like it misses something. based on what register
\(does\|is\|implements\) ???

-- 
balbi


signature.asc
Description: Digital signature

Re: [PATCH 2/5] arm: dts: am33xx: add USB phy nodes

2013-07-05 Thread Ruchika Kharwar 


On 07/05/2013 08:32 AM, Sebastian Andrzej Siewior wrote:

The memory address contains three pieces that is the reset module which
is currently the only one used and two other pices which seem
interresting based on what the register.

Please fix typos pices.. interresting.. also the description is not clear.

The phy id (0 or 1) can be obtained via of_alias_get_id(). However once
we need this, we should used something for common register access.




Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
  arch/arm/boot/dts/am33xx.dtsi | 16 
  1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 0d4df90..a24f1cb 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -333,6 +333,22 @@
status = disabled;
};
  
+		musb0_phy: phy0@47401000 {

+   compatible = ti,am335x-usb-phy;
+   reg = 0x44e10620 0x2c   /* reset module */
+   0x47401000 0x200
+   0x47401300 0x100;
+   status = disabled;
+   };
+
+   musb1_phy: phy1@47401800 {
+   compatible = ti,am335x-usb-phy;
+   reg = 0x44e10628 0x24   /* reset module */
+   0x47401800 0x200
+   0x47401b00 0x100;
+   status = disabled;
+   };
+
usb@4740 {
compatible = ti,musb-am33xx;
reg = 0x4740 0x1000 /* usbss */


--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/5] arm: dts: am33xx: add USB phy nodes

2013-07-05 Thread Sebastian Andrzej Siewior 
On 07/05/2013 04:41 PM, Ruchika Kharwar wrote:
 
 On 07/05/2013 08:32 AM, Sebastian Andrzej Siewior wrote:
 The memory address contains three pieces that is the reset module which
 is currently the only one used and two other pices which seem
 interresting based on what the register.
 Please fix typos pices.. interresting.. also the description is not
 clear.

Okay. What part is not clear?


Sebastian
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html