Re: [PATCH net-next 17/24] net: cdc_ncm: use netif_* and dev_* instead of pr_*

2013-11-04 Thread Bjørn Mork 
Joe Perches j...@perches.com writes:

 You did most all the multi-line statement
 alignment perfectly but missed a couple.

Damn! OK, that will teach me to do checkpatch --strict before
submitting.

 Maybe in a follow-on patch.

Yes, I'll fix this when I get around to the next series for this driver.

Thanks.


Bjørn

 diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
 []
 @@ -1031,17 +1035,13 @@ cdc_ncm_speed_change(struct usbnet *dev,
   * device speed. Do print it instead.
   */
  if ((tx_speed  100)  (rx_speed  100)) {
 -printk(KERN_INFO KBUILD_MODNAME
 -   : %s: %u mbit/s downlink 
 -   %u mbit/s uplink\n,
 -   dev-net-name,
 +netif_info(dev, link, dev-net,
 +   %u mbit/s downlink %u mbit/s uplink\n,
 (unsigned int)(rx_speed / 100U),
 (unsigned int)(tx_speed / 100U));
  } else {
 -printk(KERN_INFO KBUILD_MODNAME
 -   : %s: %u kbit/s downlink 
 -   %u kbit/s uplink\n,
 -   dev-net-name,
 +netif_info(dev, link, dev-net,
 +   %u kbit/s downlink %u kbit/s uplink\n,
 (unsigned int)(rx_speed / 1000U),
 (unsigned int)(tx_speed / 1000U));
  }
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next 17/24] net: cdc_ncm: use netif_* and dev_* instead of pr_*

2013-11-01 Thread Joe Perches 
On Fri, 2013-11-01 at 11:16 +0100, Bjørn Mork wrote:
 Take advantage of standard device name prefixing and
 netdevice msglvl control where possible.

Nice, thanks.

You did most all the multi-line statement
alignment perfectly but missed a couple.

Maybe in a follow-on patch.

 diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
[]
 @@ -1031,17 +1035,13 @@ cdc_ncm_speed_change(struct usbnet *dev,
* device speed. Do print it instead.
*/
   if ((tx_speed  100)  (rx_speed  100)) {
 - printk(KERN_INFO KBUILD_MODNAME
 -: %s: %u mbit/s downlink 
 -%u mbit/s uplink\n,
 -dev-net-name,
 + netif_info(dev, link, dev-net,
 +%u mbit/s downlink %u mbit/s uplink\n,
  (unsigned int)(rx_speed / 100U),
  (unsigned int)(tx_speed / 100U));
   } else {
 - printk(KERN_INFO KBUILD_MODNAME
 -: %s: %u kbit/s downlink 
 -%u kbit/s uplink\n,
 -dev-net-name,
 + netif_info(dev, link, dev-net,
 +%u kbit/s downlink %u kbit/s uplink\n,
  (unsigned int)(rx_speed / 1000U),
  (unsigned int)(tx_speed / 1000U));
   }


--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html