Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()
Hi, Grigor Tovmasyanwrites: > On 3/12/2018 5:34 PM, Felipe Balbi wrote: >> >> Hi, >> >> Grigor Tovmasyan writes: >>> One more thing. >>> >>> In "969d58abe57d usb: dwc2: Enable LPM" patch the author's (John Youn) >>> Signed-off is missing. >>> >>> Could you please manually add his Signed-off ("Signed-off-by: John Youn >>> ") or it's against rules? >> >> I need John to give me his S-o-B line, without it, I'll have to drop the >> patch and, consequently, the rest of the series. >> > > I have a call with him today. I will told him to give you his S-o-B line > as soon as possible. Thanks -- balbi signature.asc Description: PGP signature
Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()
On 3/12/2018 5:34 PM, Felipe Balbi wrote: > > Hi, > > Grigor Tovmasyanwrites: >> One more thing. >> >> In "969d58abe57d usb: dwc2: Enable LPM" patch the author's (John Youn) >> Signed-off is missing. >> >> Could you please manually add his Signed-off ("Signed-off-by: John Youn >> ") or it's against rules? > > I need John to give me his S-o-B line, without it, I'll have to drop the > patch and, consequently, the rest of the series. > I have a call with him today. I will told him to give you his S-o-B line as soon as possible. Thanks again. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()
Hi, Grigor Tovmasyanwrites: > One more thing. > > In "969d58abe57d usb: dwc2: Enable LPM" patch the author's (John Youn) > Signed-off is missing. > > Could you please manually add his Signed-off ("Signed-off-by: John Youn > ") or it's against rules? I need John to give me his S-o-B line, without it, I'll have to drop the patch and, consequently, the rest of the series. -- balbi signature.asc Description: PGP signature
Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()
One more thing. In "969d58abe57d usb: dwc2: Enable LPM" patch the author's (John Youn) Signed-off is missing. Could you please manually add his Signed-off ("Signed-off-by: John Youn") or it's against rules? On 3/12/2018 5:07 PM, Felipe Balbi wrote: > > (no top-posting!!) > > Grigor Tovmasyan writes: >> Hi, >> >> Yes. I'm verifying, it's okay. >> >> Sorry for inconvenience. > > thank you. I'll move the changes to 'next'. > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()
(no top-posting!!) Grigor Tovmasyanwrites: > Hi, > > Yes. I'm verifying, it's okay. > > Sorry for inconvenience. thank you. I'll move the changes to 'next'. -- balbi signature.asc Description: PGP signature
Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()
Hi, Yes. I'm verifying, it's okay. Sorry for inconvenience. Thanks, Grigor. On 3/12/2018 4:47 PM, Felipe Balbi wrote: > > (please avoid top-posting) > > Hi, > > Grigor Tovmasyanwrites: >> Hi Balbi, >> >> Please also cherry-pick following commit from your 'testing/next' to >> 'tmp' right before 01/14. It will solve the problem. >> >> 969d58abe57d usb: dwc2: Enable LPM > > testing/next has been updated. Can you verify it's okay? > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()
(please avoid top-posting) Hi, Grigor Tovmasyanwrites: > Hi Balbi, > > Please also cherry-pick following commit from your 'testing/next' to > 'tmp' right before 01/14. It will solve the problem. > > 969d58abe57d usb: dwc2: Enable LPM testing/next has been updated. Can you verify it's okay? -- balbi signature.asc Description: PGP signature
Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()
Hi Balbi, Please also cherry-pick following commit from your 'testing/next' to 'tmp' right before 01/14. It will solve the problem. 969d58abe57d usb: dwc2: Enable LPM On 3/12/2018 4:03 PM, Felipe Balbi wrote: > > Hi, > > Grigor Tovmasyanwrites: >> Hi Balbi, >> >> Did you tried to apply your patch of the top of your testing/next branch? >> >> If yes, could you please apply 01/14 ("[PATCH v1 01/14] usb: dwc2: >> Rename hibernation to partial_power_down") >> and 02/14 ([PATCH v1 02/14] usb: dwc2: Add hibernation field into >> dwc2_hw_params) patches right before 03/14 ([PATCH v1 03/14] usb: dwc2: >> gadget: Moved dtxfsiz backup array place). >> >> You can use "git rebase --interactive HEAD~10" command just adding >> following lines starting with "x" in the top of opened file. >> >> x git apply <01/14 patch> >> x git apply <02/14 patch> >> pick 3d6c862d9361 usb: dwc2: gadget: Moved dtxfsiz backup array place > > if I do that, patch 6/14 won't apply anymore. I've pushed a 'tmp' branch > to kernel.org with patches 1/14 - 5/14 on top of my 'next' branch. Now > 6/14 doesn't apply to that. > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()
Hi, Grigor Tovmasyanwrites: > Hi Balbi, > > Did you tried to apply your patch of the top of your testing/next branch? > > If yes, could you please apply 01/14 ("[PATCH v1 01/14] usb: dwc2: > Rename hibernation to partial_power_down") > and 02/14 ([PATCH v1 02/14] usb: dwc2: Add hibernation field into > dwc2_hw_params) patches right before 03/14 ([PATCH v1 03/14] usb: dwc2: > gadget: Moved dtxfsiz backup array place). > > You can use "git rebase --interactive HEAD~10" command just adding > following lines starting with "x" in the top of opened file. > > x git apply <01/14 patch> > x git apply <02/14 patch> > pick 3d6c862d9361 usb: dwc2: gadget: Moved dtxfsiz backup array place if I do that, patch 6/14 won't apply anymore. I've pushed a 'tmp' branch to kernel.org with patches 1/14 - 5/14 on top of my 'next' branch. Now 6/14 doesn't apply to that. -- balbi signature.asc Description: PGP signature
Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()
Hi Balbi, Did you tried to apply your patch of the top of your testing/next branch? If yes, could you please apply 01/14 ("[PATCH v1 01/14] usb: dwc2: Rename hibernation to partial_power_down") and 02/14 ([PATCH v1 02/14] usb: dwc2: Add hibernation field into dwc2_hw_params) patches right before 03/14 ([PATCH v1 03/14] usb: dwc2: gadget: Moved dtxfsiz backup array place). You can use "git rebase --interactive HEAD~10" command just adding following lines starting with "x" in the top of opened file. x git apply <01/14 patch> x git apply <02/14 patch> pick 3d6c862d9361 usb: dwc2: gadget: Moved dtxfsiz backup array place On 3/12/2018 2:22 PM, Felipe Balbi wrote: > Grigor Tovmasyanwrites: > >> Hi Balbi, >> >> This patch didn't apply, because you missing 01/14 and 02/14 commits >> from this patch seria. >> Please apply following patches and try again. >> [PATCH v1 01/14] usb: dwc2: Rename hibernation to partial_power_down >> [PATCH v1 02/14] usb: dwc2: Add hibernation field into dwc2_hw_params > > right, and patch 1 doesn't apply: > > error: patch failed: drivers/usb/dwc2/core.h:1117 > error: drivers/usb/dwc2/core.h: patch does not apply > error: patch failed: drivers/usb/dwc2/hcd.c:4378 > error: drivers/usb/dwc2/hcd.c: patch does not apply > Applying: usb: dwc2: Rename hibernation to partial_power_down > Patch failed at 0001 usb: dwc2: Rename hibernation to partial_power_down > The copy of the patch that failed is found in: .git/rebase-apply/patch > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()
Grigor Tovmasyanwrites: > Hi Balbi, > > This patch didn't apply, because you missing 01/14 and 02/14 commits > from this patch seria. > Please apply following patches and try again. > [PATCH v1 01/14] usb: dwc2: Rename hibernation to partial_power_down > [PATCH v1 02/14] usb: dwc2: Add hibernation field into dwc2_hw_params right, and patch 1 doesn't apply: error: patch failed: drivers/usb/dwc2/core.h:1117 error: drivers/usb/dwc2/core.h: patch does not apply error: patch failed: drivers/usb/dwc2/hcd.c:4378 error: drivers/usb/dwc2/hcd.c: patch does not apply Applying: usb: dwc2: Rename hibernation to partial_power_down Patch failed at 0001 usb: dwc2: Rename hibernation to partial_power_down The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- balbi signature.asc Description: PGP signature
Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()
Hi Balbi, This patch didn't apply, because you missing 01/14 and 02/14 commits from this patch seria. Please apply following patches and try again. [PATCH v1 01/14] usb: dwc2: Rename hibernation to partial_power_down [PATCH v1 02/14] usb: dwc2: Add hibernation field into dwc2_hw_params On 3/9/2018 5:10 PM, Grigor Tovmasyan wrote: > Hi Balbi, > > Seems like your testing/next was changed. > I will rebese and send them again. > > On 3/9/2018 1:07 PM, Felipe Balbi wrote: >> Grigor Tovmasyanwrites: >> >>> From: Vardan Mikayelyan >>> >>> These are wrapper functions which are calling device or host >>> enter/exit hibernation functions. >>> >>> Signed-off-by: Vardan Mikayelyan >>> Signed-off-by: John Youn >>> Signed-off-by: Grigor Tovmasyan >> didn't apply to testing/next. Care to rebase on testing/next? >> >> best >> > BR, > Grigor. > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()
Hi Balbi, Seems like your testing/next was changed. I will rebese and send them again. On 3/9/2018 1:07 PM, Felipe Balbi wrote: > Grigor Tovmasyanwrites: > >> From: Vardan Mikayelyan >> >> These are wrapper functions which are calling device or host >> enter/exit hibernation functions. >> >> Signed-off-by: Vardan Mikayelyan >> Signed-off-by: John Youn >> Signed-off-by: Grigor Tovmasyan > didn't apply to testing/next. Care to rebase on testing/next? > > best > BR, Grigor. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 10/14] usb: dwc2: Add dwc2_enter_hibernation(), dwc2_exit_hibernation()
Grigor Tovmasyanwrites: > From: Vardan Mikayelyan > > These are wrapper functions which are calling device or host > enter/exit hibernation functions. > > Signed-off-by: Vardan Mikayelyan > Signed-off-by: John Youn > Signed-off-by: Grigor Tovmasyan didn't apply to testing/next. Care to rebase on testing/next? best -- balbi signature.asc Description: PGP signature