On 01/04/2017 12:48 AM, fx IWATA NOBUO wrote:
> Dear Krzysztof,
>
> I posted new version and it's improved thanks to your review.
I've seen it. It's on my TODO list. I'll get to this in next week
(hopefully in the beginning of the week).
Best regards,
--
Krzysztof Opasiak
Samsung R&D Institut
.@samsung.com;
> gre...@linuxfoundation.org; linux-usb@vger.kernel.org
> Cc: fx MICHIMURA TADAO
> Subject: Re: [PATCH v13 05/10] usbip: exporting devices: modifications to
> daemon
>
>
>
> On 12/07/2016 01:05 AM, fx IWATA NOBUO wrote:
> > Hello,
> >
> >> how about usbip
On 12/07/2016 01:05 AM, fx IWATA NOBUO wrote:
> Hello,
>
>> how about usbip_meta_driver_set(type)?
>
> Good.
>
> I'd like to confirm the 'type' parameter.
>
> #define USBIP_DRIVER_TYPE_HOST 0
> #define USBIP_DRIVER_TYPE_DEVICE 1
>
> Then usbip_meta_driver_init should not be included.
> It
gt; Cc: fx MICHIMURA TADAO
> Subject: Re: [PATCH v13 05/10] usbip: exporting devices: modifications to
> daemon
>
> Hi,
>
> On 12/06/2016 05:40 AM, fx IWATA NOBUO wrote:
> > Hello,
> >
> >>> usbip_driver_ has widely used as function names and file
&g
Hi,
On 12/06/2016 05:40 AM, fx IWATA NOBUO wrote:
> Hello,
>
>>> usbip_driver_ has widely used as function names and file
>>> names for host side abstraction.
>>> If they were usbip_host_, I can use usbip_driver_open/close
>>> for both host(stub/vudc) and vhci.
>>
>> usbip_host() is not correct n
> change this in all files not only in those you touch.
OK. I will.
Thank you for your help,
n.iwata
//
> -Original Message-
> From: Krzysztof Opasiak [mailto:k.opas...@samsung.com]
> Sent: Friday, December 02, 2016 11:20 PM
> To: fx IWATA NOBUO; valentina.mane...@gma
On 12/02/2016 09:36 AM, fx IWATA NOBUO wrote:
> Hello,
>
>>> -static int do_accept(int listenfd)
>>> +static int do_accept(int listenfd, char *host, char *port)
>
>> In my opinion you should pass also the size of those arrays to this
>> function instead of hardcoding them like this.
>
> OK. I
iginal Message-
> From: Krzysztof Opasiak [mailto:k.opas...@samsung.com]
> Sent: Friday, December 02, 2016 6:19 AM
> To: fx IWATA NOBUO; valentina.mane...@gmail.com; shuah...@samsung.com;
> gre...@linuxfoundation.org; linux-usb@vger.kernel.org
> Cc: fx MICHIMURA TADAO
> Subject: R
Hi,
On 11/22/2016 07:48 AM, Nobuo Iwata wrote:
(...)
>
> -static int do_accept(int listenfd)
> +static int do_accept(int listenfd, char *host, char *port)
> {
> int connfd;
> struct sockaddr_storage ss;
> socklen_t len = sizeof(ss);
> - char host[NI_MAXHOST], port[NI_MAX
