Re: [PATCH v2 3/4] usb: dwc3: add dual-role support

2017-04-02 Thread John Youn
On 03/30/2017 02:27 AM, Felipe Balbi wrote: > > Hi > > Roger Quadros writes: > For something that simple, we wouldn't even need to use OTG FSM layer > because that brings no benefit for such a simple requirement. no no. I think you got it wrong. I'm not using the

Re: [PATCH v2 3/4] usb: dwc3: add dual-role support

2017-03-30 Thread Felipe Balbi
Hi Roger Quadros writes: For something that simple, we wouldn't even need to use OTG FSM layer because that brings no benefit for such a simple requirement. >>> >>> no no. I think you got it wrong. I'm not using the OTG FSM layer at all :). >> >> what are all the

Re: [PATCH v2 3/4] usb: dwc3: add dual-role support

2017-03-30 Thread Roger Quadros
Hi, On 29/03/17 16:15, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: @@ -839,6 +841,505 @@ static int dwc3_core_get_phy(struct dwc3 *dwc) return 0; } +static int dwc3_drd_start_host(struct dwc3 *dwc, int on, bool skip); +static int

Re: [PATCH v2 3/4] usb: dwc3: add dual-role support

2017-03-29 Thread Felipe Balbi
Hi, Roger Quadros writes: >>> @@ -839,6 +841,505 @@ static int dwc3_core_get_phy(struct dwc3 *dwc) >>> return 0; >>> } >>> >>> +static int dwc3_drd_start_host(struct dwc3 *dwc, int on, bool skip); >>> +static int dwc3_drd_start_gadget(struct dwc3 *dwc, int on); >>> + >>>

Re: [PATCH v2 3/4] usb: dwc3: add dual-role support

2017-03-29 Thread Roger Quadros
Hi, On 28/03/17 14:07, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> If dr_mode is "otg" then support dual role mode of operation. >> >> Get ID and VBUS information from the OTG controller >> and put the controller in the appropriate state. >> >> This is our dual-role

Re: [PATCH v2 3/4] usb: dwc3: add dual-role support

2017-03-28 Thread Felipe Balbi
Hi, Roger Quadros writes: > If dr_mode is "otg" then support dual role mode of operation. > > Get ID and VBUS information from the OTG controller > and put the controller in the appropriate state. > > This is our dual-role state table. > > IDVBUSdual-role state > --