Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-11-10 Thread Javier Martinez Canillas 
Hello ChenYu

On Fri, Nov 11, 2016 at 12:01 AM, Chen-Yu Tsai  wrote:
> On Fri, Nov 11, 2016 at 5:42 AM, Rob Herring  wrote:

[snip]

>>
>> Do you have patches using this already. If not, it is starting to get
>> a bit late for v4.10.
>>
>> I can apply this, but then you'll just be pulling in other DT patches.
>
> Not sure what you mean by "using" this...
>
> I have patches which use this to add DT-based modalias entries for
> module auto-loading to i2c and sunxi-rsb that I haven't sent.
>

Unfortunately the I2C core can't be changed without breaking a lot of
I2C drivers that are relying on the current behavior. I've already
posted a RFC patch [0] for I2C that does this about a year ago and
enumerated the issues that have to be addressed before the change can
be made (and fixed some of the issues mentioned) on this series [1].

Another issue is that an I2C device ID table is a requirement anyways
since I2C drivers expect an i2c_device_id as an argument of their
probe function. Kieran already have patches [2] to change that which
should land soon.

I plan to fix the remaining I2C drivers once his patches are merged
and re-post the RFC patch as a proper one.

> As far as DT usage goes, we already need this for the axp20x mfd driver.
> There are 2 variants, i2c and sunxi-rsb. For the I2C variant a fix was
> sent to fix module auto-loading by using the I2C client ID table:
>
> mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
> 
> https://git.kernel.org/cgit/linux/kernel/git/lee/mfd.git/commit/?h=for-mfd-next=b7142a19321484bd7681aa547c1d50148c8e2825
>

Yes, this is the workaround used by most DT-only I2C drivers. The only
reason that these drivers have an I2C device ID is due the
restrictions imposed by the I2C core.

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-11-10 Thread Chen-Yu Tsai 
On Fri, Nov 11, 2016 at 5:42 AM, Rob Herring  wrote:
> On Sun, Nov 6, 2016 at 7:56 PM, Chen-Yu Tsai  wrote:
>> On Mon, Nov 7, 2016 at 9:29 AM, Peter Chen  wrote:
>>> On Fri, Nov 04, 2016 at 01:51:34PM -0700, Stephen Boyd wrote:
 Quoting Peter Chen (2016-10-24 18:16:32)
 > On Mon, Oct 24, 2016 at 12:48:24PM -0700, Stephen Boyd wrote:
 > > Quoting Chen-Yu Tsai (2016-10-24 05:19:05)
 > > > Hi,
 > > >
 > > > On Tue, Oct 18, 2016 at 9:56 AM, Stephen Boyd 
 > > >  wrote:
 > > > > The ULPI bus can be built as a module, and it will soon be
 > > > > calling these functions when it supports probing devices from DT.
 > > > > Export them so they can be used by the ULPI module.
 > > > >
 > > > > Acked-by: Rob Herring 
 > > > > Cc: 
 > > > > Signed-off-by: Stephen Boyd 
 > > > > ---
 > > > >  drivers/of/device.c | 2 ++
 > > > >  1 file changed, 2 insertions(+)
 > > > >
 > > > > diff --git a/drivers/of/device.c b/drivers/of/device.c
 > > > > index 8a22a253a830..6719ab35b62e 100644
 > > > > --- a/drivers/of/device.c
 > > > > +++ b/drivers/of/device.c
 > > > > @@ -225,6 +225,7 @@ ssize_t of_device_get_modalias(struct device 
 > > > > *dev, char *str, ssize_t len)
 > > > >
 > > > > return tsize;
 > > > >  }
 > > > > +EXPORT_SYMBOL_GPL(of_device_get_modalias);
 > > > >
 > > > >  int of_device_request_module(struct device *dev)
 > > > >  {
 > > > > @@ -290,6 +291,7 @@ void of_device_uevent(struct device *dev, 
 > > > > struct kobj_uevent_env *env)
 > > > > }
 > > > > mutex_unlock(_mutex);
 > > > >  }
 > > > > +EXPORT_SYMBOL_GPL(of_device_uevent_modalias);
 > > >
 > > > This is trailing the wrong function.
 > > >
 > >
 > > Good catch. Must have been some bad rebase.
 > >
 > > Peter, can you fix it while applying or should I resend this patch?
 > >
 >
 > But, this is device tree patch. I can only get chipidea part and other
 > USB patches if Greg agrees.
 >

 Were you expecting Rob to take the drivers/of/* patches? Sorry I thought
 Rob acked them so they could go through usb with the other changes.
>>>
>>> I am just worried about possible merge error when linus pulls both OF
>>> and USB tree. Greg, is it ok the OF patches through USB tree with OF
>>> maintainer's ack?
>>
>> May I suggest putting the OF patches on an immutable branch so other
>> subsystems can pull them in without pulling in the USB patches? At
>> least I want to use them in the I2C subsystem, and in the sunxi-rsb
>> driver.
>
> Do you have patches using this already. If not, it is starting to get
> a bit late for v4.10.
>
> I can apply this, but then you'll just be pulling in other DT patches.

Not sure what you mean by "using" this...

I have patches which use this to add DT-based modalias entries for
module auto-loading to i2c and sunxi-rsb that I haven't sent.

As far as DT usage goes, we already need this for the axp20x mfd driver.
There are 2 variants, i2c and sunxi-rsb. For the I2C variant a fix was
sent to fix module auto-loading by using the I2C client ID table:

mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading

https://git.kernel.org/cgit/linux/kernel/git/lee/mfd.git/commit/?h=for-mfd-next=b7142a19321484bd7681aa547c1d50148c8e2825

But for the sunxi-rsb variant such a fix does not exist, as the bus
does not have a separate ID table. It uses DT exclusively.


Regards
ChenYu
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-11-10 Thread Rob Herring 
On Sun, Nov 6, 2016 at 7:56 PM, Chen-Yu Tsai  wrote:
> On Mon, Nov 7, 2016 at 9:29 AM, Peter Chen  wrote:
>> On Fri, Nov 04, 2016 at 01:51:34PM -0700, Stephen Boyd wrote:
>>> Quoting Peter Chen (2016-10-24 18:16:32)
>>> > On Mon, Oct 24, 2016 at 12:48:24PM -0700, Stephen Boyd wrote:
>>> > > Quoting Chen-Yu Tsai (2016-10-24 05:19:05)
>>> > > > Hi,
>>> > > >
>>> > > > On Tue, Oct 18, 2016 at 9:56 AM, Stephen Boyd 
>>> > > >  wrote:
>>> > > > > The ULPI bus can be built as a module, and it will soon be
>>> > > > > calling these functions when it supports probing devices from DT.
>>> > > > > Export them so they can be used by the ULPI module.
>>> > > > >
>>> > > > > Acked-by: Rob Herring 
>>> > > > > Cc: 
>>> > > > > Signed-off-by: Stephen Boyd 
>>> > > > > ---
>>> > > > >  drivers/of/device.c | 2 ++
>>> > > > >  1 file changed, 2 insertions(+)
>>> > > > >
>>> > > > > diff --git a/drivers/of/device.c b/drivers/of/device.c
>>> > > > > index 8a22a253a830..6719ab35b62e 100644
>>> > > > > --- a/drivers/of/device.c
>>> > > > > +++ b/drivers/of/device.c
>>> > > > > @@ -225,6 +225,7 @@ ssize_t of_device_get_modalias(struct device 
>>> > > > > *dev, char *str, ssize_t len)
>>> > > > >
>>> > > > > return tsize;
>>> > > > >  }
>>> > > > > +EXPORT_SYMBOL_GPL(of_device_get_modalias);
>>> > > > >
>>> > > > >  int of_device_request_module(struct device *dev)
>>> > > > >  {
>>> > > > > @@ -290,6 +291,7 @@ void of_device_uevent(struct device *dev, 
>>> > > > > struct kobj_uevent_env *env)
>>> > > > > }
>>> > > > > mutex_unlock(_mutex);
>>> > > > >  }
>>> > > > > +EXPORT_SYMBOL_GPL(of_device_uevent_modalias);
>>> > > >
>>> > > > This is trailing the wrong function.
>>> > > >
>>> > >
>>> > > Good catch. Must have been some bad rebase.
>>> > >
>>> > > Peter, can you fix it while applying or should I resend this patch?
>>> > >
>>> >
>>> > But, this is device tree patch. I can only get chipidea part and other
>>> > USB patches if Greg agrees.
>>> >
>>>
>>> Were you expecting Rob to take the drivers/of/* patches? Sorry I thought
>>> Rob acked them so they could go through usb with the other changes.
>>
>> I am just worried about possible merge error when linus pulls both OF
>> and USB tree. Greg, is it ok the OF patches through USB tree with OF
>> maintainer's ack?
>
> May I suggest putting the OF patches on an immutable branch so other
> subsystems can pull them in without pulling in the USB patches? At
> least I want to use them in the I2C subsystem, and in the sunxi-rsb
> driver.

Do you have patches using this already. If not, it is starting to get
a bit late for v4.10.

I can apply this, but then you'll just be pulling in other DT patches.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-11-06 Thread Chen-Yu Tsai 
On Mon, Nov 7, 2016 at 9:29 AM, Peter Chen  wrote:
> On Fri, Nov 04, 2016 at 01:51:34PM -0700, Stephen Boyd wrote:
>> Quoting Peter Chen (2016-10-24 18:16:32)
>> > On Mon, Oct 24, 2016 at 12:48:24PM -0700, Stephen Boyd wrote:
>> > > Quoting Chen-Yu Tsai (2016-10-24 05:19:05)
>> > > > Hi,
>> > > >
>> > > > On Tue, Oct 18, 2016 at 9:56 AM, Stephen Boyd 
>> > > >  wrote:
>> > > > > The ULPI bus can be built as a module, and it will soon be
>> > > > > calling these functions when it supports probing devices from DT.
>> > > > > Export them so they can be used by the ULPI module.
>> > > > >
>> > > > > Acked-by: Rob Herring 
>> > > > > Cc: 
>> > > > > Signed-off-by: Stephen Boyd 
>> > > > > ---
>> > > > >  drivers/of/device.c | 2 ++
>> > > > >  1 file changed, 2 insertions(+)
>> > > > >
>> > > > > diff --git a/drivers/of/device.c b/drivers/of/device.c
>> > > > > index 8a22a253a830..6719ab35b62e 100644
>> > > > > --- a/drivers/of/device.c
>> > > > > +++ b/drivers/of/device.c
>> > > > > @@ -225,6 +225,7 @@ ssize_t of_device_get_modalias(struct device 
>> > > > > *dev, char *str, ssize_t len)
>> > > > >
>> > > > > return tsize;
>> > > > >  }
>> > > > > +EXPORT_SYMBOL_GPL(of_device_get_modalias);
>> > > > >
>> > > > >  int of_device_request_module(struct device *dev)
>> > > > >  {
>> > > > > @@ -290,6 +291,7 @@ void of_device_uevent(struct device *dev, struct 
>> > > > > kobj_uevent_env *env)
>> > > > > }
>> > > > > mutex_unlock(_mutex);
>> > > > >  }
>> > > > > +EXPORT_SYMBOL_GPL(of_device_uevent_modalias);
>> > > >
>> > > > This is trailing the wrong function.
>> > > >
>> > >
>> > > Good catch. Must have been some bad rebase.
>> > >
>> > > Peter, can you fix it while applying or should I resend this patch?
>> > >
>> >
>> > But, this is device tree patch. I can only get chipidea part and other
>> > USB patches if Greg agrees.
>> >
>>
>> Were you expecting Rob to take the drivers/of/* patches? Sorry I thought
>> Rob acked them so they could go through usb with the other changes.
>
> I am just worried about possible merge error when linus pulls both OF
> and USB tree. Greg, is it ok the OF patches through USB tree with OF
> maintainer's ack?

May I suggest putting the OF patches on an immutable branch so other
subsystems can pull them in without pulling in the USB patches? At
least I want to use them in the I2C subsystem, and in the sunxi-rsb
driver.


Regards
ChenYu
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-11-06 Thread Peter Chen 
On Fri, Nov 04, 2016 at 01:51:34PM -0700, Stephen Boyd wrote:
> Quoting Peter Chen (2016-10-24 18:16:32)
> > On Mon, Oct 24, 2016 at 12:48:24PM -0700, Stephen Boyd wrote:
> > > Quoting Chen-Yu Tsai (2016-10-24 05:19:05)
> > > > Hi,
> > > > 
> > > > On Tue, Oct 18, 2016 at 9:56 AM, Stephen Boyd  
> > > > wrote:
> > > > > The ULPI bus can be built as a module, and it will soon be
> > > > > calling these functions when it supports probing devices from DT.
> > > > > Export them so they can be used by the ULPI module.
> > > > >
> > > > > Acked-by: Rob Herring 
> > > > > Cc: 
> > > > > Signed-off-by: Stephen Boyd 
> > > > > ---
> > > > >  drivers/of/device.c | 2 ++
> > > > >  1 file changed, 2 insertions(+)
> > > > >
> > > > > diff --git a/drivers/of/device.c b/drivers/of/device.c
> > > > > index 8a22a253a830..6719ab35b62e 100644
> > > > > --- a/drivers/of/device.c
> > > > > +++ b/drivers/of/device.c
> > > > > @@ -225,6 +225,7 @@ ssize_t of_device_get_modalias(struct device 
> > > > > *dev, char *str, ssize_t len)
> > > > >
> > > > > return tsize;
> > > > >  }
> > > > > +EXPORT_SYMBOL_GPL(of_device_get_modalias);
> > > > >
> > > > >  int of_device_request_module(struct device *dev)
> > > > >  {
> > > > > @@ -290,6 +291,7 @@ void of_device_uevent(struct device *dev, struct 
> > > > > kobj_uevent_env *env)
> > > > > }
> > > > > mutex_unlock(_mutex);
> > > > >  }
> > > > > +EXPORT_SYMBOL_GPL(of_device_uevent_modalias);
> > > > 
> > > > This is trailing the wrong function.
> > > > 
> > > 
> > > Good catch. Must have been some bad rebase.
> > > 
> > > Peter, can you fix it while applying or should I resend this patch?
> > > 
> > 
> > But, this is device tree patch. I can only get chipidea part and other
> > USB patches if Greg agrees.
> > 
> 
> Were you expecting Rob to take the drivers/of/* patches? Sorry I thought
> Rob acked them so they could go through usb with the other changes.

I am just worried about possible merge error when linus pulls both OF
and USB tree. Greg, is it ok the OF patches through USB tree with OF
maintainer's ack?

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-11-04 Thread Stephen Boyd 
Quoting Peter Chen (2016-10-24 18:16:32)
> On Mon, Oct 24, 2016 at 12:48:24PM -0700, Stephen Boyd wrote:
> > Quoting Chen-Yu Tsai (2016-10-24 05:19:05)
> > > Hi,
> > > 
> > > On Tue, Oct 18, 2016 at 9:56 AM, Stephen Boyd  
> > > wrote:
> > > > The ULPI bus can be built as a module, and it will soon be
> > > > calling these functions when it supports probing devices from DT.
> > > > Export them so they can be used by the ULPI module.
> > > >
> > > > Acked-by: Rob Herring 
> > > > Cc: 
> > > > Signed-off-by: Stephen Boyd 
> > > > ---
> > > >  drivers/of/device.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/of/device.c b/drivers/of/device.c
> > > > index 8a22a253a830..6719ab35b62e 100644
> > > > --- a/drivers/of/device.c
> > > > +++ b/drivers/of/device.c
> > > > @@ -225,6 +225,7 @@ ssize_t of_device_get_modalias(struct device *dev, 
> > > > char *str, ssize_t len)
> > > >
> > > > return tsize;
> > > >  }
> > > > +EXPORT_SYMBOL_GPL(of_device_get_modalias);
> > > >
> > > >  int of_device_request_module(struct device *dev)
> > > >  {
> > > > @@ -290,6 +291,7 @@ void of_device_uevent(struct device *dev, struct 
> > > > kobj_uevent_env *env)
> > > > }
> > > > mutex_unlock(_mutex);
> > > >  }
> > > > +EXPORT_SYMBOL_GPL(of_device_uevent_modalias);
> > > 
> > > This is trailing the wrong function.
> > > 
> > 
> > Good catch. Must have been some bad rebase.
> > 
> > Peter, can you fix it while applying or should I resend this patch?
> > 
> 
> But, this is device tree patch. I can only get chipidea part and other
> USB patches if Greg agrees.
> 

Were you expecting Rob to take the drivers/of/* patches? Sorry I thought
Rob acked them so they could go through usb with the other changes.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-10-24 Thread Peter Chen 
On Mon, Oct 24, 2016 at 12:48:24PM -0700, Stephen Boyd wrote:
> Quoting Chen-Yu Tsai (2016-10-24 05:19:05)
> > Hi,
> > 
> > On Tue, Oct 18, 2016 at 9:56 AM, Stephen Boyd  
> > wrote:
> > > The ULPI bus can be built as a module, and it will soon be
> > > calling these functions when it supports probing devices from DT.
> > > Export them so they can be used by the ULPI module.
> > >
> > > Acked-by: Rob Herring 
> > > Cc: 
> > > Signed-off-by: Stephen Boyd 
> > > ---
> > >  drivers/of/device.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/of/device.c b/drivers/of/device.c
> > > index 8a22a253a830..6719ab35b62e 100644
> > > --- a/drivers/of/device.c
> > > +++ b/drivers/of/device.c
> > > @@ -225,6 +225,7 @@ ssize_t of_device_get_modalias(struct device *dev, 
> > > char *str, ssize_t len)
> > >
> > > return tsize;
> > >  }
> > > +EXPORT_SYMBOL_GPL(of_device_get_modalias);
> > >
> > >  int of_device_request_module(struct device *dev)
> > >  {
> > > @@ -290,6 +291,7 @@ void of_device_uevent(struct device *dev, struct 
> > > kobj_uevent_env *env)
> > > }
> > > mutex_unlock(_mutex);
> > >  }
> > > +EXPORT_SYMBOL_GPL(of_device_uevent_modalias);
> > 
> > This is trailing the wrong function.
> > 
> 
> Good catch. Must have been some bad rebase.
> 
> Peter, can you fix it while applying or should I resend this patch?
> 

But, this is device tree patch. I can only get chipidea part and other
USB patches if Greg agrees.

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-10-24 Thread Chen-Yu Tsai 
Hi,

On Tue, Oct 18, 2016 at 9:56 AM, Stephen Boyd  wrote:
> The ULPI bus can be built as a module, and it will soon be
> calling these functions when it supports probing devices from DT.
> Export them so they can be used by the ULPI module.
>
> Acked-by: Rob Herring 
> Cc: 
> Signed-off-by: Stephen Boyd 
> ---
>  drivers/of/device.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/of/device.c b/drivers/of/device.c
> index 8a22a253a830..6719ab35b62e 100644
> --- a/drivers/of/device.c
> +++ b/drivers/of/device.c
> @@ -225,6 +225,7 @@ ssize_t of_device_get_modalias(struct device *dev, char 
> *str, ssize_t len)
>
> return tsize;
>  }
> +EXPORT_SYMBOL_GPL(of_device_get_modalias);
>
>  int of_device_request_module(struct device *dev)
>  {
> @@ -290,6 +291,7 @@ void of_device_uevent(struct device *dev, struct 
> kobj_uevent_env *env)
> }
> mutex_unlock(_mutex);
>  }
> +EXPORT_SYMBOL_GPL(of_device_uevent_modalias);

This is trailing the wrong function.

ChenYu

>
>  int of_device_uevent_modalias(struct device *dev, struct kobj_uevent_env 
> *env)
>  {
> --
> 2.10.0.297.gf6727b0
>
>
> ___
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-10-17 Thread Chen-Yu Tsai 
On Tue, Oct 18, 2016 at 9:56 AM, Stephen Boyd  wrote:
> The ULPI bus can be built as a module, and it will soon be
> calling these functions when it supports probing devices from DT.
> Export them so they can be used by the ULPI module.
>
> Acked-by: Rob Herring 
> Cc: 
> Signed-off-by: Stephen Boyd 

I'm interested in this as well. The sunxi-rsb bus is non-enumerable
and DT only, and existing slave device drivers can be built as modules.
We'd need this to support modalias loading of drivers.

ChenYu
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html