On Tue, 2017-08-08 at 22:22 +0200, Giuseppe Lippolis wrote: > > The option driver use interface blacklists instead of multiple > > match entries. > > You should probably follow the same style there. But this is up to > > Johan... > > Can I ask what ist he difference between .sendsetup and .reserved and > how to use the bitmask in drivers/usb/serial/option.c ?
The "blacklists" (which they really aren't anymore, just quirks) say which USB interfaces have that specific quick. sendsetup is to prevent the driver from sending a specific USB control message for setting up serial parameters, which some devices ignore and cause the driver to stall. reserved is what you're looking for. This one tells option not to bind to the given USB interfaces. So for example, ".reserved = BIT(3)" tells the option driver to ignore USB interface 3 on that device. ".reserved = BIT(3) | BIT(5)" tells it to ignore both interfaces 3 and 5. For your device, you'll want to set "reserved" in option.c to all the interfaces that qmi_wwan is going to claim, to make sure option doesn't claim them. option by default is a greedy driver. Dan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
