Re: 3.18-rc0: iwlegacy failed after a while

2014-10-26 Thread Stanislaw Gruszka
On Sat, Oct 25, 2014 at 01:42:46PM +0200, Pavel Machek wrote: Since 3.17 we have only 2 minor iwlegacy changes on current linus tree. If this is a regression it's probably caused by different subsystem changes, most likely by PCI changes. If this is not regression, such errors could be

RE: p2p doesn't work at 5GHz by using mwifiex driver

2014-10-26 Thread Avinash Patil
Hi QW, Are you configuring P2P client or P2P GO? We recently have fixed one TX timeout issue. Can you please check if this patch helps: http://git.kernel.org/cgit/linux/kernel/git/linville/wireless-testing.git/commit/drivers/net/wireless/mwifiex?id=d76744a93246eccdca1106037e8ee29debf48277 If

[PATCH] staging: rtl8723au pointer issue

2014-10-26 Thread Paul McQuade
ERROR: foo*bar should be foo *bar Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_cmd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c b/drivers/staging/rtl8723au/core/rtw_cmd.c

[PATCH 1/2] staging: rtl8723au: core: pointer issue

2014-10-26 Thread Paul McQuade
ERROR: foo * bar should be foo *bar Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_efuse.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_efuse.c

[PATCH 2/2] staging: rtl8723au:core

2014-10-26 Thread Paul McQuade
ERROR: spaces required around that ':' (ctx:VxE) Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c

[PATCH] staging: rtl8723au: create macro get_max_rate

2014-10-26 Thread Paul McQuade
create marco for max_rate values Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 75 -- 1 file changed, 34 insertions(+), 41 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c

[PATCH][V2] staging: rtl8723au: create macro get_max_rate

2014-10-26 Thread Paul McQuade
create marco for max_rate values Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 58 -- 1 file changed, 26 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c

[PATCH] staging: rtl8723au: create macro get_max_rate

2014-10-26 Thread Paul McQuade
create marco for max_rate values Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 58 -- 1 file changed, 26 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c

[PATCH 2/2] staging: rtl8723au: core style issue

2014-10-26 Thread Paul McQuade
spaces required around % Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c b/drivers/staging/rtl8723au/core/rtw_recv.c index

[PATCH 07/11] iwlwifi: dvm: Fix probable mask then right shift defect

2014-10-26 Thread Joe Perches
Precedence of and is not the same and is not left to right. shift has higher precedence and should be done after the mask. Add parentheses around the mask. Signed-off-by: Joe Perches j...@perches.com --- drivers/net/wireless/iwlwifi/dvm/lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 00/11] treewide: mask then shift defects and style updates

2014-10-26 Thread Joe Perches
logical mask has lower precedence than shift but should be done before the shift so parentheses are generally required. And when masking with a fixed value after a shift, normal kernel style has the shift on the left, then the shift on the right so convert a few non-conforming uses. Joe Perches

Re: [PATCH 2/2] staging: rtl8723au:core

2014-10-26 Thread Jes Sorensen
Joe Perches j...@perches.com writes: On Sun, 2014-10-26 at 16:18 +, Paul McQuade wrote: ERROR: spaces required around that ':' (ctx:VxE) Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 16 1 file changed, 8

Re: [PATCH] staging: rtl8723au: create macro get_max_rate

2014-10-26 Thread Jes Sorensen
Paul McQuade paulmcq...@gmail.com writes: create marco for max_rate values Signed-off-by: Paul McQuade paulmcq...@gmail.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 58 -- 1 file changed, 26 insertions(+), 32 deletions(-) diff --git

Re: [PATCH 2/2] staging: rtl8723au:core

2014-10-26 Thread Joe Perches
On Mon, 2014-10-27 at 06:45 +0100, Jes Sorensen wrote: Joe Perches j...@perches.com writes: On Sun, 2014-10-26 at 16:18 +, Paul McQuade wrote: ERROR: spaces required around that ':' (ctx:VxE) [] diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c