p54usb kernel panic on recent mainline kernels

2014-12-24 Thread Christopher Chavez
When a device using p54usb joins/connects/associates with an access point, a kernel panic occurs. The AP tested uses WPA2; have not tested whether the issue occurs for other security types or ad hoc connections. The specific devices tested are 2Wire 802.11g USB v1 (vendor 1630 device 0005). The fir

Re: [PATCH] cfg80211: check for carrier state only when offchanel CAC supported

2014-12-24 Thread Arend van Spriel
On 12/24/14 13:47, Avinash Patil wrote: Checking for carrier state during start_radar_detection is needed only for devices which support offchannel CAC. This patch provides this additional check of extended feature offchannel CAC support while checking for carrier state. Signed-off-by: Avinash P

Re: hostapd and 11h support

2014-12-24 Thread Arend van Spriel
On 12/24/14 20:04, Jouni Malinen wrote: On Wed, Dec 24, 2014 at 07:29:04PM +0100, Arend van Spriel wrote: The firmware on the device *can* have CAC logic built-in. When it *is* built-in it is however disabled by default. Based on your feedback I will just detect firmware support, enable dfs in f

Re: hostapd and 11h support

2014-12-24 Thread Jouni Malinen
On Wed, Dec 24, 2014 at 07:29:04PM +0100, Arend van Spriel wrote: > The firmware on the device *can* have CAC logic built-in. When it > *is* built-in it is however disabled by default. Based on your > feedback I will just detect firmware support, enable dfs in > firmware, and signal DFS offload to

Re: hostapd and 11h support

2014-12-24 Thread Arend van Spriel
On 12/24/14 18:32, Jouni Malinen wrote: On Wed, Dec 24, 2014 at 10:32:23AM +0100, Arend van Spriel wrote: I am looking at 11h support in hostapd. The supplicant uses .start_dfs_cac() driver callback (resulting in NL08211_CMD_RADAR_DETECT) and basically the CAC logic is done in the supplicant. No

Re: [PATCH V2 3/10] brcmfmac: Add support for bcm43340/1 wireless chipsets

2014-12-24 Thread Kalle Valo
Arend van Spriel writes: > On 12/23/14 19:04, Arend van Spriel wrote: >> This patch adds support for the bcm43340 and bcm43341 wireless >> chipsets. These two chipsets are identical from wireless parts >> perspective. As such they use the same firmware image. > > Kalle, > > Just curious. Would th

Re: hostapd and 11h support

2014-12-24 Thread Jouni Malinen
On Wed, Dec 24, 2014 at 10:32:23AM +0100, Arend van Spriel wrote: > I am looking at 11h support in hostapd. The supplicant uses > .start_dfs_cac() driver callback (resulting in > NL08211_CMD_RADAR_DETECT) and basically the CAC logic is done in the > supplicant. Now for our devices the entire radar

Re: [PATCH 0/3] add debugfs support to ath9k hw TPC

2014-12-24 Thread Kalle Valo
Lorenzo Bianconi writes: > *[PATCH 1/3]: enable TPC by default on AR9003 based chips > *[PATCH 2/3]: enable/disable hw TPC through debugfs > *[PATCH 3/3]: fix typo > > Lorenzo Bianconi (3): > ath9k: enable TPC by default > ath9k: add debugfs support for hw TPC > ath9k: fix typo Thanks, all

Re: [PATCH v2 3/4] mwifiex: make tx packet 64 byte DMA aligned

2014-12-24 Thread Kalle Valo
Avinash Patil writes: > From: Xinming Hu > > This patch adds support for DMA alignment of 64 bytes for TX packets. > > v2: incorporate review comments from Joe - define pad as unsigned int; > remove magic numbers from definition of MWIFIEX_MIN_DATA_HEADER_LEN > > Signed-off-by: Xinming Hu >

Re: [PATCH v2 1/4] mwifiex: enable -D__CHECK_ENDIAN__ for sparse by default

2014-12-24 Thread Kalle Valo
Avinash Patil writes: > Enable the endian checks by default. > > v2: remove -DDEBUG as suggested by Joe Perches Please don't add the change log to the commit log. Instead add it after '---' line so that git am can automatically skip it. Alternatively send a cover letter and include the change lo

Re: [PATCH] net: wireless: rtlwifi: rtl8723be: phy.c: Remove unused function

2014-12-24 Thread Kalle Valo
Rickard Strandqvist writes: > Remove the function rtl8723be_phy_get_txpower_level() that is not used > anywhere. > > This was partially found by using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandqvist Thanks, applied to wireless-drivers-next.git. -- Ka

Re: [PATCH] net: wireless: rtlwifi: rtl8192ee: trx.c: Remove unused function

2014-12-24 Thread Kalle Valo
Rickard Strandqvist writes: > Remove the function rtl92ee_get_available_desc() that is not used anywhere. > > This was partially found by using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandqvist Thanks, applied to wireless-drivers-next.git. But I simplifi

Re: [ath9k-devel] IBSS network crashes after one device leaves network

2014-12-24 Thread Oleksij Rempel
Am 24.12.2014 um 03:45 schrieb Melroy van den Berg: > Oleksij Rempel writes: >> hmm.. suddenly rate scaling is not singe limitation of ath9k-htc. >> Firmware keeps some information for each STA and trying to reduce usb >> bandwidth. If i understand it correctly, ath10k works in the same way. >> It

Re: [PATCH 00/16] rtlwifi updates for kernel 3.20

2014-12-24 Thread Kalle Valo
Larry Finger writes: > Welcome as the wireless-driver maintainer. Thanks. > I'm certain that it will take a while for all of us to function with > the new structure, but I will try. Yeah, it will take some time to get everything working smoothly again. But always feel free to give feedback if

Re: [PATCH next] drivers/net/wireless/ath/wil6210/debugfs.c: Use 'uint64_t' instead of 'cycles_t' to avoid warnings

2014-12-24 Thread Chen Gang
On 12/24/2014 11:35 PM, Kalle Valo wrote: > Chen Gang writes: > >> On 12/24/2014 11:11 PM, Kalle Valo wrote: >>> Chen Gang writes: >>> Oh, sorry, I forgot the word wrap (after change a new pc). I shall send patch v2 for it. >>> >>> While at it, could you also please simplify the title.

Re: [PATCH next] drivers/net/wireless/ath/wil6210/debugfs.c: Use 'uint64_t' instead of 'cycles_t' to avoid warnings

2014-12-24 Thread Kalle Valo
Chen Gang writes: > On 12/24/2014 11:11 PM, Kalle Valo wrote: >> Chen Gang writes: >> >>> Oh, sorry, I forgot the word wrap (after change a new pc). I shall send >>> patch v2 for it. >> >> While at it, could you also please simplify the title. You don't have to >> put the full directory there,

Re: [PATCH] ath: fix incorrect PPB on FCC radar type 5

2014-12-24 Thread Kalle Valo
Peter Oh writes: > The minimum number of pulses per burst on FCC radar type 5 is 1. > Use this number for correct radar detection. > > Signed-off-by: Peter Oh Thanks, applied to wireless-drivers-next.git. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireles

Re: [PATCH] rsi: fix memory leak in rsi_load_ta_instructions()

2014-12-24 Thread Kalle Valo
Alexey Khoroshilov writes: > Memory allocated by kmemdup() in rsi_load_ta_instructions() is leaked. > But duplication of firmware data here is useless, > so the patch removes kmemdup() at all. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov

Re: [PATCH] net: wireless: rtlwifi: rtl8192de: fw.c: Remove unused function

2014-12-24 Thread Kalle Valo
Rickard Strandqvist writes: > Remove the function rtl92d_set_fw_pwrmode_cmd() that is not used anywhere. > > This was partially found by using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandqvist Thanks, applied to wireless-drivers-next.git. But in the futu

Re: [PATCH next] drivers/net/wireless/ath/wil6210/debugfs.c: Use 'uint64_t' instead of 'cycles_t' to avoid warnings

2014-12-24 Thread Chen Gang
On 12/24/2014 11:11 PM, Kalle Valo wrote: > Chen Gang writes: > >> Oh, sorry, I forgot the word wrap (after change a new pc). I shall send >> patch v2 for it. > > While at it, could you also please simplify the title. You don't have to > put the full directory there, it just makes it more diffic

Re: [PATCH next] drivers/net/wireless/ath/wil6210/debugfs.c: Use 'uint64_t' instead of 'cycles_t' to avoid warnings

2014-12-24 Thread Kalle Valo
Chen Gang writes: > Oh, sorry, I forgot the word wrap (after change a new pc). I shall send > patch v2 for it. While at it, could you also please simplify the title. You don't have to put the full directory there, it just makes it more difficult to read. This should be enough: wil6210: Use 'uin

[PATCH next v2] drivers/net/wireless/ath/wil6210/debugfs.c: Use 'uint64_t' instead of 'cycles_t' to avoid warnings

2014-12-24 Thread Chen Gang
do_div() checks the type strictly. 'cycles_t' may be 32-bit under quite a few architectures (parisc, arm, avr32 ...). So use 'uint64_t' instead of, the related warning (with allmodconfig under parisc): CC [M] drivers/net/wireless/ath/wil6210/debugfs.o In file included from arch/parisc/inclu

Re: [PATCH next] drivers/net/wireless/ath/wil6210/debugfs.c: Use 'uint64_t' instead of 'cycles_t' to avoid warnings

2014-12-24 Thread Chen Gang
Oh, sorry, I forgot the word wrap (after change a new pc). I shall send patch v2 for it. On 12/24/2014 10:40 PM, Chen Gang wrote: > do_div() checks the type strictly. 'cycles_t' may be 32-bit under quite > a few architectures (parisc, arm, avr32 ...). So use 'uint64_t' instead > of, the related wa

[PATCH next] drivers: net: wireless: ath: wil6210: debugfs: Use 'uint64_t' instead of 'cycles_t' to avoid warnings

2014-12-24 Thread Chen Gang
do_div() checks the type strictly. 'cycles_t' may be 32-bit under quite a few architectures (parisc, arm, avr32 ...). So use 'uint64_t' instead of, the related warning (with allmodconfig undr parisc): CC [M] drivers/net/wireless/ath/wil6210/debugfs.o In file included from arch/parisc/includ

[PATCH next] drivers/net/wireless/ath/wil6210/debugfs.c: Use 'uint64_t' instead of 'cycles_t' to avoid warnings

2014-12-24 Thread Chen Gang
do_div() checks the type strictly. 'cycles_t' may be 32-bit under quite a few architectures (parisc, arm, avr32 ...). So use 'uint64_t' instead of, the related warning (with allmodconfig under parisc): CC [M] drivers/net/wireless/ath/wil6210/debugfs.o In file included from arch/parisc/inclu

Re: [PATCH] brcmfmac: Do not crash if platform data is not populated

2014-12-24 Thread Kalle Valo
Mika Westerberg writes: > The driver looks for pdata->oob_irq_supported to find out if wowl can be > supported. However, not all platforms populate pdata in which case we crash > the kernel because of NULL pointer dereference. > > Fixes: 330b4e4be937 ("brcmfmac: Add wowl support for SDIO devices.

Re: [PATCH RFC] ipw2200: select CFG80211_WEXT

2014-12-24 Thread Kalle Valo
Paul Bolle writes: > Commit 24a0aa212ee2 ("cfg80211: make WEXT compatibility unselectable") > made it impossible to depend on CFG80211_WEXT. It does still allow to > select that symbol. (Yes, the commit summary is confusing.) > > So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver ca

[PATCH v3] NFC: port100: Introduce the use of function put_unaligned_le16

2014-12-24 Thread Vaishali Thakkar
This patch introduces the use of function put_unaligned_le16. This is done using Coccinelle and semantic patch used is as follows: @a@ typedef u16, __le16; {u16,__le16} e16; identifier tmp; expression ptr; expression y,e; type T; @@ - tmp = cpu_to_le16(y); <+... when != tmp ( - memcpy(ptr, (T

[PATCH] NFC: port100: Introduce the use of function put_unaligned_le16

2014-12-24 Thread Vaishali Thakkar
This patch introduces the use of function put_unaligned_le16. This is done using Coccinelle and semantic patch used is as follows: @a@ typedef u16, __le16; {u16,__le16} e16; identifier tmp; expression ptr; expression y,e; type T; @@ - tmp = cpu_to_le16(y); <+... when != tmp ( - memcpy(ptr, (T

[PATCH v2] NFC: port100: Introduce the use of function put_unaligned_le16a...@linux.intel.com,

2014-12-24 Thread Vaishali Thakkar
This patch introduces the use of function put_unaligned_le16. This is done using Coccinelle and semantic patch used is as follows: @a@ typedef u16, __le16; {u16,__le16} e16; identifier tmp; expression ptr; expression y,e; type T; @@ - tmp = cpu_to_le16(y); <+... when != tmp ( - memcpy(ptr, (T

[PATCH] cfg80211: check for carrier state only when offchanel CAC supported

2014-12-24 Thread Avinash Patil
Checking for carrier state during start_radar_detection is needed only for devices which support offchannel CAC. This patch provides this additional check of extended feature offchannel CAC support while checking for carrier state. Signed-off-by: Avinash Patil --- include/uapi/linux/nl80211.h |

[PATCH] ath10k: fix build error when hwmon is off

2014-12-24 Thread Rajkumar Manoharan
Place hwmon APIs inside CONFIG_HWMON switch to fix undefined errors when hwmon is not enabled. ERROR: "devm_hwmon_device_register_with_groups" [drivers/net/wireless/ath/ath10k/ath10k_core.ko] undefined! Reported-by: Kalle Valo Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath1

Re: [PATCH net-next] Allow to set net namespace for wireless device via RTM_LINK

2014-12-24 Thread Vadim Kochan
On Mon, Oct 20, 2014 at 1:52 PM, Johannes Berg wrote: > On Mon, 2014-10-20 at 12:46 +0200, Marcel Holtmann wrote: > >> Maybe relaxing the check and allow ip link to move a wireless netdev >> into a namespace (and having the wiphy follow) could be allowed if it >> is the only netdev or the original

Re: [PATCH] Drivers: bcma: Fix three coding style issues, more than 80 characters per line.

2014-12-24 Thread Òscar Forner Martínez
Hi Kalle, I am doing it from London with the timezone of Spain, maybe is that the odd stuff? I can change it and do the patch again. I will check the style guide to do the changes properly this time. I have a couple of questions, as it is my first patch I am not sure how to do them. Do I have

hostapd and 11h support

2014-12-24 Thread Arend van Spriel
Hi Jouni, I am looking at 11h support in hostapd. The supplicant uses .start_dfs_cac() driver callback (resulting in NL08211_CMD_RADAR_DETECT) and basically the CAC logic is done in the supplicant. Now for our devices the entire radar detection and CAC state machine is built in firmware. So h

[PATCHv3] mac80211: enable TPC through mac80211 stack

2014-12-24 Thread Lorenzo Bianconi
Control per packet Transmit Power Control (TPC) in lower drivers according to TX power settings configured by the user. In particular TPC is enabled if value passed in enum nl80211_tx_power_setting is NL80211_TX_POWER_AUTOMATIC (no limit from userspace) or NL80211_TX_POWER_LIMITED (allow using less

Re: [PATCH] NFC: port100: Introduce the use of function put_unaligned_le16

2014-12-24 Thread Arend van Spriel
On 12/24/14 03:35, Vaishali Thakkar wrote: On Wed, Dec 24, 2014 at 12:54 AM, Arend van Spriel wrote: On 12/23/14 16:27, Vaishali Thakkar wrote: This patch introduces the use of function put_unaligned_le16. This is done using Coccinelle and semantic patch used is as follows: @a@ typedef u16,

Re: rtl8723au system lock ups, possible code regression

2014-12-24 Thread Jesus Legaspy
plain text cc linux-wireless@vger.kernel.org On Wed, Dec 24, 2014 at 2:56 AM, Jesus Legaspy wrote: > > Hi Jes, > > I hope you're having a great Christmas celebration! > I've been having this issue for a while now, and decided to submit this bug > report as many others have similar problems. Hope

Re: [PATCH] Drivers: bcma: Fix three coding style issues, more than 80 characters per line.

2014-12-24 Thread Arend van Spriel
On 12/24/14 08:20, Kalle Valo wrote: Oscar Forner Martinez writes: Three lines with more than 80 characters per line have been split in several lines. Signed-off-by: Oscar Forner Martinez --- drivers/bcma/driver_chipcommon.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-)

Re: [PATCH 8/8] ath10k: ath10k: add support to send delba

2014-12-24 Thread Kalle Valo
Rajkumar writes: > On Tue, Dec 23, 2014 at 09:46:28AM +0200, Kalle Valo wrote: >> "Manoharan, Rajkumar" writes: >> >> >> Subject: [PATCH 8/8] ath10k: ath10k: add support to send delba >> >> >> >> This per-station debugfs entry helps to send delba in manual mode >> >> for debugging purpose. It

[PATCH v2 7/8] ath10k: add support to send addba response

2014-12-24 Thread Rajkumar Manoharan
This per-station debugfs entry helps to send addba response in manual mode for debugging purpose. It accepts tid and status code as input arguments. To send addba response, echo 0 25 >/sys/kernel/debug/ieee80211/phyX/netdev:wlanX/ stations/XX:XX:XX:XX:XX:XX/addba_resp Signed-off-by: R

[PATCH v2 8/8] ath10k: add support to send delba

2014-12-24 Thread Rajkumar Manoharan
This per-station debugfs entry helps to send delba in manual mode for debugging purpose. It accepts tid, initiator and reason code as inputs. To send delba, echo 0 1 37 >/sys/kernel/debug/ieee80211/phyX/netdev:wlanX/ stations/XX:XX:XX:XX:XX:XX/delba Signed-off-by: Rajkumar Manoharan

[PATCH v2 3/8] ath10k: add wmi support for addba_set_resp

2014-12-24 Thread Rajkumar Manoharan
Add WMI support for sending addba response manually. This command is used for debugging purpose. Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/wmi-ops.h | 20 drivers/net/wireless/ath/ath10k/wmi-tlv.c | 1 + drivers/net/wireless/ath/ath10k/wmi.c

[PATCH v2 5/8] ath10k: Implement sta_add_debugfs

2014-12-24 Thread Rajkumar Manoharan
Add per station debugfs files when a station is added to mac80211's station list. This helps to group peer specific debugfs entries altogether. Right now this callback adds support to test aggregation procedures (addba/addba_resp/delba) manually. To enable automatic aggregation in target, echo 0 >

[PATCH v2 6/8] ath10k: add support to send addba request

2014-12-24 Thread Rajkumar Manoharan
This per-station debugfs entry helps to send addba request in manual mode. Need to pass two configuration parameters (tid, buffer size) as input. To send addba, echo 1 32 >/sys/kernel/debug/ieee80211/phyX/netdev:wlanX/ stations/XX:XX:XX:XX:XX:XX/addba Signed-off-by: Rajkumar Manoharan

[PATCH v2 4/8] ath10k: add wmi support for delba_send

2014-12-24 Thread Rajkumar Manoharan
Add WMI support for sending delba request. This command is used for debugging purpose. Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/wmi-ops.h | 21 + drivers/net/wireless/ath/ath10k/wmi-tlv.c | 1 + drivers/net/wireless/ath/ath10k/wmi.c | 31

[PATCH v2 2/8] ath10k: add wmi support for addba_send

2014-12-24 Thread Rajkumar Manoharan
Add WMI support for sending addba request. This command is meant for debugging purpose. Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/wmi-ops.h | 19 +++ drivers/net/wireless/ath/ath10k/wmi-tlv.c | 1 + drivers/net/wireless/ath/ath10k/wmi.c | 30 +

[PATCH v2 0/8] ath10k: add per station debugfs support

2014-12-24 Thread Rajkumar Manoharan
The following patches add support for sending addba/addba response/delba for every station entries. These commands are purely for testing purpose. Before using any of the above aggregation commands, the mode should be moved to manual. To disable automatic aggretation in target echo 1 >/sys/kernel

[PATCH v2 1/8] ath10k: add wmi support for addba_clear_resp

2014-12-24 Thread Rajkumar Manoharan
Add WMI support for clearing addba response before switching aggregation mode (auto/manual) for debugging purpose. Signed-off-by: Rajkumar Manoharan --- drivers/net/wireless/ath/ath10k/wmi-ops.h | 18 ++ drivers/net/wireless/ath/ath10k/wmi-tlv.c | 1 + drivers/net/wireless/ath/a