[PATCH 0/2] ath10k: load device specific board files

2015-03-23 Thread Michal Kazior
Until now it was okay to use a very generic board data since OTP was supposed to fill in the blanks (except some cases in which a complete cal data is provided via cal-pci-xxx or device tree). However since qca6174 this has changed. It is now necessary to load specific board file for different

Re: mac80111: Add BIP-GMAC-128 and BIP-GMAC-256 ciphers

2015-03-23 Thread Jouni Malinen
On Thu, Mar 19, 2015 at 03:53:14PM +0300, Dan Carpenter wrote: The patch 8ade538bf39b: mac80111: Add BIP-GMAC-128 and BIP-GMAC-256 ciphers from Jan 24, 2015, leads to the following static checker warning: net/mac80211/aes_gmac.c 61 struct crypto_aead *ieee80211_aes_gmac_key_setup(const

RE: [patch] mwifiex: remove an unneede NULL check in mwifiex_init_adapter()

2015-03-23 Thread Amitkumar Karwar
Hi Dan, Thanks for the patch. Subject: [patch] mwifiex: remove an unneede NULL check in mwifiex_init_adapter() adapter-sleep_cfm is always non-NULL at this point. Static checkers complain that we already dereference it at the start of the function when we do:

Re: [PATCH 2/4] ath10k: add WOW disconnect/magic-packet support

2015-03-23 Thread Kalle Valo
Janusz Dziedzic janusz.dzied...@tieto.com writes: Add support for WOW disconnect and magic-packet. Signed-off-by: Janusz Dziedzic janusz.dzied...@tieto.com [...] +#ifdef CONFIG_PM +int ath10k_wow_init(struct ieee80211_hw *hw); [...] +#else +static inline int ath10k_wow_init(struct

Re: [PATCH v2 1/2] ath10k: fix rts profile for second rate series

2015-03-23 Thread Kalle Valo
Rajkumar Manoharan rmano...@qti.qualcomm.com writes: By default rts protection is enabled in firmware for the second rateset. Currently ath10k selects RTS profile (only for software retries), when legacy stations are associated or asked by mac80211. On congested environment, when AP is

ath10k: What will happens when radar is detected ?

2015-03-23 Thread Cedric VONCKEN
In 802.11ac standard, it is possible to dynamically reduce the channel width used. My question is: If I use a channel with 80 or 40 MHz width, what will happen if I detect radar? The ath10k card/driver reduces automatically the channel width. Cedric Voncken. -- To

Re: [PATCH v4 5/6] ath10k: add wmi support for tdls

2015-03-23 Thread Michal Kazior
On 22 March 2015 at 08:49, Arik Nemtsov a...@wizery.com wrote: On Fri, Mar 20, 2015 at 1:02 PM, Marek Puzyniak marek.puzyn...@tieto.com wrote: As a part of tdls implementation introduce tdls related wmi data structures, constant values and functions. Signed-off-by: Marek Puzyniak

[patch] mwifiex: remove an unneede NULL check in mwifiex_init_adapter()

2015-03-23 Thread Dan Carpenter
adapter-sleep_cfm is always non-NULL at this point. Static checkers complain that we already dereference it at the start of the function when we do: skb_put(adapter-sleep_cfm, sizeof(struct mwifiex_opt_sleep_confirm)); Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git

Re: mac80111: Add BIP-GMAC-128 and BIP-GMAC-256 ciphers

2015-03-23 Thread Dan Carpenter
On Mon, Mar 23, 2015 at 03:24:09PM +0200, Jouni Malinen wrote: This function should be a list of commands in a row with tiny detours for exceptions and error handling. It messes everyone up if the success path is hidden somewhere in the middle and it leads to bugs like this. I'm not sure

[patch] mac80111: aes_ccm: cleanup ieee80211_aes_key_setup_encrypt()

2015-03-23 Thread Dan Carpenter
This code is written using an anti-pattern called success handling which makes it hard to read, especially if you are used to normal kernel style. It should instead be written as a list of directives in a row with branches for error handling. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

Re: [PATCH v4 0/7] ath10k: add multi-channel support

2015-03-23 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: New qca6174 with wmi-tlv firmware supports multi-channel operation. To make use of it ath10k needs a few changes: implement mac80211's chanctx API and rework tx queue control a bit. 3-way merge fails: Applying: ath10k: allow empty ssid vdev

Re: [PATCH 1/2] ath10k: share board file loading code across FW APIs

2015-03-23 Thread Kalle Valo
Michal Kazior michal.kaz...@tieto.com writes: There's no need to implement the same thing twice. Reduce code duplication. Signed-off-by: Michal Kazior michal.kaz...@tieto.com [...] @@ -730,6 +716,12 @@ static int ath10k_core_fetch_firmware_files(struct ath10k *ar) /* calibration

Re: [PATCH v4 5/6] ath10k: add wmi support for tdls

2015-03-23 Thread Kalle Valo
Marek Puzyniak marek.puzyn...@tieto.com writes: As a part of tdls implementation introduce tdls related wmi data structures, constant values and functions. Signed-off-by: Marek Puzyniak marek.puzyn...@tieto.com This patch had non-trivial conflicts, please check carefully my resolution in

Re: [PATCH 2/2] mwifiex: recover from skb allocation failures during RX

2015-03-23 Thread James Cameron
On 24/03/2015, at 1:20 AM, Avinash Patil wrote: From: Zhaoyang Liu li...@marvell.com This patch adds recovery mechanism for SDIO RX during SKB allocation failures. For allocation failures during multiport aggregation, we skip and drop RX packets. For single port read case, we will use

Re: informations about Linux wifi driver's architecture today

2015-03-23 Thread Stefano Cappa
Oh thank you. Yes. This can be very useful. Da: Arend van Spriel ar...@broadcom.com Inviato: lunedì 23 marzo 2015 11.03.59 A: Stefano Cappa Cc: linux-wireless@vger.kernel.org Oggetto: Re: informations about Linux wifi driver's architecture today On

Re: broadcast ssid in scheduled scan

2015-03-23 Thread Arend van Spriel
On 03/23/15 19:38, Arend van Spriel wrote: Johannes, Jouni, I have noticed that under some circumstances wpa_supplicant initiates a scheduled scan with broadcast ssid. This is something our firmware can not do so could this be avoided? Maybe by adding a feature flag for it. I will look into it

[PATCH v3 0/1] New driver: rtl8723au (mac80211)

2015-03-23 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This is a new driver for the rtl8723au which was written from scratch, to utilize the Linux mac80211 stack. This has been a pet project for me for some time I finally feel it is stable enough to submit. I have used it for a while without any serious

Re: Broadcom 43340

2015-03-23 Thread Jürgen Bausa
Arend van Spriel arend@... writes: I now got it working. Just put 'sleeep 20' before the commands and now it works perfectly. Holding the boot for 20s is steep, but I guess a working device trumps a fast boot Systemd runs even rc.local in parallel. So it doesn't hold the boot

[PATCH] iwlwifi: Fix memory leak in iwl_req_fw_callback()

2015-03-23 Thread Larry Finger
In this routine, kzalloc allocates a memory block. This allocation is freed in the error paths, but not in the normal exit, thus the allocation is leaked. The kmemleak facility was used to find the leak. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Johannes Berg

Re: [PATCH v7 6/6] wlcore: remove wl12xx_platform_data

2015-03-23 Thread Eliad Peller
On Mon, Mar 23, 2015 at 10:21 AM, Sekhar Nori nsek...@ti.com wrote: On Wednesday 18 March 2015 10:08 PM, Eliad Peller wrote: Now that we have wlcore device-tree bindings in place (for both wl12xx and wl18xx), remove the legacy wl12xx_platform_data struct, and move its members into the

Re: Broadcom 43340

2015-03-23 Thread Arend van Spriel
On 03/22/15 21:14, Jürgen Bausa wrote: Arend van Sprielarend@... writes: On 03/21/15 21:38, Jürgen Bausa wrote: 1. the nvram file under /sys/firmware/efi/efivars/ has a wrong MAC address. I changed it to the correct one. However, I am not sure if this is really necassary. That MAC address

Re: [PATCH v2 2/2] ath10k: allow user to toggle ani_enable via debugfs

2015-03-23 Thread Ashok Raj Nagarajan
On Fri, Mar 20, 2015 at 10:28:06AM +0100, Jose Antonio Delgado Alfonso wrote: Hi Ashok, Just a quick question, is it supported by all firmware versions? Yes Jose. It is supported by all firmware versions. Thanks, Ashok Thanks, Jose A. Delgado On 19/03/15 12:08, Ashok Raj Nagarajan

[PATCH 2/2] mwifiex: recover from skb allocation failures during RX

2015-03-23 Thread Avinash Patil
From: Zhaoyang Liu li...@marvell.com This patch adds recovery mechanism for SDIO RX during SKB allocation failures. For allocation failures during multiport aggregation, we skip and drop RX packets. For single port read case, we will use preallocated card-mpa_rx.buf to complete cmd53 read. Now we

[PATCH 1/2] mwifiex: stop command path in suspend handler

2015-03-23 Thread Avinash Patil
Cancel all pending commands including scan commands and stop CAC during cfg80211 suspend handler. Signed-off-by: Avinash Patil pat...@marvell.com --- drivers/net/wireless/mwifiex/cfg80211.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v7 6/6] wlcore: remove wl12xx_platform_data

2015-03-23 Thread Sekhar Nori
On Monday 23 March 2015 01:57 PM, Eliad Peller wrote: I was applying the whole series, but over v4.0-rc1 :) Its best to mention the baseline in cover-letter itself. check out again the cover-letter. you probably overlooked it :) I see it now :) Thanks, Sekhar -- To unsubscribe from this

[PATCH] ath10k: fix aid setup in station mode

2015-03-23 Thread Michal Kazior
While debugging something else I noticed AID was set to 0. This could lead to powersave issues in station mode. Maybe this isn't really necessary but set it properly just to be sure. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/mac.c | 8 +++- 1

Re: [PATCH v7 6/6] wlcore: remove wl12xx_platform_data

2015-03-23 Thread Sekhar Nori
+ Ido On Wednesday 18 March 2015 10:08 PM, Eliad Peller wrote: Now that we have wlcore device-tree bindings in place (for both wl12xx and wl18xx), remove the legacy wl12xx_platform_data struct, and move its members into the platform device data (that is passed to wlcore) Davinci 850 is the

Re: [PATCH v7 6/6] wlcore: remove wl12xx_platform_data

2015-03-23 Thread Eliad Peller
hi Sekhar, On Mon, Mar 23, 2015 at 9:51 AM, Sekhar Nori nsek...@ti.com wrote: + Ido On Wednesday 18 March 2015 10:08 PM, Eliad Peller wrote: Now that we have wlcore device-tree bindings in place (for both wl12xx and wl18xx), remove the legacy wl12xx_platform_data struct, and move its

Re: [PATCH v7 6/6] wlcore: remove wl12xx_platform_data

2015-03-23 Thread Sekhar Nori
On Monday 23 March 2015 01:36 PM, Eliad Peller wrote: hi Sekhar, On Mon, Mar 23, 2015 at 9:51 AM, Sekhar Nori nsek...@ti.com wrote: + Ido On Wednesday 18 March 2015 10:08 PM, Eliad Peller wrote: Now that we have wlcore device-tree bindings in place (for both wl12xx and wl18xx), remove the

Re: [PATCH v4 5/6] ath10k: add wmi support for tdls

2015-03-23 Thread Marek Puzyniak
On 23 March 2015 at 09:09, Michal Kazior michal.kaz...@tieto.com wrote: On 22 March 2015 at 08:49, Arik Nemtsov a...@wizery.com wrote: On Fri, Mar 20, 2015 at 1:02 PM, Marek Puzyniak marek.puzyn...@tieto.com wrote: As a part of tdls implementation introduce tdls related wmi data structures,

Re: Broadcom 43340

2015-03-23 Thread Arend van Spriel
On 03/23/15 21:09, Jürgen Bausa wrote: Arend van Sprielarend@... writes: I now got it working. Just put 'sleeep 20' before the commands and now it works perfectly. Holding the boot for 20s is steep, but I guess a working device trumps a fast boot Systemd runs even rc.local in parallel.

Re: [PATCH 1/2] hs20-ca: Update key generation scripts and files.

2015-03-23 Thread Julian Calaby
Hi Ben, On Tue, Mar 24, 2015 at 5:03 AM, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com This lets us properly over-ride the default w1.fi related strings in order to properly generate keys that can be used by the OCSP process. Signed-off-by: Ben Greear

Re: [PATCH 1/2] hs20-ca: Update key generation scripts and files.

2015-03-23 Thread Ben Greear
On 03/23/2015 03:16 PM, Julian Calaby wrote: Hi Ben, On Tue, Mar 24, 2015 at 5:03 AM, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com This lets us properly over-ride the default w1.fi related strings in order to properly generate keys that can be used by the OCSP

[PATCH 2/2] hs20: Update hs20 server notes file.

2015-03-23 Thread greearb
From: Ben Greear gree...@candelatech.com Include example hostapd-radius config file for the OSEN radius server. Show example of how to use the ca/setup.sh script to generate keys. Show how to start OCSP responder and generate the ocsp cache file. Signed-off-by: Ben Greear

[PATCH 1/2] hs20-ca: Update key generation scripts and files.

2015-03-23 Thread greearb
From: Ben Greear gree...@candelatech.com This lets us properly over-ride the default w1.fi related strings in order to properly generate keys that can be used by the OCSP process. Signed-off-by: Ben Greear gree...@candelatech.com --- hs20/server/ca/openssl.cnf | 12 ++--

Re: [PATCH 1/2] hs20-ca: Update key generation scripts and files.

2015-03-23 Thread Ben Greear
Sorry, this should have gone elsewherewill re-send to the appropriate location. Thanks, Ben -- Ben Greear gree...@candelatech.com Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-23 Thread Joe Perches
On Mon, 2015-03-23 at 16:25 -0400, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing the mac80211 stack. trivia: diff --git a/drivers/net/wireless/rtl8xxxu.c

[PATCH] rtlwifi: rtl8192cu: Add new USB ID

2015-03-23 Thread Larry Finger
USB ID 2001:330d is used for a D-Link DWA-131. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Stable sta...@vger.kernel.org --- drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c

Re: [PATCH 1/2] hs20-ca: Update key generation scripts and files.

2015-03-23 Thread Julian Calaby
Hi Ben, On Tue, Mar 24, 2015 at 9:31 AM, Ben Greear gree...@candelatech.com wrote: On 03/23/2015 03:16 PM, Julian Calaby wrote: Hi Ben, On Tue, Mar 24, 2015 at 5:03 AM, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com This lets us properly over-ride the default

Re: [PATCH 1/1] New driver: rtl8723au (mac80211)

2015-03-23 Thread Jes Sorensen
Joe Perches j...@perches.com writes: On Mon, 2015-03-23 at 16:25 -0400, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com This is an alternate driver for the Realtek 8723AU (rtl8723au) written from scratch utilizing the mac80211 stack. trivia: diff --git