Re: packet loss, disconnects and possible bug in iwlwifi

2015-05-26 Thread Emmanuel Grumbach
On Wed, May 27, 2015 at 2:44 AM, Nick Dimov dimovn...@gmail.com wrote: Hello, thank you for your response. I attach the full syslog since the last boot which contains some disconnects. I enabled debug mode for wpa_supplicant with -dd option (let me know if you need anything else). I also

[PATCH] ray_cs: Change 1 to true for bool type variable.

2015-05-26 Thread Shailendra Verma
The variable translate is bool type.So assigning true instead of 1. Signed-off-by: Shailendra Verma shailendra.capric...@gmail.com --- drivers/net/wireless/ray_cs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ray_cs.c

pull-request: mac80211 2015-05-26

2015-05-26 Thread Johannes Berg
Hi Dave, Unfortunately I neglected to send this to you last week before our long weekend. These changes look fairly big, but they're fairly contained to the remain-on- channel and AP_VLAN key handling code. However, if you think you don't want to pull them into net any more at this stage just

Re: [PATCHv2 0/2] add mt7601u driver

2015-05-26 Thread Johannes Berg
On Mon, 2015-05-25 at 11:35 +0200, Jakub Kiciński wrote: I just dropped the line configuring HW promisc for now like Johannes did in his removal patch. However, the right fix is to configure it based on IEEE80211_CONF_MONITOR, correct? The two aren't equivalent, so no. FIF_PROMISC_IN_BSS

10ec:8176 rtl8192ce 200-3200+ms latency on 802.11n 2.4GHz network with no load

2015-05-26 Thread Christopher M. Penalver
[1.] One line summary of the problem: 10ec:8176 rtl8192ce 200-3200+ms latency on 802.11n 2.4GHz network with no load [2.] Full description of the problem/report: With an Asus PCE-N10 PCI-E Adapter Wireless N card (10ec:8176 rtl8192ce) I have 200-3200+ms latency on a 802.11n 2.4GHz network pinging

RE: [PATCH] mac80211: fix a NULL dereference in ath9k (and likely other drivers) when fixed mesh paths are used

2015-05-26 Thread Jesse Jones
Sounds good to me and I will try this though unfortunately not until next week when I get back from vacation. Thanks, Jesse -Original Message- From: Bob Copeland [mailto:m...@bobcopeland.com] Sent: Monday, May 25, 2015 9:16 AM To: Alexis Green Cc: Johannes Berg; linux-wireless; Jesse

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-26 Thread Larry Finger
On 05/26/2015 10:48 AM, Dan Carpenter wrote: On Tue, May 26, 2015 at 07:14:01AM -0700, Greg KH wrote: I take the blame for any problems with Outreachy patches. Given the huge volume of them, one bug out of 900 isn't that bad of a percentage. We don't get many bugs through outreachy, but this

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-26 Thread Larry Finger
On 05/26/2015 12:30 AM, Sudip Mukherjee wrote: On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote: On Tue, 2015-05-26 at 10:32 +0530, Sudip Mukherjee wrote: On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote: On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote: On Mon,

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-26 Thread Dan Carpenter
On Tue, May 26, 2015 at 09:35:55AM -0700, Greg KH wrote: Also, the outreachy patch process would overwhelm everyone else on the list, it's really high volume during the application phase, I'd prefer it to stick with the mentors that wish to help out with the process. If you and/or Dan, or

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-26 Thread Dan Carpenter
On Tue, May 26, 2015 at 10:06:17AM -0700, Joe Perches wrote: If you're collecting them, I suggest you stick them in a separate branch, post them to your driverdev list and cc the appropriate maintainers, wait a week, then apply them to your main branch. That would work. A massive thread is

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-26 Thread Greg KH
On Tue, May 26, 2015 at 10:06:17AM -0700, Joe Perches wrote: On Tue, 2015-05-26 at 09:35 -0700, Greg KH wrote: On Tue, May 26, 2015 at 07:48:59AM -0700, Joe Perches wrote: The main point is that patches shouldn't be applied without being submitted to a more widely read list.

Re: [NEXT] rtlwifi: btcoexist: Fix interference between rtl8723be andBluetooth

2015-05-26 Thread Kalle Valo
From: Daniel Drake dr...@endlessm.com During usage of the new Bluetooth driver for Realtek devices, it was found that BT scans were inhibited for the RTL8723BE when wireless was active. The exact cause of this interference is not known yet, but a satisfactory work around has been found

Re: rndis_wlan: harmless issue calling set_bit()

2015-05-26 Thread Kalle Valo
These are used like: set_bit(WORK_LINK_UP, priv-work_pending); The problem is that set_bit() takes the actual bit number and not a mask so static checkers get upset. It doesn't affect run time because we do it consistently, but we may as well clean it up. Fixes: 6010ce07a66c

[PATCH v2] cfg80211: properly send NL80211_ATTR_DISCONNECTED_BY_AP in disconnect

2015-05-26 Thread Johannes Berg
From: Johannes Berg johannes.b...@intel.com When we disconnect from the AP, drivers call cfg80211_disconnect(). This doesn't know whether the disconnection was initiated locally or by the AP though, which can cause problems with the supplicant, for example with WPS. This issue obviously doesn't

[PATCH 16/39] iwlwifi: mvm: BT Coex - remove useless code

2015-05-26 Thread Emmanuel Grumbach
Since we don't need to configure the Ack / CTS kill mask anymore in the new API, we don't need to iterate all the interfaces upon rssi event on one of the interfaces. Remove that code. Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com --- drivers/net/wireless/iwlwifi/mvm/coex.c | 43

[PATCH 17/39] iwlwifi: mvm: BT Coex - allocate a short command on the stack

2015-05-26 Thread Emmanuel Grumbach
The BT_CONFIG command used to be very long, hence it was allocated on the heap in the previous API. In the new API, this command is much smaller, and can now safely be allocated on the stack. Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com --- drivers/net/wireless/iwlwifi/mvm/coex.c

[PATCH 19/39] iwlwifi: mvm: add UMAC scan iteration complete notification

2015-05-26 Thread Emmanuel Grumbach
From: Avraham Stern avraham.st...@intel.com Add UMAC scan iteration complete notification. This notification can be enabled by setting scan_iter_notif_enabled through debugfs. Upon receiving this notification, print the list of channels that have been scanned in this iteration. This is useful for

[PATCH 07/39] iwlwifi: dump API to 14

2015-05-26 Thread Emmanuel Grumbach
The iwlmvm driver is now able to handle -14.ucode. Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com --- drivers/net/wireless/iwlwifi/iwl-7000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/iwlwifi/iwl-7000.c

[PATCH 05/39] iwlwifi: mvm: small fix in a comment about UMAC scan schedules

2015-05-26 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com The UMAC API supports multiple scan schedules, but now we use only a single one. Change the comment to make this clear and avoid confusion. Signed-off-by: Luciano Coelho luciano.coe...@intel.com Reviewed-by: David Spinadel david.spina...@intel.com

[PATCH 14/39] iwlwifi: mvm: Configure agg. queue before assigning it to STA

2015-05-26 Thread Emmanuel Grumbach
From: Andrei Otcheretianski andrei.otcheretian...@intel.com In order to imeplement the extended VI session feature for Miracast, the FW requires to detect the VI queue. The detection of the VI queue is done when it is assigned to a STA with ADD_STA command, so by this time the FW expects the

[PATCH 08/39] iwlwifi: pcie: simplify return value

2015-05-26 Thread Emmanuel Grumbach
This was spot by Coccinelle. Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com --- drivers/net/wireless/iwlwifi/pcie/trans.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/iwlwifi/pcie/trans.c

[PATCH 21/39] iwlwifi: mvm: make iwl_mvm_config_sched_scan_profiles() static

2015-05-26 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com The iwl_mvm_config_sched_scan_profiles() function is only used in scan.c, so remove the declaration from mvm.h and make it static. Signed-off-by: Luciano Coelho luciano.coe...@intel.com Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com ---

[PATCH 10/39] iwlwifi: 8000: fallback to default NVM file

2015-05-26 Thread Emmanuel Grumbach
From: Eran Harary eran.har...@intel.com Set a default NVM in case the userspace specifies a file that doesn't match the hardware version. This allows not to change the boot scripts when someone replaces the device with a newer hardware step. Signed-off-by: Eran Harary eran.har...@intel.com

[PATCH 18/39] iwlwifi: mvm: print scanned channel list on scan iteration complete notification

2015-05-26 Thread Emmanuel Grumbach
From: Avraham Stern avraham.st...@intel.com When receiving scan iteration complete notification, print a list of the channels that have been scanned in this iteration. This is useful for debugging. Signed-off-by: Avraham Stern avraham.st...@intel.com Signed-off-by: Emmanuel Grumbach

[PATCH 13/39] iwlwifi: mvm: handle device start failure correctly

2015-05-26 Thread Emmanuel Grumbach
From: Johannes Berg johannes.b...@intel.com If the device fails to start correctly prior to loading the regular runtime firmware (after having run the INIT firmware), treat that error correctly by actually checking the return value of _iwl_trans_start_hw() and stopping the device again before

[PATCH 09/39] iwlwifi: mvm: Add debugfs entry for Tx power limit

2015-05-26 Thread Emmanuel Grumbach
From: Matti Gottlieb matti.gottl...@intel.com Add debugfs entry for showing the different Tx power restrictions that are caused due to various reasons. Signed-off-by: Matti Gottlieb matti.gottl...@intel.com Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com ---

Re: [PATCH 07/39] iwlwifi: dump API to 14

2015-05-26 Thread Rafał Miłecki
On 26 May 2015 at 21:17, Emmanuel Grumbach emmanuel.grumb...@intel.com wrote: The iwlmvm driver is now able to handle -14.ucode. Dump? Bump? ;) -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at

pull request: iwlwifi-next 2015-05-26

2015-05-26 Thread Grumbach, Emmanuel
Hi Kalle, this is a pull request for 4.2. Nothing really stands out besides what I wrote in the tag. Even the diffstat hints what is the biggest part of this pull request :) Note that there are fixes here that didn't make it to my previous pull request for 4.1. I tagged them for stable since the

[PATCH 33/39] iwlwifi: pcie: Remove redundant check for family type

2015-05-26 Thread Emmanuel Grumbach
From: Avri Altman avri.alt...@intel.com This check for family type is redundant as the if clause above checks a family-dependent Boolean (which is not set for family 8000 anyway). Signed-off-by: Avri Altman avri.alt...@intel.com Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com ---

[PATCH 30/39] iwlwifi: mvm: remove code that stops multiple UMAC scans of a type

2015-05-26 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com We can only have one scan per type at the same time, so the code that tries to stop several scans of a type is unnecessary. Remove that to reduce code complexity. Signed-off-by: Luciano Coelho luciano.coe...@intel.com Reviewed-by: Johannes Berg

[PATCH 23/39] iwlwifi: mvm: reorganize scan stopping functions

2015-05-26 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com The iwl_mvm_scan_offload_stop() function is used to stop LMAC regular scan, stop LMAC scheduled scan and stop UMAC scheduled scans (but not UMAC regular scans), making it very difficult to read. Reorganize the scan stopping functions by creating

[PATCH 11/39] iwlwifi: update thermal throttling values for 8000 devices

2015-05-26 Thread Emmanuel Grumbach
From: Ido Yariv i...@wizery.com 8000 devices have different thermal throttling values from previous generations. Signed-off-by: Ido Yariv idox.ya...@intel.com Reviewed-by: Johannes Berg johannes.b...@intel.com Signed-off-by: Emmanuel Grumbach emmanuel.grumb...@intel.com ---

[PATCH 02/39] iwlwifi: mvm: fix ROC reference accounting

2015-05-26 Thread Emmanuel Grumbach
From: Eliad Peller el...@wizery.com commit b112889c5af8124 (iwlwifi: mvm: add Aux ROC request/response flow) added aux ROC flow in addition to the existing ROC flow. While doing it, it moved the ROC reference release to a common work item, which is being called for both the ROC and aux ROC flows.

[PATCH 26/39] iwlwifi: mvm: rename umac scan stop function

2015-05-26 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com For consistency with the LMAC functions, rename the UMAC scan stop function to iwl_mvm_umac_scan_stop(). Additionally, move things around a bit to avoid an unnecessary forward declaration. Signed-off-by: Luciano Coelho luciano.coe...@intel.com

[PATCH 24/39] iwlwifi: mvm: don't stop regular scans when going out of idle state

2015-05-26 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com It is not necessary to stop regular scans when going out of idle state. Previously, we were doing so for LMAC scans because the iwl_mvm_scan_offload_stop() function was stopping both kinds of scans. Now that we have more granularity, we can skip it.

[PATCH 34/39] iwlwifi: tracing: add rx cmd header fields

2015-05-26 Thread Emmanuel Grumbach
From: Eliad Peller el...@wizery.com Having explicit rx cmd header fields is useful, as it can be used for event filtering (e.g. saving only debug logs, rather than the whole data) Signed-off-by: Eliad Peller eliadx.pel...@intel.com Reviewed-by: Johannes Berg johannes.b...@intel.com

[PATCH 38/39] iwlwifi: mvm: implement the BlockAck related debug triggers

2015-05-26 Thread Emmanuel Grumbach
BlockAck sessions can have events that are interesting to debug. When we send or receive a BAR, it is may indicate that something bad is happening. Even more so when mac80211 tells us that a frame timed out in the reodering buffer. Add a few triggers for BlockAck session debugging. Allow per-TID

[PATCH 20/39] iwlwifi: mvm: fix the net-detect SSIDs report order

2015-05-26 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com After the scan refactor, the order of the SSIDs passed to the firmware in all scans (including net-detect) are inverted. This was causing the reporting code to use the wrong SSIDs. To fix this, invert the array index when accessing the saved match

[PATCH 32/39] iwlwifi: nvm: fix otp parsing in 8000 hw family

2015-05-26 Thread Emmanuel Grumbach
From: Liad Kaufman liad.kauf...@intel.com The radio cfg DWORD was taken from the wrong place in the 8000 HW family, after a line in the code was wrongly changed by mistake. This broke several 8260 devices. CC: sta...@vger.kernel.org [4.1] Fixes: 5dd9c68a854a (iwlwifi: drop support for early

[PATCH 04/39] iwlwifi: Remove use of the deprecacted PTR_RET

2015-05-26 Thread Emmanuel Grumbach
From: Nicholas Krause xerofo...@gmail.com This removes the use of the two deprecated calls to the macro PTR_RET in iwl_mvm_get_regdomain and replaces them both to PTR_ERR_OR_ZERO. Signed-off-by: Nicholas Krause xerofo...@gmail.com [Commit message editing] Signed-off-by: Emmanuel Grumbach

[PATCH 39/39] iwlwifi: mvm: clean interfaces on drv_stop

2015-05-26 Thread Emmanuel Grumbach
From: Arik Nemtsov a...@wizery.com If a HW recovery was started but not completed since all interfaces went down, make sure to cleanup all interfaces before clearing the HW_RESTART flag. Signed-off-by: Arik Nemtsov arikx.nemt...@intel.com Reviewed-by: Johannes Berg johannes.b...@intel.com

[PATCH 28/39] iwlwifi: mvm: add support for 8 level scan priority API

2015-05-26 Thread Emmanuel Grumbach
From: Avraham Stern avraham.st...@intel.com Add support for scan priority API with 8 levels instead of the existing 3 levels. This API is needed to define the priority of new ooc activities, e.g. gscan. Add a TLV flag to indicate if the new API is supported so that devices that does not support

[PATCH 36/39] iwlwifi: mvm: make UMAC scans use the stopping scan status

2015-05-26 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com UMAC scans now use the general scan status for almost everything, the only part missing was in the scan complete notifications. Change it to use the stopping flags instead of clearing the flags when the stop comes from above and clean the handler

[PATCH 01/39] iwlwifi: pcie: don't call set_pwr functions for family 8000

2015-05-26 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com We should not call the iwl_pcie_set_pwr() functions in the suspend/resume flows for family 8000, because the register used is locked in devices from this family. Doing this causes an NMI protection error (RT_NMI_INTERRUPT_PREG_PROTECTION). To fix

[PATCH 27/39] iwlwifi: mvm: rename some LMAC-specific scan functions

2015-05-26 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com Some LMAC specific functions had too generic names (i.e. *_scan_offload_*) and were hard to distinguish from functions that are really generic. Rename these functions to *_lmac_scan_* in to make it more consistent and easier to read. Signed-off-by:

[PATCH 29/39] iwlwifi: mvm: refactor UMAC scan UID handling

2015-05-26 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com We can only have one scan of each type running at the same time, so we can remove one attribute in the UID information we save. We had array index, UID and type, but only UID (== array_index) and type are necessary. Refactor the code to use this

[PATCH 03/39] iwlwifi: pcie: fix tracking of cmd_in_flight

2015-05-26 Thread Emmanuel Grumbach
From: Ilan Peer ilan.p...@intel.com The cmd_in_flight tracking was introduced to workaround faulty power management hardware, by having the driver keep the NIC awake as long as there are commands in flight. However, some of the code handling this workaround was unconditionally executed, which

[PATCH 35/39] iwlwifi: mvm: combine regular and sched scan stop functions

2015-05-26 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com The regular and scheduled scan functions are very similar, so they can be combined into one. Signed-off-by: Luciano Coelho luciano.coe...@intel.com Reviewed-by: Johannes Berg johannes.b...@intel.com Signed-off-by: Emmanuel Grumbach

[PATCH 12/39] iwlwifi: mvm: advertise randomised netdetect MAC address

2015-05-26 Thread Emmanuel Grumbach
From: Johannes Berg johannes.b...@intel.com According to the nl80211 documentation, we can neither advertise scheduled scan nor netdetect address randomisation. However, all the products that currently require this don't have a need for the full randomisation. Therefore, advertise the feature

[PATCH 25/39] iwlwifi: mvm: combine part of the scan stop flows

2015-05-26 Thread Emmanuel Grumbach
From: Luciano Coelho luciano.coe...@intel.com For UMAC scans, we were simply jumping into another function when scan stop functions were called, while for LMAC scans, the flow continued. To make the flows cleaner and more balanced, combine the UMAC part into the main stop functions. This also

[PATCH 22/39] iwlwifi: mvm: BT Coex - fix shared antenna check with new API

2015-05-26 Thread Emmanuel Grumbach
The commit below fixed this for the old firmware API only. Since the new firmware API hasn't been released yet, this doesn't fix anything on currently existing firmwares. This completes: commit afcee962b09842d0f4191beb4a2d08251b4c7705 Author: Eyal Shapira e...@wizery.com Date: Mon Feb 9

Re: [RFD] linux-firmware key arrangement for firmware signing

2015-05-26 Thread Mimi Zohar
On Tue, 2015-05-26 at 18:08 +0100, One Thousand Gnomes wrote: IMHO we want the supplier of a given firmware providing signatures on the firmware git tree if this is done. A generic linux-firmware owned key would be both a horrendously inviting attack target, and a single point of failure.

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-26 Thread Greg KH
On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote: On Tue, 2015-05-26 at 10:32 +0530, Sudip Mukherjee wrote: On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote: On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote: On Mon, May 25, 2015 at 10:37:28AM -0700, Joe

Re: [v2, 1/2] adm8211: fix checkpatch errors for indentation and new line

2015-05-26 Thread Kalle Valo
This patch fixes these checkpatch.pl errors around a single switch-case block: ERROR: switch and case should be at the same indent ERROR: trailing statements should be on next line More specifically, the fix has been applied to the five occurances of the errors listed below. ERROR:

Re: [PATCH v3] brcmfmac: prohibit ACPI power management for brcmfmac driver

2015-05-26 Thread Kalle Valo
Fu, Zhonghui zhonghui...@linux.intel.com writes: ACPI will manage WiFi chip's power state during suspend/resume process on some tablet platforms(such as ASUS T100TA). This is not supported by brcmfmac driver now, and the context of WiFi chip will be damaged after resume. This patch informs

Re: rtlwifi: rtl8188ee: Fix pwrseqcmd.h include path.

2015-05-26 Thread Kalle Valo
Signed-off-by: Lauri Kenttä lauri.ken...@gmail.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [1/2] rtlwifi: rtl8192cu: Remove setting REG_BCN_MAX_ERR code in_rtl92cu_set_media_status().

2015-05-26 Thread Kalle Valo
Initialization routine set REG_BCN_MAX_ERR to 0xFF. also _rtl92cu_set_media_status set REG_BCN_MAX_ERR to same value. so i remove this code. Signed-off-by: Taehee Yoo ap420...@gmail.com Thanks, 2 patches applied to wireless-drivers-next.git: dacc7e193985 rtlwifi: rtl8192cu: Remove setting

Re: [PATCH wireless-next] mac80211: fix double flush workqueue

2015-05-26 Thread Johannes Berg
On Mon, 2015-05-25 at 09:32 +0530, Varka Bhadram wrote: Initially flushing of workqueue is done at [1], and also flushing of the same workqueue has done with ieee80211_stop_device() at [2]. [1]:https://git.kernel.org/cgit/linux/kernel/git/jberg/mac80211-next.git/tree/net/mac80211/pm.c#n50

Re: [PATCH 5/6] mwifiex: use generic name 'device dump'

2015-05-26 Thread Johannes Berg
On Tue, 2015-05-26 at 06:34 -0700, Amitkumar Karwar wrote: Currently we are dumping driver information also inside firmware dump API. We will call it as device dump and dump driver and firmware data separately. Honestly, I don't think this matters. I called it 'devcoredump' or 'device' because

[PATCH for-4.1] brcmfmac: avoid null pointer access when brcmf_msgbuf_get_pktid() fails

2015-05-26 Thread Arend van Spriel
The function brcmf_msgbuf_get_pktid() may return a NULL pointer so the callers should check the return pointer before accessing it to avoid the crash below (see [1]): brcmfmac: brcmf_msgbuf_get_pktid: Invalid packet id 273 (not in use) BUG: unable to handle kernel NULL pointer dereference at

Re: [PATCH for-4.1] brcmfmac: avoid null pointer access when brcmf_msgbuf_get_pktid() fails

2015-05-26 Thread Arend van Spriel
On 05/26/15 13:19, Arend van Spriel wrote: The function brcmf_msgbuf_get_pktid() may return a NULL pointer so the callers should check the return pointer before accessing it to avoid the crash below (see [1]): brcmfmac: brcmf_msgbuf_get_pktid: Invalid packet id 273 (not in use) BUG: unable to

Re: rtlwifi: fix typos in Kconfig

2015-05-26 Thread Kalle Valo
This patch fixes typos in drivers/net/wirless/rtlwifi/Kconfig. Signed-off-by: Kevin Lo ke...@kevlo.org Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the body of a message to majord...@vger.kernel.org

[PATCH 4/6] mwifiex: minor changes in debug messages

2015-05-26 Thread Amitkumar Karwar
Small letters are used in debug messages to match coding style at other places. Signed-off-by: Amitkumar Karwar akar...@marvell.com Signed-off-by: Cathy Luo c...@marvell.com --- drivers/net/wireless/mwifiex/main.c | 8 drivers/net/wireless/mwifiex/sdio.c | 4 ++-- 2 files changed, 6

[PATCH 2/6] mwifiex: fix a possible double free issue

2015-05-26 Thread Amitkumar Karwar
As drv_info_dump pointer doesn't get reset, we may end up freeing the allocated memory twice. Signed-off-by: Amitkumar Karwar akar...@marvell.com Signed-off-by: Cathy Luo c...@marvell.com --- drivers/net/wireless/mwifiex/init.c | 1 + drivers/net/wireless/mwifiex/main.c | 1 + 2 files changed, 2

[PATCH 6/6] mwifiex: device dump support via devcoredump framework

2015-05-26 Thread Amitkumar Karwar
Currently device dump generated in the driver is retrieved using ethtool set/get dump commands. We will get rid of ethtool approach and use devcoredump framework. Device dump can be trigger by cat /debugfs/mwifiex/mlanX/device_dump and when the dump operation is completed, data can be read by cat

[PATCH 1/6] mwifiex: fix SDIO firmware dump problem

2015-05-26 Thread Amitkumar Karwar
It's been observed that firmware doesn't go back to normal state when all firmware memories are dumped. As a result, further commands are blocked. This happens due to missing driver change of writing READ DONE to control register for SDIO interface. This patch adds a missing change to fix the

[PATCH 0/6] mwifiex: device dump enhancements

2015-05-26 Thread Amitkumar Karwar
This patch series fixes couple of bugs in device dump code paths, makes use of devcoredump mechanism after removing 'ethtool dump' approach. Amitkumar Karwar (6): mwifiex: fix SDIO firmware dump problem mwifiex: fix a possible double free issue mwifiex: dump driver information for PCIe

[PATCH 5/6] mwifiex: use generic name 'device dump'

2015-05-26 Thread Amitkumar Karwar
Currently we are dumping driver information also inside firmware dump API. We will call it as device dump and dump driver and firmware data separately. Signed-off-by: Amitkumar Karwar akar...@marvell.com Signed-off-by: Cathy Luo c...@marvell.com --- drivers/net/wireless/mwifiex/README| 6

[PATCH 3/6] mwifiex: dump driver information for PCIe interface

2015-05-26 Thread Amitkumar Karwar
Currently we are dumping driver information only for SDIO interface. This patch adds missing mwifiex_dump_drv_info() call for PCIe interface. Signed-off-by: Amitkumar Karwar akar...@marvell.com Signed-off-by: Cathy Luo c...@marvell.com --- drivers/net/wireless/mwifiex/pcie.c | 2 ++ 1 file

Re: [1/6] brcmfmac: allow device tree node without 'interrupts' property

2015-05-26 Thread Kalle Valo
As described in the device tree bindings for 'brcm,bcm4329-fmac' nodes, the interrupts property is optional. So adding a check for the presence of this property before attempting to parse and map the interrupt. If not present or parsing fails return and fallback to in-band sdio interrupt.

Re: [1/4] mwifiex: add support for FW memory read/write operations

2015-05-26 Thread Kalle Valo
From: Chin-ran Lo c...@marvell.com This patch adds support for FW memory read/write operations via debugfs. This is useful during debugging FW issues. Examples: For reading FW memory location: echo r 0x01ac /sys/kernel/debug/mwifiex/mlan0/memrw cat

Re: brcmfmac: avoid gcc-5.1 warning

2015-05-26 Thread Kalle Valo
gcc-5.0 gained a new warning in the fwsignal portion of the brcmfmac driver: drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c: In function 'brcmf_fws_txs_process': drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c:1478:8: warning: 'skb' may be used uninitialized in this function

[PATCH] ath10k: add missing firmware declarations

2015-05-26 Thread Michal Kazior
This could lead userspace initram images getting built without necessary firmware files included leading to probing failures of ath10k on boot with QCA61X4. Signed-off-by: Michal Kazior michal.kaz...@tieto.com --- drivers/net/wireless/ath/ath10k/pci.c | 2 ++ 1 file changed, 2 insertions(+)

Re: ath9k: split ar5008_hw_spur_mitigate and reuse common code inar9002_hw_spur_mitigate.

2015-05-26 Thread Kalle Valo
[ar5008 and ar9002]_hw_spur_mitigate have big portion of identical code. This patch will move common part of ar5008_hw_spur_mitigate to ar5008_hw_cmn_spur_mitigate and reuse it in ar9002_hw_spur_mitigate. As noticed by Joe Perches I reuse ar9002_hw_spur_mitigate (const) version of

Re: [1/5] rtlwifi: Update regulatory database

2015-05-26 Thread Kalle Valo
From: Shao Fu sha...@realtek.com Driver rtlwifi maintains its own regulatory information, The Chrome Autotest (https://www.chromium.org/chromium-os/testing/autotest-user-doc) showed some errors. This patch adds the necessary information for rtlwifi. Signed-off-by: Shao Fu

Re: [PATCHv3 0/2] add mt7601u driver

2015-05-26 Thread Kalle Valo
Jakub Kicinski moorr...@wp.pl writes: From: Jakub Kicinski kubak...@wp.pl This miniseries adds support for the simplest of MediaTek Wi-Fi devices. MT7601U is a single stream bgn chip with no bells or whistles. My driver is partially based on Felix's mt76 but IMHO it doesn't make sense to

Re: [4.1] rtlwifi: Remove the clear interrupt routine from all drivers

2015-05-26 Thread Kalle Valo
From: Vincent Fann vincent_f...@realtek.com Several of these drivers have there TX randomly blocked for 3~5 seconds while measuring tx throughput (iperf). The root couse happens in rtl_pci_flush(). The function uses a while-loop to wait for TX queue length to decrease to 0. The TX queue

Re: bcma: add module_bcma_driver()

2015-05-26 Thread Kalle Valo
This makes it possible to save some lines of code in drivers with an simple bcma driver registration. Signed-off-by: Hauke Mehrtens ha...@hauke-m.de Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe linux-wireless in the

Re: [PATCH] staging: rtl8723au: fix sparse warning

2015-05-26 Thread Jes Sorensen
Juston Li juston.h...@gmail.com writes: change cast to __le16 to fix the following warning: drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:1488:20: warning: cast to restricted __le16 Signed-off-by: Juston Li juston.h...@gmail.com --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c |

wl18xx: wlconf kernel compatibility

2015-05-26 Thread Yegor Yefremov
How do I know, which wlconf version is compatible with which kernel version? I have following problem: I have *.INI file for my particular WLAN chip. This file will be used to produce wl18xx-conf.bin. The size of this file will be check during device initialization. Depending on which kernel

Re: [PATCH] mac80211: fix a NULL dereference in ath9k (and likely other drivers) when fixed mesh paths are used

2015-05-26 Thread Johannes Berg
On Mon, 2015-05-25 at 12:15 -0400, Bob Copeland wrote: On Thu, May 21, 2015 at 06:05:13PM -0700, Alexis Green wrote: This patch fixes a NULL dereference in ath9k (and likely other drivers) when fixed mesh paths are used. The problem is that when a station comes up sta_info_alloc allocates

Re: [v2] mwifiex: reduce severity of debug messages for mgmt rx

2015-05-26 Thread Kalle Valo
This would ensure dmesg logs are not spammed with unknown mgmt frame subtype messages. Reviewed-by: James Cameron qu...@laptop.org Signed-off-by: Avinash Patil pat...@marvell.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line

Re: [RFD] linux-firmware key arrangement for firmware signing

2015-05-26 Thread David Howells
One Thousand Gnomes gno...@lxorguk.ukuu.org.uk wrote: Ie you need to sign something more than the firmware, such as (firmware, modinfo), so it's signed for firmware X on PCI:8086,1114 or firmware Y on ACPI:0A1D I'm suggesting that we use the name string passed to request_firmware(). IMHO we

Re: pull-request: mac80211 2015-05-26

2015-05-26 Thread David Miller
From: Johannes Berg johan...@sipsolutions.net Date: Tue, 26 May 2015 09:25:03 +0200 Unfortunately I neglected to send this to you last week before our long weekend. These changes look fairly big, but they're fairly contained to the remain-on- channel and AP_VLAN key handling code.

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-26 Thread Greg KH
On Tue, May 26, 2015 at 07:48:59AM -0700, Joe Perches wrote: On Tue, 2015-05-26 at 07:14 -0700, Greg KH wrote: On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote: As far as I understand, the Eudyptula Challenge list has internal mechanisms to nominally review patches before some

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-26 Thread Dan Carpenter
On Tue, May 26, 2015 at 07:14:01AM -0700, Greg KH wrote: I take the blame for any problems with Outreachy patches. Given the huge volume of them, one bug out of 900 isn't that bad of a percentage. We don't get many bugs through outreachy, but this isn't the first one. For example, in March and

Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()

2015-05-26 Thread Joe Perches
On Tue, 2015-05-26 at 09:35 -0700, Greg KH wrote: On Tue, May 26, 2015 at 07:48:59AM -0700, Joe Perches wrote: The main point is that patches shouldn't be applied without being submitted to a more widely read list. I take the blame for any problems with Outreachy patches. Are