[PATCH V2] iw: Avoid possible memory leak for cb

2015-08-25 Thread Amit Khatri
cb got memory from nl_cb_alloc() but not doing free during error case and use same lable to go out from function. Signed-off-by: Amit Khatri Signed-off-by: Rahul Jain --- iw.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/iw.c b/iw.c index ec56736..1385441 10064

Re: Getting started on switching rtl8188eu staging driver to LIB80211/MAC80211

2015-08-25 Thread Sreenath Madasu
Thanks Larry, I will look at those drivers Sreenath On Mon, Aug 24, 2015 at 09:42:42AM -0500, Larry Finger wrote: > On 08/23/2015 06:40 PM, Sreenath Madasu wrote: > > Hi all, > > I want to work on the TODO tasks > > > > - switch to use LIB80211 > > - switch to use MAC80211 > > > > for staging drive

Re: bcmdhd: Concurrent use of wlan0 and virtual interface in managed mode

2015-08-25 Thread Gucea Doru
Hello, Arend On Mon, Aug 24, 2015 at 11:08 AM, Arend van Spriel wrote: > On 08/23/2015 05:15 PM, Gucea Doru wrote: >> >> Hello, community > > > As you are using bcmdhd I don't think this particular community cares a lot > about it. But I will take the bait ;-) > Thanks for taking the bait :). Sh

Re: [PATCH/RFT 0/2] ath10k: add qca6164 support

2015-08-25 Thread Arnd Bergmann
On Tuesday 25 August 2015 15:47:45 Arnd Bergmann wrote: > On Tuesday 25 August 2015 15:09:45 Michal Kazior wrote: > > > > This is some weird regression with MSI ranges and we still haven't > > figured this out. > > > > For the time being add "irq_mode=1" parameter when loading ath10k_pci > > modu

Re: set channel from radiotap headers during injection

2015-08-25 Thread Johannes Berg
On Tue, 2015-08-25 at 10:47 -0700, Allan Matthew wrote: > > Where would I stick the transmit power control? In the > ieee80211_tx_info->control somewhere, or maybe in the > ieee80211_tx_info->rate_driver_data? It's got to be in control, but not sure where - perhaps look at minstrel blues stuff?

Re: set channel from radiotap headers during injection

2015-08-25 Thread Allan Matthew
On Tue, Aug 25, 2015 at 2:36 AM, Johannes Berg wrote: > It's ... complicated. First of all, it's currently not supported I > believe, in general, since there's no parsing code. Obviously, parsing > code can be changed, and I think there might even be patches floating > around for that. Adding thi

Re: [PATCH V3 0/6] brcmfmac: nvram loading and code rework

2015-08-25 Thread Kalle Valo
Arend van Spriel writes: > On 08/25/2015 06:09 PM, Rafał Miłecki wrote: >> On 20 August 2015 at 22:06, Arend van Spriel wrote: >>> This series comprises of following changes: >>> - support NVRAM loading for bcm47xx platform. >>> - revise announced interface combinations and validate against it.

Re: [PATCH V3 0/6] brcmfmac: nvram loading and code rework

2015-08-25 Thread Arend van Spriel
On 08/25/2015 06:09 PM, Rafał Miłecki wrote: On 20 August 2015 at 22:06, Arend van Spriel wrote: This series comprises of following changes: - support NVRAM loading for bcm47xx platform. - revise announced interface combinations and validate against it. - new debugfs entry for msgbuf protocol l

Re: [PATCH] rfkill: Copy "all" global state to other types

2015-08-25 Thread Marcel Holtmann
Hi Joao Paulo, > When switching the state of all RFKill switches of type all we need to > replicate the RFKILL_TYPE_ALL global state to all the other types global > state, so it is used to initialize persistent RFKill switches on > register. > > Signed-off-by: João Paulo Rechi Vita > --- > net/r

Re: [PATCH V3 0/6] brcmfmac: nvram loading and code rework

2015-08-25 Thread Rafał Miłecki
On 20 August 2015 at 22:06, Arend van Spriel wrote: > This series comprises of following changes: > - support NVRAM loading for bcm47xx platform. > - revise announced interface combinations and validate against it. > - new debugfs entry for msgbuf protocol layer used with PCIe devices. > - PCIe fi

Re: [PATCH/RFT 0/2] ath10k: add qca6164 support

2015-08-25 Thread Arnd Bergmann
On Tuesday 25 August 2015 15:09:45 Michal Kazior wrote: > > This is some weird regression with MSI ranges and we still haven't > figured this out. > > For the time being add "irq_mode=1" parameter when loading ath10k_pci > module, please. Ok, that gets the device to show up without errors. I hav

Re: [PATCH/RFT 0/2] ath10k: add qca6164 support

2015-08-25 Thread Michal Kazior
On 25 August 2015 at 14:56, Arnd Bergmann wrote: > On Thursday 13 August 2015 14:32:25 Michal Kazior wrote: >> Hi everyone, >> >> Looks like ath10k is very close to finally support >> qca6164. Recent discussion[1] led to a working >> prototype[2][3]. >> >> I'm CCing everyone I've found in my mailb

Re: [PATCH/RFT 0/2] ath10k: add qca6164 support

2015-08-25 Thread Kalle Valo
Arnd Bergmann writes: > On Tuesday 18 August 2015 11:52:45 Oscar Rydberg wrote: >> I can confirm this patch did it for my Lenovo Yoga 3 14 with QCA6164, the >> WLAN interface is now alive, up and running perfectly fine! >> (After running modprobe -r ideapad-laptop that is, should anyone have >> t

[PATCH] rfkill: Copy "all" global state to other types

2015-08-25 Thread João Paulo Rechi Vita
When switching the state of all RFKill switches of type all we need to replicate the RFKILL_TYPE_ALL global state to all the other types global state, so it is used to initialize persistent RFKill switches on register. Signed-off-by: João Paulo Rechi Vita --- net/rfkill/core.c | 9 - 1 f

Re: [PATCH/RFT 0/2] ath10k: add qca6164 support

2015-08-25 Thread Arnd Bergmann
On Thursday 13 August 2015 14:32:25 Michal Kazior wrote: > Hi everyone, > > Looks like ath10k is very close to finally support > qca6164. Recent discussion[1] led to a working > prototype[2][3]. > > I'm CCing everyone I've found in my mailbox that > complained about QCA6164 not working. Hopefully

Re: rsi: Fix possible leak when loading firmware

2015-08-25 Thread Kalle Valo
> Commit 5d5cd85ff441 ("rsi: Fix failure to load firmware after memory > leak fix and fix the leak") also added a check on the allocation of > DMA-accessible memory that may directly return. In that case the > already allocated firmware data is leaked. Make sure the data is > always freed correctl

Re: [PATCH V3 0/6] brcmfmac: nvram loading and code rework

2015-08-25 Thread Kalle Valo
Arend van Spriel writes: > On 08/20/2015 11:20 PM, Rafał Miłecki wrote: >> On 20 August 2015 at 22:06, Arend van Spriel wrote: >>> This series comprises of following changes: >>> - support NVRAM loading for bcm47xx platform. >>> - revise announced interface combinations and validate against it.

Re: [V3,1/6] brcmfmac: correct interface combination info

2015-08-25 Thread Kalle Valo
> The interface combination provided by brcmfmac did not truly reflect > the combinations supported by driver and/or firmware. > > Reviewed-by: Hante Meuleman > Reviewed-by: Franky (Zhenhui) Lin > Reviewed-by: Pieter-Paul Giesberts > Reviewed-by: Pontus Fuchs > Signed-off-by: Arend van Spriel

Re: [PATCH] brcmfmac: check all combinations when setting wiphy's addresses

2015-08-25 Thread Kalle Valo
Rafał Miłecki writes: > Broadcom is working on better reflection of interface combinations. With > upcoming patches we may have 1st combination supporting less interfaces > than others. > To don't run out of addresses check all combinations to find the one > with the greatest max_interfaces value

Re: [patch] mwifiex: fix mwifiex_rdeeprom_read()

2015-08-25 Thread Kalle Valo
Dan Carpenter writes: > There were several bugs here. > > 1) The done label was in the wrong place so we didn't copy any > information out when there was no command given. > > 2) We were using PAGE_SIZE as the size of the buffer instead of > "PAGE_SIZE - pos". > > 3) snprintf() returns

Re: [v2] rtlwifi: rtl8192cu: Add new device ID

2015-08-25 Thread Kalle Valo
> The v2 of NetGear WNA1000M uses a different idProduct: USB ID 0846:9043 > > Signed-off-by: Adrien Schildknecht > Cc: Stable > Acked-by: Larry Finger Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the

Re: rtlwifi: rtl8192ee: fix semicolon.cocci warnings

2015-08-25 Thread Kalle Valo
> drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:856:2-3: Unneeded semicolon > drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:492:3-4: Unneeded semicolon > drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:452:3-4: Unneeded semicolon > > > Remove unneeded semicolon. > > Generated by: scripts/coccinelle

Re: [v2] ath9k_htc: do ani shortcalibratio if we got -ETIMEDOUT

2015-08-25 Thread Kalle Valo
> current code will handle -ETIMEDOUT as success which is probalbly wrong. > > According to this comment I assume it is safe to handle -ETIMEDOUT as false: > drivers/net/wireless/ath/ath9k/calib.c > 290 /* > 291 * We timed out waiting for the noisefloor to load, probably due > t

Re: pull request: iwlwifi-next 2015-08-23

2015-08-25 Thread Kalle Valo
"Grumbach, Emmanuel" writes: > one very last pull request for 4.3 before the merge windows opens. I > hope it will make it. Let me know if you have issues with it. > > Thanks! > > The following changes since commit ecc7c518b3017821a6b26fb5fdaa548afa8ee236: > > iwlwifi: mvm: fix a race in D0i3 v

Re: Getting started on switching rtl8188eu staging driver to LIB80211/MAC80211

2015-08-25 Thread Hans Ulli Kroll
Hi On Sun, 23 Aug 2015, Sreenath Madasu wrote: > Hi all, > I want to work on the TODO tasks > > - switch to use LIB80211 > - switch to use MAC80211 > > for staging driver rtl8188eu. > > How can I start? Where is the documentation? > Thanks > Sreenath > I have the same problems with my RTL882

Re: set channel from radiotap headers during injection

2015-08-25 Thread Johannes Berg
On Mon, 2015-08-24 at 17:46 -0700, Allan Matthew wrote: > > Johannes- What about txpower? Should this be configurable through > the radiotap headers? It's ... complicated. First of all, it's currently not supported I believe, in general, since there's no parsing code. Obviously, parsing code ca