Re: Rate limiting AP bandwidth change messages in ieee80211_config_bw?

2015-09-30 Thread Johannes Berg
On Wed, 2015-09-30 at 13:02 -0400, Josh Boyer wrote: > Hi Johannes, > > We've seen a handful of reports that seem to have verbose output from > the ieee80211_config_bw function in net/mac80211/mlme.c. It looks > similar to this: > > [ 66.578652] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth,

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Ben Greear
On 09/30/2015 10:14 AM, Johannes Berg wrote: On Wed, 2015-09-30 at 08:44 -0700, Ben Greear wrote: Any idea how this could be done in the stack instead of the driver? I don't see why it should be? The problem is that this is a receiver-side issue, so even if I manage to hack the ath10k

Re: Low latency communication over wifi

2015-09-30 Thread Johannes Berg
On Wed, 2015-09-30 at 19:24 +0200, Pavel Machek wrote: > On Mon 2015-09-28 09:41:43, Johannes Berg wrote: > > On Sat, 2015-09-26 at 12:24 +0200, Pavel Machek wrote: > > > > > > That would be equivalent to ping -Q, right? It does not seem to have > > > any effect :-(. I'd expect at least local

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Ben Greear
On 09/30/2015 11:30 AM, Johannes Berg wrote: On Wed, 2015-09-30 at 10:20 -0700, Ben Greear wrote: Yes, it is a transmitter side problem, and A-MSDU on IBSS is disabled by default in all ath10k firmware versions that I am aware of. Right. I was hoping there might be a way to allow A-MSDU +

Re: Low latency communication over wifi

2015-09-30 Thread Bastian Bittorf
* Pavel Machek [30.09.2015 19:27]: > This should send the second ping to the priority queue based on -Q, > but I don't see an effect against one access point and it seems to > work somehow against second one. Good! you still need to hack/tune minstrel, because a lot of magic

No more posts about ath10k CT firmware for a while.

2015-09-30 Thread Ben Greear
I've been asked to not post any ath10k CT firmware related info to these lists. Not clear exactly what all I'm requested not to post at this time, but until I get this resolved one way or another, I at least won't post any firmware release notes. For those that still want to be notified

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Johannes Berg
On Wed, 2015-09-30 at 08:44 -0700, Ben Greear wrote: > > Any idea how this could be done in the stack instead of the driver? I don't see why it should be? > The problem is that this is a receiver-side issue, so even if I manage > to hack the ath10k firmware or driver rx logic, it would not fix

Re: Low latency communication over wifi

2015-09-30 Thread Pavel Machek
On Mon 2015-09-28 09:41:43, Johannes Berg wrote: > On Sat, 2015-09-26 at 12:24 +0200, Pavel Machek wrote: > > > > That would be equivalent to ping -Q, right? It does not seem to have > > any effect :-(. I'd expect at least local machine to use shorter waits > > for medium, and thus drop packets

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Felix Fietkau
On 2015-09-30 20:34, Ben Greear wrote: > On 09/30/2015 11:30 AM, Johannes Berg wrote: >> On Wed, 2015-09-30 at 10:20 -0700, Ben Greear wrote: >>> >>> Yes, it is a transmitter side problem, and A-MSDU on IBSS >>> is disabled by default in all ath10k firmware versions that I am aware of. >> >>

Re: Rate limiting AP bandwidth change messages in ieee80211_config_bw?

2015-09-30 Thread Johannes Berg
> > I'm not sure ratelimiting it would even work - it's not *that* high > frequency? Not really sure though. > > I think we can do either, it's not such a terribly important message as > far as I can tell. > Seems like Emmanuel would like to see the message stay in some form - perhaps we

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Johannes Berg
On Wed, 2015-09-30 at 10:20 -0700, Ben Greear wrote: > > Yes, it is a transmitter side problem, and A-MSDU on IBSS > is disabled by default in all ath10k firmware versions that I am aware of. Right. > I was hoping there might be a way to allow A-MSDU + IBSS + ath10k > to work in future kernels

Re: No more posts about ath10k CT firmware for a while.

2015-09-30 Thread Bastian Bittorf
* Ben Greear [30.09.2015 21:08]: > I've been asked to not post any ath10k CT firmware related info this makes me sad, because it is related. whoever asked you, can she/he stand up and explain? bye, bastian -- To unsubscribe from this list: send the line "unsubscribe

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Nicolas Cavallari
On 26/09/2015 01:00, Ben Greear wrote: > It seems that ath10k ar988X hardware has a bug where the BSSID > for IBSS AMSDU frames is all zeros. The 'main' 636 ath10k firmware > does not seem to use AMSDUs for IBSS, and when I enable it in my CT > firmware, then I see the breakage. So, I suspect it

[PATCH] staging: wilc1000: fix build error for openrisc-allmodconfig

2015-09-30 Thread Chaehyun Lim
The kbuild test robot reports the following build error for openrisc-allmodconfig. >> drivers/staging/wilc1000/wilc_sdio.c:584:2: error: implicit >> declaration of function 'memset' The error occurs due to missing a standard header file as so that three .c files are included it. Signed-off-by:

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Johannes Berg
On Fri, 2015-09-25 at 16:00 -0700, Ben Greear wrote: > It seems that ath10k ar988X hardware has a bug where the BSSID > for IBSS AMSDU frames is all zeros. The 'main' 636 ath10k firmware > does not seem to use AMSDUs for IBSS, and when I enable it in my CT > firmware, then I see the breakage.

Re: Linux Firmware Signing

2015-09-30 Thread Luis R. Rodriguez
On Thu, Sep 03, 2015 at 02:14:18PM -0700, Kees Cook wrote: > [removed bounced email addresses] > > On Wed, Sep 2, 2015 at 2:37 PM, Luis R. Rodriguez wrote: > > On Wed, Sep 02, 2015 at 01:54:43PM -0700, Kees Cook wrote: > >> On Wed, Sep 2, 2015 at 11:46 AM, Luis R. Rodriguez

[PATCH 20/32] staging: wilc1000: rename strHostIfStaInactiveT

2015-09-30 Thread Tony Cho
This patch renames strHostIfStaInactiveT to mac_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 16/32] staging: wilc1000: rename strDelStaParam

2015-09-30 Thread Tony Cho
This patch renames strDelStaParam to del_sta_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 15/32] staging: wilc1000: rename strAddStaParam

2015-09-30 Thread Tony Cho
This patch renames strAddStaParam to add_sta_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 13/32] staging: wilc1000: rename struct set_beacon

2015-09-30 Thread Tony Cho
This patch renames struct set_beacon to beacon_attr to keep the naming convention as scan_attr, connect_attr and channel_attr. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 21/32] staging: wilc1000: rename strHostIfSetDrvHandler

2015-09-30 Thread Tony Cho
This patch renames strHostIfSetDrvHandler to drv to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 22/32] staging: wilc1000: rename strHostIfSetIP

2015-09-30 Thread Tony Cho
This patch renames strHostIfSetIP to ip_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH 19/32] staging: wilc1000: rename strPowerMgmtparam

2015-09-30 Thread Tony Cho
This patch renames strPowerMgmtparam to pwr_mgmt_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 17/32] staging: wilc1000: rename strEditStaParam

2015-09-30 Thread Tony Cho
This patch renames strEditStaParam to edit_sta_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 18/32] staging: wilc1000: remove struct timer_cb

2015-09-30 Thread Tony Cho
This patch removes struct timer_cb which is not used. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

Re: [PATCH 29/32] staging: wilc1000: rename strHostIfRegisterFrame

2015-09-30 Thread Dan Carpenter
On Wed, Sep 30, 2015 at 06:55:11PM +0900, Tony Cho wrote: > This patch renames strHostIfRegisterFrame to reg_f to avoid CamelCase > naming convention. Could we go with "reg_frame"? f is very ambigous. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe

[PATCH 05/12] mwifiex: avoid gettimeofday in ba_threshold setting

2015-09-30 Thread Arnd Bergmann
mwifiex_get_random_ba_threshold() uses a complex homegrown implementation to generate a pseudo-random number from the current time as returned from do_gettimeofday(). This currently requires two 32-bit divisions plus a couple of other computations that are eventually discarded as only eight bits

[PATCH 06/12] mac80211: use ktime_get_seconds

2015-09-30 Thread Arnd Bergmann
The mac80211 code uses ktime_get_ts to measure the connected time. As this uses monotonic time, it is y2038 safe on 32-bit systems, but we still want to deprecate the use of 'timespec' because most other users are broken. This changes the code to use ktime_get_seconds() instead, which avoids the

[PATCH 11/32] staging: wilc1000: rename strHostIFSetChan

2015-09-30 Thread Tony Cho
This patch renames strHostIFSetChan to channel_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 12/32] staging: wilc1000: remove struct del_beacon

2015-09-30 Thread Tony Cho
This patch removes struct del_beacon which is not necessary. This patch also changes Handle_DelBeacon function by removing 2nd parameter, struct del_beacon because it is not used inside. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 24

[PATCH 14/32] staging: wilc1000: rename strHostIFSetBeacon

2015-09-30 Thread Tony Cho
This patch renames strHostIFSetBeacon to beacon_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 09/32] staging: wilc1000: remove struct get_channel

2015-09-30 Thread Tony Cho
This patch removes struct get_channel from the driver because it is not used anywhere. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 07/32] staging: wilc1000: rename strHostIFkeyAttr

2015-09-30 Thread Tony Cho
This patch renames strHostIFkeyAttr to key_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 100 +++--- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git

[PATCH 08/32] staging: wilc1000: rename strHostIFCfgParamAttr

2015-09-30 Thread Tony Cho
This patch renames strHostIFCfgParamAttr to cfg_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 10/32] staging: wilc1000: rename struct set_channel

2015-09-30 Thread Tony Cho
This patch renames struct set_channel to channel_attr to keep the naming convention such as scan_attr and connect_attr. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 27/32] staging: wilc1000: rename strHostIfBASessionInfo

2015-09-30 Thread Tony Cho
This patch renames strHostIfBASessionInfo to session_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [PATCH 32/32] staging: wilc1000: fix kernel fail after ifconfig wlan0 up

2015-09-30 Thread Dan Carpenter
Ugh... No. Just do this: diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c index 869736a..52d8f95 100644 --- a/drivers/staging/wilc1000/wilc_msgqueue.c +++ b/drivers/staging/wilc1000/wilc_msgqueue.c @@ -102,6 +102,8 @@ int

[PATCH 03/32] staging: wilc1000: rename strHostIFscanAttr

2015-09-30 Thread Tony Cho
This patch renames strHostIFscanAttr to scan_info in order to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git

[PATCH 04/32] staging: wilc1000: rename strHostIFconnectAttr

2015-09-30 Thread Tony Cho
This patch renames strHostIFconnectAttr to con_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 32 +++ 1 file changed, 16 insertions(+), 16 deletions(-) diff --git

[PATCH 05/32] staging: wilc1000: rename strRcvdNetworkInfo

2015-09-30 Thread Tony Cho
This patch renames strRcvdNetworkInfo to net_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 06/32] staging: wilc1000: rename strRcvdGnrlAsyncInfo

2015-09-30 Thread Tony Cho
This patch renames strRcvdGnrlAsyncInfo to async_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 29/32] staging: wilc1000: rename strHostIfRegisterFrame

2015-09-30 Thread Tony Cho
This patch renames strHostIfRegisterFrame to reg_f to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 23/32] staging: wilc1000: rename strHostIfSetMulti

2015-09-30 Thread Tony Cho
This patch renames strHostIfSetMulti to multicast_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 24/32] staging: wilc1000: rename strHostIfSetOperationMode

2015-09-30 Thread Tony Cho
This patch renames strHostIfSetOperationMode to mode to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 28/32] staging: wilc1000: rename strHostIfRemainOnChan

2015-09-30 Thread Tony Cho
This patch renames strHostIfRemainOnChan to remain_on_ch to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

[PATCH 25/32] staging: wilc1000: rename strHostIfSetMacAddress

2015-09-30 Thread Tony Cho
This patch renames strHostIfSetMacAddress to set_mac_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 26/32] staging: wilc1000: rename strHostIfGetMacAddress

2015-09-30 Thread Tony Cho
This patch renames strHostIfGetMacAddress to get_mac_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 32/32] staging: wilc1000: fix kernel fail after ifconfig wlan0 up

2015-09-30 Thread Tony Cho
From: Leo Kim This patch fix kernel fail after ifconfig wlan0 up. - if normal operation, kfree functions don't execute. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_msgqueue.c | 16 ++--

[PATCH 31/32] staging: wilc1000: rename strHostIFDelAllSta

2015-09-30 Thread Tony Cho
This patch renames strHostIFDelAllSta to del_all_sta_info to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 30/32] staging: wilc1000: rename pUserData

2015-09-30 Thread Tony Cho
This patch renames pUserData to data to avoid CamelCase naming convention. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

[PATCH 04/12] mwifiex: use ktime_get_real for timestamping

2015-09-30 Thread Arnd Bergmann
The mwifiex_11n_aggregate_pkt() function creates a ktime_t from a timeval returned by do_gettimeofday, which is slow and causes an overflow in 2038 on 32-bit architectures. This solves both problems by using the appropriate ktime_get_real() function. Signed-off-by: Arnd Bergmann

Re: [PATCH] staging: wilc1000: fix build error for openrisc-allmodconfig

2015-09-30 Thread Greg KH
On Wed, Sep 30, 2015 at 05:52:14PM +0900, Chaehyun Lim wrote: > The kbuild test robot reports the following build error for > openrisc-allmodconfig. > > >> drivers/staging/wilc1000/wilc_sdio.c:584:2: error: implicit > >> declaration of function 'memset' > > The error occurs due to missing a

Re: [PATCH] staging: wilc1000: fix build error for openrisc-allmodconfig

2015-09-30 Thread Chaehyun Lim
On Wed, Sep 30, 2015 at 7:20 PM, Greg KH wrote: > On Wed, Sep 30, 2015 at 05:52:14PM +0900, Chaehyun Lim wrote: >> The kbuild test robot reports the following build error for >> openrisc-allmodconfig. >> >> >> drivers/staging/wilc1000/wilc_sdio.c:584:2: error: implicit

[PATCH 01/32] staging: wilc1000: remove PLL_WORKAROUND

2015-09-30 Thread Tony Cho
This patch removes unnecessary definition, PLL_WORKAROUND from the Makefile. There is no use throughout the driver. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 02/32] staging: wilc1000: remove AGING_ALG

2015-09-30 Thread Tony Cho
This patch removes AGING_ALG from the Makefile because it is always in use. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/Makefile | 1 - drivers/staging/wilc1000/coreconfigurator.h | 2 -- 2 files changed, 3 deletions(-) diff --git

Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

2015-09-30 Thread Chandra Gorentla
On Tue, Sep 29, 2015 at 05:31:53AM +0300, Dan Carpenter wrote: > On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote: > > - The message queue is replaced with standard Linux linked list > > - kmem_cache is used for list members > > - A check for return value of receive method is

Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

2015-09-30 Thread Dan Carpenter
On Wed, Sep 30, 2015 at 06:12:50PM +0530, Chandra Gorentla wrote: > > > while (1) { > > > - wilc_mq_recv(, , sizeof(struct host_if_msg), > > > ); > > > + ret = wilc_mq_recv(, , > > > + sizeof(struct host_if_msg), ); > > > + if (ret) > > >

RE: [PATCH 32/32] staging: wilc1000: fix kernel fail after ifconfig wlan0 up

2015-09-30 Thread Kim, Leo
Dear Dan, Thank you! Always helpful your advice listen carefully. I will send in the morning.  Thanks, BR  Leo -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Wednesday, September 30, 2015 7:05 PM To: Cho, Tony Cc: gre...@linuxfoundation.org;

Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

2015-09-30 Thread Chandra Gorentla
On Tue, Sep 29, 2015 at 02:44:02AM +0200, Greg KH wrote: > On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote: > > - The message queue is replaced with standard Linux linked list > > - kmem_cache is used for list members > > Why? The list entires are of fixed type and repeatedly

Re: [PATCH] iw: Memory leak in error condition

2015-09-30 Thread James Cameron
On Thu, Oct 01, 2015 at 01:01:18AM +0200, Ola Olsson wrote: > >From 5239e8e9aa79a131b716398efbf7a1203decbd9b Mon Sep 17 00:00:00 2001 > From: Ola Olsson > Date: Thu, 1 Oct 2015 00:43:06 +0200 > Subject: [PATCH] iw: Memory leak in error condition Signed-off-by: Ola >

Re: [PATCH] iw: Memory leak in error condition

2015-09-30 Thread Ola Olsson
Oh yes! :) Suddenly valgrind was happy as well. >From 2724dd259f2bf61a2b7c85a70a70fd640a583453 Mon Sep 17 00:00:00 2001 From: Ola Olsson Date: Thu, 1 Oct 2015 00:43:06 +0200 Subject: [PATCH] iw: Memory leak in error condition Signed-off-by: Ola Olsson

Re: [PATCH] iw: Memory leak in error condition

2015-09-30 Thread Julian Calaby
Hi Ola, On Thu, Oct 1, 2015 at 9:39 AM, Ola Olsson wrote: > I guess not since there is a goto statement in between. Please correct > me if I am wrong. Oh, wait, you are right. I'm used to goto-free code. Sorry for the noise. Thanks, Julian Calaby > /Ola > > On Thu,

Re: [PATCH] iw: Memory leak in error condition

2015-09-30 Thread Ola Olsson
I guess not since there is a goto statement in between. Please correct me if I am wrong. /Ola On Thu, Oct 1, 2015 at 1:34 AM, Julian Calaby wrote: > Hi Ola, > > On Thu, Oct 1, 2015 at 9:27 AM, Ola Olsson wrote: >> Oh yes! :) >> Suddenly valgrind

[PATCH] iw: Memory leak in error condition

2015-09-30 Thread Ola Olsson
>From 5239e8e9aa79a131b716398efbf7a1203decbd9b Mon Sep 17 00:00:00 2001 From: Ola Olsson Date: Thu, 1 Oct 2015 00:43:06 +0200 Subject: [PATCH] iw: Memory leak in error condition Signed-off-by: Ola Olsson --- scan.c |2 ++ 1 file

Re: Rate limiting AP bandwidth change messages in ieee80211_config_bw?

2015-09-30 Thread Josh Boyer
On Wed, Sep 30, 2015 at 3:04 PM, Johannes Berg wrote: > >> >> I'm not sure ratelimiting it would even work - it's not *that* high >> frequency? Not really sure though. >> >> I think we can do either, it's not such a terribly important message as >> far as I can tell. >>

Re: [PATCH] iw: Memory leak in error condition

2015-09-30 Thread Julian Calaby
Hi Ola, On Thu, Oct 1, 2015 at 9:27 AM, Ola Olsson wrote: > Oh yes! :) > Suddenly valgrind was happy as well. > > From 2724dd259f2bf61a2b7c85a70a70fd640a583453 Mon Sep 17 00:00:00 2001 > From: Ola Olsson > Date: Thu, 1 Oct 2015 00:43:06 +0200 >

Re: [PATCH] ath10k: only advertise mesh support in raw mode

2015-09-30 Thread Bob Copeland
On Mon, Sep 28, 2015 at 10:27:30AM -0700, Peter Oh wrote: > I prefer the current design to this new approach because drivers already > know if it's mesh capable or not at build time, hence adding runtime > configuration is redundant. I do think the proposed patch is a bit overboard, so I suppose

Re: [PATCH] ath10k: only advertise mesh support in raw mode

2015-09-30 Thread Yeoh Chun-Yeow
> > I would think a small change to ath10k firmware could fix this though, > vendor willing. > +1 for this. Or even coming out with mesh mode instead of using AP mode in ath10k firmware. --- Chun-Yeow -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Johannes Berg
On Wed, 2015-09-30 at 08:07 -0700, Ben Greear wrote: > > On 09/29/2015 11:46 PM, Johannes Berg wrote: > > On Fri, 2015-09-25 at 16:00 -0700, Ben Greear wrote: > > > It seems that ath10k ar988X hardware has a bug where the BSSID > > > for IBSS AMSDU frames is all zeros. The 'main' 636 ath10k

Re: ipw2200-bss

2015-09-30 Thread Dan Williams
On Wed, 2015-09-30 at 15:21 +, Aaron Kempf wrote: > I am a tiny bit confused why this 'centrino' driver isn't in the 650mb > cd download for Debian 8.2 The driver is included in the kernel, so it should be there already. What may not be included on the CD is the firmware, which you may have

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Ben Greear
On 09/30/2015 08:17 AM, Johannes Berg wrote: On Wed, 2015-09-30 at 08:07 -0700, Ben Greear wrote: On 09/29/2015 11:46 PM, Johannes Berg wrote: On Fri, 2015-09-25 at 16:00 -0700, Ben Greear wrote: It seems that ath10k ar988X hardware has a bug where the BSSID for IBSS AMSDU frames is all

Re: Can we ignore frames with invalid BSSID in IBSS mode?

2015-09-30 Thread Ben Greear
On 09/29/2015 11:46 PM, Johannes Berg wrote: On Fri, 2015-09-25 at 16:00 -0700, Ben Greear wrote: It seems that ath10k ar988X hardware has a bug where the BSSID for IBSS AMSDU frames is all zeros. The 'main' 636 ath10k firmware does not seem to use AMSDUs for IBSS, and when I enable it in my

Re: question about potential integer truncation in mwifiex_set_wapi_ie and mwifiex_set_wps_ie

2015-09-30 Thread PaX Team
On 30 Sep 2015 at 9:10, James Cameron wrote: > On Tue, Sep 29, 2015 at 05:21:28PM +0200, PaX Team wrote: > > hi all, > > > > in drivers/net/wireless/mwifiex/sta_ioctl.c the following functions > > > > mwifiex_set_wpa_ie_helper > > mwifiex_set_wapi_ie > > mwifiex_set_wps_ie > > > >

ipw2200-bss

2015-09-30 Thread Aaron Kempf
I am a tiny bit confused why this 'centrino' driver isn't in the 650mb cd download for Debian 8.2 I detest Ubuntu in all flavors.. and if you guys would get this driver into the Debian kernel, and on the default CD installer.. it would make my life a lot easier. I wish I could help to do this..

Re: [PATCH] brcmfmac: firmware refresh for BCM43602 PCIE devices

2015-09-30 Thread Arend van Spriel
On 09/25/2015 02:00 AM, Kyle McMartin wrote: On Thu, Sep 24, 2015 at 08:45:04PM +0200, Arend van Spriel wrote: A number of end-users reported issues with BCM43602 on the 2015 MacBook Pro. It turned out the previously released firmware did not properly support that device [1]. Hence an update of

Rate limiting AP bandwidth change messages in ieee80211_config_bw?

2015-09-30 Thread Josh Boyer
Hi Johannes, We've seen a handful of reports that seem to have verbose output from the ieee80211_config_bw function in net/mac80211/mlme.c. It looks similar to this: [ 66.578652] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config is 2437 MHz, width 2 (2447/0 MHz) [ 68.522437] wlp3s0: