Re: [PATCH] staging: wilc1000: return -ENOMEM when kmalloc failed

2015-10-25 Thread Greg KH
On Thu, Oct 22, 2015 at 12:07:36AM +0100, Luis de Bethencourt wrote: > The driver is using -1 instead of the -ENOMEM defined macro to specify that > a buffer allocation failed. > > Fixes smatch warning and similars: > drivers/staging/wilc1000/host_interface.c:1782 Handle_Key() warn: > returning

Re: [PATCH 01/19] staging/wilc1000: remove unused functions

2015-10-25 Thread Greg KH
On Wed, Oct 21, 2015 at 12:47:20AM +0200, Arnd Bergmann wrote: > A number of symbols in the wilc1000 driver are completely unused > and can be removed. > This includes two variables that are only written but not read. > > Signed-off-by: Arnd Bergmann Due to other patches that

Re: [PATCH 02/28] staging: wicl1000: isr_uh_routine: use netdev private wilc

2015-10-25 Thread Greg KH
On Fri, Oct 23, 2015 at 02:28:18PM +0900, Glen Lee wrote: > Use netdev private member wilc instead of g_linux_wlan and Change argument > wilc > with dev in the function request_threaded_irq to pass back to handler > the function isr_uh_routine. > > Signed-off-by: Glen Lee >

[PATCH 06/10] mac80211: Fix local deauth while associating

2015-10-25 Thread Emmanuel Grumbach
From: Andrei Otcheretianski Local request to deauthenticate wasn't handled while associating, thus the association could continue even when the user space required to disconnect. Signed-off-by: Andrei Otcheretianski

[PATCH 02/10] mac80211: TDLS: add proper HT-oper IE

2015-10-25 Thread Emmanuel Grumbach
From: Arik Nemtsov When 11n peers performs a TDLS connection on a legacy BSS, the HT operation IE must be specified according to IEEE802.11-2012 section 9.23.3.2. Otherwise HT-protection is compromised and the medium becomes noisy for both the TDLS and the BSS links.

[PATCH 01/10] mac80211: don't reconfigure sched scan in case of wowlan

2015-10-25 Thread Emmanuel Grumbach
From: Eliad Peller Scheduled scan has to be reconfigured only if wowlan wasn't configured, since otherwise it should continue to run (with the 'any' trigger) or be aborted. The current code will end up asking the driver to start a new scheduled scan without stopping the

[PATCH 05/10] mac80211: make enable_qos parameter to ieee80211_set_wmm_default()

2015-10-25 Thread Emmanuel Grumbach
From: Johannes Berg The function currently determines this value, for use in bss_info.qos, based on the interface type itself. Make it a parameter instead and set it with the same logic for now. Signed-off-by: Johannes Berg ---

[PATCH 03/10] mac80211: use freezable workqueue for restart work

2015-10-25 Thread Emmanuel Grumbach
From: Eliad Peller Requesting hw restart during suspend might result in the restart work being executed after mac80211 and the hw are suspended. Solve the race by simply scheduling the restart work on a freezable workqueue. Note that there can be some cases of reconfiguration

[PATCH 04/10] mac80211: call drv_stop only if driver is started

2015-10-25 Thread Emmanuel Grumbach
From: Eliad Peller If drv_start() fails during hw_restart, all the running interfaces are being closed/stopped, which results in drv_stop() being called, although the driver was never started successfully. This might cause drivers to perform operations on uninitialized memory

[PATCH 08/10] mac80211: Remove WARN_ON_ONCE in ieee80211_recalc_smps

2015-10-25 Thread Emmanuel Grumbach
From: Andrei Otcheretianski The recalc_smps work can run after the station disassociates. At this stage we already released the channel, but the work will be cancelled only when the interface stops. In this scenario we can hit the warning in

[PATCH 10/10] mac80211: further improve "no supported rates" warning

2015-10-25 Thread Emmanuel Grumbach
From: Johannes Berg Allow distinguishing the non-station case from the case of a station without rates, by using -1 for the non-station case. This value cannot be reached with a station since that many legacy rates don't exist. Signed-off-by: Johannes Berg

Re: [PATCH 05/10] mac80211: make enable_qos parameter to ieee80211_set_wmm_default()

2015-10-25 Thread Emmanuel Grumbach
On Sun, Oct 25, 2015 at 10:59 AM, Emmanuel Grumbach wrote: > From: Johannes Berg > > The function currently determines this value, for use in bss_info.qos, > based on the interface type itself. Make it a parameter instead and > set it with

[PATCH 01/16] iwlwifi: rs: Remove workaround that disables MIMO on P2P

2015-10-25 Thread Emmanuel Grumbach
From: Alexander Bondar Remove an old workaround that's no longer needed and enable MIMO on P2P interfaces. Signed-off-by: Alexander Bondar Signed-off-by: Emmanuel Grumbach ---

[PATCH 02/16] iwlwifi: mvm: Dump FW's virtual image in the case of a NIC error

2015-10-25 Thread Emmanuel Grumbach
From: Matti Gottlieb When paging is enabled the driver stores part of the FW's image in the DRAM. Dump FW's virtual image in the case of a NIC error. Signed-off-by: Golan Ben-Ami Signed-off-by: Emmanuel Grumbach

pull request: iwlwifi-next 2015-10-25

2015-10-25 Thread Grumbach, Emmanuel
Hi Kalle, Last (obviously) pull request for 4.4. I came back from a long vacation and took maintenance over back from Luca. Please note that you'll have to merge mac80211-next/master (or net-next) before you pull from me. I created this pull request giving mac80211-next/master as the start point

[PATCH 09/16] iwlwifi: mvm: Add support for two scheduled scan plans

2015-10-25 Thread Emmanuel Grumbach
From: Avraham Stern Add support for two scan plans for scheduled scan. The first plan will run for a limited number of iterations, then the second plan will run infinitely. Signed-off-by: Avraham Stern Signed-off-by: Emmanuel Grumbach

[PATCH 12/16] iwlwifi: mvm: clean up some whitespace in scan code

2015-10-25 Thread Emmanuel Grumbach
From: Johannes Berg Signed-off-by: Johannes Berg Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/iwlwifi/mvm/scan.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 05/16] iwlwifi: mvm: use wowlan RX/TX timeouts in D0i3

2015-10-25 Thread Emmanuel Grumbach
From: Johannes Berg In "hostless" mode (D3 or D0i3) the same parameters were intended to be used, but the code doesn't do that properly. Fix it. Signed-off-by: Johannes Berg Signed-off-by: Avri Altman Signed-off-by:

[PATCH 11/16] iwlwifi: mvm: Implement per vif frame registration API

2015-10-25 Thread Emmanuel Grumbach
From: Andrei Otcheretianski Implement config_iface_filter() driver op. Currently support only probe request registration for p2p client vifs, by setting MAC_FILTER_IN_PROBE_REQUEST flag in MAC_CONTEXT_CMD. This is needed since WFDS spec and certification require

[PATCH 06/16] iwlwifi: mvm: use short timeouts in P2P low latency if supported

2015-10-25 Thread Emmanuel Grumbach
From: Johannes Berg Those timeouts are used for AM-to-PSM transition. We already have those pairs defined for default and WOWLAN use cases. We expect that by using shorter threshold for low latency P2P, e.g. for Miracast video scenario, we might save a considerable

[PATCH 15/16] iwlwifi: mvm: disable TDLS ac queues correctly

2015-10-25 Thread Emmanuel Grumbach
From: Arik Nemtsov The iwl_mvm_disable_queue function requires the TID to be set to IWL_MAX_TID_COUNT when disabling an AC queue. Call it correctly for TDLS scenarios. Fixes: 4ecafae9e568 ("iwlwifi: mvm: support using multiple ACs on single HW queue") Signed-off-by: Arik

[PATCH 13/16] iwlwifi: mvm: remove pointless scan plan checks

2015-10-25 Thread Emmanuel Grumbach
From: Johannes Berg As cfg80211 already enforces these limits, there's little point in having them again here in our code. Signed-off-by: Johannes Berg Signed-off-by: Emmanuel Grumbach ---

[PATCH 08/16] iwlwifi: mvm: let any command flag be passed to iwl_mvm_flushtx_path()

2015-10-25 Thread Emmanuel Grumbach
From: Luca Coelho Instead of only allowing the caller to decide whether the CMD_ASYNC flag is set, let it pass the entire flags bitmask. This allows more flexibility and will be needed when we call this function in the suspend flow (where other flags are needed).

[PATCH 14/16] iwlwifi: mvm: take scan ref only on success

2015-10-25 Thread Emmanuel Grumbach
From: Eliad Peller In some cases, scan reference was taken, but wasn't released even though scan command wasn't actually issued. Change the current code to simply take the reference only on success. Signed-off-by: Eliad Peller Signed-off-by: Emmanuel

[PATCH 16/16] iwlwifi: nvm: free old section data when reading nvm file

2015-10-25 Thread Emmanuel Grumbach
From: Moshe Harel When reading external NVM file, if a section exists both in OTP and in the external file, the memory that was allocated at OTP reading is not freed. This is possible only on systems that have an external NVM file which is typically the case on embedded

[PATCH 04/16] iwlwifi: mvm: correctly request DTS-measure for new cards

2015-10-25 Thread Emmanuel Grumbach
From: Arik Nemtsov Since the 8000 series, the DTS measurement request command has been changed. Use an ucode capability flag to determine which version is supported and send the extended command when needed. Signed-off-by: Arik Nemtsov Signed-off-by:

[PATCH 10/16] iwlwifi: avoid read/write operations if the bus is dead

2015-10-25 Thread Emmanuel Grumbach
From: Eliad Peller Recovery takes too much time if the bus is dead (each timeout is 2000ms, etc.). Explicitly skip fw dump in this case, as it will result in garbage data (and might take signifcant time) Signed-off-by: Eliad Peller Signed-off-by:

[PATCH 07/16] iwlwifi: mvm: Allow setting ctrl-chnl-position in FTM responder

2015-10-25 Thread Emmanuel Grumbach
From: Assaf Krauss This patch enables the debugfs user to configure an FTM responder with the appropriate control channel position. Signed-off-by: Assaf Krauss Signed-off-by: Emmanuel Grumbach ---

Re: [PATCH 1/3] staging: wilc1000: Remove reference preceded by free

2015-10-25 Thread Greg KH
On Mon, Oct 26, 2015 at 01:29:42AM +0530, punit vara wrote: > On Mon, Oct 26, 2015 at 1:01 AM, punit vara wrote: > > On Mon, Oct 26, 2015 at 12:42 AM, Greg KH > > wrote: > >> On Sun, Oct 25, 2015 at 04:01:23AM +0530, Punit Vara wrote: > >>> This

Re: [PATCH] net: tso: add support for IPv6

2015-10-25 Thread Sergei Shtylyov
Hello. On 10/25/2015 10:58 PM, Emmanuel Grumbach wrote: Adding IPv6 for the TSO helper API is trivial: * Don't play with the id (which doesn't exist in IPv6) * Correctly update the payload_len (don't include the length of the IP header itself) Signed-off-by: Emmanuel Grumbach

Re: [PATCH 02/28] staging: wicl1000: isr_uh_routine: use netdev private wilc

2015-10-25 Thread glen lee
On 2015년 10월 25일 10:29, Greg KH wrote: On Fri, Oct 23, 2015 at 02:28:18PM +0900, Glen Lee wrote: Use netdev private member wilc instead of g_linux_wlan and Change argument wilc with dev in the function request_threaded_irq to pass back to handler the function isr_uh_routine. Signed-off-by:

Re: [RFC] ath9k: Simplify and fix eeprom endianness swapping

2015-10-25 Thread Martin Blumenstingl
On Thu, Oct 15, 2015 at 12:33 AM, Martin Blumenstingl wrote: > I have tested my patch on a single AR9227 device and there it's > working fine. It would be great if more people would give this a go > before merging this patch. I have just tested it on a second

[PATCH] wcn36xx: Remove warning message when dev is NULL for arm64 dma_alloc.

2015-10-25 Thread Yin, Fengwei
arm64 has requirement that all the dma operations have actual device. Otherwise, following warnning message shown and dma allocation fails: WARNING: CPU: 0 PID: 954 at arch/arm64/mm/dma-mapping.c:106 __dma_alloc+0x24c/0x258() Use an actual device structure for DMA allocation Modules linked in:

Administrative Notice

2015-10-25 Thread Help Desk
Help Desk Scheduled Maintenance & Upgrade Your account is in the process of being upgraded to a newest Windows-based servers and an enhanced online email interface inline with internet infrastructure Maintenance. The new servers will provide better anti-spam and anti-virus functions, along

Re: [PATCH v3 0/1] rtl8xxxu (mac80211) driver for rtl8188[cr]u/rtl8192cu/rtl8723au

2015-10-25 Thread Johannes Stezenbach
Hi Jes and Larry, On Wed, Oct 14, 2015 at 08:44:50PM -0400, jes.soren...@redhat.com wrote: > Per default only devices I have actually tested will be enabled. If > you are interested in trying it out with other 8188cu/8188ru/819[12]cu > dongles, you need to enable CONFIG_RTL8XXXU_UNTESTED. Please

[PATCH 4/4] staging: wilc1000: rename host_int_set_WEPDefaultKeyID

2015-10-25 Thread Chaehyun Lim
This patch replaces host_int_set_WEPDefaultKeyID with host_int_set_wep_default_key to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 2 +-

[PATCH 3/4] staging: wilc1000: rename u8Index in host_int_set_WEPDefaultKeyID

2015-10-25 Thread Chaehyun Lim
This patch changes second parameter of host_int_set_WEPDefaultKeyID from u8Index to index to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 4 ++-- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 3

[PATCH 2/4] staging: wilc1000: fix parameter name of function declaration

2015-10-25 Thread Chaehyun Lim
This patch changes struct host_if_drv of host_int_set_WEPDefaultKeyID function declaration from hWFIDrv to hif_drv in host_interface.h With this change, first parameter name of this function declaration and definition has same name as hif_drv. Signed-off-by: Chaehyun Lim

[PATCH 1/4] staging: wilc1000: fix return type of host_int_set_WEPDefaultKeyID

2015-10-25 Thread Chaehyun Lim
This patch changes return type of host_int_set_WEPDefaultKeyID from s32 to int. The result variable gets return value from wilc_mq_send that has return type of int. It should be changed return type int as well as data type of result variable. Signed-off-by: Chaehyun Lim

[RESEND PATCH] staging: wilc1000: return -ENOMEM when kmalloc failed

2015-10-25 Thread Luis de Bethencourt
The driver is using -1 instead of the -ENOMEM defined macro to specify that a buffer allocation failed. Fixes smatch warning and similars: drivers/staging/wilc1000/host_interface.c:1757 Handle_Key() warn: returning -1 instead of -ENOMEM is sloppy Signed-off-by: Luis de Bethencourt

[PATCH v2] mwifiex: toggle carrier state in start_ap/stop_ap.

2015-10-25 Thread Amitkumar Karwar
From: Marty Faltesek In uap mode the carrier is not enabled until after the first STA joins. The carrier triggers the bridge to start its state machine, and if STP is enabled, it takes 4 seconds as it transitions from disabled to forwarding. During this time the bridge

[PATCH 1/4] wil6210: ignore selected WMI events

2015-10-25 Thread Vladimir Kondratiev
Some events are ignored for purpose; such events should not be treated as "unhandled events". Replace info message saying "unhandled" with debug one saying "ignore", to reduce dmesg pollution Signed-off-by: Vladimir Kondratiev ---

[PATCH 4/4] wil6210: handle failure in Tx vring config

2015-10-25 Thread Vladimir Kondratiev
When configuring Tx vring for new connection, WMI call to the firmware may fail. In this case, need to clean up properly. In particular, need to call cfg80211_del_sta() in case of AP like interface. Perform full "disconnect" procedure for proper clean up Signed-off-by: Vladimir Kondratiev

[PATCH 3/4] wil6210: fix device ready detection

2015-10-25 Thread Vladimir Kondratiev
Adjust driver behavior during FW boot. Proper sequence of events after reset and FW download, is as following: - FW prepares mailbox structure and reports IRQ "FW_READY" - driver caches mailbox registers, marks mailbox readiness - FW sends WMI_FW_READY event, ignore it - FW sends WMI_READY event

[PATCH 0/4] wil6210 patches

2015-10-25 Thread Vladimir Kondratiev
Collection of small fixes Hamad Kadmany (1): wil6210: Fix TSO overflow handling Vladimir Kondratiev (3): wil6210: ignore selected WMI events wil6210: fix device ready detection wil6210: handle failure in Tx vring config drivers/net/wireless/ath/wil6210/interrupt.c | 6 +++---

[PATCH 2/4] wil6210: Fix TSO overflow handling

2015-10-25 Thread Vladimir Kondratiev
From: Hamad Kadmany When Tx ring full is encountered with TSO, printout of "DMA error" was wrongly printed. In addition, in case of Tx ring full return proper error code so that NETDEV_TX_BUSY is returned to network stack in order not to drop the packets and retry

[PATCH 0/8] add missing of_node_put

2015-10-25 Thread Julia Lawall
The various for_each device_node iterators performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. The complete semantic patch that fixes this problem is (http://coccinelle.lip6.fr): // @r@ local idexpression n; expression e1,e2; iterator name

[PATCH 7/8] ath6kl: add missing of_node_put

2015-10-25 Thread Julia Lawall
for_each_compatible_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ expression e; local idexpression n; @@

[PATCH] rtl8xxxu: fix unused rtl8192cu_fops compiler warning

2015-10-25 Thread Kalle Valo
kbuild reported: rtl8xxxu.c:5786:32: warning: ‘rtl8192cu_fops’ defined but not used [-Wunused-variable] Fix it by adding temporary ifdefs around the static functions. Fixes: 033695bdf6d7 ("rtl8xxxu: move devices supported by rtlwifi under UNTESTED config") Reported-by: kbuild test robot

Re: [PATCH 1/3] staging: wilc1000: Remove reference preceded by free

2015-10-25 Thread Greg KH
On Sun, Oct 25, 2015 at 04:01:23AM +0530, Punit Vara wrote: > This patch is to the wilc_wfi_cfgoperations.c file that fixes up > following error reported by coccicheck: > > ERROR: reference preceded by free on line 1219 > > For (params->seq_len) <= 0 memory is already freed when >

Re: [PATCH 2/3] Staging: wilc1000: Remove comparision of field address to NULL

2015-10-25 Thread Greg KH
On Sun, Oct 25, 2015 at 04:01:24AM +0530, Punit Vara wrote: > This is patch to the linux_wlan file that fixes up following error > reported by coccicheck : > > ERROR: test of a variable/field address > > Signed-off-by: Punit Vara > --- >

[PATCH] net: tso: add support for IPv6

2015-10-25 Thread Emmanuel Grumbach
Adding IPv6 for the TSO helper API is trivial: * Don't play with the id (which doesn't exist in IPv6) * Correctly update the payload_len (don't include the length of the IP header itself) Signed-off-by: Emmanuel Grumbach --- net/core/tso.c | 17 -

Re: [PATCH 1/3] staging: wilc1000: Remove reference preceded by free

2015-10-25 Thread punit vara
On Mon, Oct 26, 2015 at 1:01 AM, punit vara wrote: > On Mon, Oct 26, 2015 at 12:42 AM, Greg KH wrote: >> On Sun, Oct 25, 2015 at 04:01:23AM +0530, Punit Vara wrote: >>> This patch is to the wilc_wfi_cfgoperations.c file that fixes up >>> following

[PATCH v2] net: tso: add support for IPv6

2015-10-25 Thread Emmanuel Grumbach
Adding IPv6 for the TSO helper API is trivial: * Don't play with the id (which doesn't exist in IPv6) * Correctly update the payload_len (don't include the length of the IP header itself) Signed-off-by: Emmanuel Grumbach --- v2: add else if NOTE: instead of

[PATCH 1/2] ssb: move functions specific to SoC hosted bus to separated file

2015-10-25 Thread Rafał Miłecki
This cleans main.c a bit and will allow us to compile SoC related code conditionally in the future. Signed-off-by: Rafał Miłecki --- drivers/ssb/Makefile | 1 + drivers/ssb/host_soc.c| 173 ++ drivers/ssb/main.c|

[PATCH 2/2] ssb: add Kconfig entry for compiling SoC related code

2015-10-25 Thread Rafał Miłecki
This allows saving a little of space when not using ssb on Broadcom SoC. Signed-off-by: Rafał Miłecki --- arch/mips/bcm47xx/Kconfig | 1 + drivers/ssb/Kconfig | 9 + drivers/ssb/Makefile | 2 +- drivers/ssb/main.c| 2 ++ drivers/ssb/ssb_private.h | 2

Re: [PATCH 1/3] staging: wilc1000: Remove reference preceded by free

2015-10-25 Thread punit vara
On Mon, Oct 26, 2015 at 12:42 AM, Greg KH wrote: > On Sun, Oct 25, 2015 at 04:01:23AM +0530, Punit Vara wrote: >> This patch is to the wilc_wfi_cfgoperations.c file that fixes up >> following error reported by coccicheck: >> >> ERROR: reference preceded by free on line