Re: [PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree

2015-11-30 Thread Kalle Valo
Kalle Valo writes: > Brent Taylor writes: > >> Signed-off-by: Brent Taylor >> >> ath6kl: Use vmalloc for loading firmware using api1 method and free using >> kvfree >> --- >> Changes v1 -> v2: >>- simplify memory allocation >>

Re: [PATCH v2 4/8] cfg80211: reg: Properly handle rules for 5 and 10 MHz channels

2015-11-30 Thread Jouni Malinen
On Mon, Nov 23, 2015 at 07:27:17PM +0100, Michal Sojka wrote: > Regulatory rules are applied to channels as if the channel is at least > 20 MHz wide. This is a problem when dealing with 5 and 10 MHz channels > because side channels of a regulatory rule get disabled even when they > fall into

Re: [PATCH 1/2] ath10k: do not use coherent memory for allocated device memory chunks

2015-11-30 Thread Kalle Valo
Felix Fietkau writes: > Coherent memory is more expensive to allocate (and constrained on some > architectures where it has to be pre-allocated). It is also completely > unnecessary, since the host has no reason to even access these allocated > memory spaces > > Signed-off-by:

Re: [PATCH v2 4/8] cfg80211: reg: Properly handle rules for 5 and 10 MHz channels

2015-11-30 Thread Johannes Berg
On Mon, 2015-11-30 at 11:56 +0200, Jouni Malinen wrote: > On Mon, Nov 23, 2015 at 07:27:17PM +0100, Michal Sojka wrote: > > Regulatory rules are applied to channels as if the channel is at > > least > > 20 MHz wide. This is a problem when dealing with 5 and 10 MHz > > channels > > because side

[PATCH] ath10k: Remove unnecessary amsdu/ampdu assignment in debugfs

2015-11-30 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan The default values of max_num_amsdu / max_num_amdpu is assigned a default value as part of 'ath10k_core_init_firmware_features' Signed-off-by: Mohammed Shafi Shajakhan ---

Re: [PATCH] ath10k: stop abusing GFP_DMA

2015-11-30 Thread Kalle Valo
Felix Fietkau writes: > Allocations from the DMA zone were originally added for legacy ISA > stuff, or PCI devices that have specific limitations in their DMA > addressing capabilities. It has no place in ath10k, which can do > full 32-bit DMA. > > Fixes memory allocation

Re: [PATCH] ath10k: Enable AP + STA interface combination support for 10.x

2015-11-30 Thread Kalle Valo
Mohammed Shafi Shajakhan writes: > From: Mohammed Shafi Shajakhan > > Enable AP + STA interface combination support for 10.x and > this enables Repeater mode testing (with WDS Repeater combinations > as well). Fix indentation as well. > >

Re: [PATCH v2] ath10k: Fix write permission on few debugfs files

2015-11-30 Thread Kalle Valo
Mohammed Shafi Shajakhan writes: > From: Mohammed Shafi Shajakhan > > Fix write permission for few of the debugfs entries > which support write file operations as well. > > Signed-off-by: Mohammed Shafi Shajakhan

Re: [PATCH] ath10k: fix board data fetch error message

2015-11-30 Thread Kalle Valo
Peter Oh writes: > The error message order of board data fetch is board info, > directory, and then file name, hence place print arguments > in the order. > > Fixes: 0a51b343abfe ("ath10k: add board 2 API support") > Signed-off-by: Peter Oh

[PATCH v2] ath10k: do not use coherent memory for allocated device memory chunks

2015-11-30 Thread Felix Fietkau
Coherent memory is more expensive to allocate (and constrained on some architectures where it has to be pre-allocated). It is also completely unnecessary, since the host has no reason to even access these allocated memory spaces Signed-off-by: Felix Fietkau ---

Re: [PATCH] ath10k: deliver mgmt frames from htt to monitor vifs only

2015-11-30 Thread Peter Oh
On 11/30/2015 04:56 AM, Grzegorz Bajorski wrote: Until now only WMI originating mgmt frames were reported to mac80211. Management frames on HTT were basically dropped (except frames which looked like management but had FCS error). To allow sniffing all frames (including offloaded frames)

[PATCH 1/1] staging: cleanup: Fix incompatible type comparison in wilc1000/host_interface.c

2015-11-30 Thread Mario J. Rugiero
This patch replaces an "if (ptr > 0)" comparison that seems to be a confusing way to check for null by a simpler "if (ptr)" check. Signed-off-by: Mario J. Rugiero --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] [sparse-cleanup] Fix incompatible type comparison in wilc1000/host_interface.c

2015-11-30 Thread Mario J. Rugiero
Signed-off-by: Mario J. Rugiero --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index d5b7725..9ce1d22 100644 ---

[PATCH 2/2] ath6kl: add log messages for firmware failure cases.

2015-11-30 Thread greearb
From: Ben Greear This gives a user a chance to know why a firmware load is failing. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath6kl/init.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git

[PATCH 1/2] ath6kl: fix tx/rx antenna reporting for 2x2 devices.

2015-11-30 Thread greearb
From: Ben Greear My previous patch incorrectly reported the antenna for 2x2 devices. It should be a mask instead of a numeric count. This patch fixes that. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 4 ++-- 1

ath10k: device has crashed during init - qca6174 chipset

2015-11-30 Thread Bartlomiej Grzeskowiak
Hi, I am trying to use ath10k driver from the latest backports-4.4-rc.2-1 with kernel 3.10.65 and qca6174 based wlan module. Could you give me some hints about possible problem. ath10k_core.ko module loaded with skip_otp=y and debug_mask=0x. I get following error message: [

Re: ath10k: device has crashed during init - qca6174 chipset

2015-11-30 Thread Janusz Dziedzic
On 1 December 2015 at 07:20, Bartlomiej Grzeskowiak wrote: > Hi, > > I am trying to use ath10k driver from the latest backports-4.4-rc.2-1 with > kernel 3.10.65 and qca6174 based wlan module. Could you give me some hints > about possible problem. > ath10k_core.ko

[PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-11-30 Thread Brent Taylor
Since commit 8437754c83351d6213c1a47ff029c1126d6042a7, ar->fw is expected to be pointing to memory allocated by vmalloc. If the api1 method (via ath6kl_fetch_fw_api1) is used to allocate memory for ar->fw, then kmemdup is used. This patch checks if the firmware being loaded is the 'fw' image,

Re: [1/9] brcmfmac: Add support for the BCM4359 11ac RSDB PCIE device.

2015-11-30 Thread Kalle Valo
Arend van Spriel writes: > Actually, the patch above should have been submitted to > wireless-drivers as it solves a suspend/hibernate issue with 4350 > device which we added in 4.4. Just to avoid any confusion you are meaning this commit: c2a43a6ba5e5 brcmfmac: Use new

Re: [PATCH 11/11] brcmfmac: Fix double free on exception at module load.

2015-11-30 Thread Kalle Valo
Arend van Spriel writes: > From: Hante Meuleman > > Reviewed-by: Arend Van Spriel > Reviewed-by: Pieter-Paul Giesberts > Signed-off-by: Hante Meuleman > Signed-off-by: Arend van

Re: [PATCH 08/11] brcmfmac: Make 5G join preference configurable.

2015-11-30 Thread Kalle Valo
Arend van Spriel writes: > From: Hante Meuleman > > By default the 5G band has an advantage of 8 dBm on the RSSI when > it comes to selection during join and roam. This patch adds a > module param to make this value configurable. Using the value 99 >

Re: [PATCH v2 0/5] wcn36xx: add some new firmware functionalities support

2015-11-30 Thread Kalle Valo
"fengwei.yin" writes: > On 2015/11/23 4:03, Eugene Krasnikov wrote: >> All 5 patches looks good to me. > > Is it OK to take these patches? Thanks. They are on my queue and I'll get to them soon. But from a quick look they seem to be ok. -- Kalle Valo -- To unsubscribe

Re: [1/9] brcmfmac: Add support for the BCM4359 11ac RSDB PCIE device.

2015-11-30 Thread Arend van Spriel
On 11/30/2015 12:17 PM, Kalle Valo wrote: Arend van Spriel writes: Actually, the patch above should have been submitted to wireless-drivers as it solves a suspend/hibernate issue with 4350 device which we added in 4.4. Just to avoid any confusion you are meaning this

Re: [PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree

2015-11-30 Thread Kalle Valo
Brent Taylor writes: > Signed-off-by: Brent Taylor > > ath6kl: Use vmalloc for loading firmware using api1 method and free using > kvfree > --- > Changes v1 -> v2: >- simplify memory allocation >- use kvfree Why? The commit log should _always_

Re: [PATCH v3] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree

2015-11-30 Thread Kalle Valo
Brent Taylor writes: > Signed-off-by: Brent Taylor > > ath6kl: Use vmalloc for loading firmware using api1 method and free using > kvfree > > ath6kl: fix kmalloc build error > --- > Changes v2 -> v3: >- fix kmalloc build error > > Changes v1 -> v2: >

Re: [v2,1/5] wcn36xx: introduce WCN36XX_HAL_AVOID_FREQ_RANGE_IND

2015-11-30 Thread Kalle Valo
> From: Andy Green > > WCN3620 firmware introduces a new async indication, we need to > add it as a known message type so we can accept it > > Signed-off-by: Andy Green Thanks, 5 patches applied to wireless-drivers-next.git: 9193adebc4d1

Re: [01/11] brcmfmac: Cleanup ssid storage.

2015-11-30 Thread Kalle Valo
Kalle Valo writes: >> From: Hante Meuleman >> >> SSIDs used for connect and p2p got stored, but never used. >> >> Reviewed-by: Arend Van Spriel >> Reviewed-by: Franky (Zhenhui) Lin >> Reviewed-by:

Re: brcm80211: fix error code in brcmf_pcie_exit_download_state()

2015-11-30 Thread Kalle Valo
> The original code returns 1 on failure and 0 on success but the caller > was expecting an error code on failure. > > Signed-off-by: Dan Carpenter Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe

Re: [v2,1/1] wireless: airo: re-use mac_pton()

2015-11-30 Thread Kalle Valo
> mac_pton() converts 6-byte MAC / BSSID to binary format. Change an open coded > variant by the generic one. > > Signed-off-by: Andy Shevchenko Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line

Re: [PATCH] mac80211: allow drivers to report (non-)monitor frames

2015-11-30 Thread Johannes Berg
On Mon, 2015-11-30 at 13:54 +0100, Grzegorz Bajorski wrote: > This allows drivers to tell mac80211 whether given > frame is to be processed regularly but skip > monitor interface delivery or vice versa. > Can you give an example, and perhaps a corresponding driver patch? johannes -- To

Re: [PATCH v2 4/5] wcn3620: use new response format for wcn3620 trigger_ba

2015-11-30 Thread Kalle Valo
"Yin, Fengwei" writes: > From: Andy Green > > On wcn3620, firmware response to trigger_ba uses the new, larger > "v2" format > > Signed-off-by: Andy Green Please prefix the patch title with the name of driver, in this case

Re: [01/11] brcmfmac: Cleanup ssid storage.

2015-11-30 Thread Kalle Valo
> From: Hante Meuleman > > SSIDs used for connect and p2p got stored, but never used. > > Reviewed-by: Arend Van Spriel > Reviewed-by: Franky (Zhenhui) Lin > Reviewed-by: Pieter-Paul Giesberts >

[PATCH] mac80211: allow drivers to report (non-)monitor frames

2015-11-30 Thread Grzegorz Bajorski
This allows drivers to tell mac80211 whether given frame is to be processed regularly but skip monitor interface delivery or vice versa. Signed-off-by: Grzegorz Bajorski --- include/net/mac80211.h | 11 +++ net/mac80211/rx.c | 5 +++-- 2 files changed,

[PATCH] ath10k: deliver mgmt frames from htt to monitor vifs only

2015-11-30 Thread Grzegorz Bajorski
Until now only WMI originating mgmt frames were reported to mac80211. Management frames on HTT were basically dropped (except frames which looked like management but had FCS error). To allow sniffing all frames (including offloaded frames) without interfering with mac80211 operation and states a

Re: rt2x00: type bug in _rt2500usb_register_read()

2015-11-30 Thread Kalle Valo
> This code causes a static checker bug. > > drivers/net/wireless/ralink/rt2x00/rt2500usb.c:232 _rt2500usb_register_read() > warn: passing casted pointer 'value' to 'rt2500usb_register_read()' 32 vs 16. > > If the low 16 bits were initialized to zero then this code would only be > a problem on

Re: libertas: cleanup a variable name

2015-11-30 Thread Kalle Valo
> ">priv->driver_lock" and ">driver_lock" are the same and > it's nicer to use the shorter one consistently. > > Signed-off-by: Dan Carpenter Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe