Re: [PATCH V3] wlcore/wl18xx: fw logger over sdio

2015-12-02 Thread kbuild test robot
Hi Shahar, [auto build test WARNING on net-next/master] [also build test WARNING on v4.4-rc3 next-20151127] url: https://github.com/0day-ci/linux/commits/Guy-Mishol/wlcore-wl18xx-fw-logger-over-sdio/20151202-222416 config: x86_64-allmodconfig (attached as .config) reproduce: # save

Re: [PATCH 08/11] brcmfmac: Make 5G join preference configurable.

2015-12-02 Thread Jouni Malinen
On Wed, Dec 02, 2015 at 02:32:55PM +0100, Arend van Spriel wrote: > On 12/01/2015 12:08 PM, Jouni Malinen wrote: > >I would like to see this as a new attribute to NL80211_CMD_CONNECT to > >provide parameters for offloaded (driver and/or firmware) BSS selection > >and roaming. If there is a driver

Invalid SPLX

2015-12-02 Thread Andy Lutomirski
Hi- My laptop has SPLC implemented like this: Name (SPLX, Package (0x04) { Zero, Package (0x03) { 0x8000, 0x8000, 0x8000 }, Package (0x03) {

Re: pull-request: mac80211 2015-11-26

2015-12-02 Thread David Miller
From: Johannes Berg Date: Wed, 02 Dec 2015 10:46:50 +0100 >> >> A small set of fixes for 4.4: >>  * remove NL80211_FEATURE_FULL_AP_CLIENT_STATE again, it >>    was broken and needs more work, we'll enable

RE: [PATCH v2] mac80211_hwsim: check ATTR_FREQ for wmediumd (netlink) packets

2015-12-02 Thread Adam R. Welle
> Applied. I added locking and made a change to accept both the off- > channel and non-offchannel since the internal datapath also does that > and we don't stop other operation for off-channel. Does your change only throw away packets when tmp_chan is set? I was under the impression that most of

[PATCH] wlcore/wl18xx: fw logger over sdio

2015-12-02 Thread Guy Mishol
From: Shahar Patury enable the FW Logger to work over the SDIO interface instead of only over UART. in new design we will use fw internal memory instead of packet ram that was used in older (and wl12xx) design. this change will reduce the impact on tp and stability. adding new

[PATCH V2] wlcore: split wl12xx/wl18xx sg parameters

2015-12-02 Thread Guy Mishol
Align to new wl18xx sg parameters. This requires to split both wl12xx/wl18xx enumerators. Signed-off-by: Guy Mishol Acked-by: Eliad Peller --- V2: Resubmitted again after modifying the commit massage drivers/net/wireless/ti/wl12xx/conf.h | 233

[PATCH] wlcore: split wl12xx/wl18xx sg parameters

2015-12-02 Thread Guy Mishol
Align to new wl18xx sg parameters. This requires to split both wl12xx/wl18xx enumerators. fixes #WILINK8_SW_DEV-395 Signed-off-by: Guy Mishol Acked-by: Eliad Peller --- drivers/net/wireless/ti/wl12xx/conf.h | 233

pull-request: mac80211 2015-12-02

2015-12-02 Thread Johannes Berg
> Please add them and send a new pull request, I'll just skip over your > existing one. Ok, here we go, below a new pull request. I've added the two commits I spoke about, fixing scanning and an uninitialized cookie variable that lead to problems if the value happened to be 0. Let me know if

Re: [PATCH 08/11] brcmfmac: Make 5G join preference configurable.

2015-12-02 Thread Dan Williams
On Wed, 2015-12-02 at 10:00 -0800, Paul Stewart wrote: > From my perspective it is useful to have the driver express whether > or not it supports this parameter. It may not change how the system > operates, but it will be useful in testing to determine whether it > is expected that a (given

Re: Invalid SPLX

2015-12-02 Thread Emmanuel Grumbach
Hi, On Wed, Dec 2, 2015 at 10:35 PM, Andy Lutomirski wrote: > Hi- > > My laptop has SPLC implemented like this: > > Name (SPLX, Package (0x04) > { > Zero, > Package (0x03) > { > 0x8000, >

wlan0: set_features() failed (-1); wanted 0x0000000000004008, left 0x0000000000004808

2015-12-02 Thread Kalle Valo
Hi, For few weeks (I think) I have seen these kind of messages: ath10k_pci :02:00.0 wlan0: set_features() failed (-1); wanted 0x4008, left 0x4808 iwlwifi :03:00.0 wlan0: set_features() failed (-1); wanted 0x4000, left 0x4800 I'm using

wireless-testing regression: Could not configure driver mode

2015-12-02 Thread Kalle Valo
Hi John, with latest wireless-testing[1] I noticed that I cannot start AP mode anymore with ath10k: nl80211: Subscribe to mgmt frames with AP handle 0x9e5b410 nl80211: Register frame type=0xb0 nl_handle=0x9e5b410 match= nl80211: Register frame command failed (type=176): ret=-95 (Operation not

Re: wireless-testing regression: Could not configure driver mode

2015-12-02 Thread Johannes Berg
On Thu, 2015-12-03 at 08:54 +0200, Kalle Valo wrote: >  > --- a/net/mac80211/offchannel.c > +++ b/net/mac80211/offchannel.c > @@ -916,6 +916,13 @@ int ieee80211_mgmt_tx(struct wiphy *wiphy, > struct wireless_dev *wdev, > kfree_skb(skb); > goto

Re: [PATCH] mac80211_hwsim: missing NULL check

2015-12-02 Thread Johannes Berg
On Mon, 2015-11-30 at 12:46 +0530, Rahul Jain wrote: > From: Amit Khatri > > txrate variable might be NULL and passing inside function > without NULL check. Applied. However, this comes with a big BUT. I seems to always be rewriting your static checker patches, or

Re: [PATCH v2] mac80211_hwsim: check ATTR_FREQ for wmediumd (netlink) packets

2015-12-02 Thread Johannes Berg
On Tue, 2015-12-01 at 17:13 -0500, arwe...@cert.org wrote: > From: Adam Welle > > If a packet is received from netlink with the frequency value set it > is > checked against the current radio's frequency and discarded if > different. > The frequency is also checked against

Re: pull-request: mac80211 2015-11-26

2015-12-02 Thread Johannes Berg
Hi, > > A small set of fixes for 4.4: >  * remove NL80211_FEATURE_FULL_AP_CLIENT_STATE again, it >    was broken and needs more work, we'll enable it for 4.5 >  * fix call_rcu() induced use-after-reset/free in mesh >    (that was

[PATCH] brcmfmac: only lock and unlock fws if fws is not null

2015-12-02 Thread Colin King
From: Colin Ian King There is a null ptr check for fws to set bcmc_credit_check, however, there a lock and unlock on fws should only performed if fwts is also not null to also avoid a potential null pointer deference. Signed-off-by: Colin Ian King

Re: [v2] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-02 Thread Eric Dumazet
On Tue, 2015-12-01 at 22:18 -0600, Brent Taylor wrote: > Since commit 8437754c8335 ("ath6kl: Use vmalloc instead of kmalloc for > fw") ar->fw is expected to be pointing to memory allocated by vmalloc. > If the api1 method (via ath6kl_fetch_fw_api1) is used to allocate memory > for ar->fw, then

Re: [PATCH 08/11] brcmfmac: Make 5G join preference configurable.

2015-12-02 Thread Arend van Spriel
On 12/01/2015 12:08 PM, Jouni Malinen wrote: On Tue, Dec 01, 2015 at 11:48:32AM +0200, Kalle Valo wrote: Arend van Spriel writes: It solves a problem for us, but admittedly it is not something that is very usable by user-space apps. So I guess what you are suggesting here

Re: [PATCH] brcmfmac: only lock and unlock fws if fws is not null

2015-12-02 Thread Arend van Spriel
On 12/02/2015 12:45 PM, Colin King wrote: From: Colin Ian King There is a null ptr check for fws to set bcmc_credit_check, however, there a lock and unlock on fws should only performed if fwts is also not null to also avoid a potential null pointer deference.

[PATCH V2] wlcore/wl18xx: fw logger over sdio

2015-12-02 Thread Guy Mishol
From: Shahar Patury enable the FW Logger to work over the SDIO interface instead of only over UART. in new design we will use fw internal memory instead of packet ram that was used in older (and wl12xx) design. this change will reduce the impact on tp and stability. adding new

Re: [PATCH 1/1] staging: cleanup: Fix incompatible type comparison in wilc1000/host_interface.c

2015-12-02 Thread Dan Carpenter
Put v2 in the subject. Also the subsystem prefix is: [PATCH v3] staging: wilc1000: ... On Mon, Nov 30, 2015 at 09:09:04PM -0300, Mario J. Rugiero wrote: > This patch replaces an "if (ptr > 0)" comparison that seems to be a > confusing way to check for null by a simpler "if (ptr)" check. > >

Re: [PATCH V2] wlcore/wl18xx: fw logger over sdio

2015-12-02 Thread kbuild test robot
Hi Shahar, [auto build test ERROR on net-next/master] [also build test ERROR on v4.4-rc3 next-20151127] url: https://github.com/0day-ci/linux/commits/Guy-Mishol/wlcore-wl18xx-fw-logger-over-sdio/20151202-212336 config: mips-allyesconfig (attached as .config) reproduce: wget https