Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-07 Thread Emmanuel Grumbach
On Sun, Feb 7, 2016 at 11:08 AM, Felix Fietkau wrote: > On 2016-02-07 08:25, Emmanuel Grumbach wrote: >> On Fri, Feb 5, 2016 at 12:41 PM, Felix Fietkau wrote: >>> Requires software tx queueing support. frag_list support (for zero-copy) >>> is optional. >>> >>>

Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-07 Thread Felix Fietkau
On 2016-02-07 08:25, Emmanuel Grumbach wrote: > On Fri, Feb 5, 2016 at 12:41 PM, Felix Fietkau wrote: >> Requires software tx queueing support. frag_list support (for zero-copy) >> is optional. >> >> Signed-off-by: Felix Fietkau > > Looks nice! > This would

Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-07 Thread Felix Fietkau
On 2016-02-07 12:32, Emmanuel Grumbach wrote: >>> + >>> +static bool ieee80211_amsdu_aggregate(struct ieee80211_sub_if_data >>> *sdata, >>> + struct sta_info *sta, >>> + struct ieee80211_fast_tx *fast_tx,

[RFC v3] mac80211: add A-MSDU tx support

2016-02-07 Thread Felix Fietkau
Requires software tx queueing support. frag_list support (for zero-copy) is optional. Signed-off-by: Felix Fietkau --- include/net/mac80211.h | 17 + net/mac80211/agg-tx.c | 5 ++ net/mac80211/debugfs.c | 2 + net/mac80211/ieee80211_i.h | 1 +

Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-07 Thread Felix Fietkau
On 2016-02-07 12:56, Emmanuel Grumbach wrote: >>> well.. Yes, you can't assume that you'll have one descriptor for one >>> MSDU payload (unless the driver doesn't advertise SG to the >>> netstack). >> Okay, please make a suggestion describing the exact kinds of limits you >> would need for

Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-07 Thread Emmanuel Grumbach
On Sun, Feb 7, 2016 at 12:06 PM, Emmanuel Grumbach wrote: > On Sun, Feb 7, 2016 at 11:08 AM, Felix Fietkau wrote: >> On 2016-02-07 08:25, Emmanuel Grumbach wrote: >>> On Fri, Feb 5, 2016 at 12:41 PM, Felix Fietkau wrote: Requires

Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-07 Thread Felix Fietkau
On 2016-02-07 11:22, Emmanuel Grumbach wrote: > On Sun, Feb 7, 2016 at 12:06 PM, Emmanuel Grumbach > wrote: >> On Sun, Feb 7, 2016 at 11:08 AM, Felix Fietkau wrote: >>> On 2016-02-07 08:25, Emmanuel Grumbach wrote: On Fri, Feb 5, 2016 at 12:41 PM,

Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-07 Thread Emmanuel Grumbach
On Sun, Feb 7, 2016 at 12:48 PM, Felix Fietkau wrote: > On 2016-02-07 11:22, Emmanuel Grumbach wrote: >> On Sun, Feb 7, 2016 at 12:06 PM, Emmanuel Grumbach >> wrote: >>> On Sun, Feb 7, 2016 at 11:08 AM, Felix Fietkau wrote: On

Re: [RFC RESEND] iwlwifi: pcie: transmit queue auto-sizing

2016-02-07 Thread Grumbach, Emmanuel
On 02/05/2016 12:06 AM, Dave Taht wrote: > I am not on linux-wireless nor netdev presently, but... > > On Thu, Feb 4, 2016 at 12:16 PM, Emmanuel Grumbach > wrote: >> As many (all?) WiFi devices, Intel WiFi devices have >> transmit queues which have 256 transmit

Re: [RFC v2] mac80211: add A-MSDU tx support

2016-02-07 Thread Emmanuel Grumbach
On Sun, Feb 7, 2016 at 1:49 PM, Felix Fietkau wrote: > On 2016-02-07 12:32, Emmanuel Grumbach wrote: + +static bool ieee80211_amsdu_aggregate(struct ieee80211_sub_if_data *sdata, + struct sta_info *sta,

Re: wl12xx regression on 4.5 (was: Re: linux-4.5-rc1 TI pandboard-es wifi wlcore locks and reset)

2016-02-07 Thread Emil Goode
Hello, On Tue, Feb 02, 2016 at 05:05:38PM +0100, Sebastian Reichel wrote: > On Tue, Feb 02, 2016 at 04:41:13PM +1100, Ross Green wrote: > > On Tue, Feb 2, 2016 at 3:34 PM, Sebastian Reichel wrote: > > > On Mon, Feb 01, 2016 at 11:38:38PM +1100, Ross Green wrote: > > >> On Mon,

Re: [RFC v3] mac80211: add A-MSDU tx support

2016-02-07 Thread Emmanuel Grumbach
On Sun, Feb 7, 2016 at 3:21 PM, Felix Fietkau wrote: > Requires software tx queueing support. frag_list support (for zero-copy) > is optional. > > Signed-off-by: Felix Fietkau > --- > include/net/mac80211.h | 17 + > net/mac80211/agg-tx.c | 5

Re: [RFC v3] mac80211: add A-MSDU tx support

2016-02-07 Thread Felix Fietkau
On 2016-02-07 21:16, Emmanuel Grumbach wrote: > On Sun, Feb 7, 2016 at 3:21 PM, Felix Fietkau wrote: >> Requires software tx queueing support. frag_list support (for zero-copy) >> is optional. >> >> Signed-off-by: Felix Fietkau >> --- >>

Re: [PATCH RESEND 40/70] staging: wilc1000: wilc_wlan.c: replaces PRINT_ER with netdev_err

2016-02-07 Thread Greg KH
On Thu, Feb 04, 2016 at 06:24:01PM +0900, Glen Lee wrote: > From: Leo Kim > > This patches replaces PRINT_ER with netdev_err. No, that's not what this patch does :( > Removes unnecessary debug logs as well. That's what this patch does. Please be more careful. I'm not

Re: [PATCH v3 3/3] staging: rtl8723au: whitespace and blank line cleaning

2016-02-07 Thread Julian Calaby
Hi Geliang, On Sun, Feb 7, 2016 at 2:30 PM, Geliang Tang wrote: > This patch cleans whitespaces and blank lines surrounding > list_for_each_entry*(). It does a lot more than this, including: - Removing some unnecessary brackets - Whitespace changes well away from the

Re: [PATCH 5/8] staging: wilc1000: fix return type of wilc_send_config_pkt

2016-02-07 Thread Greg KH
On Fri, Feb 05, 2016 at 10:35:15AM +0900, Chaehyun Lim wrote: > wilc_send_config_pkt is returned 0 or -ETIMEDOUT according to return > value of wilc_wlan_cfg_get or wilc_wlan_cfg_set. > It is better to use int type to represent linux standard error code. > > Signed-off-by: Chaehyun Lim

[PATCH] brcmfmac: Increase nr of supported flowrings.

2016-02-07 Thread Rafał Miłecki
From: Hante Meuleman New generation devices have firmware which has more than 256 flowrings. E.g. following debugging message comes from 14e4:4365 BCM4366: [ 194.606245] brcmfmac: brcmf_pcie_init_ringbuffers Nr of flowrings is 264 At various code places (related to