[PATCH 43/43] iwlwifi: mvm: support sw queue start/stop from mvm

2016-03-01 Thread Emmanuel Grumbach
From: Liad Kaufman Add a wrapper function to allow stopping SW queues from MVM as well. Signed-off-by: Liad Kaufman Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 4 +++

[PATCH 22/43] iwlwifi: pcie: configure more RFH settings

2016-03-01 Thread Emmanuel Grumbach
From: Sara Sharon Fine tune RFH registers further: * Set default queue explicitly * Set RFH to drop frames exceeding RB size * Set the maximum rx transfer size to DRAM to 128 instead of 64 Signed-off-by: Sara Sharon Signed-off-by: Emmanuel Grumbach

[PATCH 20/43] iwlwifi: mvm: update rx_status with mactime flag

2016-03-01 Thread Emmanuel Grumbach
From: Sara Sharon When forming IBSS, mac80211 scans in order to find an already existing cell to join. In case the scan does not find any existing cell a new IBSS cell is formed. When receiving the beacons of another IBSS cell we should merge if the other IBSS cell's TSF

[PATCH 36/43] iwlwifi: support ucode with d0 unified image - regular and usniffer

2016-03-01 Thread Emmanuel Grumbach
From: Golan Ben-Ami Till today, the ucode consisted of two d0 images - regular, in which the usniffer wasn't enabled, and usniffer, in which the usniffer logs were enabled. Lately, the two images were unified, so there is only one d0 image, in which the usniffer logs are

[PATCH 42/43] iwlwifi: mvm: take the transport ref back when leaving

2016-03-01 Thread Emmanuel Grumbach
From: Luca Coelho If d0i3 is supported, we have released the initial transport reference in iwl_op_mode_mvm_start(), so we should take it back in iwl_op_mode_mvm_stop() to keep it balanced. Signed-off-by: Luca Coelho Signed-off-by: Emmanuel

[PATCH 34/43] iwlwifi: mvm: kill iwl_mvm_enable_agg_txq

2016-03-01 Thread Emmanuel Grumbach
iwl_mvm_enable_agg_txq has only one user. Kill it and adapt the call site. Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 16 drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 16 +++- 2 files changed,

[PATCH 38/43] iwlwifi: pcie: detect and workaround invalid write ptr behavior

2016-03-01 Thread Emmanuel Grumbach
From: Sara Sharon In 9000 series A0 step the closed_rb_num is not wrapping around properly. The queue is wrapping around as it should, so we can W/A it by wrapping the closed_rb_num in the driver. While at it, extend RX logging and add error handling of other cases HW

[PATCH 29/43] iwlwifi: mvm: various trivial cleanups

2016-03-01 Thread Emmanuel Grumbach
* Remove uneeded includes: iwl-csr.h and devcoredump aren't used in mac80211.c. * Remove uneeded empty line Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH 37/43] iwlwifi: mvm: update ucode status before stopping device

2016-03-01 Thread Emmanuel Grumbach
From: Chaya Rachel Ivgi Leaving ucode_loaded to true after stop_device() has been called is a recipe for problems. Flows that are not sync'ed with the driver life cycle (like debugfs hooks and thermal hooks) must check that the firmware is loaded before they interact

[PATCH 21/43] iwlwifi: mvm: support filtered frames notification

2016-03-01 Thread Emmanuel Grumbach
From: Sara Sharon During d0i3 frames might be filtered by the FW and this may cause reordering buffer a delay - as the frames will not be received and reorder will time out. Introduce an API function to receive notification of filtered frames and pass the information to

[PATCH 30/43] iwlwifi: mvm: Set global RRM capability

2016-03-01 Thread Emmanuel Grumbach
From: Beni Lev Allow to publish RRM capabilities without the need to support a minimal capability set. Since some RRM features(e.g. neighbor report) are fw independent, set this capability unconditionally. Signed-off-by: Beni Lev Signed-off-by: Emmanuel

[PATCH 28/43] iwlwifi: mvm: support VHT MU-MIMO notification

2016-03-01 Thread Emmanuel Grumbach
From: Sara Sharon When the device is in d0i3/d3 we will not receive the VHT MU-MIMO group id management frame. Instead, firmware will notify us upon exit on the current status and we can in turn update mac80211. Support this notification. While at it, also check as a

[PATCH 25/43] iwlwifi: mvm: add duplicate packet detection per rx queue

2016-03-01 Thread Emmanuel Grumbach
From: Sara Sharon Next hardware will direct TCP/UDP streams to different cores. Packets belonging to the same stream will be directed to the same core. The result is that duplicates will be always directed to the same rx queue were the first packet was received. This

[PATCH 27/43] iwlwifi: mvm: remove unused field in iwl_mvm_tid_data

2016-03-01 Thread Emmanuel Grumbach
Commit 69c7fda40921c125f6a827f6270ac6aa1baa removed the users of iwl_mvm_tid_data.reduced_tpc. Due to a conflict, I forgot to commit the hunk that removed the field itself. Do this know. Signed-off-by: Emmanuel Grumbach ---

[PATCH 40/43] iwlwifi: mvm: only release the trans ref if d0i3 is supported in fw

2016-03-01 Thread Emmanuel Grumbach
From: Luca Coelho If d0i3 is not supported by the firmware (or if it's disabled via module parameters) we shouldn't release the initial transport reference, so that we won't enter runtime suspend. Signed-off-by: Luca Coelho Signed-off-by:

[PATCH 41/43] iwlwifi: add disable_11ac module param

2016-03-01 Thread Emmanuel Grumbach
From: Andrei Otcheretianski Add module parameter that disables VHT capabilities. Signed-off-by: Andrei Otcheretianski Signed-off-by: Emmanuel Grumbach ---

[PATCH 26/43] iwlwifi: mvm: add RSS queues notification infrastructure

2016-03-01 Thread Emmanuel Grumbach
From: Sara Sharon In multi rx queue HW, without execessive locking, there is no sync between the ctrl path (default queue) and the rest of the rx queues. This might cause issues on certain situations. For example, in case a delBA was processed on a default queue but out of

[PATCH 35/43] iwlwifi: mvm: Disable beacon storing in D3 when WOWLAN configured

2016-03-01 Thread Emmanuel Grumbach
From: Matti Gottlieb Currently when entering D3 with WOWLAN configured, we enable in the configuration flags beacon storing, and do not disable beacon filtering, and do not wake up from a magic packet. Having both enabled is wrong (should not have both enabled), and

[PATCH 33/43] iwlwifi: mvm: take care of padded packets

2016-03-01 Thread Emmanuel Grumbach
From: Sara Sharon To ensure that the SNAP/TCP/IP headers are DW aligned, the firmware may add 2-byte pad at the end of the mac header - after the IV, before the SNAP. In that case the mpdu descriptor pad bit will be turned on. Driver should take it into consideration, and

[PATCH 31/43] iwlwifi: mvm: forbid U-APSD for P2P Client if the firmware doesn't support it

2016-03-01 Thread Emmanuel Grumbach
From: Avri Altman Older versions of the firmware don't support U-APSD for P2P Client. Forbid U-APSD for P2P Client when an old firmware is being used. Signed-off-by: Avri Altman Signed-off-by: Emmanuel Grumbach ---

[PATCH 23/43] iwlwifi: pcie: add pm_prepare and pm_complete ops

2016-03-01 Thread Emmanuel Grumbach
From: Luca Coelho With these ops, we can know when we are about to enter system suspend. This allows us to exit D0i3 state before entering suspend. Signed-off-by: Luca Coelho Signed-off-by: Emmanuel Grumbach ---

[PATCH 39/43] iwlwifi: mvm: disable DQA support

2016-03-01 Thread Emmanuel Grumbach
From: Liad Kaufman Do not allow entrance into DQA flows until feature is completely ready and merged. Signed-off-by: Liad Kaufman Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 5

[PATCH 15/43] iwlwifi: mvm: add Tx A-MSDU inside A-MPDU

2016-03-01 Thread Emmanuel Grumbach
If the peer allows, we can have A-MSDU inside A-MDPU. Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 4 ++- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 4 ++- drivers/net/wireless/intel/iwlwifi/mvm/sta.h | 5

[PATCH 13/43] iwlwifi: mvm: update firmware of VHT MU-MIMO groups status on restart

2016-03-01 Thread Emmanuel Grumbach
From: Sara Sharon The firmware handles the VHT MU-MIMO group data on its own. However, on HW restart (and future sniffer mode) the driver shall update the firmware on the VHT MU-MIMO group membership status. Signed-off-by: Sara Sharon

[PATCH 17/43] iwlwifi: mvm: don't enable A-MSDU when the rates are too low

2016-03-01 Thread Emmanuel Grumbach
Allow A-MSDU only when we are not downscaling and the initial MCS is at least 5. Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 24 ++-- drivers/net/wireless/intel/iwlwifi/mvm/sta.h | 2 ++

[PATCH 16/43] iwlwifi: mvm: allow to limit the A-MSDU from debugfs

2016-03-01 Thread Emmanuel Grumbach
in order to be able to tune the size of the desired A-MSDU based on link condition, add a knob to modify the length of the A-MSDU. Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c | 19 +++

[PATCH 12/43] iwlwifi: mvm: enable VHT MU-MIMO for supported hardware

2016-03-01 Thread Emmanuel Grumbach
From: Sara Sharon Incoming hardware will support VHT MU-MIMO. Declare this capability for relevant hardware. Signed-off-by: Sara Sharon Signed-off-by: Emmanuel Grumbach ---

[PATCH 10/43] iwlwifi: pcie: Add new configuration to enable MSIX

2016-03-01 Thread Emmanuel Grumbach
From: Haim Dreyfuss Working with MSIX requires prior configuration. This includes requesting interrupt vectors from the OS, registering the vectors and mapping the optional causes to the relevant interrupt. In addition add new interrupt handler to handle MSIX interrupt.

[PATCH 06/43] iwlwifi: mvm: handle pass all scan reporting

2016-03-01 Thread Emmanuel Grumbach
From: Luca Coelho The firmware doesn't send match found notifications when no matchsets are passed. This makes sense because if there are no matchsets, nothing can be matched. But the nl80211 API should report when there are results available, even if no matchsets

[PATCH 07/43] iwlwifi: mvm: rs: fix a theoretical access to uninitialized array elements

2016-03-01 Thread Emmanuel Grumbach
From: Eyal Shapira Klocwork is unhappy as ht_vht_rates might be accessed with rate->index being set to values between 0 and 3 which will lead to accessing uninitialized array elements. Effectively this doesn't happen as in HT/VHT we're not using these rate indices. Still fix

[PATCH 09/43] iwlwifi: pcie: aggregate Flow Handler configuration writes

2016-03-01 Thread Emmanuel Grumbach
Instead of waking up the device each time we write a register, wake it up once, and writes the registers at once. Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 56 - 1 file changed, 28 insertions(+),

[PATCH 11/43] iwlwifi: pcie: fix identation in trans.c

2016-03-01 Thread Emmanuel Grumbach
A curly brace was misplaced, fix this. Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c

[PATCH 08/43] iwlwifi: mvm: bump firmware API to 21

2016-03-01 Thread Emmanuel Grumbach
The driver is now ready to handle this firmware. Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/iwl-7000.c | 4 ++-- drivers/net/wireless/intel/iwlwifi/iwl-8000.c | 4 ++-- drivers/net/wireless/intel/iwlwifi/iwl-9000.c | 2 +- 3 files

[PATCH 01/43] iwlwifi: mvm: add CT-KILL notification

2016-03-01 Thread Emmanuel Grumbach
From: Chaya Rachel Ivgi Up to today the driver was notified of the temperature from the FW and decided whether to enter CT-kill or not. >From now on, the FW will decide when to enter CT-kill and will notify the driver. Add support for this notification.

[PATCH 03/43] iwlwifi: mvm: add registration to cooling device

2016-03-01 Thread Emmanuel Grumbach
From: Chaya Rachel Ivgi Register cooling device in order to have the Thermal Manager handle the device's power budget according to the sent notifications. The interface adds a new thermal cooling device to /sys/class/thermal/ folder. Signed-off-by: Chaya Rachel Ivgi

[PATCH 02/43] iwlwifi: mvm: add registration to thermal zone

2016-03-01 Thread Emmanuel Grumbach
From: Chaya Rachel Ivgi Register to thermal_zone interface and implement the thermal ops. The thermal handles the device throttling, and sets the the temperature thresholds the Thermal Manager would be notified of crossing. The thermal interface adds a new thermal

[PATCH 04/43] iwlwifi: mvm: set the correct descriptor size for tracing

2016-03-01 Thread Emmanuel Grumbach
From: Sara Sharon The 9000 series uses a diffrent sized descriptor. Update the relevant tracing field. Signed-off-by: Sara Sharon Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 4

pull request: iwlwifi-next 2016-03-02

2016-03-01 Thread Grumbach, Emmanuel
Hi Kalle, This is a pull request for 4.6. It is big because a lot of patches were waiting for code in mac80211-next which is now in net-next. As you figured, I need you to pull Johannes's mac80211-next-for-davem-2016-02-26 before you pull this from me. Of course, you can just merge net-next.

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

2016-03-01 Thread Michal Kazior
On 1 March 2016 at 15:02, Johannes Berg wrote: > On Fri, 2016-02-26 at 14:09 +0100, Michal Kazior wrote: >> >> +typedef u64 codel_time_t; > > Do we really need this? And if yes, does it have to be in the public > header file? Why a typedef anyway? Hmm.. I don't think

Re: About adding support for MT76x2U to Linux kernel

2016-03-01 Thread Tuomas Räsänen
On Fri, Aug 14, 2015 at 02:32:29PM +0200, Jakub Kiciński wrote: > CC: Linus W who was hacking on mt7630e recently. > > There is a fourth option: merge mt76 and mt7601u and add support for > mt76x2u along the way ;) > Btw, how difficult it would be to add master mode support to mt7601u? >From 1

[PATCH v3 8/8] ath9k: fix BTCoex configuration for SOC chips

2016-03-01 Thread miaoqing
From: Miaoqing Pan Allow to set wl_active_time and wl_qc_time for SOC chips, also adjust bt_time_extend and bt_first_slot_time. Signed-off-by: Miaoqing Pan --- drivers/net/wireless/ath/ath9k/btcoex.c | 31 ---

[PATCH v3 0/8] ath9k GPIO & BT-Coex bug fixes

2016-03-01 Thread miaoqing
From: Miaoqing Pan ath9k GPIO & BT-Coex bug fixes. Notes: v2: fix build warning v3: move changelog to cover letter Miaoqing Pan (8): ath9k: define correct GPIO numbers and bits mask ath9k: make GPIO API to support both of WMAC and SOC ath9k: free GPIO

[PATCH v3 4/8] ath9k: cleanup led_pin initial

2016-03-01 Thread miaoqing
From: Miaoqing Pan Make ath_init_leds() and ath_deinit_leds() pairs as the only API to set leds, also removed direction configuration from ath9k_start() and ath9k_stop(). So the initial is more clear now. Signed-off-by: Miaoqing Pan ---

[PATCH v3 1/8] ath9k: define correct GPIO numbers and bits mask

2016-03-01 Thread miaoqing
From: Miaoqing Pan Define correct GPIO numbers and MASK bits to indicate the WMAC GPIO resource. Allow SOC chips(AR9340, AR9531, AR9550, AR9561) to access all GPIOs which rely on gpiolib framework. But restrict SOC AR9330 only to access WMAC GPIO which has the same

[PATCH v3 3/8] ath9k: free GPIO resource for SOC GPIOs

2016-03-01 Thread miaoqing
From: Miaoqing Pan For SOC GPIOs, should call ath9k_hw_gpio_free() to release the GPIO resource. Signed-off-by: Miaoqing Pan --- drivers/net/wireless/ath/ath9k/btcoex.c | 10 ++ drivers/net/wireless/ath/ath9k/btcoex.h | 1

CISCO AND AVAYA IP Phones

2016-03-01 Thread Laison Computech Inc
Hi, Clean tested working pulls CPUs and QTYs in stock. 115 X X5650 65 X E5410 75 X X5660 145 X E5530 100 X E5645 40 X X5680 75 X X5690 Brand new sealed IP phones and QTYs in stock. 55 x CP-7937G 77 x CP-7942G 54 x CP-7945G 75 x CP-7962G .. 45 x Avaya 9630 65 x Avaya 9641 55 x Avaya 9640

Re: pull-request: mac80211-next 2016-02-26

2016-03-01 Thread Johannes Berg
On Tue, 2016-03-01 at 17:11 -0500, David Miller wrote: >  > There was a minor merge conflict with net/mac80211/debugfs.c, take > a look and send me any fixups necessary. > Ah yes, I'd wondered when that change was coming in, but missed that you had it in net-next now. Looks good, thanks!

Re: pull-request: mac80211-next 2016-02-26

2016-03-01 Thread David Miller
From: Johannes Berg Date: Fri, 26 Feb 2016 21:37:46 +0100 > Let's try this again. I backed out some of the rfkill changes > that are buggy and fixed some of that too. I also left out the > one that generated the big discussion, but I still think it's > the saner thing

Re: [PATCH V10 1/2] nl80211: add feature for BSS selection support

2016-03-01 Thread Arend Van Spriel
On 1-3-2016 9:42, Eliad Peller wrote: > On Mon, Feb 29, 2016 at 11:44 AM, Arend van Spriel wrote: >> Introducing a new feature that the driver can use to >> indicate the driver/firmware supports configuration of BSS >> selection criteria upon CONNECT command. This can be

Re: [PATCH RFC 1/2] rhashtable: accept GFP flags in rhashtable_walk_init

2016-03-01 Thread Thomas Graf
On 02/28/16 at 08:06pm, Bob Copeland wrote: > In certain cases, the 802.11 mesh pathtable code wants to > iterate over all of the entries in the forwarding table from > the receive path, which is inside an RCU read-side critical > section. Enable walks inside atomic sections by allowing >

Re: [PATCH v5] ath10k: set MAC timestamp in management Rx frame

2016-03-01 Thread Peter Oh
On 02/29/2016 10:33 AM, Michal Kazior wrote: On 26 February 2016 at 20:03, Peter Oh wrote: Check and set Rx MAC timestamp when firmware indicates it. Firmware adds it in Rx beacon frame only at this moment. Driver and mac80211 may utilize it to detect such clockdrift or

[PATCH v6] ath10k: set MAC timestamp in management Rx frame

2016-03-01 Thread Peter Oh
Check and set Rx MAC timestamp when firmware indicates it. Firmware adds it in Rx beacon frame only at this moment. Driver and mac80211 may utilize it to detect such clockdrift or beacon collision and use the result for beacon collision avoidance. Signed-off-by: Peter Oh

[PATCH v2 06/15] wil6210: switch to generated wmi.h

2016-03-01 Thread Maya Erez
From: Lior David Switch to auto-generated version of wmi.h which is maintained by FW team. This will allow better sync between teams in the future and avoid bugs because of unexpected API changes. The wmi.h will have many differences but most are cosmetic. It also

[PATCH v2 10/15] wil6210: P2P_DEVICE virtual interface support

2016-03-01 Thread Maya Erez
From: Lior David Added support for the P2P_DEVICE virtual interface. This interface is intended for P2P management operations such as discovery and GO negotiation. Normally it is implemented by drivers to allow a separate interface for P2P management with its own MAC

[PATCH v2 15/15] wil6210: add oob_mode module parameter

2016-03-01 Thread Maya Erez
From: Lior David Add module parameter oob_mode. Takes effect the next time the interface is brought up and FW is loaded. Puts the FW in special "out of the box" (OOB) mode which is used for diagnostics and certification. Signed-off-by: Lior David

[PATCH v2 14/15] wil6210: pass is_go flag to firmware

2016-03-01 Thread Maya Erez
From: Lior David When starting a PCP, pass the is_go flag to firmware in wmi_pcp_start. This flag indicates whether we started a PCP which is also a GO(P2P group owner) or just a regular PCP. Signed-off-by: Lior David Signed-off-by: Maya

[PATCH v2 12/15] wil6210: clean ioctl debug message

2016-03-01 Thread Maya Erez
From: Lior David Fix a debug message related to IOCTL that was incorrectly logged with the MISC category, and move it inside wil_ioctl so it will always be logged even if we call wil_ioctl from other places. Signed-off-by: Lior David

[PATCH v2 08/15] wil6210: add support for platform specific notification events

2016-03-01 Thread Maya Erez
Add the ability to notify the platform driver on different events, such as FW crash, pre reset and FW ready. Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/interrupt.c| 5 ++-- drivers/net/wireless/ath/wil6210/main.c | 32

[PATCH v2 13/15] wil6210: fix no_fw_recovery mode with change_virtual_intf

2016-03-01 Thread Maya Erez
From: Lior David When FW crashed with no_fw_recovery mode enabled, user space could still call wil_cfg80211_change_iface quickly to change interface type, and this would cause recovery to proceed and FW crash logs may be lost. Fix this problem by not resetting the FW

[PATCH v2 11/15] wil6210: fix race conditions in p2p listen and search

2016-03-01 Thread Maya Erez
From: Lior David Fix 2 race conditions found during test runs of P2P discovery: 1. Because wil_p2p_cancel_listen was not protected, user space could start a new P2P listen/search before wmi_stop_discovery completed. This caused a crash in the firmware. 2. In P2P

[PATCH v2 07/15] wil6210: basic PBSS/PCP support

2016-03-01 Thread Maya Erez
From: Lior David PBSS (Personal Basic Service Set) is a new BSS type for DMG networks. It is similar to infrastructure BSS, having an AP-like entity called PCP (PBSS Control Point), but it has few differences. For example, stations inside a PBSS can communicate

[PATCH v2 05/15] wil6210: add support for discovery mode during scan

2016-03-01 Thread Maya Erez
From: Lior David Add support for discovery mode during scan. When discovery mode is active, station transmits special beacons while scanning. This can optimize the scan mainly when there is only one AP/PCP around. Discovery mode is implicitly used by firmware during

[PATCH v2 00/15] wil6210 patches

2016-03-01 Thread Maya Erez
Changes in V2: - Fixed oob_mode module parameter description This set of patches includes: - wil6210 bug fixes - P2P support - switch to generated wmi.h - replay attack detection Dedy Lansky (1): wil6210: p2p initial support Hamad Kadmany (1): wil6210: Set permanent MAC address to wiphy

[PATCH v2 04/15] wil6210: replay attack detection

2016-03-01 Thread Maya Erez
From: Vladimir Kondratiev Check PN for encrypted frames. Maintain PN data for Rx keys, pairwise per TID and group. Print PN's in the debugfs "stations" entry, like: [0] 04:ce:14:0a:3c:3d connected [ 0] ([32] 0 TU) 0x0fe [|___] total

[PATCH v2 01/15] wil6210: remove BACK RX and TX workers

2016-03-01 Thread Maya Erez
WMI synchronous handling has changed and WMI calls that provide a buffer for the reply are completed in the WMI interrupt context. This allows sending the RX and TX BACK commands from the WMI event handler without the need for the worker thread. This is a better approach as it can decrease the

[PATCH v2 02/15] wil6210: AP: prevent connecting to already connected station

2016-03-01 Thread Maya Erez
wmi_evt_connect doesn't check if the connect event is received for an already connected station. This can lead to memory leak as a new vring is allocated without freeing the previously allocated vring and to unexpected behavior of nl80211 layer due to unexpected notification of a new station. Add

Re: [PATCH] staging: rtl8723au: Fix line longer than 80 columns.

2016-03-01 Thread Edward Lipinsky
On Sat, Feb 27, 2016 at 10:48:56AM -0800, Joe Perches wrote: > On Sat, 2016-02-27 at 10:28 -0800, Edward Lipinsky wrote: > > This patch fixes the checkpatch.pl warning: > > WARNING: line over 80 characters > [] > > diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c > >

Re: [PATCHv2 08/10] rfkill: Use switch to demux userspace operations

2016-03-01 Thread João Paulo Rechi Vita
On 1 March 2016 at 08:43, Johannes Berg wrote: > On Tue, 2016-03-01 at 00:39 +0200, Jouni Malinen wrote: > >> > I agree there is a difference in the logic here, > > Gah. I thought I'd reviewed the logic and made sure there's no > difference ... :) > >> > thanks for

[PATCH v2 2/3] staging: rtl8723au: core: rtw_xmit: use list_first_entry_or_null()

2016-03-01 Thread Geliang Tang
Use list_first_entry_or_null() instead of list_empty() + container_of() to simplify the code. Signed-off-by: Geliang Tang Acked-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_xmit.c | 26 -- 1 file changed, 8

[PATCH v2 3/3] staging: rtl8723au: core: rtw_recv: use list_first_entry()

2016-03-01 Thread Geliang Tang
Use list_first_entry() instead of container_of() to simplify the code. Signed-off-by: Geliang Tang Acked-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_recv.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH v2 0/3] staging: rtl8723au: use list_first_entry*

2016-03-01 Thread Geliang Tang
On Mon, Feb 22, 2016 at 09:39:15PM -0500, Jes Sorensen wrote: > Geliang Tang writes: > > Use list_first_entry*() instead of container_of() to simplify the code. > > > > Signed-off-by: Geliang Tang > > --- > > drivers/staging/rtl8723au/core/rtw_recv.c |

[PATCH v2 1/3] staging: rtl8723au: core: rtw_recv: use list_first_entry_or_null()

2016-03-01 Thread Geliang Tang
Use list_first_entry_or_null() instead of list_empty() + container_of() to simplify the code. Signed-off-by: Geliang Tang Acked-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_recv.c | 42 --- 1 file changed, 11

[PATCH] staging: rtl8723au: fix static checker warning

2016-03-01 Thread Geliang Tang
Fix the following static checker warning: drivers/staging/rtl8723au/core/rtw_sta_mgt.c:365 rtw_get_stainfo23a() error: potential NULL dereference 'psta'. Fixes: e280d71("staging: rtl8723au: use list_for_each_entry*()") Signed-off-by: Geliang Tang ---

Re: [PATCH 12/15] wil6210: clean ioctl debug message

2016-03-01 Thread Kalle Valo
Maya Erez writes: > From: Lior David > > Fix a debug message related to IOCTL that was incorrectly logged > with the MISC category, and move it inside wil_ioctl so it will > always be logged even if we call wil_ioctl from other places. > >

Re: [PATCH 15/15] wil6210: add oob_mode module parameter

2016-03-01 Thread Kalle Valo
Maya Erez writes: > From: Lior David > > Add module parameter oob_mode. Takes effect the next time > the interface is brought up and FW is loaded. Puts the FW > in special "out of the box" (OOB) mode which is used for > diagnostics and

Re: [PATCH] mac80211: minstrel_ht: fix a logic error in RTS/CTS handling

2016-03-01 Thread Johannes Berg
On Wed, 2016-02-24 at 12:07 +0100, Felix Fietkau wrote: > RTS/CTS needs to be enabled if the rate is a fallback rate *or* if > it's a dual-stream rate and the sta is in dynamic SMPS mode. > Applied, thanks. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in

Re: [PATCH] mac80211: check PN correctly for GCMP-encrypted fragmented MPDUs

2016-03-01 Thread Johannes Berg
On Fri, 2016-02-26 at 22:16 +0100, Johannes Berg wrote: > From: Johannes Berg > > Just like for CCMP we need to check that for GCMP the fragments > have PNs that increment by one; the spec was updated to fix this > security issue and now has the following text: > >

Re: [PATCH] mac80211: Fix Public Action frame RX in AP mode

2016-03-01 Thread Johannes Berg
On Tue, 2016-03-01 at 00:29 +0200, Jouni Malinen wrote: > Public Action frames use special rules for how the BSSID field > (Address > 3) is set. A wildcard BSSID is used in cases where the transmitter > and > recipient are not members of the same BSS. As such, we need to accept > Public Action

Re: [PATCH RFC 1/2] rhashtable: accept GFP flags in rhashtable_walk_init

2016-03-01 Thread Bob Copeland
On Tue, Mar 01, 2016 at 02:54:16PM +0100, Johannes Berg wrote: > On Sun, 2016-02-28 at 20:06 -0500, Bob Copeland wrote: > > In certain cases, the 802.11 mesh pathtable code wants to > > iterate over all of the entries in the forwarding table from > > the receive path, which is inside an RCU

Re: [PATCH] mac80211: Fix Public Action frame RX in AP mode

2016-03-01 Thread Arik Nemtsov
On Tue, Mar 1, 2016 at 12:29 AM, Jouni Malinen wrote: > Public Action frames use special rules for how the BSSID field (Address > 3) is set. A wildcard BSSID is used in cases where the transmitter and > recipient are not members of the same BSS. As such, we need to accept

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

2016-03-01 Thread Johannes Berg
On Fri, 2016-02-26 at 14:09 +0100, Michal Kazior wrote: > > +typedef u64 codel_time_t; Do we really need this? And if yes, does it have to be in the public header file? Why a typedef anyway? > - * @txq_ac_max_pending: maximum number of frames per AC pending in > all txq > - * entries for a

Re: [PATCH] ath10k: Fix mgmt tx status for 10.4.3 firmware.

2016-03-01 Thread Felix Fietkau
On 2016-02-29 22:50, gree...@candelatech.com wrote: > From: Ben Greear > > When testing a 10.4.3 firmware in station mode, I notice that > when the AP is powered down, the ath10k does not notice AP is gone > because mgt frames get tx status of 3, which is not handled. >

Re: [PATCH RFC 1/2] rhashtable: accept GFP flags in rhashtable_walk_init

2016-03-01 Thread Johannes Berg
On Sun, 2016-02-28 at 20:06 -0500, Bob Copeland wrote: > In certain cases, the 802.11 mesh pathtable code wants to > iterate over all of the entries in the forwarding table from > the receive path, which is inside an RCU read-side critical > section.  Enable walks inside atomic sections by

Re: [PATCHv2 08/10] rfkill: Use switch to demux userspace operations

2016-03-01 Thread Johannes Berg
On Tue, 2016-03-01 at 00:39 +0200, Jouni Malinen wrote: > > I agree there is a difference in the logic here, Gah. I thought I'd reviewed the logic and made sure there's no difference ... :) > > thanks for taking the > > time to point it out so clearly, and sorry for missing this. But AFAIU > >

Re: [PATCH v2 2/8] ath9k: make GPIO API to support both of WMAC and SOC

2016-03-01 Thread Valo, Kalle
writes: > From: Miaoqing Pan > > commit 61b559dea40e ("ath9k: add extra GPIO led support") > added ath9k to support access SOC's GPIOs, but implemented > in a separated API: ath9k_hw_request_gpio(). > > So this patch make the APIs more common,

[PATCH 1/2] ath10k: fix HTT Tx CE ring size

2016-03-01 Thread Michal Kazior
QCA4019 can queue up to 2500 frames at a time. This means it requires roughly 5000 entires on the ring to work properly. Otherwise random tx failure may occur. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/ce.h | 2 +- 1 file changed, 1 insertion(+),

[PATCH 2/2] ath10k: change htt tx desc/qcache peer limit config

2016-03-01 Thread Michal Kazior
The number of HTT Tx descriptors and qcache peer limit aren't hw-specific. In fact they are firmware specific and should not be placed in hw_params. The QCA4019 limits were submitted with the peer flow control firmware only and to my understanding there's no non-peer-flow-ctrl QCA4019 firmware.

rt2x00queue: rt2800usb: NULL pointer crash while during USB disconnect

2016-03-01 Thread Vishal Thanki
Hi, I observed a NULL pointer access crash during my testing on a custom AM33xx based board with RT5572 USB wifi module. The kernel log is attached with the mail. With initial debugging, I think that the USB disconnect event was triggered while there was an pending/incomplete URB request present.

[PATCH v2 11/11] ath10k: implement push-pull tx

2016-03-01 Thread Michal Kazior
The current/old tx path design was that host, at its own leisure, pushed tx frames to the device. For HTT there was ~1000-1400 msdu queue depth. After reaching that limit the driver would request mac80211 to stop queues. There was little control over what packets got in there as far as DA/RA was

[PATCH v2 10/11] ath10k: keep track of queue depth per txq

2016-03-01 Thread Michal Kazior
This will be necessary for later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/core.h | 1 + drivers/net/wireless/ath/ath10k/mac.c | 5 + drivers/net/wireless/ath/ath10k/txrx.c | 7 +++ 3 files changed, 13 insertions(+) diff --git

[PATCH v2 09/11] ath10k: store txq in skb_cb

2016-03-01 Thread Michal Kazior
This will be necessary for later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/core.h | 1 + drivers/net/wireless/ath/ath10k/mac.c | 19 +-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git

[PATCH v2 05/11] ath10k: add fast peer_map lookup

2016-03-01 Thread Michal Kazior
The pull-push functionality of 10.4 will be based on peer_id and tid. These will need to be mapped, eventually, to ieee80211_txq to be used with ieee80211_tx_dequeue(). Iterating over existing stations every time peer_id needs to be mapped to a station would be inefficient wrt CPU time. The new

[PATCH v2 03/11] ath10k: refactor tx pending management

2016-03-01 Thread Michal Kazior
Tx pending counter logic assumed that the sk_buff is already known and hence was performed in HTT functions themselves. However, for the sake of future wake_tx_queue() usage the driver must be able to tell whether it can submit more frames to firmware before it dequeues frame from ieee80211_txq

[PATCH v2 06/11] ath10k: add new htt message generation/parsing logic

2016-03-01 Thread Michal Kazior
This merely adds some parsing, generation and sanity checks with placeholders for real code/functionality to be added later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/htt.h| 5 + drivers/net/wireless/ath/ath10k/htt_rx.c | 198

[PATCH v2 07/11] ath10k: implement wake_tx_queue

2016-03-01 Thread Michal Kazior
This implements very basic support for software queueing. It also contains some knobs that will be patched later. Signed-off-by: Michal Kazior --- Notes: v2: - squashed with `ath10k: add txq placeholder` - squashed with `ath10k: implement flushing of

[PATCH v2 08/11] ath10k: implement updating shared htt txq state

2016-03-01 Thread Michal Kazior
Firmware 10.4.3 onwards can support a pull-push Tx model where it shares a Tx queue state with the host. The host updates the DMA region it pointed to during HTT setup whenever number of software queued from (on host) changes. Based on this information firmware issues fetch requests to the host

[PATCH v2 04/11] ath10k: maintain peer_id for each sta and vif

2016-03-01 Thread Michal Kazior
The 10.4.3 firmware with congestion control guarantees that each peer has only a single peer_id mapping. The 1:1 mapping isn't the case for older firmwares (e.g. 10.4.1, 10.2, 10.1) but it should not matter. This 1:1 mapping is going to be only used by future code which inherently (flow-wise) is

[PATCH v2 02/11] ath10k: unify txpath decision

2016-03-01 Thread Michal Kazior
Some future changes will need to determine final tx method early on. Prepare the code. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/mac.c | 58 +++ 1 file changed, 45 insertions(+), 13 deletions(-) diff --git

Re: [PATCH V10 1/2] nl80211: add feature for BSS selection support

2016-03-01 Thread Eliad Peller
On Mon, Feb 29, 2016 at 11:44 AM, Arend van Spriel wrote: > Introducing a new feature that the driver can use to > indicate the driver/firmware supports configuration of BSS > selection criteria upon CONNECT command. This can be useful > when multiple BSS-es are found