Hi Ben,
On Thu, Mar 31, 2016 at 10:08 AM, wrote:
> From: Ben Greear
>
> We must not attempt to send WMI packets while dholding the data-lock,
s/dholding/holding/ ?
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile:
From: Ben Greear
We must not attempt to send WMI packets while dholding the data-lock,
as it may deadlock:
BUG: sleeping function called from invalid context at
drivers/net/wireless/ath/ath10k/wmi.c:1824
in_atomic(): 1, irqs_disabled(): 0, pid: 2878, name:
On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote:
> Joe Perches writes:
> > Using the normal kernel logging mechanisms makes this code
> > a bit more like other wireless drivers.
> Personally I don't see the point but I don't have any strong opinions. A
> bigger problem is
From: Per Forlin
The pend_8021x_cnt gets into a state where it's not being decreased.
When the brcmf_netdev_wait_pend8021x is called it will timeout
because there are no pending packets to be consumed. There is no
easy way of getting out of this state once it has happened.
Hi!
I don't know if you can do simulaneous wlan and BT RX - especially
since WLAN RX sometimes requires ACKs to be sent. :) But for
multicast, sure. You'd have to check the NIC schematic and antenna
switch programming to see if you can do simultaneous wlan RX (with no
TXing, eg RTS/CTS, ACK, etc)
On 03/28/2016 11:42 AM, Greg KH wrote:
On Sat, Mar 26, 2016 at 03:07:18PM -0300, Till Kamppeter wrote:
If there's anything else I need to do here, becides try to find a
co-mentor, please let me know.
I am grateful if you could enter as co-mentor, especially if there is any
kernel project now
On 03/30/2016 09:38 AM, David Miller wrote:
From: Johannes Berg
Date: Wed, 30 Mar 2016 11:14:12 +0200
On Tue, 2016-03-29 at 09:16 -0700, Ben Greear wrote:
Looks like rhashtable has too much policy in it to properly deal with
cases where there are too many hash
From: Johannes Berg
Date: Wed, 30 Mar 2016 11:14:12 +0200
> On Tue, 2016-03-29 at 09:16 -0700, Ben Greear wrote:
>> Looks like rhashtable has too much policy in it to properly deal with
>> cases where there are too many hash collisions, so I am going to work
>> on
Decrement num_mpdus_ready only when rx amsdu is processed successfully.
Not doing so, will result in leak and impact stabilty under low memory
cases.
Signed-off-by: Rajkumar Manoharan
---
drivers/net/wireless/ath/ath10k/htt_rx.c | 8
1 file changed, 4
qca99x0 and qca4019 solutions limit probe responses transmissions.
Logging warning message for each probe response drop is flooding
kernel log unnecessary with " failed to increase tx mgmt pending
count: -16, dropping". Hence reducing log level to debug.
Reported-by: Sebastian Gottschall
pre-calibration is meant for qca4019 which contains only caldata
whereas calibration file is used by ar9888 and qca99x0 that contains
both board data and caldata. So by definition both pre-cal-file and
cal-file can not coexist. Keeping them in shared memory (union), is
breaking boot sequence of
On 03/30/2016 02:22 AM, Michal Kazior wrote:
On 29 March 2016 at 17:54, Ben Greear wrote:
On 03/29/2016 12:49 AM, Michal Kazior wrote:
if you are getting a pure codel result of 160ms, that means the
implementation is broken. But I think (after having read your
From: Chaya Rachel Ivgi
The driver can read the current state during D0I3,
therefore there is no reason not to do it.
Signed-off-by: Chaya Rachel Ivgi
Signed-off-by: Emmanuel Grumbach
---
From: Liad Kaufman
When working in DQA mode, there is a lockdep log warning
about an inconsistent state of the mvmsta->lock and the
mvm->queue_info_lock. Fix this. This mode is not activated
for now.
Signed-off-by: Liad Kaufman
Signed-off-by:
From: Oren Givon
Edit some of the 9560 series and 5165 series PCI IDs.
These devices do not exist yet.
Signed-off-by: Oren Givon
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 12
On Wed, Mar 30, 2016 at 8:19 AM, Amitkumar Karwar wrote:
> From: Xinming Hu
>
> Add device tree binding documentation for MARVELL's sd8xxx
> (sd8897 and sd8997) wlan chip.
>
> Signed-off-by: Xinming Hu
> Signed-off-by: Amitkumar Karwar
From: Golan Ben-Ami
In case of FW error, support dumping the UMAC internal txfifos.
To do so, support version 2 of shared memory cfg command, which
contains the sizes of the internal txfifos, and move the command
to the system group.
Signed-off-by: Golan Ben-Ami
From: Sara Sharon
Currently the code checks if hardware reported both L4 and L3
checksums as valid, and only then reports it as validated to
the stack.
However, IPv6 does not have checksum at all and the L3 checksum
valid bit is always off for IPv6 packets, with the result
From: Sara Sharon
We want to request an interrupt vector for RSS queue per CPU,
one vector for fallback queue, and one for non-rx interrupts.
Future patch will make sure that no RSS traffic is directed to
fallback queue.
This will enable us to enable fast path on traffic
From: Sara Sharon
Declare and enable support of RX and TX checksum for 9000 family.
Configure offload_assist in the TX cmd accordingly to support
TX csum.
Signed-off-by: Sara Sharon
Signed-off-by: Emmanuel Grumbach
---
From: Liad Kaufman
Use the reserved BSS Client queue when connecting to an AP
in DQA mode.
Signed-off-by: Liad Kaufman
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/intel/iwlwifi/mvm/fw-api.h | 3 +++
From: Sara Sharon
We insert padding if the MAC header's size is not a multiple of 4
to ensure that the SNAP header is DWORD aligned. When we do so, we
let the firmware know by setting a bit in Tx command
(TX_CMD_FLG_MH_PAD) which will instruct the firmware to drop those
2
_UCODE_API_OK was a intermediate version between MIN and
MAX. If a user had a firmware below _OK but above _MIN, the
driver would work but the user would get a warning in the
kernel log telling him to update his firmware.
This is not needed since most users won't look for these
messages in the
From: Liad Kaufman
For some reason, this was defined as a signed variable.
Make it unsigned.
Signed-off-by: Liad Kaufman
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/intel/iwlwifi/iwl-trans.h | 4 +++-
From: Sara Sharon
My patch resized the pool size, but neglected to resize
the global table, which is obviously wrong since the global
table maps the pool's rxb to vid one to one. This results
in a panic in 9000 devices.
Add a build bug to avoid such a case in the future.
Hi Kalle,
This is a pull request for 4.7. Lots of work here and more to come when
dependencies on mac80211 will be resolved.
Let me know if you have issues!
Thanks.
The following changes since commit 1200b6809dfd9d73bc4c7db76d288c35fa4b2ebe:
Merge
From: Eva Rachel Retuya
Use alloc_ordered_workqueue() to allocate the workqueue instead of
create_singlethread_workqueue() since the latter is deprecated and is scheduled
for removal.
There are work items doing related operations that shouldn't be swapped when
queued in a
From: Luca Coelho
We don't use the refcount value anymore, all the refcounting is done
in the runtime PM usage_count value. Remove it.
Signed-off-by: Luca Coelho
Signed-off-by: Emmanuel Grumbach
---
From: Sara Sharon
Improve current RSS configuration:
* Use netdev_rss_key instead of keeping a local copy.
* Configure also UDP hashing to have UDP traffic spread across queues.
* Do not direct RSS traffic to our fallback queue.
Signed-off-by: Sara Sharon
This makes u-APSD work with more peers.
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 2 +-
drivers/net/wireless/intel/iwlwifi/mvm/power.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
From: Liad Kaufman
Change the CMD queue to be queue #0 (rather than queue #9)
when working in DQA mode.
Signed-off-by: Liad Kaufman
Signed-off-by: Emmanuel Grumbach
---
From: Liad Kaufman
In DQA mode, allocate a dedicated queue (#3) for content
after beacon (AKA "CaB").
Signed-off-by: Liad Kaufman
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/intel/iwlwifi/mvm/fw-api.h
From: Liad Kaufman
Set the correct sta_id in the SCD_QUEUE_CONFIG command sent
to the FW when enabling/disabling queues. This is needed in
DQA-mode to allow the FW to associate between queue and STA.
Signed-off-by: Liad Kaufman
Signed-off-by:
From: Luca Coelho
If something goes wrong with the firmware and we never get a scan
complete notification, we stay stuck forever. In order to avoid this
situation, add a timeout and trigger an NMI if it expires before
receiving the notification., so we can clean things
From: David Spinadel
Auxilary station ID in flag in scan config command wasn't set
although we set the station ID. Add the flag.
Signed-off-by: David Spinadel
Signed-off-by: Emmanuel Grumbach
---
From: Luca Coelho
We were not allowing the thermal state to be set when we were in D0i3
mode. It was not very clearly specified how it should work, but now a
decision was made to allow the state to be set in D0i3 (which will
cause a brief wake up). Remove the check in
From: Colin Ian King
isr_stats is written twice with the same value, remove one of the
redundant assignments to isr_stats.
Signed-off-by: Colin Ian King
Signed-off-by: Emmanuel Grumbach
---
From: Haim Dreyfuss
In MSIX mode we iterate over the allocated interrupt vectors and
register them to an handler. In case of registration failure,
we free all the allocated irq.
we use the outer index mistakenly instead of the inner one.
Signed-off-by: Haim Dreyfuss
From: Golan Ben-Ami
Currently reading the fw memory segments is done according to
addresses and data length that are hard-coded.
Lately a new tlv was appended to the ucode, that contains
the data type, length and address.
Parse this tlv, and in run-time store the memory
From: Sara Sharon
Due to hardware bug, upon any shadow free-queue register write
access, a legacy RBD shadow register must be written as well.
This is required in order to trigger a copy of the shadow registers
values after MAC exits sleep state.
Specifically, the driver
From: Liad Kaufman
"DQA" is shorthand for "dynamic queue allocation". This
enables on-demand allocation of queues per RA/TID rather than
statically allocating per vif, thus allowing a potential
benefit of various factors.
Please refer to the DOC section this patch adds
From: Sara Sharon
API version lower than 16 is not supported anymore - don't
load older ucode.
Remove code handling older versions.
Signed-off-by: Sara Sharon
Signed-off-by: Emmanuel Grumbach
---
From: Haim Dreyfuss
Update device id and FW serial number for 2X2 antenna devices
in 9000 generation product. These will not be available on
the market in the coming year.
Signed-off-by: Haim Dreyfuss
Signed-off-by: Emmanuel Grumbach
We have a module parameter, this is enough.
per platform customizations will be done through the init
script of the platform.
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/intel/iwlwifi/Kconfig | 10 --
From: Ayala Beker
Gscan capabilities were updated with new capabilities supported
by the device. Update GSCAN capabilities TLV.
Signed-off-by: Ayala Beker
Signed-off-by: Emmanuel Grumbach
---
From: Aviya Erenfeld
LQM stands for Link Quality Measurement. The firmware
will collect a defined set of statitics (see the
notification for details) that allow to know how busy
the medium is. The driver issues a request to the firmware
that includes the duration of the
iwlwifi / iwlmvm didn't destroy their mutexes. Fix that.
Signed-off-by: Emmanuel Grumbach
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/intel/iwlwifi/mvm/ops.c| 3 +++
drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 1
From: Chaya Rachel Ivgi
Use RX_HANDLER_ASYNC_UNLOCKED instead of unlock and re-lock
the mutex independently.
Signed-off-by: Chaya Rachel Ivgi
Signed-off-by: Emmanuel Grumbach
---
From: Aviya Erenfeld
Add debugfs entry named lqm_send_cmd for kicking a
measurement. This hook takes the duration and the timeout
as parameter.
Signed-off-by: Aviya Erenfeld
Signed-off-by: Emmanuel Grumbach
---
From: Sara Sharon
TX CMD API has changed to support offload assist.
Currently we do not enable checksum yet, but must set the
padding indication, to avoid FW errors.
Set other amsdu flag as well.
The rest of the flags will be configured only if HW csum
is enabled and will
This allows to disable uapsd for BSS only, or P2P client
separately. Remove the now unneeded
IWL_MVM_P2P_UAPSD_STANDALONE constant.
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 10 ++
From: Johannes Berg
"is_data_qos == true" is equivalent to "tid < IWL_MAX_TID_COUNT"
since tid is only assigned (and range-checked) in that case.
This removes a (harmless) smatch warning that occurs because it
can't seem to follow the above logic from the code.
Bjorn pointed out that printing an error value as an
hexadecimal isn't very convenient. Change that.
Reported-by: Bjorn Helgaas
Signed-off-by: Emmanuel Grumbach
---
drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 2 +-
1 file changed, 1
From: Sara Sharon
When entering suspend the driver calls iwl_disable_interrupts() and
then iwl_pcie_disable_ict().
On resume the driver calls only iwl_pcie_reset_ict() without calling
explicitly to iwl_enable_interrupts().
This mostly works since iwl_pcie_reset_ict is
From: Matti Gottlieb
Currently the driver has 2 buffers for paging:
1. paging db - this contains all of the pages that were in the FW
image, that the driver stores for the FW. This is allocated for each
block separately (not contiguous).
2. download buffer - we need to
From: Matti Gottlieb
Paging contains 3 sections in the fw. The first for the paging separator,
The second for the CSS block, the third with the paging data.
Currently if the driver finds the paging separator, and there is only
section left (CSS), once reading the CSS
From: Sara Sharon
Currently when stop flow is performed, there might be transport TX RTPM
references that are not freed in case we unmap a queue that still has
packets not reclaimed. Fix that.
Signed-off-by: Sara Sharon
Signed-off-by: Emmanuel
On Wed, 2016-03-30 at 21:55 +0800, Herbert Xu wrote:
> Well to start with you should assess whether you really want to
> hash multiple objects with the same key. In particular, can an
> adversary generate a large number of such objects?
No, the only reason this happens is local - if you take
On Wed, Mar 30, 2016 at 11:14:12AM +0200, Johannes Berg wrote:
> On Tue, 2016-03-29 at 09:16 -0700, Ben Greear wrote:
> > Looks like rhashtable has too much policy in it to properly deal with
> > cases where there are too many hash collisions, so I am going to work
> > on reverting it's use in
From: Xinming Hu
On some arm-based platforms, we need to configure platform specific
parameters by device tree node and also define our node as a child
node of parent SDIO host controller.
This patch parses these parameters from device tree. It includes
calibration data
From: Xinming Hu
Add device tree binding documentation for MARVELL's sd8xxx
(sd8897 and sd8997) wlan chip.
Signed-off-by: Xinming Hu
Signed-off-by: Amitkumar Karwar
---
Listing changelist for both 1/2 and 2/2 patches
v3: Don't update
From: Matti Gottlieb
Currently paging download buffer is freed during the
the unloading of the opmode which happens when the driver
is unloaded.
This causes a memory leak since the paging download
buffer is allocated every time we enable the
interface, so the download
IWL_INFO is not an error but still printed by default.
"can't access the RSA semaphore it is write protected" seems
worrisome but it is not really a problem.
CC: [4.1+]
Signed-off-by: Emmanuel Grumbach
---
Hi Kalle,
This is a pull request for 4.6 that includes 2 trivial fixes.
Please let me know if you have issues.
Thanks!
The following changes since commit 1200b6809dfd9d73bc4c7db76d288c35fa4b2ebe:
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
(2016-03-19 10:05:34 -0700)
Add support for using with both wl12xx and wl18xx.
- all wilink family needs special init command for entering wspi mode.
extra clock cycles should be sent after the spi init command while the
cs pin is high.
- switch to controling the cs pin from the spi driver for achieveing the
above.
-
On Wed, Mar 30, 2016 at 3:58 PM, Eyal Reizer wrote:
>
> From: Eyal
Are you trying to hide or something? :)
>
> Add support for using with both wl12xx and wl18xx.
>
> - all wilink family needs special init command for entering wspi mode.
>
From: Eyal
Add support for using with both wl12xx and wl18xx.
- all wilink family needs special init command for entering wspi mode.
extra clock cycles should be sent after the spi init command while the
cs pin is high.
- switch to controling the cs pin from
Hi Kalle,
> From: Kalle Valo [mailto:kv...@codeaurora.org]
> Sent: Wednesday, March 30, 2016 6:09 PM
> To: Amitkumar Karwar
> Cc: linux-wireless@vger.kernel.org; Cathy Luo; Nishant Sarmukadam;
> devicet...@vger.kernel.org; Wei-Ning Huang; Xinming Hu
> Subject: Re: [PATCH v5 2/4] mwifiex: add
Amitkumar Karwar writes:
> From: Xinming Hu
>
> On some arm-based platforms, we need to configure platform specific
> parameters by device tree node and also define our node as a child
> node of parent SDIO host controller.
> This patch parses these
Arnd Bergmann writes:
> While fixing another bug, I noticed that bcma manually sets up
> a dma_mask pointer for its child devices. We have a generic
> helper for that now, which should be able to cope better with
> any variations that might be needed to deal with cache coherency,
Hi,
now that the merge window is closed wireless-drivers-next is open for
new patches going to 4.7.
wireless-drivers remains open for important fixes going to 4.6.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to
Arend Van Spriel writes:
>> But please do remind about this, I seldomly check the "Awaiting
>> Upstream" queue so sometimes it might take way too long before I apply
>> the patch.
>
> So this is another way of saying the author should keep an eye on his
> patches
Lior David writes:
>>> + const char *ifname = alt_ifname ? "wigig%d" : "wlan%d";
>>>
>>> wdev = wil_cfg80211_init(dev);
>>> if (IS_ERR(wdev)) {
>>> @@ -160,7 +166,7 @@ void *wil_if_alloc(struct device *dev)
>>> ch =
On Wed, Mar 30, 2016 at 8:00 PM, Kalle Valo wrote:
> Wei-Ning Huang writes:
>
>> Kalle, can you help amend the message if this patch is accepted?
>
> Sure, I'll fix the typo in the commit log.
>
> But please try to avoid top posting, it makes it more
Wei-Ning Huang writes:
> Kalle, can you help amend the message if this patch is accepted?
Sure, I'll fix the typo in the commit log.
But please try to avoid top posting, it makes it more difficult to
follow the threads.
--
Kalle Valo
--
To unsubscribe from this list: send
Joe Perches writes:
> Using the normal kernel logging mechanisms makes this code
> a bit more like other wireless drivers.
Personally I don't see the point but I don't have any strong opinions. A
bigger problem is that TI drivers are not really in active development
and that's
On Wed, Mar 30, 2016 at 12:38 PM, Wei-Ning Huang wrote:
> ah.. thanks.
>
> Kalle, can you help amend the message if this patch is accepted?
> Thanks a lot.
>
http://its-not-its.info/
- Sedat -
> Wei-Ning
>
> On Wed, Mar 30, 2016 at 6:26 PM, Sedat Dilek
ah.. thanks.
Kalle, can you help amend the message if this patch is accepted?
Thanks a lot.
Wei-Ning
On Wed, Mar 30, 2016 at 6:26 PM, Sedat Dilek wrote:
> On Wed, Mar 30, 2016 at 12:14 PM, Wei-Ning Huang wrote:
>> In mwifiex_enable_hs, we need to
On Wed, Mar 30, 2016 at 12:14 PM, Wei-Ning Huang wrote:
> In mwifiex_enable_hs, we need to check if
> priv->wdev.wiphy->wowlan_config is NULL before accessing it's member.
it's... its member (not it's) :-).
- Sedat -
> This sometimes cause kernel panic when
In mwifiex_enable_hs, we need to check if
priv->wdev.wiphy->wowlan_config is NULL before accessing it's member.
This sometimes cause kernel panic when suspend/resume.
Signed-off-by: Wei-Ning Huang
---
drivers/net/wireless/marvell/mwifiex/sta_ioctl.c | 3 ++-
1 file
Sorry, please ignore this one. I forgot to strip the CHROMIUM: tag.
Wei-Ning
On Wed, Mar 30, 2016 at 6:08 PM, Wei-Ning Huang wrote:
> In mwifiex_enable_hs, we need to check if
> priv->wdev.wiphy->wowlan_config is NULL before accessing it's member.
> This sometimes cause
In mwifiex_enable_hs, we need to check if
priv->wdev.wiphy->wowlan_config is NULL before accessing it's member.
This sometimes cause kernel panic when suspend/resume.
Signed-off-by: Wei-Ning Huang
---
drivers/net/wireless/marvell/mwifiex/sta_ioctl.c | 3 ++-
1 file
On 30 March 2016 at 02:57, Dave Taht wrote:
> As a side note of wifi ideas complementary to codel, please see:
>
> http://blog.cerowrt.org/post/selective_unprotect/
>
> On Tue, Mar 29, 2016 at 12:49 AM, Michal Kazior
> wrote:
[...]
>> On the other
On 29 March 2016 at 17:54, Ben Greear wrote:
> On 03/29/2016 12:49 AM, Michal Kazior wrote:
>
>>> if you are getting a pure codel result of 160ms, that means the
>>> implementation is broken. But I think (after having read your
>>> description twice), the baseline result
On Tue, 2016-03-29 at 09:16 -0700, Ben Greear wrote:
> Looks like rhashtable has too much policy in it to properly deal with
> cases where there are too many hash collisions, so I am going to work
> on reverting it's use in mac80211.
I'm not really all that happy with that approach - can't we fix
Dear all,
I'm looking for information about the compliancy of the rt2800usb and the
ETSI EN 300 328 (V1.8.1) regulation.
I didn't find any specific flag in the driver to enable to be compliant to
this regulation, so I'm wondering if there is something to be enabled in
the driver?
Would someone
86 matches
Mail list logo