Re: [PATCH 3/3] ath10k: fix unconditional num_mpdus_ready subtraction

On 2016-04-01 00:22, Ben Greear wrote: On 03/30/2016 08:42 AM, Rajkumar Manoharan wrote: Decrement num_mpdus_ready only when rx amsdu is processed successfully. Not doing so, will result in leak and impact stabilty under low memory cases. Should this patch be rebased on top of the "ath10k:

Re: [PATCH 2/3] ath10k: remove unnecessary warning for probe response drops

On 2016-03-31 22:27, Ben Greear wrote: On 03/30/2016 08:42 AM, Rajkumar Manoharan wrote: qca99x0 and qca4019 solutions limit probe responses transmissions. Logging warning message for each probe response drop is flooding kernel log unnecessary with " failed to increase tx mgmt pending count:

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

On Fri, 1 Apr 2016 00:13:46 +0100 Chris Bainbridge wrote: > Should also fix https://bugzilla.kernel.org/show_bug.cgi?id=111781 ? > Given that this is a serious bug that can corrupt filesystems it would > be good to see the fix in stable too. Wow, this is horrible.

Re: [PATCH 10/10] mac80211: enable collecting station statistics per-CPU

Hi Johannes, [auto build test WARNING on v4.6-rc1] [also build test WARNING on next-20160331] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Emmanuel-Grumbach/mac80211-allow-passing

Re: Question on rhashtable in worst-case scenario.

On Thu, Mar 31, 2016 at 05:29:59PM +0200, Johannes Berg wrote: > > Does removing this completely disable the "-EEXIST" error? I can't say > I fully understand the elasticity stuff in __rhashtable_insert_fast(). What EEXIST error are you talking about? The only one that can be returned on

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

On Tue, Mar 29, 2016 at 07:41:30PM +0200, Lukas Wunner wrote: > Broadcom 4331 wireless cards built into Apple Macs unleash an IRQ storm > on boot until they are reset, causing spurious interrupts if the IRQ is > shared. Apparently the EFI bootloader enables the device and does not > disable it

[PATCH] ath10k: Clean up peer when sta goes away.

From: Ben Greear If WMI and/or firmware has issues removing the peer object, then we still need to clean up the peer object in the driver. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/mac.c | 10 -- 1 file changed, 8

Re: Bonjour mDNS broacast can be lost during BT-WLAN coexistence schemes?

On 30 March 2016 at 18:33, sandeep suresh wrote: > Hello Adrian, > Thanks for the response. Regarding your comment, "I don't think you can get > interrupts based on that, but you can poll the gpio pin yourself " > In any MCU, we should be able generate an interrupt on

Re: Ath10k seems to be using stale mac80211 txq references.

On 03/31/2016 02:30 PM, Ben Greear wrote: hacked 4.4.6 (with most of linux.ath ath10k patches backported), hacked 10.4.3 firmware. I enabled kasan to help track down various bugs. This one has me a bit perplexed. It seems ath10k is referencing some logic in mac80211 that has already been

Ath10k seems to be using stale mac80211 txq references.

hacked 4.4.6 (with most of linux.ath ath10k patches backported), hacked 10.4.3 firmware. I enabled kasan to help track down various bugs. This one has me a bit perplexed. It seems ath10k is referencing some logic in mac80211 that has already been deleted. Possibly this is because

[PATCH 08/10] rtl8xxxu: Identify 8192eu rev A/B parts correctly

From: Jes Sorensen 8192eu A/B cut parts were incorrectly identified as 8192cu devices. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 06/10] rtl8xxxu: Update some register definitions

From: Jes Sorensen Improve descriptive names of some registers and add some additional registers only found on nextgen chips. Signed-off-by: Jes Sorensen --- .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_regs.h | 31 +- 1

[PATCH 03/10] rtl8xxxu: Correct txdesc40 gid definition

From: Jes Sorensen txdesc40 dword2 gid is a 6 bit field, not a single bit Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 02/10] rtl8xxxu: Rename TX descriptor bits to map them to 32/40 byte descriptors

From: Jes Sorensen With the size based naming of TX descriptors. Change the bit definition namings to indicate which descriptor format they match, rather than having a device name in the bit name. Signed-off-by: Jes Sorensen ---

[PATCH 04/10] rtl8xxxu: TXDESC_SHORT_GI is txdesc32 only

From: Jes Sorensen This is no short GI bit in the txdesc40 format. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 2 +- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 2 +- 2 files changed, 2

[PATCH 05/10] rtl8xxxu: 8192eu uses txdesc40

From: Jes Sorensen 8192eu uses the new TX descriptor format Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 09/10] rtl8xxxu: Use correct H2C calls for 8192eu

From: Jes Sorensen The 8192eu uses the same H2C API as the 8723bu. Call the correct functions for update_rate_mask() and report_connect(). Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 ++-- 1 file

[PATCH 00/10] rtl8xxxu updates

From: Jes Sorensen Hi, This is a small set of changes to the rtl8xxxu driver which cleans up the naming of the TX data descriptors, and also prepares for further for adding rtl8192eu support. Cheers, Jes Jes Sorensen (10): rtl8xxxu: Change name of struct tx_desc to

[PATCH 07/10] rtl8xxxu: Use enums for chip version numbers

From: Jes Sorensen With support for more chips being added, use an enum to specify the chip version. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 84

[PATCH 10/10] rtl8xxxu: Do not set LDOA15 / LDOV12 on 8192eu

From: Jes Sorensen Per the vendor driver, it looks like the 8192eu doesn't have LDOA15 / LDOV12 registers. Signed-off-by: Jes Sorensen --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 01/10] rtl8xxxu: Change name of struct tx_desc to be more decriptive

From: Jes Sorensen There are two major types of TX descriptor formats for the RTL parts, the old 32 byte descriptor, and the newer 40 byte descriptor used by the 8723bu, 8192eu, and 88xx series. Signed-off-by: Jes Sorensen ---

[PATCH 3/3] ath10k: Add BUG_ON if we over-write peer-map pointer.

From: Ben Greear Not sure this can happen, but seems like a reasonable sanity check. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/txrx.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 1/3] ath10k: Ensure txrx-compl-task is stopped when cleaning htt-tx.

From: Ben Greear Otherwise, the txrx-compl-task may access some bad memory? Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/htt_tx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c

[PATCH 2/3] ath10k: Ensure peer_map references are cleaned up.

From: Ben Greear While debugging OS crashes due to firmware crashes, I enabled kasan, and it noticed that peer objects were being used-after-freed. Looks like there are two places we could be leaving stale references in the peer-map, so clean that up. Signed-off-by:

Re: [PATCH 0/7] rtl8xxxu: Improve handling of new TX descriptor format

jes.soren...@redhat.com writes: > From: Jes Sorensen > > Hi, > > Given the 8723bu set of patches made it into the tree, here is a much > smaller set which improves the handling of the gen2 40 byte TX > descriptor format. Kalle, Please ignore this set - I will send out

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

On Tue, 29 Mar 2016 19:41:30 +0200 Lukas Wunner wrote: > +static void quirk_apple_b43_reset(struct pci_dev *dev) > +{ > + void __iomem *mmio; > + > + if (!dmi_match(DMI_BOARD_VENDOR, "Apple Inc.") || !dev->bus->self || > + pci_pcie_type(dev->bus->self) !=

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

On 29 March 2016 at 20:20, Lukas Wunner wrote: > Broadcom 4331 wireless cards built into Apple Macs unleash an IRQ storm > on boot until they are reset, causing spurious interrupts if the IRQ is > shared. Apparently the EFI bootloader enables the device and does not > disable it

Re: [PATCH 3/3] ath10k: fix unconditional num_mpdus_ready subtraction

On 03/30/2016 08:42 AM, Rajkumar Manoharan wrote: Decrement num_mpdus_ready only when rx amsdu is processed successfully. Not doing so, will result in leak and impact stabilty under low memory cases. Should this patch be rebased on top of the "ath10k: process htt rx indication as batch mode"

Amministratore di sistema

-- La cassetta postale ha superato il limite di archiviazione, che è 20 GB come impostato dall'amministratore, si sta attualmente eseguendo il 20,9 GB, si potrebbe non essere in grado di inviare o ricevere nuovi messaggi fino a quando è convalidare nuovamente la cassetta postale. Per

[PATCH 05/10] mac80211: remove rx_stats.last_rx update after sta alloc

From: Johannes Berg There's no need to update rx_stats.last_rx after allocating a station since it's already updated during allocation. Signed-off-by: Johannes Berg --- net/mac80211/ibss.c | 4 net/mac80211/ocb.c | 2 -- 2 files changed,

[PATCH 08/10] mac80211: fix RX u64 stats consistency on 32-bit platforms

From: Johannes Berg On 32-bit platforms, the 64-bit counters we keep need to be protected to be consistently read. Use the u64_stats_sync mechanism to do that. In order to not end up with overly long lines, refactor the tidstats assignments a bit. Signed-off-by:

[PATCH 03/10] mac80211: move semicolon out of CALL_RXH macro

From: Johannes Berg Move the semicolon, people typically assume that and once line already put a semicolon behind the "call". Signed-off-by: Johannes Berg --- net/mac80211/rx.c | 34 +- 1 file changed, 17

[PATCH 01/10] mac80211: allow passing transmitter station on RX

From: Johannes Berg Sometimes drivers already looked up, or know out-of-band from their device, which station transmitted a given RX frame. Allow them to pass the station pointer to mac80211 to save the extra lookup. Signed-off-by: Johannes Berg

[PATCH 04/10] mac80211: move averaged values out of rx_stats

From: Johannes Berg Move the averaged values out of rx_stats and into rx_stats_avg, to cleanly split them out. The averaged ones cannot be supported for parallel RX in a per-CPU fashion, while the other values can be collected per CPU and then combined/selected when

[PATCH 06/10] mac80211: add separate last_ack variable

From: Johannes Berg Instead of touching the rx_stats.last_rx from the status path, introduce and use a status_stats.last_ack variable. This will make rx_stats.last_rx indicate when the last frame was received, making it available for real "last_rx" and statistics

[PATCH 07/10] mac80211: fix last RX rate data consistency

From: Johannes Berg When storing the last_rate_* values in the RX code, there's nothing to guarantee consistency, so a concurrent reader could see, e.g. last_rate_idx on the new value, but last_rate_flag still on the old, getting completely bogus values in the end. To

[PATCH 09/10] mac80211: add fast-rx path

From: Johannes Berg The regular RX path has a lot of code, but with a few assumptions on the hardware it's possible to reduce the amount of code significantly. Currently the assumptions on the driver are the following: * hardware/driver reordering buffer (if supporting

[PATCH 10/10] mac80211: enable collecting station statistics per-CPU

From: Johannes Berg If the driver advertises the new HW flag USE_RSS, make the station statistics on the fast-rx path per-CPU. This will enable calling the RX in parallel, only hitting locking or shared cachelines when the fast-RX path isn't available. Signed-off-by:

[PATCH 02/10] mac80211: count MSDUs in A-MSDU properly

From: Johannes Berg For the RX MSDU statistics, we need to count the number of MSDUs created and accepted from an A-MSDU. Right now, all frames in any A-MSDUs were completely ignored. Fix this by moving the RX MSDU statistics accounting into the deliver function.

Re: [PATCH 2/3] ath10k: remove unnecessary warning for probe response drops

On 03/30/2016 08:42 AM, Rajkumar Manoharan wrote: qca99x0 and qca4019 solutions limit probe responses transmissions. Logging warning message for each probe response drop is flooding kernel log unnecessary with " failed to increase tx mgmt pending count: -16, dropping". Hence reducing log level

[PATCH] ath9k: interpret requested txpower in EIRP domain

Tx power limitations at upper layers are interpreted in the EIRP domain. When the user requests a given maximum txpower, e.g. with: 'iw phy0 set txpower fixed 1500', he expects the EIRP to be at or below 15dBm. In ath9k_hw_apply_txpower(), the interpretation is different: the antenna-gain is

Re: Question on rhashtable in worst-case scenario.

On Thu, 2016-03-31 at 15:50 +0800, Herbert Xu wrote: > On Thu, Mar 31, 2016 at 09:46:45AM +0200, Johannes Berg wrote: > > > > > > In this case, I think perhaps you can just patch your local system > > with > > the many interfaces connecting to the same AP to add the parameter > > Herbert

[PATCH] mac80211: properly deal with station hashtable insert errors

From: Johannes Berg The original hand-implemented hash-table in mac80211 couldn't result in insertion errors, and while converting to rhashtable I evidently forgot to check the errors. This surfaced now only because Ben is adding many identical keys and that resulted in

Re: Question on rhashtable in worst-case scenario.

On Thu, 2016-03-31 at 08:13 -0700, Ben Greear wrote: >  > I see insertion failure, and then later, if of course fails to delete > as well since it was never inserted to begin with.  There is no good > way to deal with insertion error, so just need to fix the hashtable. Oh, that's an oversight in

Re: Question on rhashtable in worst-case scenario.

On 03/31/2016 12:46 AM, Johannes Berg wrote: On Wed, 2016-03-30 at 09:52 -0700, Ben Greear wrote: If someone can fix rhashtable, then great. I read some earlier comments [1] back when someone else reported similar problems, and the comments seemed to indicate that rhashtable was broken in

To Your Attention

To Your Attention, On behalf of the board and management of International Monetary Committees it was resolved by the federal executive council and agreed that your Inheritance/Contract Fund valued at $10.5M would be released to you via DIPLOMATIC CHANNEL immediately your attention is received

[PATCH] ath10k: remove MSI range support

MSI-X is never well-tested, might contain bugs and generally isn't really all that useful to maintain. Also ath10k is mainly used with shared/singly-MSI interrupt systems. Hence removing MSI range support. This change will be useful for further cleanup in copy engine lock and to add NAPI support.

RE: [PATCH] mwifiex: fix Tx timeout issue during suspend test

Hi Kalle, > From: Amitkumar Karwar [mailto:akar...@marvell.com] > Sent: Wednesday, March 16, 2016 8:16 PM > To: linux-wireless@vger.kernel.org > Cc: Nishant Sarmukadam; Amitkumar Karwar > Subject: [PATCH] mwifiex: fix Tx timeout issue during suspend test > > Call netif_carrier_off/on while

[PATCHv2 0/2] mac80211: implement fq_codel

Hi, I've cleaned up and removed the txop-queue-limiting and scheduling from the patch (compared to my last RFC). It's still to early for the scheduling thing to go prime time. The fair queuing on the other hand does seem to work. In good RF conditions it seems to improve things (e.g. multiple

[PATCHv2 1/2] mac80211: implement fair queuing per txq

Qdiscs assume all packets regardless of destination address are treated equally by underlying an device link. This isn't true for wireless where each node is a link in it's own right with different and varying signal quality over time. Existing wireless behavior stuffs device tx queues with no

[PATCHv2 2/2] mac80211: expose some txq/fq internals and knobs via debugfs

Makes it easier to debug, test and experiment. Signed-off-by: Michal Kazior --- Notes: v2: * add moduleparam.h to tx.c (fixes broken compilation with backports) net/mac80211/debugfs.c| 86 +++

IPv6: routing/forwarding/masking link-local addresses

Hi, The most commonly used framing/addressing in 802.11 is 3addr. This is how most Access Points work and Clients follow suit. However it is impossible to put a 3addr Client interface into a bridge because it's not possible to properly distinguish RA/TA/DA/SA addresses. There is 4addr framing

Re: [PATCH] brcmfmac: Don't increase 8021x_cnt for dropped packets

2016-03-30 23:04 GMT+02:00 : > From: Per Forlin > > The pend_8021x_cnt gets into a state where it's not being decreased. > When the brcmf_netdev_wait_pend8021x is called it will timeout > because there are no pending packets to be consumed. There is no

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

On Thu, Mar 31, 2016 at 11:07 AM, Joe Perches wrote: > On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote: >> Joe Perches writes: >> > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: >> > > Joe Perches writes: >> > > > >> > > > Using

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote: > Joe Perches writes: > > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: > > > Joe Perches writes: > > > > > > > > Using the normal kernel logging mechanisms makes this code > > > > a bit more like

Re: Question on rhashtable in worst-case scenario.

On Thu, Mar 31, 2016 at 09:46:45AM +0200, Johannes Berg wrote: > > In this case, I think perhaps you can just patch your local system with > the many interfaces connecting to the same AP to add the parameter > Herbert suggested (.insecure_elasticity = true in sta_rht_params). This > is, after all,

Re: Question on rhashtable in worst-case scenario.

On Wed, 2016-03-30 at 09:52 -0700, Ben Greear wrote: > If someone can fix rhashtable, then great. > I read some earlier comments [1] back when someone else reported > similar problems, and the comments seemed to indicate that rhashtable > was broken in this manner on purpose to protect against

Re: [RFC] ath10k: implement dql for htt tx

On 30 March 2016 at 17:28, Ben Greear wrote: > On 03/30/2016 02:22 AM, Michal Kazior wrote: >> >> On 29 March 2016 at 17:54, Ben Greear wrote: >>> >>> On 03/29/2016 12:49 AM, Michal Kazior wrote: >>> > if you are getting a pure codel result