Re: [PATCH v2] brcmfmac: Don't increase 8021x_cnt for dropped packets

2016-04-07 1:57 GMT+02:00 Per Förlin : > 2016-04-06 23:50 GMT+02:00 Arend Van Spriel : >> >> >> On 6-4-2016 17:56, Per Förlin wrote: >>> Hi, >>> >>> Thanks for getting back to me, >>> >>> * Chip: chip 43340 rev 2 pmurev 20 >>> * I'm running

Re: [PATCH v2] brcmfmac: Don't increase 8021x_cnt for dropped packets

2016-04-06 23:50 GMT+02:00 Arend Van Spriel : > > > On 6-4-2016 17:56, Per Förlin wrote: >> Hi, >> >> Thanks for getting back to me, >> >> * Chip: chip 43340 rev 2 pmurev 20 >> * I'm running kernel 4.1 (backports) for the wireless parts >> * I have not to setup my

[PATCH 5/7] staging: wilc1000: change handle_set_operation_mode's return type to void

When handle_set_operation_mode is called in hostIFthread that is a kernel thread, it is not checked return type of this function. This patch changes return type to void and removes braces if statement due to have a single statement. Signed-off-by: Chaehyun Lim ---

[PATCH 7/7] staging: wilc1000: rename result in handle_set_operation_mode

This patch renames result to ret that is used to get return value from wilc_send_config_pkt. Some handle_*() functions are used as result, others are used as ret. It will be changed as ret in all handle_*() functions to match variable name. Signed-off-by: Chaehyun Lim ---

[PATCH 6/7] staging: wilc1000: change data type of result in handle_set_operation_mode

This patch changes data type of result variable from s32 to int. result is used to get return value from wilc_send_config_pkt that has return type of int. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 3/7] staging: wilc1000: change data type of result in handle_set_wfi_drv_handler

This patch changes data type of result variable from s32 to int. result is used to get return value from wilc_send_config_pkt that has return type of int. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 4/7] staging: wilc1000: rename result in handle_set_wfi_drv_handler

This patch renames result to ret that is used to get return value from wilc_send_config_pkt. Some handle_*() function are used as result, others are used as ret. It will be changed as ret in all handle_*() function to match variable name. Signed-off-by: Chaehyun Lim ---

[PATCH 1/7] staging: wilc1000: change return type of ret variable in handle_get_tx_pwr

This patch changes return type of ret variable from s32 to int. ret has return value from wilc_send_config_pkt that has return type of int. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 2/7] staging: wilc1000: change handle_set_wfi_drv_handler's return type to void

When handle_set_wfi_drv_handler is called in hostIFthread that is a kernel thread, it is not checked return type of this function. This patch changes return type to void and removes braces if statement due to have a single statement. Signed-off-by: Chaehyun Lim ---

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

On Wed, Apr 06, 2016 at 11:30:29PM +0200, Lukas Wunner wrote: > Matthew's grub patch puts the wireless card into D3hot, which does not > stop the interrupts. I have tested this. (It may stop the DMA, I cannot > verify that as it doesn't occur on my machine for lack of an access point.) Ah,

Re: [PATCH v2] brcmfmac: Don't increase 8021x_cnt for dropped packets

On 6-4-2016 17:56, Per Förlin wrote: > Hi, > > Thanks for getting back to me, > > * Chip: chip 43340 rev 2 pmurev 20 > * I'm running kernel 4.1 (backports) for the wireless parts > * I have not to setup my environment for the latest kernel yet. > It's on my todo list. > > Looking at the

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

Hi, On Wed, Apr 06, 2016 at 05:17:24PM +0200, Michael Büsch wrote: > On Wed, 6 Apr 2016 08:31:51 -0500 Bjorn Helgaas wrote: > > > Even for interrupts, it's only a 90% solution because we do still get > > a few interrupts before the quirk runs. There may not be enough to > >

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

[+cc Matt Fleming, linux-efi] Hi Bjorn, On Tue, Apr 05, 2016 at 02:40:15PM -0500, Bjorn Helgaas wrote: > On Tue, Mar 29, 2016 at 08:20:30PM +0200, Lukas Wunner wrote: > > Broadcom 4331 wireless cards built into Apple Macs unleash an IRQ storm > > on boot until they are reset, causing spurious

ietf proposed standards for dscp to 802.11e mappings

If anyone cares https://datatracker.ietf.org/doc/draft-szigeti-tsvwg-ieee-802-11/?include_text=1 these will be discussed on the tsvwg mailing list. https://www.ietf.org/mailman/listinfo/tsvwg There are several things in here I object to - no discussion of multicast, and arbitrarily

RE: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

On Wed, Apr 06, 2016 at 22:07:39, Kalle Valo wrote: > > > More than that, wl1251 family is not officially supported via the > > mainline Linux. > > I guess you mean not officially supported by TI? Because wl1251 driver > has been in mainline for ages and reportedly working. > Correct.

Re: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

"Machani, Yaniv" writes: > More than that, wl1251 family is not officially supported via the > mainline Linux. I guess you mean not officially supported by TI? Because wl1251 driver has been in mainline for ages and reportedly working. -- Kalle Valo -- To unsubscribe from this

Re: [v2] mwifiex: advertise low priority scan feature

> From: Amitkumar Karwar > > Low priority scan handling code which delays or aborts scan > operation based on Tx traffic is removed recently. The reason > is firmware already takes care of it in our new feature scan > channel gap. Hence we should advertise low priority scan

Re: brcmfmac: sdio: remove unused variable retry_limit

> From: Colin Ian King > > retry_limit has never been used during the life of this driver, so > we may as well remove it as it is redundant. > > Signed-off-by: Colin Ian King > Reviewed-by: Julian Calaby Thanks,

Re: [v6] rt2x00usb: Use usb anchor to manage URB

> With current driver, it is observed that a URB is not > completed while the USB disconnect is initiated. Due to > that, the URB completion handler is trying to access > the resource which was freed as a part of USB disconnect. > Managing the URBs with anchor will make sure that all > the URBs

Re: wl12xx: remove redundant null check on wl->scan.ssid

> From: Colin Ian King > > ssid is an array of u8, so it can never be null, so the null check on > wl->scan.ssid is redundant and can be removed. > > Signed-off-by: Colin Ian King Thanks, applied to wireless-drivers-next.git. Kalle Valo --

Re: rtlwifi: btcoexist: Convert BTC_PRINTK to btc__dbg

> Use a more common logging style. > > Miscellanea: > > o Add specific logging macros for ALGORITHM and INTERFACE types > o Output the messages at KERN_DEBUG > o Coalesce formats > o Align arguments > o Whitespace style adjustments for only these changes > > Signed-off-by: Joe Perches

Re: [1/9] rtlwifi: Fix Smatch warnings

> Smatch reports the following: > > CHECK drivers/net/wireless/realtek/rtlwifi/pci.c > drivers/net/wireless/realtek/rtlwifi/pci.c:366 rtl_pci_check_buddy_priv() > error: we previously assumed 'tpriv' could be null (see line 368) > drivers/net/wireless/realtek/rtlwifi/pci.c:1216

Re: [1/2] rtlwifi: rtl8723be: Add antenna select module parameter

> A number of new laptops have been delivered with only a single antenna. > In principle, this is OK; however, a problem arises when the on-board > EEPROM is programmed to use the other antenna connection. The option > of opening the computer and moving the connector is not always possible > as

Re: brcmfmac: uninitialized "ret" variable

> There is an error path where "ret" isn't initialized. > > Signed-off-by: Dan Carpenter Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to

Re: [PATCH] mwifiex: bridged packets cause wmm_tx_pending counter to go negative

Marty Faltesek writes: > When a packet is queued from the bridge, wmm_tx_pending is not > incremented, but when the packet is dequeued the counter is decremented. Signed-off-by line is missing, please resend. -- Kalle Valo -- To unsubscribe from this list: send the line

Re: [PATCH] mwifiex: fw download does not release sdio bus during failure

Marty Faltesek writes: > --- > drivers/net/wireless/marvell/mwifiex/sdio.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Signed-off-by line is missing, please resend. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless"

Re: [trivial] mwifiex: Spelling s/minmum/minimum/, s/bandwidth/bandwith/

> Signed-off-by: Geert Uytterhoeven Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] mwifiex: transmit packet stats incorrect.

Marty Faltesek writes: > tx_packets counter is incremented for aggregated packets, when it had > already been incremented for the aggregated packet's constituent > parts. Removing the extra count. Because Signed-off-by line is missing I can't take this. Please resend. --

Re: [PATCH] ath9k: fix rng high cpu load

miaoq...@codeaurora.org writes: > From: Miaoqing Pan > > If no valid ADC randomness output, ath9k rng will continuously > reading ADC, which will cause high CPU load. So increase the > delay to wait for ADC ready. > > Bugzilla:

Re: pull request: iwlwifi-next 2016-03-30

"Grumbach, Emmanuel" writes: > This is a pull request for 4.7. Lots of work here and more to come when > dependencies on mac80211 will be resolved. > Let me know if you have issues! > > Thanks. > > The following changes since commit

Re: [PATCHv2 1/2] mac80211: implement fair queuing per txq

On Wed, Apr 6, 2016 at 12:21 AM, Johannes Berg wrote: > [removing other lists since they spam me with moderation bounces] I have added your email address be accepted to the codel, make-wifi-fast lists. My apologies for the bounces. The people on those lists generally

Re: [Make-wifi-fast] [PATCHv2 1/2] mac80211: implement fair queuing per txq

> On 6 Apr, 2016, at 10:16, Michal Kazior wrote: > > When a driver asks mac80211 to dequeue given txq it implies a > destination station as well. This is important because 802.11 > aggregation can be performed only on groups of packets going to a > single station on a

Re: [PATCH v2] brcmfmac: Don't increase 8021x_cnt for dropped packets

Hi, Thanks for getting back to me, * Chip: chip 43340 rev 2 pmurev 20 * I'm running kernel 4.1 (backports) for the wireless parts * I have not to setup my environment for the latest kernel yet. It's on my todo list. Looking at the code you pointed out I realize my fix i misplaced. It's

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

On Wed, 6 Apr 2016 08:31:51 -0500 Bjorn Helgaas wrote: > Even for interrupts, it's only a 90% solution because we do still get > a few interrupts before the quirk runs. There may not be enough to > trigger the "IRQ nobody cared" check, If no driver requested the shared

[PATCH 6/8] ath10k: move htt_op_version to struct ath10k_fw_file

Preparation for testmode.c to use ath10k_core_fetch_board_data_api_n(). Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c | 12 ++-- drivers/net/wireless/ath/ath10k/core.h |1 + drivers/net/wireless/ath/ath10k/debug.c|2 +-

[PATCH 5/8] ath10k: move wmi_op_version to struct ath10k_fw_file

Preparation for testmode.c to use ath10k_core_fetch_board_data_api_n(). Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c | 20 ++-- drivers/net/wireless/ath/ath10k/core.h |5 ++--- drivers/net/wireless/ath/ath10k/debug.c

[PATCH 7/8] ath10k: switch testmode to use ath10k_core_fetch_firmware_api_n()

Now that all firmware-N.bin related are within struct ath10k_fw_file we can switch to use ath10k_core_fetch_firmware_api_n() and delete almost identical ath10k_tm_fetch_utf_firmware_api_2(). Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c |4

[PATCH 8/8] ath10k: remove enum ath10k_swap_code_seg_bin_type

It's not needed for anything so just get rid of it. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c |3 +-- drivers/net/wireless/ath/ath10k/swap.c | 22 ++ drivers/net/wireless/ath/ath10k/swap.h |9 + 3 files

[PATCH 3/8] ath10k: move fw_version inside struct ath10k_fw_file

Preparation for testmode.c to use ath10k_core_fetch_board_data_api_n(). Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c | 13 + drivers/net/wireless/ath/ath10k/core.h |3 ++- drivers/net/wireless/ath/ath10k/testmode.c | 12

[PATCH 2/8] ath10k: refactor firmware images to struct ath10k_fw_components

To make it easier to share ath10k_core_fetch_board_data_api_n() with testmode.c refactor all firmware components to struct ath10k_fw_components. This structure will hold firmware related files, for example firmware-N.bin and board-N.bin. For firmware-N.bin create a new struct ath10k_fw_file which

[PATCH 4/8] ath10k: move fw_features to struct ath10k_fw_file

Preparation for testmode.c to use ath10k_core_fetch_board_data_api_n(). Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c | 28 +++- drivers/net/wireless/ath/ath10k/core.h |5 ++---

[PATCH 1/8] ath10k: remove deprecated firmware API 1 support

This has ben deprecated years ago, I haven't heard anyone using it since and most likely it won't even work anymore. So just remove all of it. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/core.c | 73

[PATCH] cfg80211: Improve Connect/Associate command documentation

The roaming cases for the Connect command were not fully covered and neither Connect nor Associate command uses of the prev_bssid parameter were very clear. Add details to describe how the prev_bssid argument is supposed to be used and when the driver should use association or reassociation.

[PATCH 2/2] Check protocol number in nl80211 netlink socket release notification handler.

This patch corrects the problem where non-privileged user can create netlink socket with the same port_id as used by hostapd but different protocol number. Upon close() or process termination, a notification is sent to nl80211 subsystem which will destroy virtual wireless network interfaces

[PATCH 1/2] Do not send netlink socket release notification when socket is not bound

This patch corrects the problem where non-privileged user may create netlink socket with port_id equal to port_id used by hostapd to create virtual wireless network interfaces. Call to bind() will fail for such socket, but release notification sent on close() or process termination to nl80211

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

On Tue, Apr 05, 2016 at 09:49:45PM +0200, Michael Büsch wrote: > On Tue, 5 Apr 2016 14:40:15 -0500 > Bjorn Helgaas wrote: > > > [+cc Matthew] > > > > Hi Lukas, > > > > On Tue, Mar 29, 2016 at 08:20:30PM +0200, Lukas Wunner wrote: > > > Broadcom 4331 wireless cards built

Re: pull-request: mac80211-next 2016-04-06

On Wed, 2016-04-06 at 15:25 +0200, Johannes Berg wrote: > Hi Dave, > > For the 4.6 cycle, there's of course much more. The few things that > Err, -next, so that's 4.7. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to

pull-request: mac80211-next 2016-04-06

Hi Dave, For the 4.6 cycle, there's of course much more. The few things that stand out are in the tag message below. There's a pending patchset to add NAN (Neighbor Awareness Networking, a WFA protocol) API support, but the API isn't ready yet. I might have that later in time for 4.6. Let me

pull-request: mac80211 2016-04-06

Hi Dave, First set of fixes for 4.6. Nothing really stands out. Let me know if there's any problem. Thanks, johannes The following changes since commit 05cf8077e54b20dddb756eaa26f3aeb5c38dd3cf: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2016-04-01 20:03:33 -0500) are

Re: [PATCH] mac80211: fix "warning: ‘target_metric’ may be used uninitialized"

On Mon, 2016-04-04 at 14:15 -0400, Jeff Mahoney wrote: > This fixes: > > net/mac80211/mesh_hwmp.c:603:26: warning: ‘target_metric’ may be used > uninitialized in this function > > target_metric is only consumed when reply = true so no bug exists > here, > but gcc doesn't notice that.  

Re: [PATCH 2/2] cfg80211: Allow reassociation to be requested with internal SME

On Tue, 2016-03-29 at 13:53 +0300, Jouni Malinen wrote: > If the user space issues a NL80211_CMD_CONNECT with > NL80211_ATTR_PREV_BSSID when there is already a connection, allow > this > to proceed as a reassociation instead of rejecting the new connect > command with EALREADY. > > Signed-off-by:

RE: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

On Wed, Apr 06, 2016 at 15:12:43, Pali Rohár wrote: > > > > For other TI wilink chips there are -ap.bin firmware files > > > > (wl1271-fw-ap.bin and wl128x-fw-ap.bin) which support AP mode. > > > > But for > > > > wl1251 firmware file with guessed name "wl1251-fw-ap.bin" is > > > > missing. > >

Re: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

On Wednesday 06 April 2016 13:30:22 Machani, Yaniv wrote: > On Mon, Apr 04, 2016 at 15:39:44, Pali Rohár wrote: > > > In linux-firmware repository [1] is missing AP firmware for TI > > > wl1251 chip. There is only STA firmware wl1251-fw.bin which > > > supports managed and ad-hoc modes. > > > > >

RE: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

On Mon, Apr 04, 2016 at 15:39:44, Pali Rohár wrote: > > In linux-firmware repository [1] is missing AP firmware for TI > > wl1251 chip. There is only STA firmware wl1251-fw.bin which supports > > managed and ad-hoc modes. > > > > For other TI wilink chips there are -ap.bin firmware files > >

Re: [PATCH] PCI: Add Broadcom 4331 reset quirk to prevent IRQ storm

That patch appears to be the grub 1 equivalent to grub2 git://git.savannah.gnu.org/grub.git rev 9d34bb8 which puts the network device into D3 power state. I am running grub2 with that patch and it doesn't fix my irq 17 problem. Can we not fix this in grub2 via something like Lukas original

RE: [PATCHv3 RESEND 06/11] cfg80211: Provide an API to report NAN function termination

> -Original Message- > From: Malinen, Jouni [mailto:jo...@qca.qualcomm.com] > Sent: Wednesday, April 6, 2016 12:40 PM > To: Grumbach, Emmanuel > Cc: johan...@sipsolutions.net; linux-wireless@vger.kernel.org; > Otcheretianski, Andrei

RE: [PATCHv3 RESEND 01/11] cfg80211: add start / stop NAN commands

> -Original Message- > From: Malinen, Jouni [mailto:jo...@qca.qualcomm.com] > Sent: Wednesday, April 6, 2016 12:34 PM > To: Grumbach, Emmanuel > Cc: johan...@sipsolutions.net; linux-wireless@vger.kernel.org; > Otcheretianski, Andrei

Re: [PATCH] ath10k: Fix return value for btcoex and peer stats debugfs

Hello Joe, On Tue, Apr 05, 2016 at 10:28:56AM -0700, Joe Perches wrote: > On Tue, 2016-04-05 at 20:58 +0530, Mohammed Shafi Shajakhan wrote: > > From: Mohammed Shafi Shajakhan > > > > Return value is incorrect for btcoex and peer stats debugfs > > 'write' entries if

RE: [PATCHv3 RESEND 01/11] cfg80211: add start / stop NAN commands

> > On Tue, Mar 29, 2016 at 12:34:59PM +0300, Emmanuel Grumbach wrote: > > This allows user space to start/stop NAN interface. > > A NAN interface is like P2P device in a few aspects: it doesn't have a > > netdev associated to it. > > Add the new interface type and prevent operations that can't

Re: [PATCHv3 RESEND 01/11] cfg80211: add start / stop NAN commands

On Tue, Mar 29, 2016 at 12:34:59PM +0300, Emmanuel Grumbach wrote: > This allows user space to start/stop NAN interface. > A NAN interface is like P2P device in a few aspects: it > doesn't have a netdev associated to it. > Add the new interface type and prevent operations that > can't be executed

RE: [PATCHv3 RESEND 01/11] cfg80211: add start / stop NAN commands

> On Tue, Mar 29, 2016 at 12:34:59PM +0300, Emmanuel Grumbach wrote: > > Define several attributes that may be configured by user space when > > starting NAN functionality (master preference and dual band operation) > > > diff --git a/include/uapi/linux/nl80211.h > >

Re: [PATCHv3 RESEND 01/11] cfg80211: add start / stop NAN commands

> Why NL80211_ATTR_NAN_MASTER_PREF is mandatory? The spec suggests to > assume master preference value of 128 if not provided. Please see > quoted text from NAN 1.0 specification: > "A NAN Device which out-of-the-box will have a Master Preference > greater than or equal to 128 with the intention

Re: [PATCHv3 RESEND 06/11] cfg80211: Provide an API to report NAN function termination

On Tue, Mar 29, 2016 at 12:35:04PM +0300, Emmanuel Grumbach wrote: > Provide a function that reports NAN DE function termination. The function > may be terminated due to one of the following reasons: user request, > ttl expiration or failure. > diff --git a/include/uapi/linux/nl80211.h

Re: [PATCHv3 RESEND 05/11] cfg80211: provide a function to report a match for NAN

On Wed, 2016-04-06 at 09:38 +, Malinen, Jouni wrote: >  > > +void cfg80211_nan_match(struct wireless_dev *wdev, > > + struct cfg80211_nan_match_params *match, > > gfp_t gfp); > Looks like this function is common for publish, subscribe and follow > up. If so, can we please

Re: [PATCHv3 RESEND 05/11] cfg80211: provide a function to report a match for NAN

On Tue, Mar 29, 2016 at 12:35:03PM +0300, Emmanuel Grumbach wrote: > Provide a function the driver can call to report a match. > This will send the event to the user space. > diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h > +/** > + * struct cfg80211_nan_match_params - NAN match

Re: NETLINK_URELEASE non-bound socket problem (was: [PATCH] Fix local DoS in cfg80211 subsystem)

On Wed, 2016-04-06 at 11:20 +0300, Dmitrijs Ivanovs wrote: > Hi Johannes! > > I will prepare patch which does not send NETLINK_URELEASE for unbound > sockets as you suggest. But I think protocol check in nl80211 is > still needed because port_id is unique per-protocol. > Yes, good point. Can

Re: [PATCHv3 RESEND 01/11] cfg80211: add start / stop NAN commands

On Tue, Mar 29, 2016 at 12:34:59PM +0300, Emmanuel Grumbach wrote: > Define several attributes that may be configured by user space > when starting NAN functionality (master preference and dual > band operation) > diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h > @@

[PATCH] NETLINK_URELEASE non-bound socket problem

Currently, any non-privileged user can create netlink socket with port_id equal to port_id used by hostapd to create wireless network interfaces on-the-fly when more than one BSS is configured. When such socket is closed, nl80211 will receive socket release notification and such virtual interfaces

Re: [PATCHv3 RESEND 10/11] mac80211: Add API to report nan function match

On Tue, 2016-03-29 at 12:35 +0300, Emmanuel Grumbach wrote: >  > +void ieee80211_nan_func_match(struct ieee80211_vif *vif, > +   struct cfg80211_nan_match_params > *match, > +   gfp_t gfp) > +{ > + struct ieee80211_sub_if_data *sdata =

Re: iwlwifi monitor mode: No data frame captured on 5 Ghz

On Wed, Apr 6, 2016 at 12:39 AM, Reinoud Koornstra wrote: > On Tue, Apr 5, 2016 at 7:25 AM, Gucea Doru wrote: >> On Tue, Apr 5, 2016 at 1:00 PM, Grumbach, Emmanuel >> wrote: Hello, I am trying to

Re: [PATCHv3 RESEND 09/11] mac80211: Implement add_nan_func and rm_nan_func

On Tue, 2016-03-29 at 12:35 +0300, Emmanuel Grumbach wrote: > + * @rm_nan_func: Remove a nan function. The driver must call > + * ieee80211_nan_func_terminated() with > + * NL80211_NAN_FUNC_TERM_REASON_USER_REQUEST reason code upon > removal. bad indentation. Also here: nan -> NAN. > + /*

Re: [PATCHv3 RESEND 08/11] mac80211: implement nan_change_conf

On Tue, 2016-03-29 at 12:35 +0300, Emmanuel Grumbach wrote: >  >   * @start_nan: join an existing nan cluster, or create a new one. >   * @stop_nan: leave the nan cluster. > + * @nan_change_conf: change nan configuration. The data in > cfg80211_nan_conf > + * contains full new configuration and

Re: [PATCHv3 RESEND 07/11] cfg80211: add utility functions to clone and free nan_func

> +int cfg80211_clone_nan_func_members(struct cfg80211_nan_func *f1, > + const struct cfg80211_nan_func *f2) > +{ > + memcpy(f1, f2, sizeof(*f1)); That's pretty weird. And the only user of this (in a later patch) is first allocating the f1. I think this

Re: [PATCHv3 RESEND 06/11] cfg80211: Provide an API to report NAN function termination

On Tue, 2016-03-29 at 12:35 +0300, Emmanuel Grumbach wrote: >  > @@ -2246,6 +2248,7 @@ enum nl80211_attrs { >   NL80211_ATTR_NAN_FUNC, >   NL80211_ATTR_NAN_FUNC_INST_ID, >   NL80211_ATTR_NAN_MATCH, > + NL80211_ATTR_NAN_FUNC_TERM_REASON, You can add this as a nested function

Re: [PATCHv3 RESEND 05/11] cfg80211: provide a function to report a match for NAN

On Tue, 2016-03-29 at 12:35 +0300, Emmanuel Grumbach wrote: >  > +/** > + * enum nl80211_nan_match_attributes - NAN match attributes > + * @__NL80211_NAN_MATCH_INVALID: invalid > + * @NL80211_NAN_MATCH_FUNC_TYPE: nl80211_nan_function_type > (u8). This is > + * the type of the function which had

Re: [PATCHv3 RESEND 03/11] cfg80211: add add_nan_func / rm_nan_func

> + NL80211_ATTR_NAN_FUNC_INST_ID, I don't see why this has to be a top-level attribute. > +enum nl80211_nan_func_attributes { > + __NL80211_NAN_FUNC_INVALID, > + NL80211_NAN_FUNC_TYPE, You can easily move it into here, and  > + /* propagate the instance id and cookie to

Re: [PATCHv3 RESEND 04/11] cfg80211: allow the user space to change current NAN configuration

On Tue, 2016-03-29 at 12:35 +0300, Emmanuel Grumbach wrote: > Some NAN configuration paramaters parameters >  /** > + * enum cfg80211_nan_conf_changes - indicates changed fields in nan > configuration again, NAN please > + * > + * @CFG80211_NAN_CONF_CHANGED_PREF: master preference > + *

Re: [PATCHv3 RESEND 03/11] cfg80211: add add_nan_func / rm_nan_func

On Tue, 2016-03-29 at 12:35 +0300, Emmanuel Grumbach wrote: > + * @cookie: user defined cookie (will be returned with > notifications) Didn't we change it to not be user defined? > + * @NL80211_NAN_FUNC_TTL: number of DWs this function should stay > active. 0 is > + * equivalent to no TTL at

Re: [PATCHv3 RESEND 02/11] mac80211: add boilerplate code for start / stop NAN

On Tue, 2016-03-29 at 12:35 +0300, Emmanuel Grumbach wrote: > This codes doens't do much besides allowing to start and > stop the vif. Few typos? :) > + * @start_nan: join an existing nan cluster, or create a new one. > + * @stop_nan: leave the nan cluster. NAN johannes -- To unsubscribe from

Re: [PATCHv3 RESEND 01/11] cfg80211: add start / stop NAN commands

>  /** > + * struct cfg80211_nan_conf - nan configuration > + * > + * This struct defines nan configuration parameters I think you should consistently capitalize "NAN" in comments. > + * @start_nan: Start the NAN interface. > + * @stop_nan: Stop the NAN interface. johannes -- To unsubscribe

Re: [PATCH v2] brcmfmac: Don't increase 8021x_cnt for dropped packets

On 5-4-2016 22:01, per.for...@gmail.com wrote: > From: Per Forlin > > The pend_8021x_cnt gets into a state where it's not being decreased. > When the brcmf_netdev_wait_pend8021x is called it will timeout > because there are no pending packets to be consumed. There is no >

Re: NETLINK_URELEASE non-bound socket problem (was: [PATCH] Fix local DoS in cfg80211 subsystem)

Hi Johannes! I will prepare patch which does not send NETLINK_URELEASE for unbound sockets as you suggest. But I think protocol check in nl80211 is still needed because port_id is unique per-protocol. On Tue, Apr 5, 2016 at 12:56 PM, Johannes Berg wrote: > Hi

Re: [PATCH] mac80211: debugfs var for the default aggregation timeout.

On Tue, 2016-04-05 at 19:46 -0400, Avery Pennarun wrote: > This test was with backports-20150525 on ath9k.  (We have newer > versions in the queue, but they haven't rolled out to our customers > yet.  Anyway, earlier in this thread, I was able to trigger the race > condition on much newer

RE: [PATCH] wlcore: spi: add wl18xx support

Ping on this patch > -Original Message- > From: Eyal Reizer [mailto:eyalrei...@gmail.com] > Sent: Wednesday, March 30, 2016 4:07 PM > To: kv...@codeaurora.org; linux-wireless@vger.kernel.org; > net...@vger.kernel.org; linux-ker...@vger.kernel.org > Cc: Reizer, Eyal > Subject: [PATCH]

Re: [PATCH 4/7] wil6210: print debug message when transmitting while disconnected

On Tue, 2016-04-05 at 14:24 +0300, Maya Erez w > Network stack can try to transmit data while AP / STA is > disconnected. > Change this print-out to debug level as this should not be > handled as error. Should probably say something about adding ratelimited logging functions > diff --git

Re: [PATCHv2 1/2] mac80211: implement fair queuing per txq

[removing other lists since they spam me with moderation bounces] > The hope had been the original codel.h would have been reusable, > which is not the case at present. So what's the strategy for making it happen? Unless there is one, I don't see the point in making the code more complicated

Re: [PATCHv2 1/2] mac80211: implement fair queuing per txq

On Wed, 2016-04-06 at 07:35 +0200, Michal Kazior wrote: > I just wanted to follow the suggested/implied usage of codel code and > keep modifications to a minimum. I could very well just assimilate it > if you wish. I don't really feel all that strongly about it, but I also don't see the point.

Re: [PATCH 1/7] wil6210: add function name to wil log macros

On Tue, 2016-04-05 at 14:24 +0300, Maya Erez wrote: > Add __func__ to all wil log macros for easier debugging. I think this is unnecessary and merely bloats code size. For all the _dbg calls, dynamic debug can add function names if desired. If really desired, I suggest changing the logging

Re: [Make-wifi-fast] [PATCHv2 1/2] mac80211: implement fair queuing per txq

On 6 April 2016 at 08:03, Jonathan Morton wrote: > >> On 6 Apr, 2016, at 08:35, Michal Kazior wrote: >> >> Packets can be destined to different stations/txqs. At enqueue time I >> do a partial hash of a packet to get an "index" which I then use to

Re: [Make-wifi-fast] [PATCHv2 1/2] mac80211: implement fair queuing per txq

> On 6 Apr, 2016, at 08:35, Michal Kazior wrote: > > Packets can be destined to different stations/txqs. At enqueue time I > do a partial hash of a packet to get an "index" which I then use to > address a txq_flow from per-radio list (out of 4096 of them). You can > end