Re: [PATCH] [linux-next] rtlwifi: Fix typo in printk

2016-06-28 Thread Larry Finger
On 06/28/2016 10:37 PM, Masanari Iida wrote: This patch fix spelling typos found in drivers/net/wireless/realtek. Signed-off-by: Masanari Iida Acked--by: Larry Finger Thanks, Larry ---

Re: [PATCH 0/4] Mesh mpm fixes and enhancements

2016-06-28 Thread Julian Calaby
Hi Yaniv, On Tue, Jun 28, 2016 at 9:13 PM, Yaniv Machani wrote: > This patch set is addressing some issues found in the current 802.11s > implementation, > specifically when using hostap mpm. > It's aligning the beacon format and handling some corner cases. > > Maital Hahn (2):

Re: [PATCH] [linux-next] rtlwifi: Fix typo in printk

2016-06-28 Thread Julian Calaby
Hi All, On Wed, Jun 29, 2016 at 1:37 PM, Masanari Iida wrote: > This patch fix spelling typos found in drivers/net/wireless/realtek. > > Signed-off-by: Masanari Iida Looks right to me. Reviewed-by: Julian Calaby Thanks,

[PATCH] [linux-next] rtlwifi: Fix typo in printk

2016-06-28 Thread Masanari Iida
This patch fix spelling typos found in drivers/net/wireless/realtek. Signed-off-by: Masanari Iida --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c | 2 +- drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c | 2 +-

Re: [PATCH] mac80211: ensure info->control.vif is set for queued pkts.

2016-06-28 Thread Ben Greear
On 06/28/2016 01:03 PM, Johannes Berg wrote: On Tue, 2016-06-28 at 07:50 -0700, Ben Greear wrote: So, maybe a WARN_ON would be appropriate at the place frames are enqueued in the backlog queue? Since this patch did fix my problem, maybe that WARN_ON would show the path that allow frames with

Re: [PATCH v4] wlcore: spi: add wl18xx support

2016-06-28 Thread Rob Herring
On Sun, Jun 26, 2016 at 10:10:54AM +, Reizer, Eyal wrote: > Add support for using with both wl12xx and wl18xx. > > - all wilink family needs special init command for entering wspi mode. > extra clock cycles should be sent after the spi init command while the > cs pin is high. > - Use

Re: [PATCH] mac80211: ensure info->control.vif is set for queued pkts.

2016-06-28 Thread Johannes Berg
On Tue, 2016-06-28 at 07:50 -0700, Ben Greear wrote: > So, maybe a WARN_ON would be appropriate at the place frames are > enqueued in the backlog queue?  Since this patch did fix my problem, > maybe that WARN_ON would show the path that allow frames with bad > control.vif to be inserted? Yeah

Re: [PATCH] libertas_tf: Remove create_workqueue

2016-06-28 Thread Kalle Valo
Bhaktipriya Shridhar writes: > Ping! I'm lagging behind, the patch is still on my queue: https://patchwork.kernel.org/patch/9162447/ Please don't top most, it's annoying. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in

Re: [PATCH] libertas_tf: Remove create_workqueue

2016-06-28 Thread Bhaktipriya Shridhar
Ping! Thanks, Bhaktipriya On Sun, Jun 12, 2016 at 4:17 AM, Tejun Heo wrote: > On Wed, Jun 08, 2016 at 01:38:53AM +0530, Bhaktipriya Shridhar wrote: >> alloc_workqueue replaces deprecated create_workqueue(). >> >> A dedicated workqueue has been used since the workitem (viz >>

Re: [PATCH] mac80211: ensure info->control.vif is set for queued pkts.

2016-06-28 Thread Krishna Chaitanya
On Tue, Jun 28, 2016 at 8:20 PM, Ben Greear wrote: > On 06/28/2016 07:00 AM, Johannes Berg wrote: >> >> On Wed, 2016-06-15 at 11:24 -0700, gree...@candelatech.com wrote: >>> >>> From: Ben Greear >>> >>> When driving ath10k with a modified pktgen,

Re: [PATCH] mac80211: ensure info->control.vif is set for queued pkts.

2016-06-28 Thread Ben Greear
On 06/28/2016 07:00 AM, Johannes Berg wrote: On Wed, 2016-06-15 at 11:24 -0700, gree...@candelatech.com wrote: From: Ben Greear When driving ath10k with a modified pktgen, we see excessive amounts of these warnings: Jun 6 13:47:53 localhost kernel: WARNING: CPU: 1

RE: [PATCH 2/4] mac80211/cfg: mesh: fix healing time when a mesh peer is disconnecting

2016-06-28 Thread Machani, Yaniv
On Tue, Jun 28, 2016 at 15:27:47, Bob Copeland wrote: > linux- wirel...@vger.kernel.org; net...@vger.kernel.org; Hahn, Maital > Subject: Re: [PATCH 2/4] mac80211/cfg: mesh: fix healing time when a > mesh peer is disconnecting > > On Tue, Jun 28, 2016 at 02:13:05PM +0300, Yaniv Machani wrote: > >

Re: [PATCH] rtlwifi: Create _rtl_dbg_trace function to reduce RT_TRACE code size

2016-06-28 Thread Larry Finger
On 06/27/2016 10:55 PM, Joe Perches wrote: On Mon, 2016-06-27 at 19:53 -0500, Larry Finger wrote: On 06/25/2016 05:46 PM, Joe Perches wrote: This debugging macro can expand to a lot of code. Make it a function to reduce code size. (x86-64 defconfig w/ all rtlwifi drivers and allyesconfig) $

Re: [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template

2016-06-28 Thread Bob Copeland
On Tue, Jun 28, 2016 at 02:13:06PM +0300, Yaniv Machani wrote: > From: Meirav Kama > > There are several values in HT info elements of mesh beacon (built by the > mac80211) that are incorrect. Would be good to enumerate the problems here. > To fix them: > 1. mac80211 will check

Re: [PATCH] mac80211: ensure info->control.vif is set for queued pkts.

2016-06-28 Thread Johannes Berg
On Wed, 2016-06-15 at 11:24 -0700, gree...@candelatech.com wrote: > From: Ben Greear > > When driving ath10k with a modified pktgen, we see excessive amounts > of these warnings: > > Jun  6 13:47:53 localhost kernel: WARNING: CPU: 1 PID: 1186 at >

RE: [PATCH 4/4] mac80211: sta_info: max_peers reached falsely

2016-06-28 Thread Machani, Yaniv
On Tue, Jun 28, 2016 at 15:56:21, Bob Copeland wrote: > linux- wirel...@vger.kernel.org; net...@vger.kernel.org; Kama, Meirav > Subject: Re: [PATCH 4/4] mac80211: sta_info: max_peers reached falsely > > On Tue, Jun 28, 2016 at 02:13:07PM +0300, Yaniv Machani wrote: > > From: Meirav Kama

Re: [PATCH 4/4] mac80211: sta_info: max_peers reached falsely

2016-06-28 Thread Bob Copeland
On Tue, Jun 28, 2016 at 02:13:07PM +0300, Yaniv Machani wrote: > From: Meirav Kama > > Issue happened when receiving delete_sta command without > changing plink_state from ESTAB to HOLDING before. > When receiving delete_sta command for mesh interface > verify plink_state is not

Re: [PATCH 2/4] mac80211/cfg: mesh: fix healing time when a mesh peer is disconnecting

2016-06-28 Thread Bob Copeland
On Tue, Jun 28, 2016 at 02:13:05PM +0300, Yaniv Machani wrote: > From: Maital Hahn > > Once receiving a CLOSE action frame from the disconnecting peer, > flush all entries in the path table which has this peer as the > next hop. Please address the user-visible behavior in your

Re: [PATCH] mac80211: Use macro instead of number

2016-06-28 Thread Johannes Berg
On Wed, 2016-06-22 at 20:23 +0900, Masashi Honma wrote: > Use IEEE80211_MIN_ACTION_SIZE macro for robust management frame > check. > Applied. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [patch] mac80211: silence an uninitialize variable warning

2016-06-28 Thread Johannes Berg
On Mon, 2016-06-27 at 17:31 +0300, Dan Carpenter wrote: > We normally return an unitialized value, but no one checks it so it > doesn't matter.  Anyway, let's silence the static checker warning. > Applied. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in

[PATCH] mac80211: rx: frames received out of order

2016-06-28 Thread Yaniv Machani
From: Meirav Kama MP received data frames from another MP. Frames are forwarded from Rx to Tx to be transmitted to a third MP. Upon cloning the skb, the tx_info was zeroed, and the hw_queue wasn't set correctly, causing frames to be inserted to queue 0 (VOICE). If re-queue

[PATCH] mac80211: util: mesh is not connected properly after recovery

2016-06-28 Thread Yaniv Machani
From: Maital Hahn In the reconfigure process for mesh interface, moved the reconfiguration of the mesh peers to be done only after restarting the beacons, the same as it is done for AP. Signed-off-by: Maital Hahn Acked-by: Yaniv Machani ---

[PATCH 1/4] mac80211: mesh: flush stations before beacons are stopped

2016-06-28 Thread Yaniv Machani
From: Maital Hahn Some drivers (e.g. wl18xx) expect that the last stage in the de-initialization process will be stopping the beacons, similar to ap. Update ieee80211_stop_mesh() flow accordingly. Signed-off-by: Maital Hahn Acked-by: Yaniv Machani

[PATCH 0/4] Mesh mpm fixes and enhancements

2016-06-28 Thread Yaniv Machani
This patch set is addressing some issues found in the current 802.11s implementation, specifically when using hostap mpm. It's aligning the beacon format and handling some corner cases. Maital Hahn (2): mac80211: mesh: flush stations before beacons are stopped mac80211/cfg: mesh: fix

[PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template

2016-06-28 Thread Yaniv Machani
From: Meirav Kama There are several values in HT info elements of mesh beacon (built by the mac80211) that are incorrect. To fix them: 1. mac80211 will check configuration from cfg and will build accordingly. 2. changes made in mesh default values. Signed-off-by: Meirav Kama

[PATCH 4/4] mac80211: sta_info: max_peers reached falsely

2016-06-28 Thread Yaniv Machani
From: Meirav Kama Issue happened when receiving delete_sta command without changing plink_state from ESTAB to HOLDING before. When receiving delete_sta command for mesh interface verify plink_state is not ESTAB and if so, decrease plink count and update beacon. Signed-off-by:

[PATCH 2/4] mac80211/cfg: mesh: fix healing time when a mesh peer is disconnecting

2016-06-28 Thread Yaniv Machani
From: Maital Hahn Once receiving a CLOSE action frame from the disconnecting peer, flush all entries in the path table which has this peer as the next hop. In addition, upon receiving a packet, if next hop is not found, trigger PERQ immidiatly, instead of just putting it in the

Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support

2016-06-28 Thread Johannes Berg
On Thu, 2016-05-12 at 17:34 +0800, Wei-Ning Huang wrote: >  > Johannes, I feel like being able to set calibration data at runtime > is something common to all wireless drivers, so instead of using > vendor commands what do you think if I pass the calibration data name > instead of using those

Re: [PATCH] nl80211: improve nl80211_parse_mesh_config type checking

2016-06-28 Thread Johannes Berg
On Wed, 2016-06-15 at 22:29 +0200, Arnd Bergmann wrote: > When building a kernel with W=1, the nl80211.c file causes a number > of > warnings, all about the same problem: > > net/wireless/nl80211.c: In function 'nl80211_parse_mesh_config': > net/wireless/nl80211.c:5287:103: error: comparison is

Re: [PATCH 1/2] cfg80211: Add support to set tx power for a station associated

2016-06-28 Thread Johannes Berg
On Tue, 2016-06-14 at 23:14 +0530, Ashok Raj Nagarajan wrote: > This patch adds support to set transmit power setting type and > transmit power level attributes to NL80211_CMD_SET_STATION in order > to facilitate adjusting the transmit power level of a station > associated to the AP. Why would

Re: [PATCH] mac80211: Fix mesh estab_plinks counting in STA removal case

2016-06-28 Thread Johannes Berg
On Sun, 2016-06-19 at 23:51 +0300, Jouni Malinen wrote: > If a user space program (e.g., wpa_supplicant) deletes a STA entry > that > is currently in NL80211_PLINK_ESTAB state, the number of established > plinks counter was not decremented and this could result in rejecting > new plink

[PATCH] wlcore/wl18xx: mesh: added initial mesh support for wl8

2016-06-28 Thread Yaniv Machani
From: Maital Hahn 1. Added support for interface and role of mesh type. 2. Enabled enable/start of mesh-point role, and opening and closing a connection with a mesh peer. 3. Added multirole combination of mesh and ap under the same limits of dual ap mode. 4. Add support for

Re: [PATCH 2/2] ath10k: Fix sending NULL/ Qos NULL data frames for QCA99X0 and later

2016-06-28 Thread Michal Kazior
On 27 June 2016 at 16:36, Mohammed Shafi Shajakhan wrote: > Hi Michal, > > thanks for the review .. > > On Mon, Jun 27, 2016 at 11:27:27AM +0200, Michal Kazior wrote: >> On 23 June 2016 at 18:40, Mohammed Shafi Shajakhan >> wrote: >> > From: