[RFC (v7)] add basic register-field manipulation macros

Hi! This is what I came up with. Changes: - drop the explicit type marking (u32/u64) - depend on the type of the mask instead; - only allow compilation time constant masks; - barf at "type of register too small to ever match mask" on get; - rename PUT -> PREP. I did not put the new

Re: [PATCH] wlcore: mesh: add zone time sync support

On Mon, 2016-08-08 at 11:57 +0300, Guy Mishol wrote: > Add zone time sync support for mesh role. > This allows to configure the mesh peer > master of each zone for time synchronization. What is this? mac80211 already tries to maintain TSF sync with mesh peers if get/set TSF ops are supported by

Re: [PATCH 2/3] ath10k: Grab rcu_read_lock before the txqs spinlock.

On 08/18/2016 08:01 PM, Manoharan, Rajkumar wrote: diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 916119c..d96c06e 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -4307,8 +4307,8 @@ void

Re: [PATCH 2/3] ath10k: Grab rcu_read_lock before the txqs spinlock.

> diff --git a/drivers/net/wireless/ath/ath10k/mac.c > b/drivers/net/wireless/ath/ath10k/mac.c > index 916119c..d96c06e 100644 > --- a/drivers/net/wireless/ath/ath10k/mac.c > +++ b/drivers/net/wireless/ath/ath10k/mac.c > @@ -4307,8 +4307,8 @@ void ath10k_mac_tx_push_pending(struct ath10k *ar) >

Re: [RFC (v7)] add basic register-field manipulation macros

On Thu, Aug 18, 2016 at 10:11 AM, Jakub Kicinski wrote: > Hi! > > This is what I came up with. Changes: I can live with this, certainly. I'm not really sure how many drivers (or perhaps core code, for that matter) will actually start using it, but it at least

Re: [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

On 18-08-16 16:17, Javier Martinez Canillas wrote: > If request_irq() fails in mwifiex_sdio_probe_of(), only an error message > is printed but the actual error is not propagated to the caller function. Hmm. The caller function, ie. mwifiex_sdio_probe(), does not seem to care. The device may

Re: [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

Hello Arend, On 08/18/2016 03:49 PM, Arend van Spriel wrote: > > > On 18-08-16 21:29, Javier Martinez Canillas wrote: >> Hello Arend, >> >> Thanks a lot for your feedback. >> >> On 08/18/2016 03:14 PM, Arend van Spriel wrote: >>> On 18-08-16 16:17, Javier Martinez Canillas wrote: If

Re: [PATCH 0/2] wireless: Use complete() instead complete_all()

On Thu, Aug 18, 2016 at 03:12:04PM +0200, Daniel Wagner wrote: > This series ignores all complete_all() usages in the firmware loading > path. They will be hopefully address by Luis' sysdata patches [0]. > That leaves a couple of complete_all() calls. I had not considered this as a gain, but glad

[PATCH 1/3] ath10k: Ensure there are no stale ar->txqs entries.

From: Ben Greear I was seeing kernel crashes due to accessing freed memory while debugging a 9984 firmware that was crashing often. This patch fixes the crashes. I am not certain if there is a better way or not. Signed-off-by: Ben Greear ---

[PATCH 3/3] ath10k: Improve logging message.

From: Ben Greear Helps to know the sta pointer. Signed-off-by: Ben Greear --- drivers/net/wireless/ath/ath10k/mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c

[PATCH 2/3] ath10k: Grab rcu_read_lock before the txqs spinlock.

From: Ben Greear I was seeing some spin-lock hangs in this area of the code, and it seems more proper to do the rcu-read-lock outside of the spin lock. I am not sure how much this matters, however. Signed-off-by: Ben Greear ---

Re: [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

Hello Arend, Thanks a lot for your feedback. On 08/18/2016 03:14 PM, Arend van Spriel wrote: > On 18-08-16 16:17, Javier Martinez Canillas wrote: >> If request_irq() fails in mwifiex_sdio_probe_of(), only an error message >> is printed but the actual error is not propagated to the caller

Re: [PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

On 18-08-16 21:29, Javier Martinez Canillas wrote: > Hello Arend, > > Thanks a lot for your feedback. > > On 08/18/2016 03:14 PM, Arend van Spriel wrote: >> On 18-08-16 16:17, Javier Martinez Canillas wrote: >>> If request_irq() fails in mwifiex_sdio_probe_of(), only an error message >>> is

Re: [PATCH 1/3] mac80211: RX BA support for sta max_rx_aggregation_subframes

On Thu, 2016-08-18 at 10:36 +0300, Maxim Altshul wrote: >  > @@ -1735,6 +1735,9 @@ struct ieee80211_sta_rates { >   * @supp_rates: Bitmap of supported rates (per band) >   * @ht_cap: HT capabilities of this STA; restricted to our own > capabilities >   * @vht_cap: VHT capabilities of this STA;

Re: [PATCH 2/3] wlcore: Pass win_size taken from ieee80211_sta to FW

On Thu, 2016-08-18 at 10:36 +0300, Maxim Altshul wrote: > When starting a new BA session, we must pass the win_size to the FW. > > To do this we take max_rx_aggregation_subframes (BA RX win size) > which is stored in ieee80211_sta structure (e.g per link and not per > HW) I believe this is

[PATCH] net: wireless: rtl8xxxu: Make rtl8xxxu_ampdu_action less chatty

On my home network rtl8xxxu is spamming the log with IEEE80211_AMPDU_RX_START / IEEE80211_AMPDU_RX_STOP every few seconds turn these messages into debug messages. Signed-off-by: Hans de Goede --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 10 +- 1 file

[PATCH] mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

If request_irq() fails in mwifiex_sdio_probe_of(), only an error message is printed but the actual error is not propagated to the caller function. Signed-off-by: Javier Martinez Canillas --- drivers/net/wireless/marvell/mwifiex/sdio.c | 1 + 1 file changed, 1

[PATCH 2/2] ath10k: use complete() instead complete_all()

From: Daniel Wagner There is only one waiter for the completion, therefore there is no need to use complete_all(). Let's make that clear by using complete() instead of complete_all(). The usage pattern of the completion is: waiter context

[PATCH 0/2] wireless: Use complete() instead complete_all()

From: Daniel Wagner Hi, Using complete_all() is not wrong per se but it suggest that there might be more than one reader. For -rt I am reviewing all complete_all() users and would like to leave only the real ones in the tree. The main problem for -rt about

[PATCH 1/2] carl9170: Fix wrong completion usage

From: Daniel Wagner carl9170_usb_stop() is used from several places to flush and cleanup any pending work. The normal pattern is to send a request and wait for the irq handler to call complete(). The completion is not reinitialized during normal operation and as the

Re: mwifiex: fix large amsdu packets causing firmware hang

Amitkumar Karwar wrote: > From: Cathy Luo > > Sometimes host prepares and downloads a large amsdu packet to firmware > which leads to a memory corruption in firmware. > The reason is __dev_alloc_skb() may allocate larger buffer than required > size. This

wireless-drivers-next is OPEN

David Miller writes: > I've merged 'net' into 'net-next' and applied a bunch of pending stuff. > > Fire at will... Delayed because of my vacation but wireless-drivers-next is finally open for new patches. I'll start going through the backlog of patches now. I have also

[PATCH] ath10k: fix sending frame in management path in push txq logic

In the wake tx queue path, we are not checking if the frame to be sent takes management path or not. For eg. QOS null func frame coming here will take the management path. Since we are not incrementing the descriptor counter (num_pending_mgmt_tx) w.r.t tx management, on tx completion it is

[PATCH 3/3] wlcore: Add RX_BA_WIN_SIZE_CHANGE_EVENT event

This event is used by the Firmware to limit the RX BA win size for a specific link. The event handler updates the new size in the mac's sta->sta struct. BA sessions opened for that link will use the new restricted win_size. This limitation remains until a new update is received or until the link

[PATCH 1/3] mac80211: RX BA support for sta max_rx_aggregation_subframes

The ability to change the max_rx_aggregation frames is useful in cases of IOP. There exist some devices (latest mobile phones and some AP's) that tend to not respect a BA sessions maximum size (in Kbps). These devices won't respect the AMPDU size that was negotiated during associasion (even

[PATCH 0/3] IOP RX BA session issues

Some background: There exist some devices (latest mobile phones and some AP's e.g LG G4 H815, Samsung Galaxy S5 G900H) that tend to not respect a BA sessions maximum size (in Kbps). These devices won't respect the AMPDU size that was negotiated during associasion (even though they do

[PATCH 2/3] wlcore: Pass win_size taken from ieee80211_sta to FW

When starting a new BA session, we must pass the win_size to the FW. To do this we take max_rx_aggregation_subframes (BA RX win size) which is stored in ieee80211_sta structure (e.g per link and not per HW) We will use the value stored per link when passing the win_size to firmware through the

Partnership Cooperation

Dear Friend, Your contact details came to me by recommendation, I am interested in investing in your country and I believe you have the capabilities of providing the needed assistance, solutions and advise in actualizing this, Let me know if you are willing to understake this task for me so we