Re: [PATCH 2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

2016-08-20 Thread Julian Calaby
Hi Marcus, On Sun, Aug 21, 2016 at 2:46 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 20 Aug 2016 18:21:29 +0200 > > Remove a jump label which is unneeded in this function at the end. > > Signed-off-by: Markus Elfring > --- > drivers/net/wireless/intersil/hostap/hostap_ioctl

Re: [PATCH] brcmfmac: Add USB ID for Cisco Linksys AE1200

2016-08-20 Thread Arend van Spriel
On 20-08-16 17:17, Ismael Luceno wrote: > Ping. > > On 22/Jun/2016 17:54, Ismael Luceno wrote: >> On 22/Jun/2016 21:07, Arend van Spriel wrote: >>> On 22-06-16 20:36, Ismael Luceno wrote: On 21/Jun/2016 21:02, Arend van Spriel wrote: > On 21-06-16 02:18, Ismael Luceno wrote: >> Signed

Re: [PATCH 0/3] hostap: Fine-tuning for a few functions

2016-08-20 Thread Arend van Spriel
On 20-08-16 18:43, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 20 Aug 2016 18:35:43 +0200 > > A few update suggestions were taken into account > from static source code analysis. Is it worth touching this old stuff especially when you are not making any functional changes. Rega

Re: [PATCH] brcmfmac: Add USB ID for Cisco Linksys AE1200

2016-08-20 Thread Rafał Miłecki
On 20 August 2016 at 17:17, Ismael Luceno wrote: > Ping. No need to ping (and don't top post please). https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#checking_state_of_patches_from_patchwork

[PATCH 3/3] hostap: Delete unnecessary initialisations for the variable "ret"

2016-08-20 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 20 Aug 2016 18:23:14 +0200 The local variable "ret" will be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning of four functions. Signed-off-by: Markus Elfring --- drivers/net/wireless/intersil/hostap/hostap_ioctl.c |

[PATCH 2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

2016-08-20 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 20 Aug 2016 18:21:29 +0200 Remove a jump label which is unneeded in this function at the end. Signed-off-by: Markus Elfring --- drivers/net/wireless/intersil/hostap/hostap_ioctl.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH 1/3] hostap: Use memdup_user() rather than duplicating its implementation

2016-08-20 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 20 Aug 2016 18:19:43 +0200 Reuse existing functionality from memdup_user() instead of keeping duplicate source code. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- .../net/wireless/intersil/hostap/hostap_ioctl.c|

[PATCH 0/3] hostap: Fine-tuning for a few functions

2016-08-20 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 20 Aug 2016 18:35:43 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use memdup_user() Delete an unnecessary jump label Delete unnecessary variable initialisations .../net/wireless/intersil/hosta

Re: [PATCH] brcmfmac: Add USB ID for Cisco Linksys AE1200

2016-08-20 Thread Ismael Luceno
Ping. On 22/Jun/2016 17:54, Ismael Luceno wrote: > On 22/Jun/2016 21:07, Arend van Spriel wrote: > > On 22-06-16 20:36, Ismael Luceno wrote: > > > On 21/Jun/2016 21:02, Arend van Spriel wrote: > > >> On 21-06-16 02:18, Ismael Luceno wrote: > > >>> Signed-off-by: Ismael Luceno > > >> > > >> A bit