Re: [PATCH 2/3] mac80211: multicast to unicast conversion

2016-10-03 Thread M. Braun
Am 30.09.2016 um 09:29 schrieb Johannes Berg: >> +static ssize_t ieee80211_if_fmt_unicast( >> +const struct ieee80211_sub_if_data *sdata, char *buf, int >> buflen) > > That's a very ... unusual way to break the lines here it is the same style as used in debugfs_netdev.c for other attributes,

Re: [v2] mwifiex: report wakeup for wowlan

2016-10-03 Thread Rajat Jain
Hello Kalie, On Mon, Oct 3, 2016 at 6:04 AM, Kalle Valo wrote: > Rajat Jain wrote: >> Enable notifying wakeup source to the PM core in case of >> a wake on wireless LAN event. >> >> Signed-off-by: Wei-Ning Huang >> Signed-off-by:

Re: pull-request: mac80211-next 2016-09-30

2016-10-03 Thread David Miller
From: Johannes Berg Date: Mon, 03 Oct 2016 12:07:00 +0200 > On Mon, 2016-10-03 at 01:54 -0400, David Miller wrote: >>  >> Could you please look into this and send me a new pull request with >> the conflicts resolved? >> > > Sure, will do (tomorrow, we have a holiday

Re: Final 4.8 w-t build is wt-2016-10-03

2016-10-03 Thread Bob Copeland
On Mon, Oct 03, 2016 at 04:42:58PM +0200, Christian Lamparter wrote: > Thanks for the timely update. > I have a request: can you please pull Linus' kernel tags? > Currently the last tag from Linus' is v4.4-rc4 [0] and > everything between v4.4-rc5 and v4.8 is missing?! I've done this now. --

Re: [PATCH] cfg80211: Add HT and VHT information in start_ap

2016-10-03 Thread Malinen, Jouni
On Mon, Sep 12, 2016 at 12:09:42PM +0200, Johannes Berg wrote: > I have no major objections to this. However, a few things: > > 1) are you planning to add support for this into a kernel driver at >    all, anyway? > 2) are you planning to have a driver upstream that contains the now >    

[PATCH 3/3] ath6kl: configure SDIO when power is reapplied

2016-10-03 Thread James Minor
When power is removed from the device, all of the SDIO settings return to default. Fix that by reconfiguring after power is applied. Signed-off-by: James Minor Reviewed-by: Steve deRosier --- drivers/net/wireless/ath/ath6kl/sdio.c | 9

[PATCH 2/3] ath6kl: after cleanup properly reflect that sg is disabled

2016-10-03 Thread James Minor
This allows the hardware to be restarted, as it will cause the sg to be reinitialized. Signed-off-by: James Minor Reviewed-by: Steve deRosier --- drivers/net/wireless/ath/ath6kl/sdio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 1/3] ath6kl: fix busreqs so they can be reused when sg is cleaned up

2016-10-03 Thread James Minor
To reuse the busreqs in case of hardware restart, they must be properly reinitialized. If the scat_req pointer isn't reset to 0, __ath6kl_sdio_write_async() will assume there is sg work to be done (causing a kernel OOPS). Signed-off-by: James Minor Reviewed-by: Steve

[PATCH 0/3] Allow ath6kl to be restarted

2016-10-03 Thread James Minor
To work around a boot issue with the AR6234, I discovered a few instances where error cleanup code is not working as expected. A full solution for the boot issue is being worked up, but in the mean time these fixes make error cleanup work properly. James Minor (3): ath6kl: fix busreqs so they

Re: Final 4.8 w-t build is wt-2016-10-03

2016-10-03 Thread Bob Copeland
On Mon, Oct 03, 2016 at 04:42:58PM +0200, Christian Lamparter wrote: > Hello, > > On Monday, October 3, 2016 9:45:07 AM CEST Bob Copeland wrote: > > Per the subject, Linus released 4.8 yesterday so, unless I broke something > > in recent conflict resolutions, wireless-testing is on pause until

Re: [RFC 0/3] of: add common bindings to (de)activate IEEE 802.11 bands

2016-10-03 Thread Rob Herring
On Sun, Oct 2, 2016 at 5:50 PM, Martin Blumenstingl wrote: > There are at least two drivers (ath9k and mt76) out there, where > devicetree authors need to override the enabled bands. > > For ath9k there is only one use-case: disabling a band which has been >

Re: Final 4.8 w-t build is wt-2016-10-03

2016-10-03 Thread Christian Lamparter
Hello, On Monday, October 3, 2016 9:45:07 AM CEST Bob Copeland wrote: > Per the subject, Linus released 4.8 yesterday so, unless I broke something > in recent conflict resolutions, wireless-testing is on pause until the > merge window closes in two weeks. Have a happy (Canadian) thanksgiving! >

Final 4.8 w-t build is wt-2016-10-03

2016-10-03 Thread Bob Copeland
Per the subject, Linus released 4.8 yesterday so, unless I broke something in recent conflict resolutions, wireless-testing is on pause until the merge window closes in two weeks. Have a happy (Canadian) thanksgiving! https://git.kernel.org/cgit/linux/kernel/git/wireless/wireless-testing.git --

Re: [PATCH v3 1/3] Documentation: dt: net: add mt76 wireless device binding

2016-10-03 Thread Kalle Valo
Arnd Bergmann writes: > On Friday 30 September 2016, Felix Fietkau wrote: >> >> >> >> + device_type = "pci"; >> >> >> >> + mediatek,mtd-eeprom = < 0x8000>; >> >> >> >> + mediatek,2ghz = <0>; >> >> > >> >> > It's not clear what the

Re: [v2] mwifiex: report wakeup for wowlan

2016-10-03 Thread Kalle Valo
Rajat Jain wrote: > Enable notifying wakeup source to the PM core in case of > a wake on wireless LAN event. > > Signed-off-by: Wei-Ning Huang > Signed-off-by: Rajat Jain > Tested-by: Wei-Ning Huang >

Re: [PATCH 1/2] rtl8xxxu: Fix memory leak in handling rxdesc16 packets

2016-10-03 Thread Jes Sorensen
Kalle Valo writes: > jes.soren...@redhat.com writes: > >> From: Jes Sorensen >> >> A device running without RX package aggregation could return more data >> in the USB packet than the actual network packet. In this case the >> could would clone the

Re: [PATCH 2/2] rtl8xxxu: Fix big-endian problem reporting mactime

2016-10-03 Thread Jes Sorensen
Kalle Valo writes: > jes.soren...@redhat.com writes: > >> From: Jes Sorensen >> >> The full RX descriptor is converted so converting tsfl again would >> return it to it's original endian value. >> >> Signed-off-by: Jes Sorensen

Re: RTL8192EU on rtl8xxxu driver breaks every few minutes

2016-10-03 Thread Jes Sorensen
"Franc[e]sco" writes: > Thanks for the patch, just tested the rtl8xxxu-devel branch and it seems > to have the same exact issue with the same dmesg output with the > addition of "rtl8192eu_active_to_emu: Disabling MAC timed out" when I > disconnect the dongle. > > I

Re: [PATCH] mac80211: fix CMD_FRAME for AP_VLAN

2016-10-03 Thread M. Braun
Am 03.10.2016 um 13:03 schrieb M. Braun: > because the in ieee80211_mgmt_tx the ups, that was the patch itself. I think I carried it over from ieee80211_add_key, that does > >if (mac_addr) { >if (ieee80211_vif_is_mesh(>vif)) >sta =

[PATCHv3 2/3] mac80211: check A-MSDU inner frame source address on AP interfaces

2016-10-03 Thread Michael Braun
When using WPA security, the station and thus the required key is identified by its mac address when packets are received. So a station usually cannot spoof its source mac address. But when a station sends an A-MSDU frame, port control and crypto is done using the outer mac address, while the

[PATCHv3 3/3] mwifiex: check A-MSDU inner frame source address on AP interfaces

2016-10-03 Thread Michael Braun
When using WPA security, the station and thus the required key is identified by its mac address when packets are received. So a station usually cannot spoof its source mac address. But when a station sends an A-MSDU frame, port control and crypto is done using the outer mac address, while the

[PATCHv2 1/3] mac80211: fix CMD_FRAME for AP_VLAN

2016-10-03 Thread Michael Braun
When using IEEE 802.11r FT OVER-DS roaming with AP_VLAN, hostapd needs to send out a frame using CMD_FRAME for a station assigned to an AP_VLAN interface. Right now, the userspace needs to give the exact AP_VLAN interface index for CMD_FRAME; hostapd does not do this. Additionally, userspace

Re: [PATCH] mac80211: fix CMD_FRAME for AP_VLAN

2016-10-03 Thread M. Braun
Am 30.09.2016 um 13:41 schrieb Johannes Berg: >> -sta = sta_info_get(sdata, mgmt->da); >> +if (ieee80211_vif_is_mesh(>vif)) >> +sta = sta_info_get(sdata, mgmt->da); >> +else >> +sta = sta_info_get_bss(sdata, mgmt->da); >>

Re: [PATCHv3] wireless: check A-MSDU inner frame source address on AP interfaces

2016-10-03 Thread Michael Braun
Am 30.09.2016 um 12:01 schrieb Johannes Berg: > A few more things: > > First of all - there's nothing specific to "AP interfaces", which you > say in the subject, as far as I can tell? That should be removed? >> if (unlikely(ta && >>+ (iftype == NL80211_IFTYPE_AP || >>+

Re: pull-request: mac80211-next 2016-09-30

2016-10-03 Thread Johannes Berg
On Mon, 2016-10-03 at 01:54 -0400, David Miller wrote: >  > Could you please look into this and send me a new pull request with > the conflicts resolved? > Sure, will do (tomorrow, we have a holiday today). Would you prefer I send you the merge resolution for your tree, or just pull in net for

[PATCH] ath9k: Move generic entries below specific ones in ath_pci_id_table.

2016-10-03 Thread Vittorio Gambaletta (VittGam)
If generic entries are positioned above specific ones, then the former will be matched first and used instead of the latter. Cc: Cc: Cc: Cc: Signed-off-by: Vittorio Gambaletta

Re: [PATCH] ath10k: cache calibration data when the core is stopped.

2016-10-03 Thread Michal Kazior
On 13 September 2016 at 23:11, Marty Faltesek wrote: [...] > +int > +ath10k_cal_data_alloc(struct ath10k *ar, void **buf) > +{ > + u32 hi_addr; > + __le32 addr; > + int ret; > + > + vfree(*buf); > + *buf = vmalloc(QCA988X_CAL_DATA_LEN);

Re: [PATCH 2/2] ath10k: add platform regulatory domain support

2016-10-03 Thread Valo, Kalle
Bartosz Markowski writes: > On 14 September 2016 at 09:06, Valo, Kalle wrote: >> >> Bartosz Markowski writes: >> >> > On 12 September 2016 at 17:35, Valo, Kalle wrote: >> > >> >> >

Re: [PATCH] ath10k: cache calibration data when the core is stopped.

2016-10-03 Thread Valo, Kalle
Marty Faltesek writes: > Caching calibration data allows it to be accessed when the > device is not active. > > Signed-off-by: Marty Faltesek [...] > +int > +ath10k_cal_data_alloc(struct ath10k *ar, void **buf) > +{ [...] > +

Re: [PATCH] ath10k: cache calibration data when the core is stopped.

2016-10-03 Thread Valo, Kalle
Marty Faltesek writes: > Caching calibration data allows it to be accessed when the > device is not active. > > Signed-off-by: Marty Faltesek No comma in the title, please. What tree did you use as the baseline? This doesn't seem to apply to

Re: [PATCH 2/2] ath10k: add platform regulatory domain support

2016-10-03 Thread Bartosz Markowski
On 14 September 2016 at 09:06, Valo, Kalle wrote: > > Bartosz Markowski writes: > > > On 12 September 2016 at 17:35, Valo, Kalle wrote: > > > >> > +#ifdef CONFIG_ACPI > >> > +#define WRD_METHOD "WRDD" > >> > +#define

Re: [PATCH 2/2] rtl8xxxu: Fix rtl8192eu driver reload issue

2016-10-03 Thread Kalle Valo
jes.soren...@redhat.com writes: > From: Jes Sorensen > > The 8192eu suffered from two issues when reloading the driver. > > The same problems as with the 8723bu where REG_RX_WAIT_CCA bits 22 and > 23 didn't get set in rtl8192e_enable_rf(). > > In addition it also seems

Re: [PATCH 1/2] rtl8xxxu: Fix rtl8723bu driver reload issue

2016-10-03 Thread Kalle Valo
Jes Sorensen writes: > Greg KH writes: >> On Fri, Sep 30, 2016 at 07:35:17PM -0400, jes.soren...@redhat.com wrote: >>> From: Jes Sorensen >>> >>> The generic disable_rf() function clears bits 22 and 23 in >>> REG_RX_WAIT_CCA,

Re: [PATCH 2/2] rtl8xxxu: Fix big-endian problem reporting mactime

2016-10-03 Thread Kalle Valo
jes.soren...@redhat.com writes: > From: Jes Sorensen > > The full RX descriptor is converted so converting tsfl again would > return it to it's original endian value. > > Signed-off-by: Jes Sorensen I'll add: Cc: sta...@vger.kernel.org # 4.8+

Re: [PATCH 1/2] rtl8xxxu: Fix memory leak in handling rxdesc16 packets

2016-10-03 Thread Kalle Valo
jes.soren...@redhat.com writes: > From: Jes Sorensen > > A device running without RX package aggregation could return more data > in the USB packet than the actual network packet. In this case the > could would clone the skb but then determine that that there was no >

Re: [PATCH 1/2] rtl8xxxu: Fix memory leak in handling rxdesc16 packets

2016-10-03 Thread Kalle Valo
jes.soren...@redhat.com writes: > From: Jes Sorensen > > A device running without RX package aggregation could return more data > in the USB packet than the actual network packet. In this case the > could would clone the skb but then determine that that there was no >