Re: cfg80211: race problem between suspend and disconnect event

2016-10-21 Thread Johannes Berg
> Yes. In our case, *802_11_DEAUTHENTICATE command downloaded to > firmware takes care of flushing the keys. > > I can see below code in cfg80211's disconnect handling. It seems to > be there for long time. Yeah, I saw it, but it's not clear to me that there's much point in it. In any case,

[PATCH v6] mwifiex: parse device tree node for PCIe

2016-10-21 Thread Rajat Jain
From: Xinming Hu This patch derives device tree node from pcie bus layer framework, and fixes a minor memory leak in mwifiex_pcie_probe() (in failure path). Device tree bindings file has been renamed(marvell-sd8xxx.txt -> marvell-8xxx.txt) to accommodate PCIe changes.

Re: sequence diagrams in rst documentation

2016-10-21 Thread Johannes Berg
On Fri, 2016-10-21 at 18:11 +0200, Markus Heiser wrote: > Yes and No. It depends on the tools (toolchains) we want to use. > As far as I can see from a abstract POV it should by simple for > math:: / since we already use/need LaTeX for PDF, for other tools > I have to look. Not sure if we were

Re: sequence diagrams in rst documentation

2016-10-21 Thread Johannes Berg
> I general I think, we should not include Java into our toolchains > even if it is optional. Thats, why I won't vote for > http://plantuml.com/ Keep in mind though that such a vote may well end up being a vote not just against plantuml, but also against having sequence diagrams to start with -

Re: [PATCH 2/2] mac80211: use inline kernel-doc for struct ieee80211_hw

2016-10-21 Thread Johannes Berg
On Fri, 2016-10-21 at 20:59 +0200, Arend van Spriel wrote: > Me neither. I actually found it annoying to have all kernel-doc above > the type definition and indeed easy to miss fields. Now struct > ieee80211_hw is not alone and we have it all over the place in the > wireless subsystem. Is this

RE: [PATCH][RFC] nl80211/mac80211: Rounded RSSI reporting

2016-10-21 Thread Zaborowski, Andrew
Hi, > The problem is that you really want this to be offloaded to the device, > *especially* if you care about low power usage, because you absolutely > don't want to be processing each beacon (which is typically what we > derive the data from today) in the host CPU - you want those to be >

Re: [PATCH 2/2] mac80211: use inline kernel-doc for struct ieee80211_hw

2016-10-21 Thread Arend van Spriel
On 21-10-16 15:01, Johannes Berg wrote: > On Fri, 2016-10-21 at 15:57 +0300, Jani Nikula wrote: >> It's easier to manage the kernel-doc for the fields when they >> documentation is next to the field. > > Hah, I wasn't even aware this was possible. Thanks! Me neither. I actually found it annoying

Re: compex wle900vx (ath10k) problem on 4.4.24 / armv7

2016-10-21 Thread Michal Kazior
On 21 October 2016 at 18:25, Oliver Zemann wrote: > The problem is gone with kernel 4.7.3 on armbian - both compex cards work > (wle600, wle900), unfortunately that kernel does not support sfp (seems like > its kind of proprietary drivers from clearfog). So its a driver

Re: compex wle900vx (ath10k) problem on 4.4.24 / armv7

2016-10-21 Thread Oliver Zemann
The problem is gone with kernel 4.7.3 on armbian - both compex cards work (wle600, wle900), unfortunately that kernel does not support sfp (seems like its kind of proprietary drivers from clearfog). So its a driver issue but i have no clue who to contact or where to file a bug report. The only

Re: sequence diagrams in rst documentation

2016-10-21 Thread Markus Heiser
Am 21.10.2016 um 15:04 schrieb Johannes Berg : >> I had the same conclusion for math:: directives pulling in latex >> dependency [1]. Hopefully Markus can help here. > > Yeah, good one. > > Maybe it's actually simple? Depending on where sphinx will look for > plugins

RE: cfg80211: race problem between suspend and disconnect event

2016-10-21 Thread Amitkumar Karwar
Hi Johannes, > From: Johannes Berg [mailto:johan...@sipsolutions.net] > Sent: Friday, October 21, 2016 12:16 AM > To: Amitkumar Karwar > Cc: Kalle Valo; Brian Norris; Nishant Sarmukadam; Cathy Luo; linux- > wirel...@vger.kernel.org; Ganapathi Bhat > Subject: Re: cfg80211: race problem between

[PATCH 2/2] mwifiex: ignore calibration data failure

2016-10-21 Thread Amitkumar Karwar
Firmware may reject calibration data from host for certain OTP settings. In that case, we should continue initialisation ignoring the failure. Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 16 +--- 1 file changed, 5

Re: [PATCH 1/2] mac80211: fix some sphinx warnings

2016-10-21 Thread Johannes Berg
On Fri, 2016-10-21 at 16:14 +0300, Jani Nikula wrote: > On Fri, 21 Oct 2016, Johannes Berg wrote: > > > > On Fri, 2016-10-21 at 15:57 +0300, Jani Nikula wrote: > > > > > > Signed-off-by: Jani Nikula > > > --- > > >  include/net/mac80211.h | 21

Re: [PATCH 1/2] mac80211: fix some sphinx warnings

2016-10-21 Thread Jani Nikula
On Fri, 21 Oct 2016, Johannes Berg wrote: > On Fri, 2016-10-21 at 15:57 +0300, Jani Nikula wrote: >> Signed-off-by: Jani Nikula >> --- >>  include/net/mac80211.h | 21 + >>  1 file changed, 13 insertions(+), 8 deletions(-) >>

lening bieden 3%

2016-10-21 Thread UK CREDIT LTD LOAN
-- Groeten heer / mevrouw: Ik ben Dr, Peter Ibrahim van particuliere lening bedrijf UK CREDIT LTD lening, gevestigd in het Verenigd Koninkrijk. Wij bieden alle soorten van leningen aan particulieren en bedrijven, Maak jezelf financieel stabiel door het verkrijgen van een lening van UK

lening bieden 3%

2016-10-21 Thread UK CREDIT LTD LOAN
-- Groeten heer / mevrouw: Ik ben Dr, Peter Ibrahim van particuliere lening bedrijf UK CREDIT LTD lening, gevestigd in het Verenigd Koninkrijk. Wij bieden alle soorten van leningen aan particulieren en bedrijven, Maak jezelf financieel stabiel door het verkrijgen van een lening van UK

Re: [PATCH 2/2] mac80211: use inline kernel-doc for struct ieee80211_hw

2016-10-21 Thread Johannes Berg
On Fri, 2016-10-21 at 15:57 +0300, Jani Nikula wrote: > It's easier to manage the kernel-doc for the fields when they > documentation is next to the field. Hah, I wasn't even aware this was possible. Thanks! johannes

Re: [PATCH 1/2] mac80211: fix some sphinx warnings

2016-10-21 Thread Johannes Berg
On Fri, 2016-10-21 at 15:57 +0300, Jani Nikula wrote: > Signed-off-by: Jani Nikula > --- >  include/net/mac80211.h | 21 + >  1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/include/net/mac80211.h b/include/net/mac80211.h > index

Re: sequence diagrams in rst documentation

2016-10-21 Thread Johannes Berg
> I had the same conclusion for math:: directives pulling in latex > dependency [1]. Hopefully Markus can help here. Yeah, good one. Maybe it's actually simple? Depending on where sphinx will look for plugins first, we could just ship the plugins with a no-op implementation (pass through the

wl12xx stuck in fw

2016-10-21 Thread Nicklas Persson
Hi, I have been debugging my WLAN driver interface for a while. I have a Beaglebone equivalent board with the TI wl1271 wireless module. I am very new to linux drivers and wireless configuration so these couple of days I have spent have been really interesting and I have much more knowledge now.

[PATCH 2/2] mac80211: use inline kernel-doc for struct ieee80211_hw

2016-10-21 Thread Jani Nikula
It's easier to manage the kernel-doc for the fields when they documentation is next to the field. Signed-off-by: Jani Nikula --- The same treatment is sorely needed for struct ieee80211_ops also, but I don't have the time... this would get rid of the rest of the warnings

Re: sequence diagrams in rst documentation

2016-10-21 Thread Jani Nikula
On Fri, 21 Oct 2016, Johannes Berg wrote: >> >https://pythonhosted.org/sphinxcontrib-aafig/ >> > >> > I've not actually played with it at all, but I like the idea that >> > we'd have readable diagrams in the source docs as well... >> >> Well, maybe. I agree having

[PATCH 1/2] mac80211: fix some sphinx warnings

2016-10-21 Thread Jani Nikula
Signed-off-by: Jani Nikula --- include/net/mac80211.h | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/include/net/mac80211.h b/include/net/mac80211.h index a810dfcb83c2..e2dba93e374f 100644 --- a/include/net/mac80211.h +++

Re: sequence diagrams in rst documentation

2016-10-21 Thread Johannes Berg
> > https://pythonhosted.org/sphinxcontrib-aafig/ > > > > I've not actually played with it at all, but I like the idea that > > we'd have readable diagrams in the source docs as well... > > Well, maybe. I agree having it readable in the source docs as well is > nice, but for sequence

Re: [PATCH v3] cfg80211: Check radar_detect and num_different_channels with beacon interface combinations.

2016-10-21 Thread Johannes Berg
On Thu, 2016-10-13 at 20:45 +0530, Purushottam Kushwaha wrote: > This commit enhances the current beacon interval validation to also > consider > the "radar_detect" and "num_different_channels". > > Move calculation of GCD for all beaconing interfaces to > "cfg80211_iter_combinations". > >

[PATCH 3/4] cfg80211: validate beacon int as part of iface combinations

2016-10-21 Thread Johannes Berg
From: Johannes Berg Remove the pointless checking against interface combinations in the initial basic beacon interval validation, that currently isn't taking into account radar detection or channels properly. Instead, just validate the basic range there, and then delay

[PATCH 4/4] mac80211: validate new interface's beacon intervals

2016-10-21 Thread Johannes Berg
From: Johannes Berg As part of interface combination checking, verify any new interface's beacon intervals. In fact, just always add the beacon interval since that's harmless. With this patch, mac80211 is prepared for drivers that set the min_beacon_int_gcd parameter in

[PATCH 2/4] cfg80211: disallow beacon_int_min_gcd with IBSS

2016-10-21 Thread Johannes Berg
From: Johannes Berg This can't really be supported right now, because the IBSS interface may change its beacon interval at any time due to joining another network; thus, there's already "support" for different beacon intervals here, implicitly. Until we figure out how

[PATCH 1/4] cfg80211: mesh: track (and thus validate) beacon interval

2016-10-21 Thread Johannes Berg
From: Johannes Berg This is needed for beacon interval validation; if we don't store it, then new interfaces added won't validate that the beacon interval is the same as existing ones. Fix this. Signed-off-by: Johannes Berg ---

brcmfmac interface combinations

2016-10-21 Thread Johannes Berg
Hi Arend, I'm looking into the interface combinations stuff, mostly due to the patches from QCA to add the support for differing beacon intervals. One thing that I was considering, was to change the API for cfg80211_check_combinations() to not require the driver to fill in the # of interfaces of

[mac80211-next:master 25/25] net/mac80211/util.c:3411:8: error: implicit declaration of function 'cfg80211_iter_combinations'

2016-10-21 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master head: 9fd96261756ed32c762d417b2c4dfd1febbbf71c commit: 9fd96261756ed32c762d417b2c4dfd1febbbf71c [25/25] cfg80211: don't export cfg80211_iter_combinations() config: x86_64-randconfig-x019-201642 (attached as

[PATCH] cfg80211: don't export cfg80211_iter_combinations()

2016-10-21 Thread Johannes Berg
From: Johannes Berg Nothing uses it outside of cfg80211, and since only cfg80211_check_combinations() uses it in the same file it can even be static - do that. Signed-off-by: Johannes Berg --- include/net/cfg80211.h | 18 --

[PATCH] cfg80211: fix beacon interval in interface combination iteration

2016-10-21 Thread Johannes Berg
From: Johannes Berg We shouldn't abort the iteration with an error when one of the potential combinations can't accomodate the beacon interval request, we should just skip that particular combination. Fix the code to do so. Signed-off-by: Johannes Berg

[PATCH 2/2] rsi: Device initialization sequence is changed

2016-10-21 Thread Prameela Rani Garnepudi
BT Co-ex support has been added in the firmware and hence BT, COEX queues are introducted. To support the latest firmware queues, packet processing, and initialization sequence is modified in the Host. Common device configuration parameters (tx command frame) need to be send after common card

[PATCH 1/2] rsi: New firware loading method for RSI 91X devices

2016-10-21 Thread Prameela Rani Garnepudi
RSI deprecated the old firmware loading method and introduced new method using soft boot loader for 9113 chipsets. Current driver only supports 9113 device model hence firmware loading method has been changed. In the new method, complete RAM image and flash image are present in the flash. Two

Re: [PATCH] cfg80211: add generic helper to check interface is running

2016-10-21 Thread Johannes Berg
On Thu, 2016-10-20 at 20:08 +0100, Arend van Spriel wrote: > Adding a helper using wdev to check if interface is running. This > deals with both non-netdev and netdev interfaces. In struct > wireless_dev replacing 'p2p_started' and 'nan_started' by > 'is_running' as those are mutual exclusive

Re: [PATCH] cfg80211: allow vendor commands to be sent to nan interface

2016-10-21 Thread Arend Van Spriel
On 20-10-2016 14:45, Johannes Berg wrote: > On Thu, 2016-10-20 at 14:44 +0200, Arend Van Spriel wrote: >> >> Sure. On top of this patch or will you deal with those conflicts? >> > > I already applied this, so on top please (i.e. just resend what you > just had, with a commit message?) Yup.