Re: [PATCH 1/3] cfg80211: Make pre-CAC results valid only for ETSI domain

On Monday 27 February 2017 08:08 PM, Johannes Berg wrote: > On Mon, 2017-02-20 at 16:09 +0530, Vasanthakumar Thiagarajan wrote: >> DFS requirement for ETSI domain (section 4.7.1.4 in >> ETSI EN 301 893 V1.8.1) is the only one which explicitly >> states that once DFS channel is marked as available

[PATCH v2 2/4] mac80211-hwsim: remove dmesg spam about get-survey.

From: Ben Greear This message just fills up dmesg and/or kernel logs and does not provide any useful information. Signed-off-by: Ben Greear --- drivers/net/wireless/mac80211_hwsim.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH v2 1/4] mac80211-hwsim: notify user-space about channel change.

From: Ben Greear The goal is to allow the user-space application to properly filter packets before sending them down to the kernel. This should more closely mimic what a real piece of hardware would do. Signed-off-by: Ben Greear --- v2:

[PATCH v2 4/4] mac80211-hwsim: add length checks before allocating skb.

From: Ben Greear Modify the receive-from-user-space logic to do length and 'is-down' checks before trying to allocate an skb. And, if we are going to ignore the pkt due to radio idle, then do not return an error code to user-space. User-space cannot reliably know

[PATCH v2 3/4] mac80211-hwsim: add rate-limited debugging for rx-netlink

From: Ben Greear This makes it easier to understand why wmediumd (or similar) is getting errors when sending frames to the kernel. Signed-off-by: Ben Greear --- v2: Add and use hwsim_ratelimit() instead of net_ratelimit. Squash two

Re: [PATCH 2/2][RFC] mac80211_hwsim: Report radio addresses in NEW_RADIO/GET_RADIO

On 02/27/2017 05:23 PM, Andrew Zaborowski wrote: Hi, On 27 February 2017 at 18:10, Ben Greear wrote: On 02/27/2017 07:26 AM, Andrew Zaborowski wrote: As it turns out it can be read from /sys, but I do need it so I can know what to put in HWSIM_ATTR_ADDR_RECEIVER

Re: [PATCH 2/2][RFC] mac80211_hwsim: Report radio addresses in NEW_RADIO/GET_RADIO

Hi, On 27 February 2017 at 18:10, Ben Greear wrote: > On 02/27/2017 07:26 AM, Andrew Zaborowski wrote: >> As it turns out it can be read from /sys, but I do need it so I can >> know what to put in HWSIM_ATTR_ADDR_RECEIVER based on the destination >> addr in the frame or

[PATCH v2 4/4] brcmfmac: Handle status == BRCMF_E_STATUS_ABORT in cfg80211_escan_handler

If a scan gets aborted BRCMF_SCAN_STATUS_BUSY gets cleared in cfg->scan_status and when we receive an abort event from the firmware the BRCMF_SCAN_STATUS_BUSY check in the cfg80211_escan_handler will trigger resulting in multiple errors getting logged. Check for a status of BRCMF_E_STATUS_ABORT

[PATCH] wireless: ipw2200: remove redundant check of rc < 0

From: Colin Ian King The check for rc < 0 is always false so the check is redundant and can be removed. Detected with CoverityScan, CID#101143 ("Logically dead code") Signed-off-by: Colin Ian King ---

Re: [PATCH 3/3] ath9k: ahb: Add OF support

On 27 February 2017 at 23:48, Alban wrote: > On Mon, 27 Feb 2017 22:13:21 +0100 > Rafał Miłecki wrote: > >> Why you didn't cc linux-wireless?!?! > > I first wanted to be sure that the devdata part was generally > acceptable, this patch was just included as an

Re: [PATCH 3/3] ath9k: ahb: Add OF support

On Mon, 27 Feb 2017 22:13:21 +0100 Rafał Miłecki wrote: > Why you didn't cc linux-wireless?!?! I first wanted to be sure that the devdata part was generally acceptable, this patch was just included as an example of a user. But it sound like that part will have to move to nvmem

[PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error

Using pr_err for things which are not errors is a bad idea. E.g. it will cause the plymouth bootsplash screen to drop back to the text console so that the user can see the error, which is not what we normally want to happen. Instead add a new brcmf_info macro and use that. Signed-off-by: Hans de

[PATCH v2 2/4] brcmfmac: p2p and normal ap access are not always possible at the same time

The firmware responding with -EBUSY when trying to add an extra virtual-if is a normal thing, do not print an error for this. Signed-off-by: Hans de Goede --- .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c| 14 ++

[PATCH v2 3/4] brcmfmac: Do not complain about country code "00"

The country code gets set to "00" by default at boot, ignore this rather then logging an error about it. Signed-off-by: Hans de Goede --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH 3/3] ath9k: ahb: Add OF support

Why you didn't cc linux-wireless?!?! On 27 February 2017 at 21:28, Alban wrote: > @@ -513,6 +515,43 @@ static void ath9k_eeprom_release(struct ath_softc *sc) > release_firmware(sc->sc_ah->eeprom_blob); > } > > +#ifdef CONFIG_OF > +static int ath9k_init_of(struct ath_softc

Re: [PATCH 099/306] mac80211-hwsim: notify user-space about channel change.

On 02/23/2017 10:36 PM, Johannes Berg wrote: + msg_head = genlmsg_put(skb, 0, 0, _genl_family, 0, + HWSIM_CMD_NOTIFY); I think you should use a more specific command name. + if (nla_put(skb, HWSIM_ATTR_ADDR_TRANSMITTER, +

Re: [PATCH 099/306] mac80211-hwsim: notify user-space about channel change.

On 02/23/2017 10:36 PM, Johannes Berg wrote: + msg_head = genlmsg_put(skb, 0, 0, _genl_family, 0, + HWSIM_CMD_NOTIFY); I think you should use a more specific command name. + if (nla_put(skb, HWSIM_ATTR_ADDR_TRANSMITTER, +

Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

Hi Johannes, This is loosely based on RFC5148, specifically event-triggered message generation as described in section 5.2. The frames are not duplicated, but, hopefully offset enough so they don't collide at the receiver (and, since, these are management frames, there is no retransmission and

Re: brcmfmac: problem using WPS with wpa_supplicant on BCM43362

Hi Arend, On Fri, 2017-02-24 at 13:15 +0100, Arend Van Spriel wrote: > On 24-2-2017 11:26, Jörg Krause wrote: > > Hi Arend, > > > > On Fri, 2017-02-24 at 10:58 +0100, Arend Van Spriel wrote: > > > On 24-2-2017 10:43, Jörg Krause wrote: > > > > Hi Arend, > > > > > > > > On Fri, 2017-02-24 at

Re: [PATCH 4.12] brcmfmac: move brcmf_txcomplete function to fwsignal.c

Hi Rafał, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on next-20170227] [cannot apply to v4.10] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki

[PATCH] ath9k: don't trigger spectral scan when not enabled

Doing so enables the FFT generation without prior configuration, leading to an IRQ storm caused by invalid (or at least unwanted) PHY errors. Signed-off-by: Zefir Kurtisi --- drivers/net/wireless/ath/ath9k/common-spectral.c | 3 +++ 1 file changed, 3 insertions(+)

Re: [PATCH 2/2][RFC] mac80211_hwsim: Report radio addresses in NEW_RADIO/GET_RADIO

On 02/27/2017 07:26 AM, Andrew Zaborowski wrote: Hi, On 27 February 2017 at 14:27, Johannes Berg wrote: Additionally I tried to add a HWSIM_ATTR_WIPHY to report the wiphy index directly without users going through wiphy name to index mapping, but get_wiphy_idx()

Re: BUG_ON in sg code

On Mon, 2017-02-27 at 15:10 +, Ard Biesheuvel wrote: > > > because you put odata/idata on the stack. What's going on there? I > > thought we knew we can't do that? Did I miss something? > > > > It was I who missed something, obviously. Ok. I thought maybe I missed a plan to actually make

Re: [PATCH 1/2] mac80211_hwsim: Make sure NEW_RADIO contains final name

> > [HWSIM_ATTR_RADIO_NAME] = { .type = NLA_STRING }, > > > > enforces that a NUL byte *must* be present when userspace gives us > > the > > information, so we're save - just asymmetric. > > It seems that would be NLA_NUL_STRING, whlie for NLA_STRING it's > optional, Oops. I indeed

Re: [PATCH 1/3] cfg80211: Make pre-CAC results valid only for ETSI domain

On Mon, 2017-02-20 at 16:09 +0530, Vasanthakumar Thiagarajan wrote: > DFS requirement for ETSI domain (section 4.7.1.4 in > ETSI EN 301 893 V1.8.1) is the only one which explicitly > states that once DFS channel is marked as available afer > the CAC, this channel will remain in available state

Re: [PATCH 2/2][RFC] mac80211_hwsim: Report radio addresses in NEW_RADIO/GET_RADIO

Hi, On 27 February 2017 at 14:27, Johannes Berg wrote: >> Additionally I tried to add a HWSIM_ATTR_WIPHY to report the wiphy >> index directly without users going through wiphy name to index >> mapping, but get_wiphy_idx() is internal to cfg80211. The index is >>

BUG_ON in sg code

Hi Ard, Apologies for the non-follow-up - couldn't find the original patch. Your patch "crypto: ccm - switch to separate cbcmac driver" causes a BUG_ON when virtual stacks are used, in crypto_ccm_auth() is called, because you put odata/idata on the stack. What's going on there? I thought we knew

Re: [PATCH 160/306] mac80211-hwsim: add rate-limited debugging for rx-netlink

On Fri, 2017-02-24 at 07:27 -0800, Ben Greear wrote: > > On 02/23/2017 10:39 PM, Johannes Berg wrote: > > > > > + !info->attrs[HWSIM_ATTR_SIGNAL]) { > > > + if (net_ratelimit()) > > > + printk(KERN_DEBUG " hwsim rx-nl: Missing > > > required attribute\n"); > > > >

Re: [PATCH 1/2] mac80211_hwsim: Make sure NEW_RADIO contains final name

Hi, On 27 February 2017 at 14:24, Johannes Berg wrote: > On Fri, 2017-02-24 at 01:08 +0100, Andrew Zaborowski wrote: >> Also related to this I find that the HWSIM_ATTR_RADIO_NAME attributes >> emitted contain the name string and are exactly of the right length >> while

Re: [PATCH] mac80211: Print text for disassociation reason

On Wed, 2017-02-15 at 14:21 +0100, Arkadiusz Miśkiewicz wrote: > When disassociation happens only numeric reason is printed > in ieee80211_rx_mgmt_disassoc(). Add text variant, too. Applied, thanks. johannes

Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

On Fri, 2017-02-24 at 11:58 -0800, Alexis Green wrote: > From: Jesse Jones > > Changes since v1: Only flush tx queue if interface is mesh mode. >   This prevents kernel panics due to uninitialized spin_lock. > > When more than one station hears a broadcast request, it is

Re: [PATCH 2/2][RFC] mac80211_hwsim: Report radio addresses in NEW_RADIO/GET_RADIO

> Additionally I tried to add a HWSIM_ATTR_WIPHY to report the wiphy > index directly without users going through wiphy name to index > mapping, but get_wiphy_idx() is internal to cfg80211.  The index is > exposed to userspace and is more useful than the name so I wonder if > this function should

ANNOUNCE: Netdev 2.1 update Feb 27

A few announcements: 1) The CFP is now officially closed. Thanks to everyone who submitted. 2) We are extending the early registration to March 5. Register early so we can plan better (and so you can save some $$). https://onlineregistrations.ca/netdev21/ - hotel (If you can get the hotel

Re: [PATCH 1/2] mac80211_hwsim: Make sure NEW_RADIO contains final name

On Fri, 2017-02-24 at 01:08 +0100, Andrew Zaborowski wrote: > On 23 February 2017 at 13:02, Andrew Zaborowski > wrote: > > ieee80211_alloc_hw_nm will validate the requested name (if any) > > before > > creating the new device and may use a name different from the one

Re: [PATCH v2] mac80211: allow overriding station bandwidth.

On Wed, 2017-02-15 at 17:16 -0800, gree...@candelatech.com wrote: > From: Ben Greear > > This allows one to disable VHT160 (or 80+80) on hardware > that might otherwise try to use it. I just decided against applying this now because of the changing VHT extended NSS BW

[PATCH 4.12] brcmfmac: move brcmf_txcomplete function to fwsignal.c

From: Rafał Miłecki This function is called by USB and SDIO only, both using BCDC & FW Signalling. Move it out of core.c to make this file more generic and allow making fwsignal optional in the future. Signed-off-by: Rafał Miłecki ---

[PATCH 4.12] brcmfmac: get rid of brcmf_txflowblock helper function

From: Rafał Miłecki This helper function is pretty trivial and we can easily do without it. What's important though it's one of FWS (Firmware Signalling) dependencies in core.c. The plan is to make FWS required by BCDC only so we don't have to use/compile it when using msgbuf.

[PATCH 0/4] brcmfmac: Remove a bunch of false positive error logs

Hi All, Here is a small series to stop brcmfmac from spamming dmesg with errors which are not really errors at all. Note the 4th patch actually contains a small behavior change rather then just changing logging, so it needs a bit of extra review attention. Regards, Hans

[PATCH 4/4] brcmfmac: Handle status == BRCMF_E_STATUS_ABORT in cfg80211_escan_handler

If a scan gets aborted BRCMF_SCAN_STATUS_BUSY gets cleared in cfg->scan_status and when we receive an abort event from the firmware the BRCMF_SCAN_STATUS_BUSY check in the cfg80211_escan_handler will trigger resulting in multiple errors getting logged. Check for a status of BRCMF_E_STATUS_ABORT

[PATCH V2 2/3] cfg80211: Disallow moving out of operating DFS channel in non-ETSI

For non-ETSI regulatory domain, CAC result on DFS channel may not be valid once moving out of that channel (as done during remain-on-channel, scannning and off-channel tx). Running CAC on an operating DFS channel after every off-channel operation will only add complexity and disturb the current

[PATCH V2 3/3] cfg80211: Share Channel DFS state across wiphys of same DFS domain

Sharing DFS channel state across multiple wiphys (radios) could be useful with multiple radios on the system. When one radio completes CAC and markes the channel available another radio can use this information and start beaconing without really doing CAC. Whenever there is a state change in dfs

[PATCH V2 1/3] cfg80211: Make pre-CAC results valid only for ETSI domain

DFS requirement for ETSI domain (section 4.7.1.4 in ETSI EN 301 893 V1.8.1) is the only one which explicitly states that once DFS channel is marked as available afer the CAC, this channel will remain in available state even moving to a different operating channel. But the same is not explicitly

[PATCH V2 0/3] Pre-CAC and sharing DFS state across multiple radios

Currently irrespective of dfs domain and radar detection activity pre-CAC results for a wiphy are retained till the wiphy is detroyed. This may not be preferred in non-ETSI dfs domain where pre-CAC is not explicitly mentioned in the respective DFS requirement spec. This patch set modifies the

Subcarrier nulling in ath9k

Hi, Is it possible to null specific subcarriers through the ath9k driver code or ath9k firmware? Or is it completely done at the hardware? Any help is appreciated. Thanks, GN

Re: [PATCH] NFC: remove TI nfcwilink driver

Hi Rob, On Wed, Jan 25, 2017 at 04:23:07PM -0600, Rob Herring wrote: > It appears that TI WiLink devices including NFC (WL185x/WL189x) never > shipped. The only information I found were announcements in Feb > 2012 about the parts. There's been no activity on this driver besided > common changes

Re: [PATCH resend 1/4] nfc: Add support RC-S380P to port100

Hi Hirofumi, On Sat, Feb 04, 2017 at 10:15:22AM +0900, OGAWA Hirofumi wrote: > > > Signed-off-by: OGAWA Hirofumi > --- > > drivers/nfc/port100.c |8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) All 4 patches applied, thanks. Cheers, Samuel.

Re: [PATCH] NFC: remove TI nfcwilink driver

Hi Rob, On Fri, Feb 24, 2017 at 02:56:48PM -0600, Rob Herring wrote: > On Wed, Jan 25, 2017 at 11:54 PM, Marcel Holtmann wrote: > > Hi Rob, > > > >> It appears that TI WiLink devices including NFC (WL185x/WL189x) never > >> shipped. The only information I found were

RE: [PATCHv2 0/4] cfg80211: mac80211: BTCOEX feature support

Hi Arend, > > > > This patchset add support for BTCOEX feature to enable/disable and > > modifying btcoex priority value via nl80211 > > > > Tamizh chelvam (4): > > ath10k: Add support to enable or disable btcoex via nl80211 > > ath10k: Add support to update btcoex priority value via nl80211

[PATCH 2/4] brcmfmac: p2p and normal ap access are not always possible at the same time

The firmware responding with -EBUSY when trying to add an extra virtual-if is a normal thing, do not print an error for this. Signed-off-by: Hans de Goede --- .../net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c| 14 ++

[PATCH 3/4] brcmfmac: Do not complain about country code "00"

The country code gets set to "00" by default at boot, ignore this rather then logging an error about it. Signed-off-by: Hans de Goede --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH 1/4] brcmfmac: Do not print the firmware version as an error

Using pr_err for things which are not errors is a bad idea. E.g. it will cause the plymouth bootsplash screen to drop back to the text console so that the user can see the error, which is not what we normally want to happen. Instead add a new brcmf_info macro and use that. Signed-off-by: Hans de