RE: [RFCv2 2/2] mac80211: Implement data xmit for 802.11 encap offload

2017-03-20 Thread Manikanta Pubbisetty
Hi, >[Manikanta] In that case I will keep this change, should we consider a separate >driver hook for legacy/mgmt tx like drv_tx_8023?? >> How about having wake_tx_queue_8023 and ieee80211_tx_dequeue_8023 >so >> that Ethernet transmit path is totally exclusive. Thoughts?? > >I'm not sure this will

Re: [PATCH v2 1/5] NFC: st21nfca: Fix obvious typo when check error code

2017-03-20 Thread Christophe Ricard
Hi Andy, The patch looks good to me. The device got enumerated via ACPI on development platforms for integration tests purposes. Best Regards Christophe On 17/03/2017 08:49, Andy Shevchenko wrote: On Tue, 2017-03-07 at 12:25 +0200, Andy Shevchenko wrote: We return -ENODEV if ACPI provides

[PATCH 3/3] soc: qcom: smd-rpm: Add msm8996 compatibility

2017-03-20 Thread Bjorn Andersson
With the RPM driver transitioned to RPMSG we can reuse the SMD-RPM driver ontop of GLINK for 8996, without any modifications. Signed-off-by: Bjorn Andersson --- drivers/soc/qcom/smd-rpm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c

[PATCH 1/3] soc: qcom: smd: Transition client drivers from smd to rpmsg

2017-03-20 Thread Bjorn Andersson
By moving these client drivers to use RPMSG instead of the direct SMD API we can reuse them ontop of the newly added GLINK wire-protocol support found in the 820 and 835 Qualcomm platforms. As the new (RPMSG-based) and old SMD implementations are mutually exclusive we have to change all client dri

[PATCH 2/3] soc: qcom: smd: Remove standalone driver

2017-03-20 Thread Bjorn Andersson
Remove the standalone SMD implementation as we have transitioned the client drivers to use the RPMSG based one. Also remove all dependencies on QCOM_SMD from Kconfig files, in order to keep them selectable in the absence of the removed symbol. Signed-off-by: Bjorn Andersson --- Based on v4.11-r

[PATCH v3] rt2x00: add support for MT7620

2017-03-20 Thread Daniel Golle
From: Roman Yeryomin Basic support for MT7620 built-in wireless radio was added to OpenWrt in r41441. It has seen some heavy cleaning and refactoring since in order to match the Kernel's code quality standards. Signed-off-by: Roman Yeryomin Signed-off-by: Daniel Golle Acked-by: Stanislaw Grusz

Re: ath10k monitor mode issue

2017-03-20 Thread Alexis Green
As far as I understand, only CT firmware provides per-packet information about TX rate at the moment. http://www.candelatech.com/ath10k-10.4.php Best regards, Alexis On Mon, Mar 20, 2017 at 11:00 AM, Matteo Grandi wrote: > Hello all, > > I have an issue to collect tx/rx bitrates using ath10k. >

Re: [PATCH 1/7] Documentation: dt: net: Update the ath9k binding for SoC devices

2017-03-20 Thread Rob Herring
On Mon, Mar 13, 2017 at 10:05:09PM +0100, Alban wrote: > The current binding only cover PCI devices so extend it for SoC devices. > > Most SoC platforms use an MTD partition for the calibration data > instead of an EEPROM. The qca,no-eeprom property was added to allow > loading the EEPROM content

Re: [4/4] mwifiex: pcie: de-duplicate buffer allocation code

2017-03-20 Thread Brian Norris
Hi Kalle, On Mon, Mar 20, 2017 at 05:08:35PM +, Kalle Valo wrote: > Brian Norris wrote: > > This code was duplicated as part of the PCIe FLR code added to this > > driver. Let's de-duplicate it to: > > > > * make things easier to read (mwifiex_pcie_free_buffers() now has a > >correspond

Re: [NetDev-tech] [NetDev] [Netdev ANNOUNCE]: New tc workshop accepted

2017-03-20 Thread Pablo Neira Ayuso
On Mon, Mar 20, 2017 at 06:56:44PM +, Mathieu Desnoyers wrote: > Hi Jamal, > > So, the interesting thing is that I've been automatically > re-subscribed to peo...@netdevconf.org about 1 day after > I explicitly unsubscribed. What do I need to do to stop > receiving those unsolicited emails ?

Re: [NetDev] [Netdev ANNOUNCE]: New tc workshop accepted

2017-03-20 Thread Mathieu Desnoyers
Hi Jamal, So, the interesting thing is that I've been automatically re-subscribed to peo...@netdevconf.org about 1 day after I explicitly unsubscribed. What do I need to do to stop receiving those unsolicited emails ? Best regards, Mathieu - On Mar 20, 2017, at 1:32 PM, Jamal Hadi Salim j.

Re: [BUG] with a 4.10.x kernel it's impossible to apply country regulatory rules

2017-03-20 Thread Larry Finger
On 03/18/2017 02:45 PM, Johannes Berg wrote: On Sat, 2017-03-18 at 12:41 -0500, Larry Finger wrote: I have duplicated your bug and I have bisected it to commit 2ae0f17df1cd52aafd1ab0415ea1f1dd56dc0e2a Author: Johannes Berg Date: Mon Oct 24 14:40:04 2016 +0200 genetlink: use idr to tra

ath10k monitor mode issue

2017-03-20 Thread Matteo Grandi
Hello all, I have an issue to collect tx/rx bitrates using ath10k. I want to collect Tx/RX statistics on a mesh network using compexWLE900VX Wi-Fi miniPCIe adapters chipset QCA9884 (QCA988X) with ath10k firmware firmware-5.bin_10.2.4.70.59-2. The OS is Ubuntu 14.04 kernel 3.14.48 backports 4.4.2.

Re: [1/5] brcmfmac: move brcmf_txflowblock to bcdc layer

2017-03-20 Thread Kalle Valo
Arend Van Spriel wrote: > From: Franky Lin > > brcmf_txflowblock is invoked by sdio and usb bus module which are using > bcdc protocol. This patch makes it a bcdc API instead of a core module > function. > > Reviewed-by: Arend Van Spriel > Signed-off-by: Franky Lin > Signed-off-by: Arend van

Re: Wireless failed

2017-03-20 Thread Fernanda Vejar
Hello Larry, ok thank you, I will consider your advice. I run: "cp iwlwifi-2030-6.ucode /lib/firmware". I checked it out and it was right copied into the folder. Fernanda 2017-03-20 14:33 GMT-03:00 Larry Finger : > On 03/20/2017 11:46 AM, Fernanda Vejar wrote: >> >> Hello Larry, >> >> thank y

Re: Wireless failed

2017-03-20 Thread Larry Finger
On 03/20/2017 11:46 AM, Fernanda Vejar wrote: Hello Larry, thank you very much for your fast answer. Buy running "modinfo iwlwifi": filename: /lib/modules/3.13.0-112-lowlatency/updates/drivers/net/wireless/iwlwifi/iwlwifi.ko version:iwlwifi-stack-public:release/LinuxCore5:3714:27076532

[Netdev ANNOUNCE]: New tc workshop accepted

2017-03-20 Thread Jamal Hadi Salim
The tech committee would like to announce a new accepted workshop. Jamal Hadi Salim will chair the Traffic Control (tc) workshop Details are as follows: - Face to Face discussions on different tc topics Current WAG agenda (subject to update): New tc offloads since netdev 1.2 New features/r

Re: rt2x00: add support for MT7620

2017-03-20 Thread Kalle Valo
Daniel Golle wrote: > From: Roman Yeryomin > > Basic support for MT7620 built-in wireless radio was added to > OpenWrt in r41441. It has seen some heavy cleaning and refactoring > since in order to match the Kernel's code quality standards. > > Signed-off-by: Roman Yeryomin > Signed-off-by: Da

Re: [1/4] rtlwifi: Update 8821ae new phy parameters and its parser.

2017-03-20 Thread Kalle Valo
Larry Finger wrote: > From: Ping-Ke Shih > > There are new PHY table values for the RTL8821AE. The changes require > new parsing code. > > Signed-off-by: Ping-Ke Shih > Signed-off-by: Larry Finger 4 patches applied to wireless-drivers-next.git, thanks. 84d26fda52e2 rtlwifi: Update 8821ae ne

Re: rt2x00: fix TX_PWR_CFG_4 register definition

2017-03-20 Thread Kalle Valo
Daniel Golle wrote: > Some of the macros used to describe the TX_PWR_CFG_4 register accidentally > refer to TX_PWR_CFG_3, probably a copy&paste error. Fix that. > > Signed-off-by: Daniel Golle > Acked-by: Stanislaw Gruszka Patch applied to wireless-drivers-next.git, thanks. 5ce33b603063 rt2x0

Re: ipw2200: remove redundant check of rc < 0

2017-03-20 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > The check for rc < 0 is always false so the check is redundant > and can be removed. > > Detected with CoverityScan, CID#101143 ("Logically dead code") > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 889c

Re: [v3,1/3] brcmfmac: Do not print the firmware version as an error

2017-03-20 Thread Kalle Valo
Hans de Goede wrote: > Using pr_err for things which are not errors is a bad idea. E.g. it > will cause the plymouth bootsplash screen to drop back to the text > console so that the user can see the error, which is not what we > normally want to happen. > > Instead add a new brcmf_info macro and

Re: brcmfmac: always print error when PSM's watchdog fires

2017-03-20 Thread Kalle Valo
Rafał Miłecki wrote: > From: Rafał Miłecki > > So far we were attaching BRCMF_E_PSM_WATCHDOG event listener in > brcmf_debug_attach which gets compiled only with CONFIG_BRCMDBG. This > event means something went wrong and firmware / hardware usually can't > be expected to work (reliably). > > Su

Re: mwifiex: pcie: clean up error prints in mwifiex_pcie_reset_notify()

2017-03-20 Thread Kalle Valo
Brian Norris wrote: > We shouldn't be printing a kernel pointer as a decimal integer. But we > really shouldn't be printing this case at all; we should never get here > with NULL drvdata. We've eliminated this unnecessary conditional in > several other places, so kill it here too. > > Similarly,

Re: [4.12,1/2] bcma: use helper function to set core dev's parent

2017-03-20 Thread Kalle Valo
Rafał Miłecki wrote: > From: Rafał Miłecki > > A tiny code deduplication thanks to the bcma_bus_get_host_dev. > > Signed-off-by: Rafał Miłecki 2 patches applied to wireless-drivers-next.git, thanks. 5e48a4cd2ee9 bcma: use helper function to set core dev's parent f825f6ed20e3 bcma: fill core O

Re: [4.12] bcma: drop unneeded check for CONFIG_OF_IRQ

2017-03-20 Thread Kalle Valo
Rafał Miłecki wrote: > From: Rafał Miłecki > > We already have the same check in bcma_of_get_irq which really calls > symbols available with CONFIG_OF_IRQ only. It appears this duplicated > check was accidentally added in commit c58d900cc96a ("bcma: fix building > without OF_IRQ"). The rest of co

Re: [v3] mwifiex: fix kernel crash after shutdown command timeout

2017-03-20 Thread Kalle Valo
Brian Norris wrote: > We observed a SHUTDOWN command timeout during reboot stress test due to > a corner case firmware bug. It can lead to either a use-after-free + > OOPS (on either the adapter structure, or the 'card' structure) or an > abort (where, e.g., the PCI device is "disabled" before we'

Re: [4/4] mwifiex: pcie: de-duplicate buffer allocation code

2017-03-20 Thread Kalle Valo
Brian Norris wrote: > This code was duplicated as part of the PCIe FLR code added to this > driver. Let's de-duplicate it to: > > * make things easier to read (mwifiex_pcie_free_buffers() now has a >corresponding mwifiex_pcie_alloc_buffers()) > * reduce likelihood of bugs > * make error lo

Re: mwifiex: send fewer channels to scan while connected

2017-03-20 Thread Kalle Valo
Amitkumar Karwar wrote: > Application triggers periodic background scans when device is connected. > We will scan less number of channels per scan command so that data > traffic won't get affected. > > Signed-off-by: Amitkumar Karwar Patch applied to wireless-drivers-next.git, thanks. 0a5cc497

Re: [v2,1/3] mwifiex: add qualifier to firmware structures

2017-03-20 Thread Kalle Valo
Ganapathi Bhat wrote: > From: Karthik Ananthapadmanabha > > Adding qualifier "__packed" indicates that no padding should be > performed on the qualified object for alignment. > This patch adds qualifier __packed to the required firmware > structures in mwifiex driver. > > Signed-off-by: Karthik

Re: [3/3] mwifiex: wake system up when receives a wake irq

2017-03-20 Thread Kalle Valo
Jeffy Chen wrote: > Currrently we are disabling this wake irq after receiving it. If this > happens before we finish suspend and the pm event check is disabled, > the system will continue suspending, and this irq would not work again. > > We may need to abort system suspend to avoid that. > > Si

Re: atmel: remove time_t usage

2017-03-20 Thread Kalle Valo
Alexandre Belloni wrote: > last_qual never really holds a time. It only holds jiffies. Make it the > same type as jiffies. > > Signed-off-by: Alexandre Belloni Patch applied to wireless-drivers-next.git, thanks. 5c5105666de5 atmel: remove time_t usage -- https://patchwork.kernel.org/patch/95

Re: Wireless failed

2017-03-20 Thread Fernanda Vejar
Hello Larry, thank you very much for your fast answer. Buy running "modinfo iwlwifi": filename: /lib/modules/3.13.0-112-lowlatency/updates/drivers/net/wireless/iwlwifi/iwlwifi.ko version:iwlwifi-stack-public:release/LinuxCore5:3714:27076532 license:GPL author: Copyright(c)

Re: [PATCH v2] mac80211: Jitter HWMP MPATH reply frames to reduce collision on dense networks.

2017-03-20 Thread Thomas Pedersen
On Thu, Mar 2, 2017 at 9:41 AM, Jesse Jones wrote: >> Hi Alexis, >> >> > This is loosely based on RFC5148, specifically event-triggered message >> > generation as described in section 5.2. >> >> I'm confused. I see how that generally seems to apply to any mobile >> network, but it *does* state up-

Re: [PATCH 1/2] dt: bindings: add new dt entry for ath10k calibration variant

2017-03-20 Thread Adrian Chadd
Vendors using ath10k will like this. I mean, I'm using ath10k, and I really like this moving forward. This will make life so much easier in the long run. Everyone else isn't using board-2.bin; they're just copying calibration/board data files over so the reference driver can assemble a board data

Re: [PATCH 1/2] dt: bindings: add new dt entry for ath10k calibration variant

2017-03-20 Thread Sven Eckelmann
On Montag, 20. März 2017 10:07:33 CET Rob Herring wrote: > On Fri, Mar 10, 2017 at 09:06:14AM +0100, Sven Eckelmann wrote: > > The bus + bmi-chip-id + bmi-board-id is not enough to identify the correct > > board data file on QCA4019 based devices. Multiple different boards share > > the same values

Re: Wireless failed

2017-03-20 Thread Larry Finger
On 03/20/2017 10:10 AM, Fernanda Vejar wrote: Hello Larry, thank you very much for your response. I'm using "Trisquel 7.0 LTS Belenos" since a few days. My kernel version is acoording to "uname -r" : "3.13.0-112-lowlatency". By "lspci --n"n I have found : "01:00.0 Network controller [0280]: Int

Re: [PATCH 1/2] dt: bindings: add new dt entry for ath10k calibration variant

2017-03-20 Thread Rob Herring
On Fri, Mar 10, 2017 at 09:06:14AM +0100, Sven Eckelmann wrote: > The bus + bmi-chip-id + bmi-board-id is not enough to identify the correct > board data file on QCA4019 based devices. Multiple different boards share > the same values. Only the original reference designs can currently be > identifi

Re: ath6kl: Remove old 802.11a-only channels

2017-03-20 Thread Kalle Valo
Rostyslav Khudolii wrote: > Channels 34/38/42/46 can only be used for compatibility with old devices sold > in Japan. Modern products, such as AR6003/AR6004 don't support these channels. > Keeping them in the upstream is error prone and requires full network stack > support. A custom patch should

Re: ath10k: remove redundant check of len with buf_len

2017-03-20 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > The check of len > buf_len is redundant as len is initialized > to 0 and buf_len to 4096, so this comparison is always false. > Remove it. > > Signed-off-by: Colin Ian King Patch applied to ath-next branch of ath.git, thanks. eed4721fb617 ath1

Re: ath10k: Fix typo in wmi header file

2017-03-20 Thread Kalle Valo
Mohammed Shafi Shajakhan wrote: > From: Mohammed Shafi Shajakhan > > Fix typo(spelling mistake) in wmi.h > > Signed-off-by: Mohammed Shafi Shajakhan Patch applied to ath-next branch of ath.git, thanks. 0a7d88e432e7 ath10k: fix typo in wmi header file -- https://patchwork.kernel.org/patch/9

[PATCH] ath10k: Fix NAPI enable/disable symmetry for AHB interface

2017-03-20 Thread Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan Move NAPI enable to 'ath10k_ahb_hif_start' from 'ath10k_ahb_hif_power_up'. This is to maintain the symmetry of calling napi_enable() from ath10k_ahb_hif_start() so that it matches with napi_disable() being called from ath10k_pci_hif_stop(). This change is based on

Re: ath10k: fix warnings from an earlier commit

2017-03-20 Thread Kalle Valo
Kalle Valo wrote: > I failed to notice that commit 523f6701dbab ("ath10k: update available channel > list for 5G radio") added two new warnings: > > drivers/net/wireless/ath/ath10k/mac.c:3129:6: warning: symbol > 'ath10k_mac_update_channel_list' was not declared. Should it be static? > drivers/n

Re: Wireless failed

2017-03-20 Thread Fernanda Vejar
Hello Larry, thank you very much for your response. I'm using "Trisquel 7.0 LTS Belenos" since a few days. My kernel version is acoording to "uname -r" : "3.13.0-112-lowlatency". By "lspci --n"n I have found : "01:00.0 Network controller [0280]: Intel Corporation Centrino Wireless-N 2230 [8086:08

Re: [PATCH] MAINTAINERS: Add the DT binding to the ath9k file list

2017-03-20 Thread Kalle Valo
Alban writes: > Changes to the DT binding should also be sent to the ath9k list. > > Signed-off-by: Alban Use your full name, please. > diff --git a/MAINTAINERS b/MAINTAINERS > index c776906..ca5a560 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -10370,6 +10370,7 @@ L:linux-wireless@

Re: [4.11] ath10k: fix incorrect wlan_mac_base in qca6174_regs

2017-03-20 Thread Kalle Valo
Ryan Hsu wrote: > From: Ryan Hsu > > In the 'commit ebee76f7fa46 ("ath10k: allow setting coverage class")', > it inherits the design and the address offset from ath9k, but the address > is not applicable to QCA6174, which leads to a random crash while doing the > resume() operation, since the se

Re: [PATCH] staging: wilc1000: Fix sparse warning in wilc_wfi_cfgoperations.c

2017-03-20 Thread Dan Carpenter
On Sun, Mar 19, 2017 at 11:17:08PM -0700, Jacob Zachariah wrote: > Fix the following warning reported by sparse: > > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51: warning: incorrect > type in assignment (different base types) > drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:5