Re: [PATCH 2/2] cfg80211: Add support for FILS shared key authentication offload

2017-03-30 Thread Johannes Berg
On Fri, 2017-03-31 at 00:22 +0300, Jouni Malinen wrote: > From: Vidyullatha Kanchanapally > > Enhance nl80211 and cfg80211 connect request and response APIs to > support FILS shared key authentication offload. The new nl80211 > attributes can be used to provide additional information to the > dri

Re: [PATCH 1/2] cfg80211: Use a structure to pass connect response params

2017-03-30 Thread Johannes Berg
On Fri, 2017-03-31 at 00:22 +0300, Jouni Malinen wrote: > From: Vidyullatha Kanchanapally > > Currently the connect event from driver takes all the connection > response parameters as arguments. With support for new features these > response parameters can grow. Use a structure to pass these > pa

pull-request: mac80211 2017-03-31

2017-03-30 Thread Johannes Berg
Hi Dave, Before netconf, I figured I'd get these two fixes to you, at least I wanted to have them out of the way. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit b768b16de58d5e0b1d7c3f936825b25327ced20c: openvswitch: Fix refcount leak

Re: [RESEND] ath9k failure to authenticate WPA2 client mode

2017-03-30 Thread Tim Harvey
On Thu, Mar 30, 2017 at 9:22 AM, Tim Harvey wrote: > On Wed, Mar 29, 2017 at 10:54 PM, Janusz Dziedzic > wrote: >> On 29 March 2017 at 19:03, Tim Harvey wrote: >>> Greetings, >>> >>> (resending plaintext - oops) >>> >>> I'm seeing failures to authenticate with a WPA2 secured AP using ath9k >>> b

[PATCH] ath6kl: Add __printf verification to ath6kl_dbg

2017-03-30 Thread Joe Perches
Fix fallout too. Signed-off-by: Joe Perches --- drivers/net/wireless/ath/ath6kl/debug.h| 2 ++ drivers/net/wireless/ath/ath6kl/htc_pipe.c | 2 +- drivers/net/wireless/ath/ath6kl/wmi.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/

[PATCH 2/2] cfg80211: Add support for FILS shared key authentication offload

2017-03-30 Thread Jouni Malinen
From: Vidyullatha Kanchanapally Enhance nl80211 and cfg80211 connect request and response APIs to support FILS shared key authentication offload. The new nl80211 attributes can be used to provide additional information to the driver to establish a FILS connection. Also enhance the set/del PMKSA t

[PATCH 1/2] cfg80211: Use a structure to pass connect response params

2017-03-30 Thread Jouni Malinen
From: Vidyullatha Kanchanapally Currently the connect event from driver takes all the connection response parameters as arguments. With support for new features these response parameters can grow. Use a structure to pass these parameters rather than passing them as function arguments. Signed-off

Re: [for-4.11, 1/2] brcmfmac: use local iftype avoiding use-after-free of virtual interface

2017-03-30 Thread Kalle Valo
Arend Van Spriel wrote: > A use-after-free was found using KASAN. In brcmf_p2p_del_if() the virtual > interface is removed using call to brcmf_remove_interface(). After that > the virtual interface instance has been freed and should not be referenced. > Solve this by storing the nl80211 iftype in

Re: rtlwifi: Fix scheduling while atomic splat

2017-03-30 Thread Kalle Valo
Larry Finger wrote: > Following commit cceb0a597320 ("rtlwifi: Add work queue for c2h cmd."), > the following BUG is reported when rtl8723be is used: > > BUG: sleeping function called from invalid context at mm/slab.h:432 > in_atomic(): 1, irqs_disabled(): 1, pid: 0, name: swapper/0 > CPU: 0 PID:

Re: pull-request: iwlwifi 2017-03-29

2017-03-30 Thread Kalle Valo
Luca Coelho writes: > Hi Kalle, > > Here are some fixes for 4.11. More details in the tag description. > > I have sent this out before and kbuildbot didn't find any issues. > > Cheers, > Luca. > > > The following changes since commit 6be3b6cce1e225f189b68b4e84fc711d19b4277b: > > ath10k: fix in

Re: [RESEND] ath9k failure to authenticate WPA2 client mode

2017-03-30 Thread Tim Harvey
On Wed, Mar 29, 2017 at 10:54 PM, Janusz Dziedzic wrote: > On 29 March 2017 at 19:03, Tim Harvey wrote: >> Greetings, >> >> (resending plaintext - oops) >> >> I'm seeing failures to authenticate with a WPA2 secured AP using ath9k >> based cards on wireless-next: >> >> root@xenial-armhf:~# wpa_pas

Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

2017-03-30 Thread poma
On 30.03.2017 16:06, Jes Sorensen wrote: > On 03/30/2017 03:15 AM, Greg Kroah-Hartman wrote: >> On Wed, Mar 29, 2017 at 08:20:19PM -0500, Larry Finger wrote: >>> On 03/29/2017 12:47 PM, Hans de Goede wrote: The rtl8723bs is found on quite a few systems used by Linux users, such as on Atom

Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

2017-03-30 Thread Jes Sorensen
On 03/30/2017 03:15 AM, Greg Kroah-Hartman wrote: On Wed, Mar 29, 2017 at 08:20:19PM -0500, Larry Finger wrote: On 03/29/2017 12:47 PM, Hans de Goede wrote: The rtl8723bs is found on quite a few systems used by Linux users, such as on Atom systems (Intel Computestick and various other Atom base

[PATCH] mwifiex: apply radar flag

2017-03-30 Thread Amitkumar Karwar
From: Karthik D A When IEEE80211_CHAN_RADAR is set by cfg80211, passive scan must be performed. In mwifiex,active scan is performed even though flag is set from cfg80211. mwifiex_reg_apply_radar_flags() function added in this patch correctly uses radar flag. Signed-off-by: Karthik D A Signed-of

[PATCH v2 1/8] NFC: fix broken device allocation

2017-03-30 Thread Johan Hovold
Commit 7eda8b8e9677 ("NFC: Use IDR library to assing NFC devices IDs") moved device-id allocation and struct-device initialisation from nfc_allocate_device() to nfc_register_device(). This broke just about every nfc-device-registration error path, which continue to call nfc_free_device() that trie

[PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes

2017-03-30 Thread Johan Hovold
This started out with the observation that the nfcmrvl_uart driver unconditionally dereferenced the tty class device despite the fact that not every tty has an associated struct device (Unix98 ptys). Some further changes were needed in the common nfcmrvl code to fully address this, some of which al

[PATCH v2 3/8] NFC: nfcmrvl: do not use device-managed resources

2017-03-30 Thread Johan Hovold
This specifically fixes resource leaks in the registration error paths. Device-managed resources is a bad fit for this driver as devices can be registered from the n_nci line discipline. Firstly, a tty may not even have a corresponding device (should it be part of a Unix98 pty) something which wou

[PATCH v2 2/8] NFC: nfcmrvl_uart: add missing tty-device sanity check

2017-03-30 Thread Johan Hovold
Make sure to check the tty-device pointer before trying to access the parent device to avoid dereferencing a NULL-pointer when the tty is one end of a Unix98 pty. Fixes: e097dc624f78 ("NFC: nfcmrvl: add UART driver") Cc: stable # 4.2 Cc: Vincent Cuissard Signed-off-by: Johan Hovold --- dri

[PATCH v2 8/8] NFC: nfcmrvl: allow gpio 0 for reset signalling

2017-03-30 Thread Johan Hovold
Allow gpio 0 to be used for reset signalling, and instead use negative errnos to disable the reset functionality. Signed-off-by: Johan Hovold --- drivers/nfc/nfcmrvl/main.c| 9 - include/linux/platform_data/nfcmrvl.h | 2 +- 2 files changed, 5 insertions(+), 6 deletions(-) d

[PATCH v2 7/8] NFC: nfcmrvl_usb: use interface as phy device

2017-03-30 Thread Johan Hovold
Use the USB-interface rather than parent USB-device device, which is what this driver binds to, when registering the nci device. Note that using the right device is important when dealing with device- managed resources as the interface can be unbound independently of the parent device. Also note

[PATCH v2 4/8] NFC: nfcmrvl: use nfc-device for firmware download

2017-03-30 Thread Johan Hovold
Use the nfc- rather than phy-device in firmware-management code that needs a valid struct device. This specifically fixes a NULL-pointer dereference in nfcmrvl_fw_dnld_init() during registration when the underlying tty is one end of a Unix98 pty. Note that the driver still uses the phy device for

[PATCH v2 5/8] NFC: nfcmrvl: fix firmware-management initialisation

2017-03-30 Thread Johan Hovold
The nci-device was never deregistered in the event that fw-initialisation failed. Fix this by moving the firmware initialisation before device registration since the firmware work queue should be available before registering. Note that this depends on a recent fix that moved device-name initialis

[PATCH v2 6/8] NFC: nfcmrvl_uart: fix device-node leak during probe

2017-03-30 Thread Johan Hovold
Make sure to release the device-node reference when done parsing the node. Fixes: e097dc624f78 ("NFC: nfcmrvl: add UART driver") Cc: Vincent Cuissard Signed-off-by: Johan Hovold --- drivers/nfc/nfcmrvl/uart.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/nfc/nfcmrvl/uart.c b/dr

Re: [PATCH] brcmfmac: wrap brcmf_fws_(de)init into bcdc layer

2017-03-30 Thread Arend Van Spriel
On 29-3-2017 13:27, Rafał Miłecki wrote: > On 03/22/2017 08:43 PM, Arend Van Spriel wrote: >> On 21-3-2017 14:44, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> fwsignal is only used by bcdc. Create new protocol interface functions >>> for core code to perform proto specific (de)initializa

[PATCH 1/3] mwifiex: remove unnecessary wakeup interrupt number sanity check

2017-03-30 Thread Xinming Hu
From: Xinming Hu Sanity check of interrupt number in interrupt handler is unnecessary and confusion, remove it. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/main.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a

[PATCH 3/3] mwifiex: pcie: avoid hardcode wifi-only firmware name

2017-03-30 Thread Xinming Hu
From: Xinming Hu Wifi-only firmware name should be chipset specific. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/pcie.c | 8 +++- drivers/net/wireless/marvell/mwifiex/pcie.h | 6 ++ 2 files changed, 13 insertions(+), 1 deletion(-)

[PATCH 2/3] mwifiex: using general print function during device intialization

2017-03-30 Thread Xinming Hu
From: Xinming Hu adapter->dev is initialized after mwifiex_register done, before that print message by general pr_* function Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- drivers/net/wireless/marvell/mwifiex/pcie.c | 78 - drivers/net/wireless/marve

Re: [PATCH 2/5] brcmfmac: move brcmf_fws_deinit to bcdc layer

2017-03-30 Thread Arend Van Spriel
On 29-3-2017 13:23, Rafał Miłecki wrote: > On 03/28/2017 12:43 PM, Arend van Spriel wrote: >> From: Franky Lin >> >> Move brcmf_fws_deinit into brcmf_proto_bcdc_detach since it is a bcdc >> exclusive feature. >> >> Signed-off-by: Franky Lin >> Change-Id: Iefa5db632b92185a49d538b1cd25b7d8be618ce0

Re: [PATCH 1/5] brcmfmac: wrap brcmf_fws_init into bcdc layer

2017-03-30 Thread Arend Van Spriel
On 29-3-2017 13:18, Rafał Miłecki wrote: > On 03/28/2017 12:43 PM, Arend van Spriel wrote: >> From: Franky Lin >> >> Create a new protocol layer interface brcmf_proto_init_cb for protocol >> layer to finish initialzation after core module components(fweh and >> etc.) are initialized. >> >> Signed-

Re: wlan0 keeps deauthenticating DEAUTH_LEAVING about every minute

2017-03-30 Thread Johannes Berg
On Wed, 2017-03-29 at 20:58 +0200, Arend Van Spriel wrote: > > > >   * 2437 MHz [6]  > > > Maximum TX power: 20.0 dBm > > > Channel widths: > > > > That's quite odd, why isn't it listing any possible channel > > widths?! > > Is iw not handling 20MHZ_NOHT definition? But iw i

Re: [RESEND] ath9k failure to authenticate WPA2 client mode

2017-03-30 Thread Bastian Bittorf
* Janusz Dziedzic [30.03.2017 08:26]: > On 29 March 2017 at 19:03, Tim Harvey wrote: > > I don't know when ath9k last worked honestly. I usually use them under > > OpenWrt which has its own patches against periodic updates of linux > > backports. I noticed this first with Ubuntu 16.04 with the Ub

Re: Adding a vendor Information Element to beacon / probe response frames

2017-03-30 Thread Etan Kissling
If it's on the Raspberry Pi, you'll need to use 4.10 as the patch has not been backported. You can also use the stock kernel and simply apply the patch to that one file. Thanks Etan > On 30 Mar 2017, at 09:44, Arend Van Spriel > wrote: > > + linux-wireless, brcm80211-dev-list > >> On 30-3-

Re: Adding a vendor Information Element to beacon / probe response frames

2017-03-30 Thread Arend Van Spriel
+ linux-wireless, brcm80211-dev-list On 30-3-2017 0:07, Tao Peng wrote: > Hi Arend, Etan, > > I found this email thread on the Hostap mailing list archive, and I am having > the exact same problem. It seems that you’ve identified the problem as in the > broadcom wifi chip firmware / driver. >

Re: [PATCH] staging: Add rtl8723bs sdio wifi driver

2017-03-30 Thread Greg Kroah-Hartman
On Wed, Mar 29, 2017 at 08:20:19PM -0500, Larry Finger wrote: > On 03/29/2017 12:47 PM, Hans de Goede wrote: > > The rtl8723bs is found on quite a few systems used by Linux users, > > such as on Atom systems (Intel Computestick and various other > > Atom based devices) and on many (budget) ARM boar