[PATCH 4/4] mwifiex: don't leak 'chan_stats' on reset

2017-04-14 Thread Brian Norris
'chan_stats' is (re)allocated in _mwifiex_fw_dpc() -> mwifiex_init_channel_scan_gap(), which is called whenever the device is initialized -- at probe or at reset. But we only free it in we completely unregister the adapter, meaning we leak a copy of it during every reset. Let's free it in the

[PATCH 3/4] mwifiex: pcie: clear outstanding work when resetting

2017-04-14 Thread Brian Norris
When we shut down the device (i.e., during 'reset'), we cancel any outstanding work, but we don't clear any work-related flags. This can cause problems if, e.g., we begin to queue a new firmware dump or card reset while the other one is in progress. That might leave work_flags with a stale value,

[PATCH 1/4] mwifiex: pcie: fix cmd_buf use-after-free in remove/reset

2017-04-14 Thread Brian Norris
Command buffers (skb's) are allocated by the main driver, and freed upon the last use. That last use is often in mwifiex_free_cmd_buffer(). In the meantime, if the command buffer gets used by the PCI driver, we map it as DMA-able, and store the mapping information in the 'cb' memory. However, if

[PATCH 2/4] mwifiex: reset timeout flag when resetting device

2017-04-14 Thread Brian Norris
If we reset because of a command timeout, we should reset this flag. Otherwise, we might erroneously think the next command after reset is timing out, and trigger another reset. The above behavior effectively neuters the automatic card_reset() behavior, as it means we will never recover from a

[PATCH] brcmfmac: only build fwsignal module for CONFIG_BRCMFMAC_PROTO_BCDC

2017-04-14 Thread Arend van Spriel
The fwsignal module is only referenced by the bcdc module and part of the bcdc protocol. So only build it when CONFIG_BRCMFMAC_PROTO_BCDC is selected. Fixes: acf8ac41dd73 ("brcmfmac: remove reference to fwsignal data from struct brcmf_pub") Signed-off-by: Arend van Spriel

4.10.9 nok with realtek wlan, atom

2017-04-14 Thread rupert THURNER
On Thu, Feb 9, 2017 at 9:09 PM, Larry Finger wrote: > On 02/09/2017 01:43 PM, Bjorn Helgaas wrote: >> >> [+cc rtl8192ce folks in case they've seen this] >> >> On Thu, Feb 09, 2017 at 03:45:01PM +0100, rupert THURNER wrote: >>> >>> hi, >>> >>> not technical expert

Re: [RFC 1/3] bpf/wireless: add wifimon program type

2017-04-14 Thread Alexei Starovoitov
On Wed, Apr 12, 2017 at 05:30:40PM +0200, Johannes Berg wrote: > On Wed, 2017-04-12 at 11:19 -0400, David Miller wrote: > > > > > Instead it may make more sense to just have a "wifi_info(skb, > > info)" > > > function you can call, e.g. with a structure that has various > > fields > > > and flags

Re: Re: Re: [PATCH v3 4/4] mwifiex: pcie: extract wifi part from combo firmware during function level reset

2017-04-14 Thread Brian Norris
Hi, On Fri, Apr 14, 2017 at 03:28:28AM +, Xinming Hu wrote: > According to the firmware download protocol, every CMD should not exceed > MWIFIEX_UPLD_SIZE. > we can add a sanity check , like, > if (data_len > MWIFIEX_UPLD_SIZE - sizeof(fwdata->header)) > *error* I was primarily

Re: How to debug DMAR errors?

2017-04-14 Thread Ben Greear
On 04/14/2017 09:24 AM, Alexander Duyck wrote: On Fri, Apr 14, 2017 at 9:19 AM, Ben Greear wrote: On 04/14/2017 08:45 AM, Alexander Duyck wrote: On Thu, Apr 13, 2017 at 11:12 AM, Ben Greear wrote: Hello, I have been seeing a regular

Re: How to debug DMAR errors?

2017-04-14 Thread Alexander Duyck
On Fri, Apr 14, 2017 at 9:19 AM, Ben Greear wrote: > > > On 04/14/2017 08:45 AM, Alexander Duyck wrote: >> >> On Thu, Apr 13, 2017 at 11:12 AM, Ben Greear >> wrote: >>> >>> Hello, >>> >>> I have been seeing a regular occurrence of DMAR errors,

Re: How to debug DMAR errors?

2017-04-14 Thread Ben Greear
On 04/14/2017 08:45 AM, Alexander Duyck wrote: On Thu, Apr 13, 2017 at 11:12 AM, Ben Greear wrote: Hello, I have been seeing a regular occurrence of DMAR errors, looking something like this when testing my ath10k driver/firmware under some specific loads (maximum

RE: HR department.

2017-04-14 Thread Mona Duncan
From: Mona Duncan Sent: 14 April 2017 10:08 Subject: HR department. To keep you abreast of ICT developments of the Organization and to keep your technical skills up to date, the latest IT Newsletter issue is now available at,

work as the agent of valero energy usa

2017-04-14 Thread Martin Parrish
VALERO CRUDE OIL CORPORATION USA is looking for an agent, to be our coordinator in Europe and Asia, which you will act as an intermediary between our company and the final buyer of petroleum products in those regions,Inform us if you are interested Sincerely, Martin Parrish

Re: How to debug DMAR errors?

2017-04-14 Thread Alexander Duyck
On Thu, Apr 13, 2017 at 11:12 AM, Ben Greear wrote: > Hello, > > I have been seeing a regular occurrence of DMAR errors, looking something > like this when testing my ath10k driver/firmware under some specific loads > (maximum receive of 512 byte frames in AP mode): > >

Re: [PATCH] ath9k: Add Dell Wireless 1601 with wowlan capability

2017-04-14 Thread Damien Thébault
Hello, Sorry about this, but when I first sent this patch it didn't reach the maintainers in Cc because of spam filters. My MX IP is now in spamhaus PBL whitelist so this should work this time. Add the Dell Wireless 1601 card as an AR9462 in the ath9k pci list. Note that the wowlan feature is

Greetings.

2017-04-14 Thread Sarah JOHNSON
Good Day Dearest. My name is Sarah JOHNSON I am 18 years old, the only daughter of late Mr. Raymond JOHNSON from Burkina Faso, I am contacting you to help me relocate to your country to continue my university education in your country, before my father died he gave me a deposit slip document

[PATCH v2 14/26] iwlwifi: pcie: copy TX functions to new transport

2017-04-14 Thread Luca Coelho
From: Sara Sharon This is just a copy-paste in order to make changes tracking easier. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/internal.h | 13 +

[PATCH v2 24/26] iwlwifi: pcie: prepare for dynamic queue allocation

2017-04-14 Thread Luca Coelho
From: Sara Sharon In a000 transport we will allocate queues dynamically. Right now queue are allocated as one big chunk of memory and accessed as such. The dynamic allocation of the queues will require accessing the queues as pointers. In order to keep simplicity of

[PATCH v2 16/26] iwlwifi: mvm: tell the firmware about the U-APSD parameters

2017-04-14 Thread Luca Coelho
From: Emmanuel Grumbach Newer firmware versions will be able to handle all the WMM-PS flows internally when we act as a GO. The firwmare relies on the fact that the drivers puts frames for different peers in different queues (DQA) to achieve this. The driver will not

[PATCH v2 13/26] iwlwifi: mvm: support moving to mgmt tid

2017-04-14 Thread Luca Coelho
From: Sara Sharon For a000 FW moved to 15 as management TID. The change for us is fairly local - translate old TID to 15 when enabling and disabling a queue, and make sure to cover it also on TX responses. Signed-off-by: Sara Sharon Signed-off-by:

[PATCH v2 25/26] iwlwifi: pcie: introduce new stop_device

2017-04-14 Thread Luca Coelho
From: Sara Sharon This function is basically the same as gen1, except for clean ups of old devices configuration that are never used in a000 configuration. It will also help with refactoring rf_kill later on. Signed-off-by: Sara Sharon

[PATCH v2 17/26] iwlwifi: mvm: move new API code to the end

2017-04-14 Thread Luca Coelho
From: "Goodstein, Mordechay" By moving all the code that depends on the new API we avoid unnecessary indentation in the code. Signed-off-by: Mordechai Goodstein Signed-off-by: Luca Coelho ---

[PATCH v2 21/26] iwlwifi: pcie: support host commands in new transport

2017-04-14 Thread Luca Coelho
From: Sara Sharon Code is basically the same, with a cleanups of old narrow host command, ampg workarounds, some cosmetic stuff, and usage of TFH functions when accessing TFD queues. This enables also the cleanup of iwl_pcie_tfd_set_tb() since now it won't be called

[PATCH v2 20/26] iwlwifi: pcie: rewrite TFD creation

2017-04-14 Thread Luca Coelho
From: Sara Sharon Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/tx-gen2.c | 215 +- 1 file changed, 82 insertions(+), 133 deletions(-) diff --git

[PATCH v2 11/26] iwlwifi: pcie: introduce a000 TX queues management

2017-04-14 Thread Luca Coelho
From: Sara Sharon In a000 devices the TX handling is different in a few ways: * Queues are allocated dynamically * DQA is enabled by default * Driver shouldn't access TFH registers - ucode configures it all in SCD_QUEUE_CFG command Support all this in a new API with op

[PATCH v2 22/26] iwlwifi: pcie: support new write pointer width

2017-04-14 Thread Luca Coelho
From: Sara Sharon In a000 devices we have 16 bytes for the TFD index and 16 for the queue, in order to support 512 queues. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho ---

[PATCH v2 19/26] iwlwifi: pcie: support new TX command

2017-04-14 Thread Luca Coelho
From: Sara Sharon Move to use the correct structure. Remove code referring to old command. Update DMA locations. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho ---

[PATCH v2 12/26] iwlwifi: mvm: support a000 SCD queue configuration

2017-04-14 Thread Luca Coelho
From: Sara Sharon a000 devices queue management is going to change significantly. We will have 512 queues. Those queues will be assigned number by the firmware and not by the driver. In addition, due to SN offload having TX queue shared between TIDs is impossible Also,

[PATCH v2 18/26] iwlwifi: pcie: cleanup old transport code from gen2

2017-04-14 Thread Luca Coelho
From: Sara Sharon Cleanup code that is irrelevant for a000 devices. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/internal.h | 4 -

[PATCH v2 23/26] iwlwifi: pcie: remove block and freeze operations from new transport

2017-04-14 Thread Luca Coelho
From: Sara Sharon New transport will be used only by op modes that supports buffer station offload - hence those will never be called. Clean it up. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho ---

[PATCH v2 10/26] iwlwifi: mvm: support new TX API

2017-04-14 Thread Luca Coelho
From: Sara Sharon Support the new TX command API for a000 devices. Command is a very slim version of current TX command. Generalize iwl_mvm_tx_mpdu to get rid of TX command dependencies. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho

[PATCH v2 15/26] iwlwifi: mvm: remove unnecessary debugging from UMAC scan

2017-04-14 Thread Luca Coelho
From: Luca Coelho There are several occasions where a scan of the same type is requested concurrently, so logging every time this happens is just noisy and unnecessary. Remove the logging for these cases. Signed-off-by: Luca Coelho ---

[PATCH v2 08/26] iwlwifi: mvm: spin off SAR profile selection function

2017-04-14 Thread Luca Coelho
From: Luca Coelho For dynamic SAR, we will need to select the current profile from different places. In preparation for that, spin the profile selection code out of iwl_mvm_sar_init(). Signed-off-by: Luca Coelho ---

[PATCH v2 09/26] iwlwifi: mvm: add support for EWRD (Dynamic SAR) ACPI table

2017-04-14 Thread Luca Coelho
From: Luca Coelho Dynamic SAR allows changing TX power limits at runtime to comply with SAR regulations on multiple form factors (e.g. tablet vs. clamshell mode). To support this, a new table was added to ACPI, which is called Extended Wireless Regulatory Descriptor

[PATCH v2 04/26] iwlwifi: mvm: prepare for station count change

2017-04-14 Thread Luca Coelho
From: Sara Sharon In a000 devices we will support up to 32 stations. The max station define is used also for invalid station marking which makes finding usages of actual maximum station pretty hard to sort through - change it to be a different define in order to make

[PATCH v2 06/26] iwlwifi: mvm: disable multi-queue for a000 devices

2017-04-14 Thread Luca Coelho
From: Sara Sharon Firmware isn't configuring multi RX queue hardware yet in the self init mode. Disable it for now until we have an API that enables it. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho ---

[PATCH v2 03/26] iwlwifi: cleanup unused function

2017-04-14 Thread Luca Coelho
From: Sara Sharon iwl_has_secure_boot() isn't getting called anywhere. Clean it up. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/iwl-config.h | 10 -- 1 file

[PATCH v2 07/26] iwlwifi: mvm: refactor SAR init to prepare for dynamic SAR

2017-04-14 Thread Luca Coelho
From: Haim Dreyfuss We are adding support for dynamic TX power tables for SAR (specific absorption rate) compliance. Currently, we only support a single (static) TX power table, which is read from ACPI, and use it statically. To prepare for more tables that can be

[PATCH v2 00/26] iwlwifi: updates intended for v4.12 2017-04-13

2017-04-14 Thread Luca Coelho
From: Luca Coelho Hi, This is v2 of the second patch set intended for v4.12. These are the changes: * A large amount of work on the A000 device series; * A couple of cleanup patches; * Dynamic SAR support; As usual, I'm pushing this to a pending branch, for

[PATCH v2 01/26] iwlwifi: mvm: read new secure boot registers

2017-04-14 Thread Luca Coelho
From: Sara Sharon Addresses were changed for a000 devices. Signed-off-by: Sara Sharon Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/iwl-prph.h | 2 ++ drivers/net/wireless/intel/iwlwifi/mvm/fw.c |

[PATCH v2 02/26] iwlwifi: mvm: add queues after adding station

2017-04-14 Thread Luca Coelho
From: Sara Sharon Currently aux & broadcast queues are added before calling add station, which results with a SCD_QUEUE_CFG command sent with a station id unknown yet to fw. While this works for pre-a000 firmware, the a000 fw requires the order to be reversed. The reason

Email change

2017-04-14 Thread Michal Kazior
Hi everyone, I'm parting ways with Tieto today so my email is going to become defunct. I'll be reachable via: kazikcz at gmail dot com. Michał