Re: [PATCH] libertas: Avoid reading past end of buffer

On Tue, 2017-05-09 at 16:23 -0700, Kees Cook wrote: > Using memcpy() from a string that is shorter than the length copied means > the destination buffer is being filled with arbitrary data from the kernel > rodata segment. Instead, use strncpy() which will fill the trailing bytes > with zeros.

[PATCH] libertas: Avoid reading past end of buffer

Using memcpy() from a string that is shorter than the length copied means the destination buffer is being filled with arbitrary data from the kernel rodata segment. Instead, use strncpy() which will fill the trailing bytes with zeros. Additionally adjust indentation to keep checkpatch.pl happy.

Re: [PATCH] wcn36xx: Close SMD channel on device removal

On Mon 08 May 23:17 PDT 2017, Kalle Valo wrote: > Bjorn Andersson writes: > > > The SMD channel is not the primary WCNSS channel and must explicitly be > > closed as the device is removed, or the channel will already by open on > > a subsequent probe call in e.g. the

Re: [PATCH v5] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

On 05/09/2017 08:07 AM, Kalle Valo wrote: External Email Kalle Valo writes: QSR10G (aka Pearl) is Quantenna's 8x8, 160M, 11ac offering. QSR10G supports 2 simultaneous WMACs - one 5G and one 2G. 5G WMAC supports 160M, 8x8 configuration. FW supports up to 8 concurrent

[PATCH] mac80211: Validate michael MIC before attempting packet decode.

In order to allow wpa_supplicant to correctly identify a perceived WPA TKIP key recovery attack the michael MIC must be checked before the packet decode is attempted. A packet with an invalid MIC will always fail a decrypt check which previously was being checked first. Therefore the MIC failure

Re: [v2,1/3] ath9k: Support channels in licensed bands

On 9 May 2017 at 05:57, Simon Wunderlich wrote: > Hey Kalle, > > it seems like there was some discussion here and I wouldn't expect too many > more opinions ... do you think we can have a decision based on what has been > discussed here? (Note: FreeBSD has had in-tree

[no subject]

subscribe linux-wireless

Re: [PATCH v5] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

Kalle Valo writes: >>> QSR10G (aka Pearl) is Quantenna's 8x8, 160M, 11ac offering. >>> QSR10G supports 2 simultaneous WMACs - one 5G and one 2G. >>> 5G WMAC supports 160M, 8x8 configuration. FW supports >>> up to 8 concurrent virtual interfaces on each WMAC. >>> >>> Patch

Re: [PATCH v5] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets

Igor Mitsyanko writes: > On 03/11/2017 12:04 PM, Igor Mitsyanko wrote: >> This patch adds support for new FullMAC WiFi driver for Quantenna >> QSR10G chipsets. > > Hi all, > this patch is pending for a while now, does it require more work > (except for what

Re: [PATCH 1/3] rsi: Rename the file rsi_91x_pkt.c to rsi_91x_hal.c

Hi Kvalle, On Tue, Apr 4, 2017 at 10:30 AM, Prameela Rani Garnepudi wrote: > The file rsi_91x_hal.c will contain new firmware loading method for > RSI 9113 chipset. So this file will have device specific operations. > As the file 'rsi_91x_pkt.c' contains code for

[v2 05/11] rsi: Remove unnecessary buffer allocation

From: Prameela Rani Garnepudi In functions usb read register and usb write register, dynamic allocation of 4 bytes is used. This is removed as it is unncessary for local variable and for such small data. Signed-off-by: Prameela Rani Garnepudi

[v2 08/11] rsi: Add host interface operations as separate structure.

From: Prameela Rani Garnepudi Host interface operations are currently function pointers in rsi_hw structure. As more host interface operations are going to be introduced, separate structure is added for these for convenience. Signed-off-by: Prameela Rani Garnepudi

[v2 10/11] rsi: Add new firmware loading method

From: Prameela Rani Garnepudi The older firmware loading method has been deprecated and not in use for any chipets. New method is introduced which works based on soft boot loader. In this method, complete RAM image and FLASH image are present in the flash. Before

[v2 11/11] rsi: Remove old firmware loading method

From: Prameela Rani Garnepudi The older firmware loading method is not usable by any Redpine chipset. Hence removing that part of the code. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar

[v2 06/11] rsi: Handle usb multi-byte write failure case properly

From: Prameela Rani Garnepudi In function usb_write_register_multiple, if any intermediate block transfer is failed, further operations should be terminated. 'else' is removed, as there is no significance for it after return. Signed-off-by: Prameela Rani Garnepudi

[v2 09/11] rsi: Add new host interface operations

From: Prameela Rani Garnepudi Host interface opearation master_reg_read, master_reg_write and load_data_master_write are added. These functions are needed for the new firmware loading method. As part of this, the function master_access_msword is moved from

[v2 07/11] rsi: Add usb multi-byte read operation

From: Prameela Rani Garnepudi USB multibyte read will be used in the new firmware loading method for RS9113 chipset. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar ---

[v2 04/11] rsi: use macros in USB specific code

From: Prameela Rani Garnepudi For USB vendor read and write operations new macros added to avoid redundant usage of long or'ed macros. Also for timeouts standard USB macros are used. Signed-off-by: Prameela Rani Garnepudi Signed-off-by:

[v2 03/11] rsi: Changes in USB read and write operations

From: Prameela Rani Garnepudi USB read and write registers maximum size is limited 2^16. More than this size is not used in the driver. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar

[v2 02/11] rsi: Changes to sdio reads and writes

From: Prameela Rani Garnepudi SDIO read or write maximum size is limited to 2^16. This is done to make the host interface operations common for SDIO and USB. Signed-off-by: Prameela Rani Garnepudi Signed-off-by: Amitkumar Karwar

[v2 01/11] rsi: Rename file rsi_91x_pkt.c to rsi_91x_hal.c

From: Prameela Rani Garnepudi The file rsi_91x_hal.c is going to contain device specific code i.e new firmware loading method for RS9113 chipset. As the file rsi_91x_pkt.c contains code to prepare device specific descriptors for transmit packet, this file is renamed to

[v2 00/11] Firmware loading changes

This patch series includes firmware loading enhancements for Redpine 9113 chipset. The older method is not being used by any Redpine chipset. There is no firmware image submitted to upstream yet. We will submit 9113's firmware image once these changes are accepted. This patch series is based on

[PATCH v2] ath10k: remove unnecessary code

The array fields in struct wmi_start_scan_arg that are checked here are fixed size arrays so they can never be NULL. Addresses-Coverity-ID: 1260031 Cc: Arend Van Spriel Cc: Kalle Valo Signed-off-by: Gustavo A. R. Silva

[PATCH v2] ath9k: remove unnecessary code

The array field eeprom_data in struct th9k_platform_data is a fixed size array so it can never be NULL. Addresses-Coverity-ID: 1364903 Cc: Arend Van Spriel Cc: Kalle Valo Signed-off-by: Gustavo A. R. Silva ---

Re: [PATCH] net: wireless: ath: ath9k: remove unnecessary code

Quoting Kalle Valo : "Gustavo A. R. Silva" writes: Hi Kalle, Quoting Kalle Valo : "Gustavo A. R. Silva" writes: The name of an array used by itself will always return the array's

Re: [v2,1/3] ath9k: Support channels in licensed bands

Hey Kalle, it seems like there was some discussion here and I wouldn't expect too many more opinions ... do you think we can have a decision based on what has been discussed here? I'd be happy to rebase the remaining patches if that is necessary. Thank you! Simon On Friday, April 21,

Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

Hi Arend, Quoting Arend Van Spriel : On 9-5-2017 7:33, Kalle Valo wrote: "Gustavo A. R. Silva" writes: The name of an array used by itself will always return the array's address. So these tests will always evaluate as false and

Re: [PATCH] net: wireless: ath: ath9k: remove unnecessary code

Hi Kalle, Quoting Kalle Valo : "Gustavo A. R. Silva" writes: The name of an array used by itself will always return the array's address. So this test will always evaluate as true. Addresses-Coverity-ID: 1364903 Signed-off-by: Gustavo A. R.

Re: [PATCH] wil6210: Replace five seq_puts() calls by seq_putc()

On Tue, 2017-05-09 at 09:50 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 8 May 2017 22:22:04 +0200 > > Five single characters (line breaks) should be put into a sequence. > Thus use the corresponding function "seq_putc". > > This issue was

Re: [PATCH] net: wireless: ath: ath9k: remove unnecessary code

"Gustavo A. R. Silva" writes: > Hi Kalle, > > Quoting Kalle Valo : > >> "Gustavo A. R. Silva" writes: >> >>> The name of an array used by itself will always return the array's address. >>> So this test will always

Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

Arend Van Spriel writes: > On 9-5-2017 7:33, Kalle Valo wrote: >> "Gustavo A. R. Silva" writes: >> >>> The name of an array used by itself will always return the array's address. >>> So these tests will always evaluate as false and

Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

On 9-5-2017 7:33, Kalle Valo wrote: > "Gustavo A. R. Silva" writes: > >> The name of an array used by itself will always return the array's address. >> So these tests will always evaluate as false and therefore the _return_ >> will never be executed. >> >> Signed-off-by:

Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

Hi Kalle, Quoting Kalle Valo : "Gustavo A. R. Silva" writes: The name of an array used by itself will always return the array's address. So these tests will always evaluate as false and therefore the _return_ will never be executed.

Re: [PATCH] net: wireless: ath: ath9k: remove unnecessary code

"Gustavo A. R. Silva" writes: > The name of an array used by itself will always return the array's address. > So this test will always evaluate as true. > > Addresses-Coverity-ID: 1364903 > Signed-off-by: Gustavo A. R. Silva > --- >

Re: [PATCH] wil6210: Replace five seq_puts() calls by seq_putc()

On Tue, 2017-05-09 at 09:50 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 8 May 2017 22:22:04 +0200 > > Five single characters (line breaks) should be put into a sequence. > Thus use the corresponding function "seq_putc". Please stop, this

[PATCH] wil6210: Replace five seq_puts() calls by seq_putc()

From: Markus Elfring Date: Mon, 8 May 2017 22:22:04 +0200 Five single characters (line breaks) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 3/3] ath9k: Adjust a null pointer check in three functions

From: Markus Elfring Date: Mon, 8 May 2017 22:17:13 +0200 The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written "!buf" Thus adjust this expression. Signed-off-by: Markus Elfring

[PATCH 2/3] ath9k: Replace four seq_printf() calls by seq_putc()

From: Markus Elfring Date: Mon, 8 May 2017 22:04:47 +0200 Four single characters (line breaks) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 1/3] ath9k: Reduce function calls for sequence output in read_file_dma()

From: Markus Elfring Date: Mon, 8 May 2017 21:55:09 +0200 Some data were put into a sequence by separate function calls. Print the same data with two function calls less. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 0/3] ath9k: Fine-tuning for some function implementations

From: Markus Elfring Date: Tue, 9 May 2017 09:19:09 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Reduce function calls for sequence output in read_file_dma() Replace four seq_printf() calls by

Re: [PATCH] wcn36xx: Close SMD channel on device removal

Bjorn Andersson writes: > The SMD channel is not the primary WCNSS channel and must explicitly be > closed as the device is removed, or the channel will already by open on > a subsequent probe call in e.g. the case of reloading the kernel module. > > This issue was