Re: [PATCH] NFC: nci: Remove an unneeded NULL check

Hi Dan, On Wed, Jun 14, 2017 at 10:49:46AM +0300, Dan Carpenter wrote: > "conn_info" can't be NULL here. Also we just dereferenced it a couple > lines earlier, so that makes static checkers complain. > > Signed-off-by: Dan Carpenter > > diff --git

Re: [PATCH] nfc: Add sockaddr length checks before accessing sa_family in bind handlers

On Tue, Jun 13, 2017 at 06:44:28PM +0200, Mateusz Jurczyk wrote: > Verify that the caller-provided sockaddr structure is large enough to > contain the sa_family field, before accessing it in bind() handlers of the > AF_NFC socket. Since the syscall doesn't enforce a minimum size of the >

Re: [PATCH] NFC: add NULL checks to avoid potential NULL pointer dereference

On Tue, May 30, 2017 at 03:43:07PM -0500, Gustavo A. R. Silva wrote: > NULL checks at line 457: if (!link0 || !link1) {, implies that both > pointers link0 and link1 might be NULL. > Function nfcsim_link_free() dereference pointers link0 and link1. > Add NULL checks before calling

Re: [PATCH] nfc: nci: remove unnecessary null check

Hi Gustavo, On Tue, Jun 13, 2017 at 11:37:18AM -0500, Gustavo A. R. Silva wrote: > Remove unnecessary NULL check for pointer conn_info. > conn_info is set in list_for_each_entry() using container_of(), > which is never NULL. > > Addresses-Coverity-ID: 1362349 > Cc: Guenter Roeck

Re: [PATCH] nfc: Ensure presence of required attributes in the activate_target netlink handler

Hi Mateusz, On Wed, May 24, 2017 at 12:42:26PM +0200, Mateusz Jurczyk wrote: > Check that the NFC_ATTR_TARGET_INDEX and NFC_ATTR_PROTOCOLS attributes (in > addition to NFC_ATTR_DEVICE_INDEX) are provided by the netlink client > prior to accessing them. This prevents potential unhandled NULL

Re: [PATCH] nfc: Fix the sockaddr length sanitization in llcp_sock_connect

Hi Mateusz, On Wed, May 24, 2017 at 12:26:20PM +0200, Mateusz Jurczyk wrote: > Fix the sockaddr length verification in the connect() handler of NFC/LLCP > sockets, to compare against the size of the actual structure expected on > input (sockaddr_nfc_llcp) instead of its shorter version

Re: [PATCH 0/3] NFC: Misc. kernel updates and trf7970a erratum handling

Hi Mark, On Thu, Jun 15, 2017 at 10:46:14AM -0700, Mark Greer wrote: > Add a couple minor fixups and remove the trf7970a erratum handling > in which the last byte in the response to a Type 5 Read Multiple Blocks > command is discarded. That handling is moved to the neard daemon where > there is

Re: [PATCH 0/2] NFC-digital: Adjustments for four function implementations

Hi Markus, On Mon, May 22, 2017 at 02:57:42PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 22 May 2017 14:50:05 +0200 > > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Improve

Re: [PATCH] NFC: trf7970a: fix check of clock frequencies, use && instead of ||

Hi Colin, On Mon, Apr 24, 2017 at 02:36:02PM +0100, Colin King wrote: > From: Colin Ian King > > The "or" condition (clk_freq != TRF7970A_27MHZ_CLOCK_FREQUENCY) || > (clk_freq != TRF7970A_13MHZ_CLOCK_FREQUE) will always be true because > clk_freq cannot be equal to two

Re: [PATCH v3 00/13] NFC: clean up for ACPI GPIO usage

Hi Andy, On Mon, Jun 19, 2017 at 01:08:45PM +0300, Andy Shevchenko wrote: > This clean up series to NFC drivers that are using GPIOs on ACPI enabled > platforms. Since GPIO ACPI library goes stricter about requesting > resources we need to amend drivers for that. Here we are for NFC > subsystem.

[PATCH 20/25] iwlwifi: pcie: don't report RF-kill enabled while shutting down

From: Johannes Berg When toggling the RF-kill pin quickly in succession, the driver can get rather confused because it might be in the process of shutting down, expecting all commands to go through quickly due to rfkill, but the transport already thinks the device is

[PATCH 17/25] iwlwifi: pcie: pull out common rfkill IRQ handling code

From: Johannes Berg There's no point in duplicating exactly the same code here for legacy and MSI-X interrupts, so pull it out into a new function to call in both places. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho

[PATCH 21/25] iwlwifi: pcie: remove pointless debugfs parsing for csr file

From: Johannes Berg We don't actually care about the value at all, just making sure that we can successfully parse a single integer value, but that's entirely pointless - remove it. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho

[PATCH 10/25] iwlwifi: use bitfield.h for some registers

From: Johannes Berg Letting the preprocessor/compiler generate the shift/mask by itself is a win for readability, so use bitfield.h for some registers. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho ---

[PATCH 15/25] iwlwifi: mvm: make iwl_mvm_update_mcc() easier to follow

From: Johannes Berg Some static checkers (e.g. smatch) complain about the logic, saying that resp_cp might be leaked. Clearly that isn't true, but making the logic easier to follow does not result in any significant code changes and makes the code more readable by moving

[PATCH 24/25] iwlwifi: pcie: use kstrtou32_from_user()

From: Johannes Berg Use kstrtou32_from_user() in debugfs instead of open-coding it. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 13 - 1

[PATCH 13/25] iwlwifi: mvm: support D0I3_END_CMD at the start of resume

From: Luca Coelho New FW versions require the D0I3_END_CMD to be sent as the first command to the FW in the resume flow. If the TLV is set, send that command first, otherwise keep the original behavior (i.e. send last). Signed-off-by: Luca Coelho

[PATCH 16/25] iwlwifi: mvm: rs: add logs for the wrong antenna case

From: Gregory Greenman In case that rate's antenna is wrong at the init stage, it's very hard to say what went wrong. Add debug data to the already existing WARN_ON_ONCE. Signed-off-by: Gregory Greenman Signed-off-by: Luca Coelho

[PATCH 22/25] iwlwifi: mvm: document status bits

From: Johannes Berg Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 12 1 file changed, 12 insertions(+) diff --git

[PATCH 23/25] iwlwifi: mvm: support aggregations on A000 HW

From: Liad Kaufman On A000 HW, the SCD rdptr has only 8 bits allocated for it, thus when checking if a queue is full, or when checking if the SSN is equal to the TID's next_reclaimed, A000 HW should trim the SSN. Fix this by "normalizing" the SSN to wrap around 0xFF when

[PATCH 12/25] iwlwifi: mvm: make D0I3_END_CMD sync during system resume

From: Luca Coelho There is no need to send D0I3_END_CMD as ASYNC during the system resume flow. Additionally, the other flags used are meaningless in this case (they were just copied from the runtime resume flow), so remove them all. Signed-off-by: Luca Coelho

[PATCH 18/25] iwlwifi: pcie: add fake RF-kill to debugfs

From: Johannes Berg In order to debug "hardware" RF-kill flows, add a low-level hook to allow changing the "hardware" RF-kill from debugfs. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho ---

[PATCH 14/25] iwlwifi: mvm: change the firmware name loading

From: Mordechai Goodstein The firmware moved the development from a0 MAC to z0. z0 is using the same RFID and device ID as a0 so we only need to switch the name. Signed-off-by: Mordechai Goodstein Signed-off-by: Luca Coelho

[PATCH 04/25] iwlwifi: mvm: Enable security on new TX API

From: David Spinadel Install GTKs on AP side for new TX API. Don't add IV space, it's added by the HW. While at that fix GCMP abnd GCMP-256 GTK installation which work similarly to the new TX API. Signed-off-by: David Spinadel Signed-off-by:

[PATCH 08/25] iwlwifi: mvm: avoid variable shadowing

From: Johannes Berg Avoid one kind of symbol shadowing another in iwl_mvm_flush_sta() by renaming the function parameter. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho ---

[PATCH 09/25] iwlwifi: mvm: use scnprintf() instead of snprintf()

From: Johannes Berg It's safer to use scnprintf() here because the buffer might be too short for the full format strings. In most cases this isn't true because of external limits on the values. In one case, this fixes a stack data leak. Signed-off-by: Johannes Berg

[PATCH 02/25] iwlwifi: remove resp_pkt NULL checks

From: Johannes Berg Contrary to what some of the comments say, if rfkill was asserted the transport will return -ERFKILL instead of success, if CMD_WANT_SKB was set, so it's not necessary to check cmd.resp_pkt for being NULL if the return code was success. Validate that

[PATCH 07/25] iwlwifi: pcie: fix TVQM queue ID range check

From: Johannes Berg The queue ID should never be 512 either, so correct the check to be >= instead of just >. Fixes: 310181ec34e2 ("iwlwifi: move to TVQM mode") Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho

[PATCH 00/25] iwlwifi: updates intended for v4.13 2017-06-23

From: Luca Coelho Morjens, More patches intended for 4.13. These are the changes: * Johannes' documentation work continues; * Some changes in suspend/resume handling to support new FWs; * A bunch of RF-kill related fixes; * Continued work towards the A000 family; *

[PATCH 01/25] iwlwifi: mvm: remove txq EMPTYING_DELBA state for DQA

From: Liad Kaufman In DQA mode, there is no need to wait for the TXQ to clear out after getting a DELBA, since traffic can continue running on the queue. Signed-off-by: Liad Kaufman Signed-off-by: Luca Coelho ---

[PATCH 03/25] iwlwifi: mvm: disable dbg data collect when fw isn't alive

From: Liad Kaufman If FW isn't alive, trying to collect debug data will result in errors both in driver and in the collected data, so just warn and leave the collecting function in this case. Signed-off-by: Liad Kaufman Signed-off-by: Luca Coelho

[PATCH 06/25] iwlwifi: mvm: remove pointless num_stored condition

From: Johannes Berg Since we exit if buf->num_stored is 0, there's no need to check it again later. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 2 +- 1

[PATCH 05/25] iwlwifi: mvm: avoid unnecessary cache trashing in Tx path

From: Emmanuel Grumbach When sending a Tx Command with a Tx packet, we allocate the Tx command separately from the payload of the packet. The WiFi MAC header is then copied into the buffer that was allocated for the Tx Command. This means that this buffer needs to be

Re: [PATCH 00/12] ath10k: firmware update 20170621

On Thu, Jun 22, 2017 at 11:31:56AM +0300, Kalle Valo wrote: > Hi, > > here's a set of firmware and board file updates for ath10k. > applied, thanks kalle. --kyle > Kalle > > Kalle Valo (12): > ath10k: QCA4019 hw1.0: update board-2.bin > ath10k: QCA4019 hw1.0: update firmware to

[PATCH] rsi: add in missing RSI_FSM_STATES into array fsm_state

From: Colin Ian King Two recent commits added new RSI_FSM_STATES (namely FSM_FW_NOT_LOADED and FSM_COMMON_DEV_PARAMS_SENT) and the corresponding table fsm_state was not updated to match. This can lead to an array overrun when accessing the latter two states in

Re: [RFC 3/6] mac80211: add a TXQ for other powersave-buffered frames

On 06/21/2017 11:24 PM, Johannes Berg wrote: On Wed, 2017-06-21 at 17:02 -0700, Ben Greear wrote: I think a comment for the above code block would be warranted (and for ath10k as well). I guess this is the part about dequeueing the frames immediately? Yeah, I figured it was pretty obvious,

Re: [PATCH v2] rtlwifi: Replace hardcode value with macro

On 06/22/2017 07:00 AM, Souptick Joarder wrote: In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval and hw->max_rate_tries are replaced by macro. Signed-off-by: Souptick Joarder --- Changes in v2: - Signed-off was missing in previous one. This patch

[PATCH v2] rtlwifi: Remove unnecessary conditions

As wmm_enable is initialized to false, hence the else condition never execute and boundary is assigned with TX_PAGE_BOUNDARY. So the if-else condition can be removed and boundary will be assigned with TX_PAGE_BOUNDARY. Signed-off-by: Souptick Joarder --- Changes in v2: -

Re: [PATCH 05/14] mwifiex: re-register wiphy across reset

On Wed, 2017-06-21 at 11:27 -0700, Brian Norris wrote: > > > I'm not sure what you mean by "we need to atually stop all the > > virtual interfaces ([...]) first". > > Judging by your following comments, I may have been completely > mistaken. > (But that's why I asked you folks!) :) > > There

Re: [PATCH 05/14] mwifiex: re-register wiphy across reset

On Wed, 2017-06-21 at 10:48 -0700, Brian Norris wrote: > > Yes, that all sounds nice. But for my sake, can you describe better > what's actually going on there (e.g., can you point me at which code > does this)? It's much easier with mac80211, it has all the state. Basically the reconfig is in

Re: [PATCH] rtlwifi: Remove unnecessary conditions

Hi Julian, On Thu, Jun 22, 2017 at 6:03 PM, Julian Calaby wrote: > Hi Souptick, > > On Thu, Jun 22, 2017 at 9:16 PM, Souptick Joarder > wrote: >> As wmm_enable is initialized to false, hence the else condition never >> execute and boundary is

Re: [PATCH] rtlwifi: Remove unnecessary conditions

Hi Souptick, On Thu, Jun 22, 2017 at 9:16 PM, Souptick Joarder wrote: > As wmm_enable is initialized to false, hence the else condition never > execute and boundary is assigned with TX_PAGE_BOUNDARY. So the if-else > condition can be removed and boundary will be assigned

[PATCH v2] rtlwifi: Replace hardcode value with macro

In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval and hw->max_rate_tries are replaced by macro. Signed-off-by: Souptick Joarder --- Changes in v2: - Signed-off was missing in previous one. drivers/net/wireless/realtek/rtlwifi/base.c | 6 +++---

[PATCH] rtlwifi: Remove unnecessary conditions

As wmm_enable is initialized to false, hence the else condition never execute and boundary is assigned with TX_PAGE_BOUNDARY. So the if-else condition can be removed and boundary will be assigned with TX_PAGE_BOUNDARY. Signed-off-by: Souptick Joarder ---

[PATCH 3/3] mac80211: fix VLAN handling with TXQs

From: Johannes Berg With TXQs, the AP_VLAN interfaces are resolved to their owner AP interface when enqueuing the frame, which makes sense since the frame really goes out on that as far as the driver is concerned. However, this introduces a problem: frames to be

[PATCH 2/3] mac80211: avoid allocating TXQs that won't be used

From: Johannes Berg For AP_VLAN and monitor interfaces we'll never use the TXQs we allocated, so avoid doing so. Signed-off-by: Johannes Berg --- net/mac80211/iface.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 1/3] mac80211: agg-tx: call drv_wake_tx_queue in proper context

From: Johannes Berg Since drv_wake_tx_queue() is normally called in the TX path, which is already in an RCU critical section, we should call it the same way in the aggregation code path, so if the driver expects to be able to use RCU, it'll already be protected without

Re: net_device::destructor patch for brcmfmac

On 22-06-17 12:02, Kalle Valo wrote: > Johannes Berg writes: > >> On Thu, 2017-06-22 at 11:45 +0200, Arend van Spriel wrote: >>> Hi Kalle, >>> >>> I have a fix for brcmfmac, which is related to a change Dave made in >>> struct net_device, ie. commit cf124db566e6

Re: net_device::destructor patch for brcmfmac

Johannes Berg writes: > On Thu, 2017-06-22 at 11:45 +0200, Arend van Spriel wrote: >> Hi Kalle, >> >> I have a fix for brcmfmac, which is related to a change Dave made in >> struct net_device, ie. commit cf124db566e6 ("net: Fix inconsistent >> teardown and release of

[PATCH 3/4] brcmfmac: rework headroom check in .start_xmit()

Since commit 9cc4b7cb86cb ("brcmfmac: Make skb header writable before use") the headroom usage has been fixed. However, the driver was keeping statistics that got lost. So reworking the code so we get those driver statistics back for debugging. Cc: James Hughes

[PATCH 1/4] brcmfmac: cleanup kerneldoc for struct brcmf_bus

A couple of old fields were still described and one field was not described. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel

[PATCH 2/4] brcmfmac: use atomic_t for statistic counter in struct brcmf_bus

The statistic counter is used in common layer and in the bus layer in different thread contexts so change to use atomic operations. Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin

[PATCH 4/4] MAINTAINERS: add brcm80211 maintainer info from Cypress

Since Cypress took over IoT part of Broadcom some chips supported by brcmfmac moved over as well. Adding maintainer info of our peers at Cypress to make their support official. Cc: Chi-Hsien Lin Cc: Wright Feng Reviewed-by: Hante Meuleman

[PATCH 0/4] brcm80211: general admin and headroom rework

This smallish set contains: * rework headroom handling in .start_xmit() callback. * add Cypress maintainers for brcm80211. The series apply to the master branch of the wireless-drivers-next repository. Arend van Spriel (4): brcmfmac: cleanup kerneldoc for struct brcmf_bus brcmfmac: use

Re: net_device::destructor patch for brcmfmac

On Thu, 2017-06-22 at 11:45 +0200, Arend van Spriel wrote: > Hi Kalle, > > I have a fix for brcmfmac, which is related to a change Dave made in > struct net_device, ie. commit cf124db566e6 ("net: Fix inconsistent > teardown and release of private netdev state."). This change is not > in >

Re: [RFC 5/6] mac80211: add a general fallback TXQ

On Thu, 2017-06-22 at 01:50 +0200, Johannes Berg wrote: > In a number of cases, like management frames, mac80211 will not > put the frame on any TXQ but immediately TX it to the driver. > It'd be nicer to be able to use TXQs for all frames, so add a > "fallback" TXQ. This will serve as a

[PATCH 09/12] ath10k: QCA988X hw2.0: update firmware to 10.2.4.70.63-2

Signed-off-by: Kalle Valo --- WHENCE | 2 +- ath10k/QCA988X/hw2.0/firmware-5.bin | Bin 248188 -> 249384 bytes 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/WHENCE b/WHENCE index 33e23611be18..cb93391f44e0 100644 --- a/WHENCE

[PATCH 07/12] ath10k: QCA9888 hw2.0: update board-2.bin

Signed-off-by: Kalle Valo --- ath10k/QCA9888/hw2.0/board-2.bin | Bin 12148 -> 72788 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/ath10k/QCA9888/hw2.0/board-2.bin b/ath10k/QCA9888/hw2.0/board-2.bin index

[PATCH 01/12] ath10k: QCA4019 hw1.0: update board-2.bin

Signed-off-by: Kalle Valo --- ath10k/QCA4019/hw1.0/board-2.bin | Bin 72788 -> 109172 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/ath10k/QCA4019/hw1.0/board-2.bin b/ath10k/QCA4019/hw1.0/board-2.bin index

[PATCH 05/12] ath10k: QCA9377 hw1.0: update board-2.bin

Signed-off-by: Kalle Valo --- ath10k/QCA9377/hw1.0/board-2.bin | Bin 427668 -> 304308 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/ath10k/QCA9377/hw1.0/board-2.bin b/ath10k/QCA9377/hw1.0/board-2.bin index

[PATCH 03/12] ath10k: QCA6174 hw3.0: update board-2.bin

Signed-off-by: Kalle Valo --- ath10k/QCA6174/hw3.0/board-2.bin | Bin 361924 -> 477060 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/ath10k/QCA6174/hw3.0/board-2.bin b/ath10k/QCA6174/hw3.0/board-2.bin index

[PATCH 12/12] ath10k: update year in license

Signed-off-by: Kalle Valo --- LICENSE.QualcommAtheros_ath10k | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/LICENSE.QualcommAtheros_ath10k b/LICENSE.QualcommAtheros_ath10k index 7fae6323f5df..c68935c11adf 100644 --- a/LICENSE.QualcommAtheros_ath10k

[PATCH 06/12] ath10k: QCA9887 hw1.0: update firmware to 10.2.4-1.0-00029

Signed-off-by: Kalle Valo --- WHENCE | 2 +- ath10k/QCA9887/hw1.0/firmware-5.bin | Bin 234560 -> 235880 bytes 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/WHENCE b/WHENCE index 24e71b395d33..84961ab49d1a 100644 --- a/WHENCE

[PATCH 00/12] ath10k: firmware update 20170621

Hi, here's a set of firmware and board file updates for ath10k. Kalle Kalle Valo (12): ath10k: QCA4019 hw1.0: update board-2.bin ath10k: QCA4019 hw1.0: update firmware to 10.4-3.4-00082 ath10k: QCA6174 hw3.0: update board-2.bin ath10k: QCA6174 hw3.0: add WLAN.RM.4.4-00022-QCARMSWPZ-2

Re: [PATCH][net-next] qtnfmac: fix uninitialized return code in ret

> Not related to your patch but qtnf_map_bar() should be changed not to > return NULL. When functions return both NULL and error pointers the > NULL is supposed to be a special type of success return. Here it is > just a fail return where we forgot to set the error code to > ERR_PTR(-ENOMEM).

Re: cfg80211_ops

On 22-06-17 08:30, Johannes Berg wrote: > Also, set_default_key is, IIRC, not needed in WPA/WPA2 client mode, but > may be needed for WEP - not sure off the top of my head. correct (if brcmfmac is). Gr. AvS

[PATCH] mwifiex: Do not change bss_type in change_virtual_intf

When user adds a virtual interface driver will set the bss_type to the iface_type given by the user. When supplicant is started on the same interface, a call to change_virtual_intf will be triggered if if_type is not NL80211_IFTYPE_STATION. Here driver should not update it's bss_type, because

Re: cfg80211_ops

On Wed, 2017-06-21 at 17:53 -0700, Igor Mitsyanko wrote: > > > scan > > add_key > > get_key > > del_key > > sat_default_key > > connect > > disconnect > > set_wiphy_params > > Hi, is this for STA-only? I guess you also need > mgmt_frame_register > mgmt_tx For really basic operation, I don't

Re: [RFC 3/6] mac80211: add a TXQ for other powersave-buffered frames

On Wed, 2017-06-21 at 17:02 -0700, Ben Greear wrote: > I think a comment for the above code block would be warranted (and > for ath10k as well). > > I guess this is the part about dequeueing the frames immediately? Yeah, I figured it was pretty obvious, but I can add a comment :) johannes