[PATCH] iwlwifi: mvm: Fix a memory leak in an error handling path in 'iwl_mvm_sar_get_wgds_table()'

2017-07-11 Thread Christophe JAILLET
We should free 'wgds.pointer' here as done a few lines above in another error handling path. It was allocated within 'acpi_evaluate_object()'. Signed-off-by: Christophe JAILLET --- A comment in '/drivers/acpi/acpica/utalloc.c' states that: /* [...] Note: The caller

Re: [PATCH] drivers/staging/wilc1000: fix sparse warning: right shift by bigger than source value

2017-07-11 Thread Rui Teng
On 12/07/2017 1:04 AM, Greg Kroah-Hartman wrote: On Mon, Jul 10, 2017 at 04:57:31PM +0800, Rui Teng wrote: This patch sets memory to zero directly to avoid unnecessary shift and bitwise operations on bool type, which can fix a sparse warning and also improve performance. It does? How did you

Re: WARN_ON_ONCE(work > weight) in napi_poll()

2017-07-11 Thread Igor Mitsyanko
On 07/11/2017 10:28 AM, Andrey Ryabinin wrote: It gave me this: [118648.825347] #1 quota too big 72 64 16 [118648.825351] #2 quota too big 72 64 16 [118648.825471] [ cut here ] [118648.825484] WARNING: CPU: 0 PID: 0 at ../net/core/dev.c:5274 net_rx_action+0x258/0x360

Hola amigo

2017-07-11 Thread Wang Jianlin
-- Tengo la intención de darle una porción de mi riqueza como un libre albedrío financiero Donación a usted, Responder a participar. Wang Jianlin Grupo Wanda

Re: net-next STATUS page

2017-07-11 Thread Stephen Hemminger
On Tue, 11 Jul 2017 07:24:16 -0700 (PDT) David Miller wrote: > It has gotten to the point that even casually walking around > Faro, Portugal last week, random German tourists would stop > me in the street and ask if net-next was open or not. > > Therefore, in order to avoid

Re: WARN_ON_ONCE(work > weight) in napi_poll()

2017-07-11 Thread Andrey Ryabinin
On 07/11/2017 12:24 AM, Ryan Hsu wrote: > On 07/04/2017 08:59 AM, Andrey Ryabinin wrote: > >> On 07/04/2017 04:49 PM, Kalle Valo wrote: >>> Andrey Ryabinin writes: >>> I occasionally hit WARN_ON_ONCE(work > weight); in napi_poll() on a laptop with ath10k card.

Re: [PATCH] drivers/staging/wilc1000: fix sparse warning: right shift by bigger than source value

2017-07-11 Thread Greg Kroah-Hartman
On Mon, Jul 10, 2017 at 04:57:31PM +0800, Rui Teng wrote: > This patch sets memory to zero directly to avoid unnecessary shift and > bitwise operations on bool type, which can fix a sparse warning and also > improve performance. It does? How did you measure the performance impact? What was now

Re: net-next STATUS page

2017-07-11 Thread Cong Wang
On Tue, Jul 11, 2017 at 7:24 AM, David Miller wrote: > > It has gotten to the point that even casually walking around > Faro, Portugal last week, random German tourists would stop > me in the street and ask if net-next was open or not. > > Therefore, in order to avoid any and

Re: net-next STATUS page

2017-07-11 Thread Phil Sutter
On Tue, Jul 11, 2017 at 05:05:06PM +0200, Jiri Pirko wrote: > Tue, Jul 11, 2017 at 04:24:16PM CEST, da...@davemloft.net wrote: > > > >It has gotten to the point that even casually walking around > >Faro, Portugal last week, random German tourists would stop > >me in the street and ask if net-next

Re: net-next STATUS page

2017-07-11 Thread Jiri Pirko
Tue, Jul 11, 2017 at 04:24:16PM CEST, da...@davemloft.net wrote: > >It has gotten to the point that even casually walking around >Faro, Portugal last week, random German tourists would stop >me in the street and ask if net-next was open or not. > >Therefore, in order to avoid any and all confusion

Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

2017-07-11 Thread Russell Joyce
Thanks for your comments. > What I think Rafał is saying is that it would be better to have this > code in cfg80211 so other drivers including mac80211 could use it. While I agree that moving all wireless LED triggers to cfg80211 would be an ideal situation, it seems a bit out of scope for what

Re: [BUG] brcmfmac: BRCM4354 cannot connect since commit 270a6c1f65

2017-07-11 Thread S. Gilles
On 2017-07-11T14:35:07+0200, Arend van Spriel wrote: > [...] > > Looking at the diff of the bad commit, I came up with the patch below. > Can you try it and let me know the result? That seems to fix everything for me, thanks for the quick patch! Thanks, S. Gilles

[PATCH 3/3] rsi: fix static checker warning

2017-07-11 Thread Amitkumar Karwar
From: Amitkumar Karwar u32 pointer is changed to u16 and filled the value. Problem is solved by using local temporary variable. Below static checker warning was reported. drivers/net/wireless/rsi/rsi_91x_usb.c:400 rsi_usb_master_reg_read() warn: passing

Re: [bug report] rsi: Add new host interface operations

2017-07-11 Thread Amitkumar Karwar
Hi Dan, On Fri, Jul 7, 2017 at 7:58 PM, Dan Carpenter wrote: > None of these issues have been addressed. > I have just submitted 3 patches which address these issues. Thanks Amitkumar

[PATCH 2/3] rsi: check length before USB read/write register

2017-07-11 Thread Amitkumar Karwar
From: Amitkumar Karwar These checks are required. Otherwise we may end up getting memory corruption if invalid length is passed. Fixes: b97e9b94ad75c ("rsi: Add new host interface operations") Signed-off-by: Amitkumar Karwar ---

[PATCH 1/3] rsi: use macro for allocating USB buffer

2017-07-11 Thread Amitkumar Karwar
From: Amitkumar Karwar 4 bytes is fixed size for reading or writing USB register. We will use a macro instead of hardcoding this. Fixes: b97e9b94ad75c ("rsi: Add new host interface operations") Signed-off-by: Amitkumar Karwar ---

net-next STATUS page

2017-07-11 Thread David Miller
It has gotten to the point that even casually walking around Faro, Portugal last week, random German tourists would stop me in the street and ask if net-next was open or not. Therefore, in order to avoid any and all confusion I have created this web site:

[PATCH 3/3] ath10k: push peer type to target for TDLS peers

2017-07-11 Thread mpubbise
From: Manikanta Pubbisetty WMI interface for all the firmwares(except QCA6714) does not include the type of peer(default/bss/tdls) requested during peer creation, therefore target creates a default peer. TDLS implementation on 10.4 firmware requires host to configure

[PATCH 2/3] ath10k: add tdls support for 10.4 firmwares

2017-07-11 Thread mpubbise
From: Manikanta Pubbisetty This patch adds the support of TDLS feature for 10.4 firmware versions. A new WMI service is added to advertise the support of TDLS for 10.4 firmwares. Signed-off-by: Manikanta Pubbisetty ---

[PATCH 1/3] ath10k: extend wmi service map to accommodate new services

2017-07-11 Thread mpubbise
From: Manikanta Pubbisetty Though there is room to accommodate 512 services in wmi service ready event, target uses only first 4-bits of each 32-bit word for advertising wmi services thereby limiting max wmi services to 64. TDLS implementation for 10.4 firmwares

Re: [BUG] brcmfmac: BRCM4354 cannot connect since commit 270a6c1f65

2017-07-11 Thread Arend van Spriel
On 11-07-17 14:21, S. Gilles wrote: > Hi, > > I have an Asus C201, which comes with a BRCM4354 (SDIO). On boot, > dmesg shows > > brcmfmac: brcmf_c_preinit_dcmds: Firmware version = wl0: Apr 8 2015 > 13:03:52 version 7.35.79.79 (r547158) FWID 01-7f29997a > > Since

[BUG] brcmfmac: BRCM4354 cannot connect since commit 270a6c1f65

2017-07-11 Thread S. Gilles
Hi, I have an Asus C201, which comes with a BRCM4354 (SDIO). On boot, dmesg shows brcmfmac: brcmf_c_preinit_dcmds: Firmware version = wl0: Apr 8 2015 13:03:52 version 7.35.79.79 (r547158) FWID 01-7f29997a Since 270a6c1f65fe68a28a5d39cd405592c550b496c7 (brcmfmac: rework headroom check in

[PATCH] rt2x00: make const array glrt_table static

2017-07-11 Thread Colin King
From: Colin Ian King Don't populate array glrt_table on the stack but make it static. Makes the object code a smaller by over 670 bytes: Before: textdata bss dec hex filename 1317724733 0 136505 21539 rt2800lib.o After: textdata

Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

2017-07-11 Thread Arend van Spriel
On 10-07-17 19:02, Russell Joyce wrote: >> 1) I think most of it should be some cfg80211 shareable code. > > I’m not sure exactly what you mean by this, could you please clarify? What I think Rafał is saying is that it would be better to have this code in cfg80211 so other drivers including

Re: ath10k QCA6174 not working -> missing data in board2.bin?

2017-07-11 Thread The Rasterman
On Wed, 5 Jul 2017 20:52:58 +0900 Carsten Haitzler (The Rasterman) said: i've built the linux wireless master tree and got firmware-6 working ... but same results. i can get a bit more out of the qualcomm wifi device if i switch irq mode: [ 365.108503] ath10k_pci

ath9k: insufficient skb len

2017-07-11 Thread Ortwin Glück
Hi, I saw this WARN_ON splat on ath9k in hostap mode. The code triggering the warning says it's a driver bug. Thanks for checking. Ortwin [629805.015640] [ cut here ] [629805.015695] WARNING: CPU: 2 PID: 0 at net/mac80211/rx.c:630 ieee80211_rx_napi+0x8a5/0xa70

[PATCH v2 06/10] wireless: iwlegacy: constify attribute_group structures.

2017-07-11 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- Changes in v2: Added cover later.

[PATCH v2 07/10] wireless: iwlegacy: Constify attribute_group structures.

2017-07-11 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- Changes in v2: Added cover later.

[PATCH v2 00/10] Constify attribute_group structures

2017-07-11 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. So mark the non-const structs as const. Arvind Yadav (10): [PATCH v2 01/10] net: cdc_ncm: constify attribute_group structures. [PATCH v2 02/10] net: can: at91_can: constify attribute_group structures. [PATCH v2 03/10] net: can:

[PATCH v2 05/10] wireless: ipw2100: constify attribute_group structures.

2017-07-11 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- Changes in v2: Added cover later.

[PATCH v2 04/10] wireless: ipw2200: constify attribute_group structures.

2017-07-11 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- Changes in v2: Added cover later.