Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function

On Thu, 2017-08-03 at 08:23 +0300, Kalle Valo wrote: > "Luis R. Rodriguez" writes: > > > > +int request_firmware_nowait(struct module *module, bool uevent, > > > + const char *name, struct device *device, gfp_t gfp, > > > + void

Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function

"Luis R. Rodriguez" writes: >> +int request_firmware_nowait(struct module *module, bool uevent, >> +const char *name, struct device *device, gfp_t gfp, >> +void *context, >> +void (*cont)(const struct

Re: [PATCH 2/2] qlcnic: add const to bin_attribute structure

-Original Message- From: Bhumika Goyal Date: Wednesday, August 2, 2017 at 11:27 PM To: "julia.law...@lip6.fr" , "kv...@codeaurora.org" , "linux-wireless@vger.kernel.org" ,

Re: [PATCH 3/3] brcmfmac: fix wrong num_different_channels when mchan feature enabled

On 2017/8/2 下午 09:40, Kalle Valo wrote: Arend van Spriel writes: On 8/2/2017 11:32 AM, Kalle Valo wrote: Wright Feng writes: The num_different_channels in wiphy info is not correct when firmware supports mchan. When mchan is on,

Re: brcm43430 sdio wifi regression with 4.13-rc1

Hello! Thank you for infrmation! I will check rc4 as soon as possible and will let you know. 03.08.2017, 05:06, "Arend van Spriel" : > On 02-08-17 22:43, russianneuroman...@ya.ru wrote: >>  Hello! >> >>  Sorry for late answer. >> >>>  russianneuromancer has

Re: [PATCH v2 9/9] wil6210: make debugfs compilation optional

On 02-08-17 23:00, Maya Erez wrote: > From: Gidon Studinski > > Since debugfs is a kernel configuration option, enable the driver to > compile without debugfs. > > Signed-off-by: Gidon Studinski > Signed-off-by: Maya Erez

Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function

On Mon, Jul 31, 2017 at 05:09:44PM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > So far we got only one function for loading firmware asynchronously: > request_firmware_nowait. It didn't allow much customization of firmware > loading process - there is only one bool

Re: brcm43430 sdio wifi regression with 4.13-rc1

On 02-08-17 22:43, russianneuroman...@ya.ru wrote: > Hello! > > Sorry for late answer. > >> russianneuromancer has reported seeing a similar problem with 4.13. > >> russianneuromancer, can you check if the device you are seeing this with > also has a brcm43430 sdio wifi and if so if switching

[PATCH v2 4/9] wil6210: check no_fw_recovery in resume failure recovery

Reset 11ad device on resume failure only if no_fw_recovery is not set. Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/pm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/wil6210/pm.c

[PATCH v2 3/9] wil6210: support FW RSSI reporting

From: Dedy Lansky New FW supports reporting RSSI signal in dBm. Report RSSI to kernel in case FW has this capability. Signed-off-by: Dedy Lansky Signed-off-by: Maya Erez ---

[PATCH v2 6/9] wil6210: notify wiphy on wowlan support

Set wowlan to indicate that 11ad device can wake-up on any trigger and disconnect. Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/cfg80211.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/wireless/ath/wil6210/cfg80211.c

[PATCH v2 9/9] wil6210: make debugfs compilation optional

From: Gidon Studinski Since debugfs is a kernel configuration option, enable the driver to compile without debugfs. Signed-off-by: Gidon Studinski Signed-off-by: Maya Erez ---

[PATCH v2 5/9] wil6210: add statistics for suspend time

Add statistics for total, min and max suspend time, that calculates the time the 11ad device was in suspend. Those statistics will help to estimate the power impact of d3hot feature. Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/debugfs.c | 17

[PATCH v2 7/9] wil6210: fix interface-up check

From: Hamad Kadmany While wil_open is executed, any call to netif_running would return a success. In case there are failures within wil_open, should not treat the device as if it is already opened in relevant functions (like FW recovery and runtime suspend check).

[PATCH v2 1/9] wil6210: protect against invalid length of tx management frame

From: Hamad Kadmany Validate buffer length has the minimum needed size when sending management frame to protect against possible buffer overrun. Signed-off-by: Hamad Kadmany Signed-off-by: Lior David

[PATCH v2 0/9] wil6210 patches

Changes from v1: - Removal of runtime PM patch, pending a fix to system suspend flow Dedy Lansky (2): wil6210: support FW RSSI reporting wil6210: store FW RF calibration result Gidon Studinski (1): wil6210: make debugfs compilation optional Hamad Kadmany (3): wil6210: protect against

[PATCH v2 2/9] wil6210: allow configuring scan timers

From: Hamad Kadmany Allow setting scan timeout and scan dwell time through module parameters. Signed-off-by: Hamad Kadmany Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/cfg80211.c | 17

Re: brcm43430 sdio wifi regression with 4.13-rc1

Hello! Sorry for late answer. > russianneuromancer has reported seeing a similar problem with 4.13. > russianneuromancer, can you check if the device you are seeing this with also has a brcm43430 sdio wifi and if so if switching to: >

[PATCH] mwifiex: replace netif_carrier_on/off by netif_device_attach/dettach

Driver is doing netif_carrier_off during suspend, which will set the IFF_LOWER_UP flag to 0. As a result certain applications will think this as a real carrier down and behave accordingly. This will cause issues like loss of IP address, for example. To fix this use netif_device_dettach during

pull-request: iwlwifi 2017-08-02

Hi Kalle, Here is my second batch of fixes for 4.13. More details in the tag description. I have sent this out before and kbuildbot didn't find any issues. Please let me know if there are any issues. Cheers, Luca. The following changes since commit 5f5d03143de5e0c593da4ab18fc6393c2815e108:

[PATCH 2/2] qlcnic: add const to bin_attribute structure

Add const to bin_attribute structure as it is only passed to the functions sysfs_{remove/create}_bin_file. The corresponding arguments are of type const, so declare the structure to be const. Signed-off-by: Bhumika Goyal --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c

[PATCH 1/2] wlcore: add const to bin_attribute structure

Add const to bin_attribute structure as it is only passed to the functions sysfs_{remove/create}_bin_file. The corresponding arguments are of type const, so declare the structure to be const. Signed-off-by: Bhumika Goyal --- drivers/net/wireless/ti/wlcore/sysfs.c | 2 +- 1

Re: [EXT] Re: pull-request mwifiex-firmware 2017-08-01

Hi Ganapathi, On Wed, Aug 02, 2017 at 09:44:51AM +, Ganapathi Bhat wrote: > Hi Brian, > > > On Tue, Aug 01, 2017 at 06:35:40PM +, Ganapathi Bhat wrote: > > > The following changes since commit > > 11db1311bff6fed84d11b03fbfb142209c1239ab: ^^^ Note that even the above commit is not in

Re: [PATCH v1] ath10k: Switch to use new generic UUID API

On Wed, 2017-08-02 at 14:44 +, Kalle Valo wrote: > Andy Shevchenko writes: > > > There are new types and helpers that are supposed to be used in new > > code. > > > > As a preparation to get rid of legacy types and API functions do > > the conversion here.

Re: [PATCH v1] ath10k: Switch to use new generic UUID API

Andy Shevchenko writes: > There are new types and helpers that are supposed to be used in new code. > > As a preparation to get rid of legacy types and API functions do > the conversion here. > > Signed-off-by: Andy Shevchenko

Re: [PATCH] rt2x00: Fix MMIC countermeasures.

I traced through this code during MMIC failure and ieee80211_rx_h_decrypt() drops the frame before getting to ieee80211_rx_h_michael_mic_verify(). Johannes suggested this change to me in response to a previous thread and I am offering this patch after having conducted the proper testing on it.

Re: [PATCH v5] rtlwifi: Replace hardcode value with macro

On 08/02/2017 07:29 AM, Souptick Joarder wrote: In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval and hw->max_rate_tries are replaced by macro and removed the comment. Signed-off-by: Souptick Joarder Finally! Acked-by: Larry Finger

[PATCH v1] ath10k: Switch to use new generic UUID API

There are new types and helpers that are supposed to be used in new code. As a preparation to get rid of legacy types and API functions do the conversion here. Signed-off-by: Andy Shevchenko --- drivers/net/wireless/ath/ath10k/core.h | 2 +-

Re: [PATCH] rt2x00: Fix MMIC countermeasures.

Johannes Berg writes: > On Wed, 2017-08-02 at 09:01 +0200, Stanislaw Gruszka wrote: > >> The relevant mac80211 code look like this: >> >> ieee80211_rx_result >> ieee80211_rx_h_michael_mic_verify(struct ieee80211_rx_data *rx) > > I believe that ieee80211_rx_h_decrypt()

Re: [PATCH 3/3] brcmfmac: fix wrong num_different_channels when mchan feature enabled

Arend van Spriel writes: > On 8/2/2017 11:32 AM, Kalle Valo wrote: >> Wright Feng writes: >> >>> The num_different_channels in wiphy info is not correct when firmware >>> supports mchan. When mchan is on, num_different_channels is always

[PATCH v5] rtlwifi: Replace hardcode value with macro

In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval and hw->max_rate_tries are replaced by macro and removed the comment. Signed-off-by: Souptick Joarder --- drivers/net/wireless/realtek/rtlwifi/base.c | 5 ++--- drivers/net/wireless/realtek/rtlwifi/base.h

Re: [PATCH v5] rtlwifi: Replace hardcode value with macro

Please ignore this patch. On Wed, Aug 2, 2017 at 5:50 PM, Souptick Joarder wrote: > In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval > and hw->max_rate_tries are replaced by macro and removed the comment. > > Signed-off-by: Souptick Joarder

Re: [PATCH] rt2x00: Fix MMIC countermeasures.

On Wed, 2017-08-02 at 09:01 +0200, Stanislaw Gruszka wrote: > The relevant mac80211 code look like this: > > ieee80211_rx_result > ieee80211_rx_h_michael_mic_verify(struct ieee80211_rx_data *rx) I believe that ieee80211_rx_h_decrypt() will drop the frames you're looking at, and I do think the

[PATCH v5] rtlwifi: Replace hardcode value with macro

In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval and hw->max_rate_tries are replaced by macro and removed the comment. Signed-off-by: Souptick Joarder --- drivers/net/wireless/realtek/rtlwifi/base.c | 5 ++--- drivers/net/wireless/realtek/rtlwifi/base.h

Re: [PATCH v2] mac80211: remove mic_fail_no_key label

On Wed, 2017-08-02 at 12:53 +0200, Stanislaw Gruszka wrote: > For historic reasons we have separate cases for mic_fail and > mic_fail_no_key. But with current code we can merge those cases, > as we already have NULL key check since commit a66b98db570a > ("mac80211: fix rx->key NULL dereference

Re: [PATCH v4] rtlwifi: Replace hardcode value with macro

On 8/2/2017 1:59 PM, Souptick Joarder wrote: In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval and hw->max_rate_tries are replaced by macro and removed the comment. Signed-off-by: Souptick Joarder --- drivers/net/wireless/realtek/rtlwifi/base.c | 5

[PATCH v4] rtlwifi: Replace hardcode value with macro

In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval and hw->max_rate_tries are replaced by macro and removed the comment. Signed-off-by: Souptick Joarder --- drivers/net/wireless/realtek/rtlwifi/base.c | 5 ++--- drivers/net/wireless/realtek/rtlwifi/base.h

[PATCH v2] mac80211: remove mic_fail_no_key label

For historic reasons we have separate cases for mic_fail and mic_fail_no_key. But with current code we can merge those cases, as we already have NULL key check since commit a66b98db570a ("mac80211: fix rx->key NULL dereference during mic failure"). Patch makes the rx->key->u.tkip.mic_failures

Re: [PATCH v4] rtlwifi: Replace hardcode value with macro

On 8/2/2017 12:47 PM, Souptick Joarder wrote: Hi Kalle, On Wed, Aug 2, 2017 at 2:51 PM, Kalle Valo wrote: Larry Finger writes: On 07/31/2017 06:14 AM, Souptick Joarder wrote: In _rtl_init_mac80211(), hardcoded value for

Re: [PATCH v4] rtlwifi: Replace hardcode value with macro

Hi Kalle, On Wed, Aug 2, 2017 at 2:51 PM, Kalle Valo wrote: > Larry Finger writes: > >> On 07/31/2017 06:14 AM, Souptick Joarder wrote: >>> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval >>> and hw->max_rate_tries are

[PATCH v2] ath10k: fix memory leak in rx ring buffer allocation

From: Rakesh Pillai ath10k: fix memory leak in rx ring buffer allocation The rx ring buffers are added to a hash table if firmware support full rx reorder. If the full rx reorder support flag is not set before allocating the rx ring buffers, none of the buffers are

Re: [PATCH 3/3] brcmfmac: fix wrong num_different_channels when mchan feature enabled

On 8/2/2017 11:32 AM, Kalle Valo wrote: Wright Feng writes: The num_different_channels in wiphy info is not correct when firmware supports mchan. When mchan is on, num_different_channels is always overridden to 1 in brcmf_setup_ifmodes. Correct the logic by moving

Re: [PATCH] mac80211: remove mic_fail_no_key label

Stanislaw Gruszka writes: > On Wed, Aug 02, 2017 at 11:10:11AM +0200, Arend van Spriel wrote: >> On 8/2/2017 11:04 AM, Stanislaw Gruszka wrote: >> >For historic reasons we have separate cases for mic_fail and >> >mic_fail_no_key. But with current code we can merge those

Re: [PATCH 3/8] rsi: add support for legacy power save

Amitkumar Karwar writes: > From: Karun Eagalapati > > This patch adds support for legacy power save. Necessary > configuration frames are downloaded to firmware when power save > is enabled/disabled > > Signed-off-by: Karun Eagalapati

RE: [EXT] Re: pull-request mwifiex-firmware 2017-08-01

Hi Brian, > On Tue, Aug 01, 2017 at 06:35:40PM +, Ganapathi Bhat wrote: > > The following changes since commit > 11db1311bff6fed84d11b03fbfb142209c1239ab: > > > > linux-firmware: update Marvell PCIe-USB8897-A2 firmware image > (2017-06-05 02:19:40 -0700) > > > > are available in the git

Re: [PATCH 1/8] rsi: add support for rf-kill functionality

Amitkumar Karwar writes: > From: "pavani.muthyala" > > This patch implements rfkill_poll handler. Also, necessary changes > are done in interface up and down handler to support rfkill > functionality. > > Signed-off-by: pavani.muthyala

Re: [PATCH] mac80211: remove mic_fail_no_key label

On Wed, Aug 02, 2017 at 11:10:11AM +0200, Arend van Spriel wrote: > On 8/2/2017 11:04 AM, Stanislaw Gruszka wrote: > >For historic reasons we have separate cases for mic_fail and > >mic_fail_no_key. But with current code we can merge those cases, > >as we already have NULL key check since: > > >

Re: [PATCH 3/3] brcmfmac: fix wrong num_different_channels when mchan feature enabled

Wright Feng writes: > The num_different_channels in wiphy info is not correct when firmware > supports mchan. When mchan is on, num_different_channels is always > overridden to 1 in brcmf_setup_ifmodes. Correct the logic by moving > num_different_channels setting

Re: [PATCH 1/3] brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/opensecurity mode

Wright Feng writes: > When setting wpa_auth to WPA_AUTH_NONE(1) in AP mode with WEP secuirty, > firmware will set privacy bit and add WPA OUI in VENDOR IE in beacon and > probe response. typo: "secuirty" > It confuses the supplicant in sation client by the security

Re: [PATCH v4] rtlwifi: Replace hardcode value with macro

Larry Finger writes: > On 07/31/2017 06:14 AM, Souptick Joarder wrote: >> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval >> and hw->max_rate_tries are replaced by macro. > > That is NOT what your patch does. It only removes a comment! Granted, >

Re: [PATCH] mac80211: remove mic_fail_no_key label

On 8/2/2017 11:04 AM, Stanislaw Gruszka wrote: For historic reasons we have separate cases for mic_fail and mic_fail_no_key. But with current code we can merge those cases, as we already have NULL key check since: commit a66b98db570a638afd909459e1e6bfa272344bd3 Author: Arik Nemtsov

[PATCH] mac80211: remove mic_fail_no_key label

For historic reasons we have separate cases for mic_fail and mic_fail_no_key. But with current code we can merge those cases, as we already have NULL key check since: commit a66b98db570a638afd909459e1e6bfa272344bd3 Author: Arik Nemtsov Date: Thu Jun 23 00:00:24 2011 +0300

Re: [PATCH 2/3] brcmfmac: Add support for CYW4373 SDIO/USB chipset

Arend van Spriel writes: > On 01-08-17 17:10, Chi-Hsien Lin wrote: >> >> >> On 08/01/2017 8:43, Arend van Spriel wrote: >>> >>> >>> On 01-08-17 10:48, Wright Feng wrote: From: Chi-Hsien Lin These changes add support for

Re: [PATCH] rt2x00: Fix MMIC countermeasures.

Hi The patch was mangled by your email client, but I'm not sure if it is correct anyway. On Tue, Aug 01, 2017 at 06:43:33PM -0400, Michael Skeffington wrote: > Mac80211 doesnt check MMIC failure until after falling through the > check for whether the packet is decrypted. Therefore, this driver