NACK: [PATCH] rtlwifi: btcoex: make function btc8723b2ant_dac_swing static

2017-08-12 Thread Colin Ian King
On 12/08/17 23:00, Colin King wrote: > From: Colin Ian King > > The function btc8723b2ant_dac_swing is local to the source and > does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'btc8723b2ant_dac_swing' was not declared.

[PATCH] rtlwifi: btcoex: make function btc8723b2ant_dac_swing static

2017-08-12 Thread Colin King
From: Colin Ian King The function btc8723b2ant_dac_swing is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'btc8723b2ant_dac_swing' was not declared. Should it be static? Signed-off-by: Colin Ian King

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-12 Thread James Feeney
Hey Kalle Still, a problem: On 08/12/2017 01:35 AM, Kalle Valo wrote: > Kalle Valo writes: > >> Andreas Born writes: >> >>> Earlier today I submitted the patch (bonding: require speed/duplex >>> only for 802.3ad, alb and tlb) [2] that only

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

2017-08-12 Thread Kalle Valo
Kalle Valo writes: > Andreas Born writes: > >> Earlier today I submitted the patch (bonding: require speed/duplex >> only for 802.3ad, alb and tlb) [2] that only partially reverts what is >> a regression following my aforementioned logic. This