Re: [PATCH 5/6] ath10k: add memory dump support for QCA6174/QCA9377

2017-08-15 Thread Ben Greear
On 08/15/2017 01:23 AM, Kalle Valo wrote: From: Alan Liu Add memory dump to the firmware crash data file which is provided to user space via devcoredump interface. This makes it easier for firmware engineers to debug firmware crashes. Due to increased memory

Re: pull-request: wireless-drivers 2017-08-15

2017-08-15 Thread David Miller
From: Kalle Valo Date: Tue, 15 Aug 2017 14:30:34 +0300 > more fixes to net tree for 4.13. More info in the signed tag below, > please let me know if there are any problems. Pulled, thanks Kalle.

Re: [v7 wlcore: add missing nvs file name info for wilink8

2017-08-15 Thread Sebastian Reichel
Hi, On Mon, Aug 14, 2017 at 12:15:16PM +, Reizer, Eyal wrote: > The following commits: > commit c815fdebef44 ("wlcore: spi: Populate config firmware data") > commit d776fc86b82f ("wlcore: sdio: Populate config firmware data") > > Populated the nvs entry for wilink6 and wilink7 only while it

[PATCH 7/9] qtnfmac: introduce counter for Rx underflow events

2017-08-15 Thread Sergey Matyukevich
Introduce counter for Rx underflow events. Export this counter via debugfs. Signed-off-by: Sergey Matyukevich --- drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 16 ++-- .../net/wireless/quantenna/qtnfmac/pearl/pcie_bus_priv.h | 1 +

[PATCH 6/9] qtnfmac: switch to kernel circ_buf implementation

2017-08-15 Thread Sergey Matyukevich
Current code for both Rx and Tx queue management is a custom and incomplete circular buffer implementation. It makes a lot of sense to switch to kernel built-in circ_buf implementation. Signed-off-by: Sergey Matyukevich ---

[PATCH 5/9] qtnfmac: decrease default Tx queue size

2017-08-15 Thread Sergey Matyukevich
Avoid extra buffering in driver by default. Use max hardware Tx queue size. Signed-off-by: Sergey Matyukevich --- drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 8/9] qtnfmac: modify tx reclaim locking

2017-08-15 Thread Sergey Matyukevich
Perform additional reclaim from qtnf_pcie_data_tx. Lock tx_lock serves only reclaim synchronization purposes. Rename it accordingly and improve granularity moving this lock to qtnf_pcie_data_tx_reclaim. Signed-off-by: Sergey Matyukevich ---

[PATCH 4/9] qtnfmac: skb2rbd_attach cleanup

2017-08-15 Thread Sergey Matyukevich
Update PCIE_HDP_TX_HOST_Q_WR_PTR register in skb2rbd_attach as a part of procedure of passing new Rx buffer to hardware. Sync up all the the qtnf_rx_bd descriptor updates before passing Rx buffer to hardware. Signed-off-by: Sergey Matyukevich ---

[PATCH 1/9] qtnfmac: remove unused qtnf_rx_frame declaration

2017-08-15 Thread Sergey Matyukevich
Signed-off-by: Sergey Matyukevich --- drivers/net/wireless/quantenna/qtnfmac/bus.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/bus.h b/drivers/net/wireless/quantenna/qtnfmac/bus.h index dda05003d522..56e5fed92a2a

[PATCH 3/9] qtnfmac: use __netdev_alloc_skb_ip_align

2017-08-15 Thread Sergey Matyukevich
Replace __dev_alloc_skb and explicit NET_IP_ALIGN alignment by built-in __netdev_alloc_skb_ip_align function. Signed-off-by: Sergey Matyukevich --- drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-)

[PATCH] qtnfmac: pcie datapath optimizations and cleanups

2017-08-15 Thread Sergey Matyukevich
Hello Kalle and all, This patchset implements several optimizations and cleanups for pcie datapath in qtnfmac driver. Major changes include: - switch to kernel circ_buf implementation - modify tx reclaim locking - introduce counter for rx underflow events Signed-off-by: Sergey Matyukevich

[PATCH 2/9] qtnfmac: switch to napi_gro_receive

2017-08-15 Thread Sergey Matyukevich
Use napi_gro_receive() rather than netif_receive_skb() in qtnfmac driver. Signed-off-by: Sergey Matyukevich --- drivers/net/wireless/quantenna/qtnfmac/pearl/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [5/6] ath10k: add memory dump support for QCA6174/QCA9377

2017-08-15 Thread Kalle Valo
Kalle Valo wrote: > Add memory dump to the firmware crash data file which is provided to user > space > via devcoredump interface. This makes it easier for firmware engineers to > debug > firmware crashes. > > Due to increased memory consumption the memory dump is

pull-request: wireless-drivers 2017-08-15

2017-08-15 Thread Kalle Valo
Hi Dave, more fixes to net tree for 4.13. More info in the signed tag below, please let me know if there are any problems. Kalle The following changes since commit 5f5d03143de5e0c593da4ab18fc6393c2815e108: brcmfmac: fix memleak due to calling brcmf_sdiod_sgtable_alloc() twice (2017-07-27

Re: AP mode with Broadcom 4330

2017-08-15 Thread Russell King - ARM Linux
On Tue, Aug 15, 2017 at 10:58:42AM +0100, Russell King - ARM Linux wrote: > Sorry for the confusion - the problem with iwlwifi turned out to be a > lack of /dev/random entropy, causing hostapd to forcefully deauth the > client - that was hidden when running hostapd from systemd and is only >

Re: AP mode with Broadcom 4330

2017-08-15 Thread Russell King - ARM Linux
On Tue, Aug 15, 2017 at 11:42:12AM +0200, Arend van Spriel wrote: > On 15-08-17 10:22, Russell King - ARM Linux wrote: > >On Mon, Aug 14, 2017 at 11:25:03PM -0700, ros...@gmail.com wrote: > >>If using rtlwifi, you could try using rtl8xxxu and see if you get > >>similar results. ¯\_(ツ)_/¯ > > >

Re: AP mode with Broadcom 4330

2017-08-15 Thread Arend van Spriel
On 15-08-17 10:22, Russell King - ARM Linux wrote: On Mon, Aug 14, 2017 at 11:25:03PM -0700, ros...@gmail.com wrote: If using rtlwifi, you could try using rtl8xxxu and see if you get similar results. ¯\_(ツ)_/¯ I'm using rtl8xxxu. I don't think rtlwifi supports the 8192eu - it certainly does

[PATCH v3] nl80211: add an option to allow MFP without requiring it

2017-08-15 Thread Emmanuel Grumbach
User space can now allow the kernel to associate to an AP that requires MFP or that doesn't have MFP enabled in the same NL80211_CMD_CONNECT command. The driver / firmware will decide whether to use it or not. Add a feature bit to inform the user space the kernel supports this setting. This new

[PATCH 6/6] ath10k: add memory dump support QCA988X

2017-08-15 Thread Kalle Valo
Copy two regions of registers and bigger DRAM region to the dump file. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/coredump.c | 40 1 file changed, 40 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/coredump.c

[PATCH 5/6] ath10k: add memory dump support for QCA6174/QCA9377

2017-08-15 Thread Kalle Valo
From: Alan Liu Add memory dump to the firmware crash data file which is provided to user space via devcoredump interface. This makes it easier for firmware engineers to debug firmware crashes. Due to increased memory consumption the memory dump is disabled by default.

[PATCH 4/6] ath10k: add coredump_mask module parameter

2017-08-15 Thread Kalle Valo
For memory dump support (it consumes quite a lot of memory) we need to control what is exactly stored to the crash dump. Add a module parameter call coredump_mask to do that. It's a bit mask of these values: enum ath10k_fw_crash_dump_type { ATH10K_FW_CRASH_DUMP_REGISTERS = 0,

[PATCH 3/6] ath10k: detach coredump.c from debug.c

2017-08-15 Thread Kalle Valo
Now coredump is totally separate from debug.c and doesn't depend on CONFIG_ATH10K_DEBUGFS anymore, only on CONFIG_DEV_COREDUMP. Also remove leftovers from the removed debugfs file support. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/Makefile |2 +

[PATCH 2/6] ath10k: refactor firmware crashdump code to coredump.c

2017-08-15 Thread Kalle Valo
In preparation to add RAM dump support. No functional changes, only moving code and renaming function names. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/Makefile |1 drivers/net/wireless/ath/ath10k/core.c |3

[PATCH 1/6] ath10k: remove deprecated fw_crash_dump debugfs file

2017-08-15 Thread Kalle Valo
The fw_crash_dump file was deprecated by commmit 727000e6af34 ("ath10k: support dev_coredump for crash dump") in v4.11 in favor of dev_coredump interface, remove it now for good. Everyone should use dev_coredump now. Signed-off-by: Kalle Valo ---

Re: AP mode with Broadcom 4330

2017-08-15 Thread Russell King - ARM Linux
On Mon, Aug 14, 2017 at 11:25:03PM -0700, ros...@gmail.com wrote: > If using rtlwifi, you could try using rtl8xxxu and see if you get > similar results. ¯\_(ツ)_/¯ I'm using rtl8xxxu. I don't think rtlwifi supports the 8192eu - it certainly does not list the device id: Bus 001 Device 002: ID

[PATCH 0/6] ath10k: firmware ramdump support

2017-08-15 Thread Kalle Valo
Hi, here are patches adding firmware ramdump support to make it easier to debug firmware crashes. This also removes the depracated fw_crash_dump debugfs file. Kalle --- Alan Liu (1): ath10k: add memory dump support for QCA6174/QCA9377 Kalle Valo (5): ath10k: remove deprecated

[PATCH v2] nl80211: add an option to allow MFP without requiring it

2017-08-15 Thread Emmanuel Grumbach
User space can now allow the kernel to associate to an AP that requires MFP or that doesn't have MFP enabled in the same NL80211_CMD_CONNECT command. The driver / firmware will decide whether to use it or not. Add a feature bit to inform the user space the kernel supports this setting. This new

Re: [PATCH] nl80211: add an option to allow MFP without requiring it

2017-08-15 Thread Grumbach, Emmanuel
On Tue, 2017-08-15 at 10:49 +0300, Emmanuel Grumbach wrote: > On Tue, 2017-08-15 at 10:16 +0300, Kalle Valo wrote: > > "Grumbach, Emmanuel" writes: > > > > > On Mon, 2017-08-14 at 20:14 +0300, Kalle Valo wrote: > > > > Emmanuel Grumbach

Re: [PATCH] nl80211: add an option to allow MFP without requiring it

2017-08-15 Thread Grumbach, Emmanuel
On Tue, 2017-08-15 at 10:16 +0300, Kalle Valo wrote: > "Grumbach, Emmanuel" writes: > > > On Mon, 2017-08-14 at 20:14 +0300, Kalle Valo wrote: > > > Emmanuel Grumbach writes: > > > > > > > User space can now allow the kernel to

[PATCH] brcmfmac: add CLM download support

2017-08-15 Thread Wright Feng
From: Chung-Hsien Hsu The firmware for brcmfmac devices includes information regarding regulatory constraints. For certain devices this information is kept separately in a binary form that needs to be downloaded to the device. This patch adds support to download this

Re: [PATCH 05/11] rsi: handle station connection in AP mode

2017-08-15 Thread Kalle Valo
Arend van Spriel writes: @@ -1157,18 +1159,81 @@ static int rsi_mac80211_sta_add(struct ieee80211_hw *hw, { struct rsi_hw *adapter = hw->priv; struct rsi_common *common = adapter->priv; + bool sta_exist = false;

Re: [PATCH] nl80211: add an option to allow MFP without requiring it

2017-08-15 Thread Kalle Valo
"Grumbach, Emmanuel" writes: > On Mon, 2017-08-14 at 20:14 +0300, Kalle Valo wrote: >> Emmanuel Grumbach writes: >> >> > User space can now allow the kernel to associate to an AP >> > that requires MFP or that doesn't have MFP enabled

Re: AP mode with Broadcom 4330

2017-08-15 Thread rosenp
If using rtlwifi, you could try using rtl8xxxu and see if you get similar results. ¯\_(ツ)_/¯ On Tue, 2017-08-15 at 00:30 +0100, Russell King - ARM Linux wrote: > On Fri, Jul 28, 2017 at 09:50:21PM +0200, Arend van Spriel wrote: > > On 28-07-17 19:49, Russell King - ARM Linux wrote: > > >

Re: [PATCH] nl80211: add an option to allow MFP without requiring it

2017-08-15 Thread Grumbach, Emmanuel
On Mon, 2017-08-14 at 13:36 -0700, Igor Mitsyanko wrote: > On 08/14/2017 01:13 PM, Grumbach, Emmanuel wrote: > > > It is kind of not clear right now for drivers where to get > > > information from: > > > - NL attributes passed from userspace and forwarded to a driver > > > > Since those exist, it