Re: [PATCH v4 8/9] netlink: fix nla_put_{u8,u16,u32} for KASAN

From: Arnd Bergmann Date: Fri, 22 Sep 2017 23:29:19 +0200 > When CONFIG_KASAN is enabled, the "--param asan-stack=1" causes rather large > stack frames in some functions. This goes unnoticed normally because > CONFIG_FRAME_WARN is disabled with CONFIG_KASAN by default as of commit

Re: [PATCH v4 7/9] rocker: fix rocker_tlv_put_* functions for KASAN

From: Arnd Bergmann Date: Fri, 22 Sep 2017 23:29:18 +0200 > Inlining these functions creates lots of stack variables that each take > 64 bytes when KASAN is enabled, leading to this warning about potential > stack overflow: > > drivers/net/ethernet/rocker/rocker_ofdpa.c: In

[PATCH v2] ath10k: add new cipher suite support

QCA99x0 and QCA4019 family chips support CCMP-256, GCMP-128, and GCMP-256 ciphers in hardware, so advertise support for these. As firmware does not support group management frame ciphers (BIP), handle them in software (mac80211). Reviewed-by: Sebastian Gottschall Cc:

RE: [PATCH] ath10k: add new cipher suite support

> Am 22.09.2017 um 23:17 schrieb Rajkumar Manoharan: > > - ar->hw->wiphy->n_cipher_suites = ARRAY_SIZE(cipher_suites); > > + > > + /* QCA988x and QCA6174 family chips do not support CCMP-256, > GCMP-128 > > +* and GCMP-256 ciphers in hardware. > > +*/ > > + if

Re: [PATCH] ath10k: add new cipher suite support

Am 22.09.2017 um 23:17 schrieb Rajkumar Manoharan: - ar->hw->wiphy->n_cipher_suites = ARRAY_SIZE(cipher_suites); + + /* QCA988x and QCA6174 family chips do not support CCMP-256, GCMP-128 +* and GCMP-256 ciphers in hardware. +*/ + if

[PATCH] mac80211: fix bandwidth computation for TDLS peers

From: Manikanta Pubbisetty Section 11.23.1 of 80211-2016 specification allows TDLS peers to operate on wider bandwidths though they are connected to a BSS which do not support wider bandwidth operations, provided both the peers advertize wider banwidth capabilities.

Re: rtlwifi: rtl8821ae: Fix connection lost problem

On 09/25/2017 03:06 AM, Kalle Valo wrote: Larry Finger wrote: In commit 40b368af4b75 ("rtlwifi: Fix alignment issues"), the read of REG_DBI_READ was changed from 16 to 8 bits. For unknown reasonsi this change results in reduced stability for the wireless connection.

RE: [PATCH v4 4/9] em28xx: fix em28xx_dvb_init for KASAN

From: Arnd Bergmann > Sent: 22 September 2017 22:29 ... > It seems that this is triggered in part by using strlcpy(), which the > compiler doesn't recognize as copying at most 'len' bytes, since strlcpy > is not part of the C standard. Neither is strncpy(). It'll almost certainly be a marker in

[PATCH 2/3] rsi: sdio: Add WOWLAN support for S4 hibernate state

From: Karun Eagalapati We are disabling of interrupts from firmware in freeze handler. Also setting power management capability KEEP_MMC_POWER to make device wakeup for WoWLAN trigger. At restore, we observed a device reset on some platforms. Hence reloading of firmware and

[PATCH 1/3] rsi: sdio: add WOWLAN support for S3 suspend state

From: Karun Eagalapati WoWLAN is supported in RS9113 device through GPIO pin2. wowlan config frame is internally sent to firmware in mac80211 suspend handler. Also beacon miss threshold and keep-alive time values are increased to avoid un-necessary disconnection with AP.

[PATCH 3/3] rsi: sdio: Add WOWLAN support for S5 shutdown state

From: Karun Eagalapati Unlike other power states, WoWLAN configuration does not come from mac80211 for shutdown. Hence configuring the WoWLAN from shut down callback it self. Remaining steps of disabling SDIO interrupts, setting 'MMC_PM_KEEP_POWER' flag are same as other

[PATCH 0/3] rsi: WOWLAN support

From: Amitkumar Karwar This patch series adds WOWLAN support for system's S3, S4 and S5 power states. wakeup through magic packet has been verified in these power states. Karun Eagalapati (3): rsi: sdio: add WOWLAN support for S3 suspend state rsi: sdio: Add

Re: [PATCH] wireless: iwlwifi: fix minor code style issues

On Sat, 2017-09-23 at 12:31 +0200, Christoph Böhmwalder wrote: > Fixes three trivial issues as reported by checkpatch.pl, namely two > switch/case indentation issues and one alignment issue in a multiline comment. > > Signed-off-by: Christoph Böhmwalder > --- Thanks,

[RFC] Add cfg80211/nl80211 support for AP mode 802.11 FT roaming

From: Dedy Lansky Drivers which have integrated AP SME can use this to communicate with userspace (e.g. hostapd) for the purpose of FT roaming processing. cfg80211 API added for driver to indicate received Authentication and Reassociation frames from the roaming STA.

Re: usb/wireless/rsi_91x: use-after-free write in __run_timers

Andrey Konovalov writes: > On Mon, Sep 25, 2017 at 6:26 AM, Kalle Valo wrote: >> Andrey Konovalov writes: >> >>> I've got the following report while fuzzing the kernel with syzkaller. >>> >>> On commit

Re: [PATCH RESEND] wireless: iwlwifi: fix minor code style issues

> Why are you already resending this? Sorry, I guess I was too impatient. I also messed up the spelling in a "To:" line and forgot triv...@kernel.org the first time I sent it, so I figured I'd just fix it in a resend. I'll make sure to wait a little longer next time. -- Regards, Christoph

Re: [PATCH RESEND] wireless: iwlwifi: fix minor code style issues

On Mon, 2017-09-25 at 13:37 +0200, Christoph Böhmwalder wrote: > Fixes three trivial issues as reported by checkpatch.pl, namely two switch/case indentation issues and one alignment issue in a multiline comment. Signed-off-by: Christoph Böhmwalder --- Why are you

[PATCH RESEND] wireless: iwlwifi: fix minor code style issues

Fixes three trivial issues as reported by checkpatch.pl, namely two switch/case indentation issues and one alignment issue in a multiline comment. Signed-off-by: Christoph Böhmwalder --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 7 --- 1 file changed, 4

Re: usb/wireless/rsi_91x: use-after-free write in __run_timers

On Mon, Sep 25, 2017 at 6:26 AM, Kalle Valo wrote: > Andrey Konovalov writes: > >> I've got the following report while fuzzing the kernel with syzkaller. >> >> On commit 6e80ecdddf4ea6f3cd84e83720f3d852e6624a68 (Sep 21). >> >>

[bug report] NFC: st21nfcb: Add support for secure element

Hello Christophe Ricard, The patch 8ae01f796771: "NFC: st21nfcb: Add support for secure element" from Feb 1, 2015, leads to the following static checker warning: drivers/nfc/st-nci/se.c:373 st_nci_hci_event_received() warn: constraint overflow 'ndev->hci_dev->pipes' 127 <= 0-127

Re: [1/7] brcmfmac: handle FWHALT mailbox indication

On 25 September 2017 at 10:26, James Hughes wrote: > On 25 September 2017 at 09:18, Kalle Valo wrote: >> Arend Van Spriel wrote: >> >>> The firmware uses a mailbox to communicate to the host what is going >>> on.

Re: [1/7] brcmfmac: handle FWHALT mailbox indication

On 25 September 2017 at 09:18, Kalle Valo wrote: > Arend Van Spriel wrote: > >> The firmware uses a mailbox to communicate to the host what is going >> on. In the driver we validate the bit received. Various people seen >> the following

pull-request: wireless-drivers 2017-09-25

Hi Dave, here a pull request to net for 4.14, more info in the signed tag below. Please let me know if there are any problems. Kalle The following changes since commit 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e: Linux 4.14-rc1 (2017-09-16 15:47:51 -0700) are available in the git repository

Re: b43: make const arrays static, reduces object code size

Colin Ian King wrote: > From: Colin Ian King > > Don't populate const arrays on the stack, instead make them static. > Makes the object code smaller by over 60 bytes: > > Before: >text data bss dec hex filename >

Re: iwlegacy: make const array static to shink object code size

Colin Ian King wrote: > From: Colin Ian King > > Don't populate const array ac_to_fifo on the stack in an inlined > function, instead make it static. Makes the object code smaller > by over 800 bytes: > >text data bss

Re: [v2] rsi: sdio suspend and resume support

Amitkumar Karwar wrote: > From: Karun Eagalapati > > SDIO suspend and resume handlers are implemented and verified > that device works after suspend/resume cycle. > > Signed-off-by: Karun Eagalapati > Signed-off-by: Amitkumar

Re: [V3, 1/9] qtnfmac: convert channel width from bitfiled to simple enum

Igor Mitsyanko wrote: > From: Igor Mitsyanko > > This will allow to use qlink channel width values to specify BW setting > corresponding to enum nl80211_chan_width. > Current user is converted to apply BIT() macro manually to

Re: mwifiex: make const array tos_to_ac static, reduces object code size

Colin Ian King wrote: > From: Colin Ian King > > Don't populate the read-only const array tos_to_ac on the stack, > instead make it static. Makes the object code smaller by 250 bytes: > > Before: >text data bss dec

Re: [v2] rsi: add version information

Amitkumar Karwar wrote: > From: Pavani Muthyala > > We will dump information about firmware version, firmware file > name and operating mode during initialization. > > Signed-off-by: Pavani Muthyala

Re: [v2] rtl8xxxu: Don't printk raw binary if serial number is not burned in.

Adam Borowski wrote: > I assume that a blank efuse comes with all ones, thus I did not bother > recognizing other possible junk values. This matches 100% of dongles > I've seen (a single Gembird 8192eu). > > Signed-off-by: Adam Borowski Patch applied

Re: brcmsmac: make const array ucode_ofdm_rates static, reduces object code size

Colin Ian King wrote: > From: Colin Ian King > > Don't populate const array ucode_ofdm_rates on the stack, instead make it > static. Makes the object code smaller by 100 bytes: > > Before: >text data bss dec hex

Re: [1/1] wireless: broadcom: brcm80211: use setup_timer() helper

> > It's a frequent problem to have misconfigured name in patchwork. I guess > it happens as the first mail patchwork sees from you is the one stored > to the database. And if that mail has an incorrect name, that will be > used from that onwards. You have only onetime chance to fix it yourself >

Re: [1/1] brcmfmac: use setup_timer() helper

Allen Pais wrote: > Use setup_timer function instead of initializing timer with the > function and data fields. > > Signed-off-by: Allen Pais Patch applied to wireless-drivers-next.git, thanks. 30ac40763939 brcmfmac: use setup_timer() helper --

Re: [1/7] brcmfmac: handle FWHALT mailbox indication

Arend Van Spriel wrote: > The firmware uses a mailbox to communicate to the host what is going > on. In the driver we validate the bit received. Various people seen > the following message: > > brcmfmac: brcmf_sdio_hostmail: Unknown mailbox data content: 0x40012 >

Re: rtlwifi: rtl8821ae: Fix connection lost problem

Larry Finger wrote: > In commit 40b368af4b75 ("rtlwifi: Fix alignment issues"), the read > of REG_DBI_READ was changed from 16 to 8 bits. For unknown reasonsi > this change results in reduced stability for the wireless connection. > This regression was located using

Re: [1/1] wireless: broadcom: brcm80211: use setup_timer() helper

Allen writes: >> >> Also your name in patchwork is just "Allen", without your lastname. I can fix >> it this time, but please register to patchwork to fix your name. (Annoyingly >> patchwork takes the name from it's database, not from the "From:" header) > > Ah that's

Re: [1/1] wireless: broadcom: brcm80211: use setup_timer() helper

> > Also your name in patchwork is just "Allen", without your lastname. I can fix > it this time, but please register to patchwork to fix your name. (Annoyingly > patchwork takes the name from it's database, not from the "From:" header) Ah that's strange. I'll register again. Thanks, - Allen >

Re: [1/1] wireless: broadcom: brcm80211: use setup_timer() helper

Allen wrote: > Use setup_timer function instead of initializing timer with the > function and data fields. > > Signed-off-by: Allen Pais Also your name in patchwork is just "Allen", without your lastname. I can fix it this time, but please

Re: wcn36xx: Disable 5GHz for wcn3620

Loic Poulain wrote: > wcn3620 can only operate on 2.4GHz band due to RF limitation. > If wcn36xx digital block is associated with an external IRIS > RF module, retrieve the id and disable 5GHz band in case of > wcn3620 id. > > Signed-off-by: Loic Poulain

Re: [2/2] ath9k: Avoid a potential deadlock

Ville Syrjälä wrote: > Lockdep warns us that sc_pm_lock and cc_lock can cause a deadlock when > cc_lock is acquired by itself with interrupts enabled. Disable irqs > whenever taking cc_lock to avoid this. > > [ 19.094524] kworker/u2:0/5 just changed the state of lock: > [ 19.094578]

Re: ath10k: make ath10k_hw_ce_regs const

Bhumika Goyal wrote: > Make them const as they are not modified in the file referencing > them. They are only stored in the const field 'hw_ce_reg' of an ath10k > structure. Also, make the declarations in the header const. > > Signed-off-by: Bhumika Goyal

Re: [8/10] ath9k: Use ARRAY_SIZE macro

Thomas Meyer wrote: > Use ARRAY_SIZE macro, rather than explicitly coding some variant of it > yourself. > Found with: find -type f -name "*.c" -o -name "*.h" | xargs perl -p -i -e > 's/\bsizeof\s*\(\s*(\w+)\s*\)\s*\ /\s*sizeof\s*\(\s*\1\s*\[\s*0\s*\]\s*\) > /ARRAY_SIZE(\1)/g'

mwifiex: Firmware wakeup failed in 4.1 kernel

Hi, I'm using 4.1 stock kernel on imx cpu and 8897 wifi chip connected over pcie to cpu. I did stress test by disabling AP in loop when wifi card is connected to perform scanning and reconnect. After 25 attempts I'll get following and after that wifi is unusable: mwifiex_pcie :01:00.0:

Re: [PATCH] mac80211: aead api to reduce redundancy

On Mon, Sep 25, 2017 at 07:22:26AM +0200, Johannes Berg wrote: > > The code moves to crypto/ though, and I'm not even sure I can vouch for > the Makefile choice there. Thanks, I missed that. I don't think this belongs in crypto. This proposed helper is only useful for wireless so it should stay