Re: [PATCH] mwifiex: Use put_unaligned_le32

On 10/05/2017 12:07 PM, Himanshu Jha wrote: In this case, the key is CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. It seems that asm-generic/unaligned.h is set up to include different headers, based on the expected architecture behavior. Yes, asm-generic/unaligned.h looks more appopriate and is

Re: converting mac80211 to TXQs entirely

Johannes Berg writes: > On Thu, 2017-10-05 at 18:28 +0200, Toke Høiland-Jørgensen wrote: > >> I'm been thinking about how to move the airtime fairness scheduler >> out of ath9k and into mac80211 (so more drivers can take advantage of >> it). This will require some

Re: [PATCH] mwifiex: Use put_unaligned_le32

On Thu, Oct 05, 2017 at 11:02:50AM -0700, Brian Norris wrote: > On Thu, Oct 05, 2017 at 08:52:33PM +0530, Himanshu Jha wrote: > > There are various instances where a function used in file say for eg > > int func_align (void* a) > > is used and it is defined in align.h > > But many files don't

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

On Thu, Oct 05, 2017 at 09:16:31PM +0800, Herbert Xu wrote: > On Thu, Oct 05, 2017 at 06:16:20PM +0800, Herbert Xu wrote: > > > > That was my point. Functions like sctp_pack_cookie shouldn't be > > setting the key in the first place. The setkey should happen at > > the point when the key is

Re: [PATCH] mwifiex: Use put_unaligned_le32

On Thu, Oct 05, 2017 at 08:52:33PM +0530, Himanshu Jha wrote: > There are various instances where a function used in file say for eg > int func_align (void* a) > is used and it is defined in align.h > But many files don't *directly* include align.h and rather include > any other header which

Re: [PATCH 00/18] use ARRAY_SIZE macro

On Mon, Oct 02, 2017 at 09:33:12PM -0400, Jérémy Lefaure wrote: > On Mon, 2 Oct 2017 15:22:24 -0400 > bfie...@fieldses.org (J. Bruce Fields) wrote: > > > Mainly I'd just like to know which you're asking for. Do you want me to > > apply this, or to ACK it so someone else can? If it's sent as a

[PATCH v2] net/mac80211/mesh_plink: Convert timers to use timer_setup()

In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. This requires adding a pointer back to the sta_info since container_of() can't resolve the sta_info. Cc:

Re: [08/11] ath10k_sdio: common read write

Hi Gary, On 2017-10-05 15:39, Gary Bisson wrote: Hi Alagu, On Sat, Sep 30, 2017 at 11:07:45PM +0530, silexcom...@gmail.com wrote: From: Alagu Sankar convert different read write functions in sdio hif to bring it under a single read-write path. This helps in

Re: converting mac80211 to TXQs entirely

On Thu, 2017-10-05 at 18:28 +0200, Toke Høiland-Jørgensen wrote: > I'm been thinking about how to move the airtime fairness scheduler > out of ath9k and into mac80211 (so more drivers can take advantage of > it). This will require some changes to the TXQ API that drivers speak > to, so wanted to

Re: converting mac80211 to TXQs entirely

Johannes Berg writes: > Part 2 - where can we go from here > > > Of course - as mentioned in the subject - my goal is to just convert > over to TXQs entirely in mac80211. That would get rid of a LOT of > special case code, like queueing for aggregation setup, powersave

Re: [PATCH] rsi: fix integer overflow warning

On Thu, 2017-10-05 at 15:12 +, David Laight wrote: > From: Joe Perches > > Sent: 05 October 2017 13:19 > > On Thu, 2017-10-05 at 14:05 +0200, Arnd Bergmann wrote: > > > gcc produces a harmless warning about a recently introduced > > > signed integer overflow: > > > > > >

Re: converting mac80211 to TXQs entirely

Part 2 - where can we go from here Of course - as mentioned in the subject - my goal is to just convert over to TXQs entirely in mac80211. That would get rid of a LOT of special case code, like queueing for aggregation setup, powersave buffering (both unicast and multicast), etc. I think the

Re: [PATCH] mwifiex: Use put_unaligned_le32

On Thu, Oct 05, 2017 at 11:41:38AM +0300, Kalle Valo wrote: > Himanshu Jha writes: > > >> > --- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c > >> > +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c > >> > @@ -17,6 +17,7 @@ > >> > * this warranty disclaimer. >

RE: [PATCH] rsi: fix integer overflow warning

From: Joe Perches > Sent: 05 October 2017 13:19 > On Thu, 2017-10-05 at 14:05 +0200, Arnd Bergmann wrote: > > gcc produces a harmless warning about a recently introduced > > signed integer overflow: > > > > drivers/net/wireless/rsi/rsi_91x_hal.c: In function 'rsi_prepare_mgmt_desc': > >

Re: [PATCH 00/11] SDIO support for ath10k

Hi Alagu, First of all, thank you for sharing your patches, this will be a very nice improvement to have SDIO QCA9377 working with ath10k. I've tried your series with Nitrogen7 [1] platform which is supported in mainline already. It uses BD-SDMAC [2] which uses the same module as the SX-SDMAC.

Re: [PATCH] NFC: fdp: make struct nci_ops static

On Thu, 5 Oct 2017 10:47:12 +0100 Colin King wrote: > From: Colin Ian King > > The structure nci_ops is local to the source and does not need to > be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'nci_ops' was

Re: [RFC v2 1/2] fq: support filtering a given tin

Johannes Berg writes: > From: Johannes Berg > > Add to the FQ API a way to filter a given tin, in order to > remove frames that fulfil certain criteria according to a > filter function. > > This will be used by mac80211 to remove frames

[RFC v2 1/2] fq: support filtering a given tin

From: Johannes Berg Add to the FQ API a way to filter a given tin, in order to remove frames that fulfil certain criteria according to a filter function. This will be used by mac80211 to remove frames belonging to an AP VLAN interface that's being removed.

[RFC v2 2/2] mac80211: only remove AP VLAN frames from TXQ

From: Johannes Berg When removing an AP VLAN interface, mac80211 currently purges the entire TXQ for the AP interface. Fix this by using the FQ API introduced in the previous patch to filter frames. Signed-off-by: Johannes Berg ---

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

On Thu, Oct 05, 2017 at 06:16:20PM +0800, Herbert Xu wrote: > > That was my point. Functions like sctp_pack_cookie shouldn't be > setting the key in the first place. The setkey should happen at > the point when the key is generated. That's sctp_endpoint_init > which AFAICS only gets called in

Re: [RFC 1/2] fq: support filtering a given tin

On Thu, 2017-10-05 at 14:24 +0200, Toke Høiland-Jørgensen wrote: > > + for (;;) { > > + head = >new_flows; > > + if (list_empty(head)) { > > + head = >old_flows; > > + if (list_empty(head)) > > + break; > > +

Re: [RFC 1/2] fq: support filtering a given tin

Johannes Berg writes: > +static void fq_tin_filter(struct fq *fq, > + struct fq_tin *tin, > + fq_skb_filter_t filter_func, > + void *filter_data, > + fq_skb_free_t free_func) > +{ >

Re: [PATCH] rsi: fix integer overflow warning

On Thu, 2017-10-05 at 14:05 +0200, Arnd Bergmann wrote: > gcc produces a harmless warning about a recently introduced > signed integer overflow: > > drivers/net/wireless/rsi/rsi_91x_hal.c: In function 'rsi_prepare_mgmt_desc': > include/uapi/linux/swab.h:13:15: error: integer overflow in

converting mac80211 to TXQs entirely

Hi, Part 1 is just a dump of my notes analysing the current TX scheme. driver setup non-QUEUE_CONTROL drivers * have >= 4 queues - per-AC queues [0-3] * have < 4 queues - all goes to queue 0 QUEUE_CONTROL drivers * hwsim (doesn't handle CAB correctly) - each vif:

[PATCH] rsi: fix integer overflow warning

gcc produces a harmless warning about a recently introduced signed integer overflow: drivers/net/wireless/rsi/rsi_91x_hal.c: In function 'rsi_prepare_mgmt_desc': include/uapi/linux/swab.h:13:15: error: integer overflow in expression [-Werror=overflow] (((__u16)(x) & (__u16)0x00ffU) << 8) | \

[RFC 1/2] fq: support filtering a given tin

From: Johannes Berg Add to the FQ API a way to filter a given tin, in order to remove frames that fulfil certain criteria according to a filter function. This will be used by mac80211 to remove frames belonging to an AP VLAN interface that's being removed.

[RFC 2/2] mac80211: only remove AP VLAN frames from TXQ

From: Johannes Berg When removing an AP VLAN interface, mac80211 currently purges the entire TXQ for the AP interface. Fix this by using the FQ API introduced in the previous patch to filter frames. Signed-off-by: Johannes Berg ---

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

On Wed, Oct 04, 2017 at 09:37:58PM -0700, David Miller wrote: > > > I'm not talking about the code-path in question. I'm talking > > about the function which generates the secret key in the first > > place. AFAICS that's only called in GFP_KERNEL context. What > > am I missing? > > The setkey

Re: [PATCH] PCI MSI: allow alignment restrictions on vector allocation

On Thu, 5 Oct 2017, Daniel Drake wrote: > On Mon, Oct 2, 2017 at 10:38 PM, Thomas Gleixner wrote: > > What's wrong with just using the legacy INTx emulation if you cannot > > allocate 4 MSI vectors? > > The Legacy interrupt simply doesn't work for the wifi on at least 8 new

Re: [08/11] ath10k_sdio: common read write

Hi Alagu, On Sat, Sep 30, 2017 at 11:07:45PM +0530, silexcom...@gmail.com wrote: > From: Alagu Sankar > > convert different read write functions in sdio hif to bring it under a > single read-write path. This helps in having a common dma bounce buffer >

[PATCH] NFC: fdp: make struct nci_ops static

From: Colin Ian King The structure nci_ops is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'nci_ops' was not declared. Should it be static? Signed-off-by: Colin Ian King ---

Re: [PATCH] mwifiex: Use put_unaligned_le32

Himanshu Jha writes: >> > --- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c >> > +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c >> > @@ -17,6 +17,7 @@ >> > * this warranty disclaimer. >> > */ >> > >> > +#include >> >> I don't think this is correct.

Re: [PATCH] mwifiex: Use put_unaligned_le32

On Thu, Oct 05, 2017 at 10:23:37AM +0300, Kalle Valo wrote: > Himanshu Jha writes: > > > Use put_unaligned_le32 rather than using byte ordering function and > > memcpy which makes code clear. > > Also, add the header file where it is declared. > > > > Done using

[PATCH v6] brcmfmac: add CLM download support

From: Chung-Hsien Hsu The firmware for brcmfmac devices includes information regarding regulatory constraints. For certain devices this information is kept separately in a binary form that needs to be downloaded to the device. This patch adds support to download this

Re: [PATCH] mwifiex: Use put_unaligned_le32

Himanshu Jha writes: > Use put_unaligned_le32 rather than using byte ordering function and > memcpy which makes code clear. > Also, add the header file where it is declared. > > Done using Coccinelle and semantic patch used is : > > @ rule1 @ > identifier tmp;

Re: [PATCH v3 1/2] dt-bindings: add device tree binding for Allwinner XR819 SDIO Wi-Fi

Icenowy Zheng writes: > 于 2017年10月4日 GMT+08:00 下午6:11:45, Maxime Ripard > 写到: >>On Wed, Oct 04, 2017 at 10:02:48AM +, Arend van Spriel wrote: >>> On 10/4/2017 11:03 AM, Icenowy Zheng wrote: >>> > >>> > >>> > 于 2017年10月4日 GMT+08:00

Re: [PATCH] net/mac80211/mesh_plink: Convert timers to use

On Wed, 2017-10-04 at 17:49 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to all timer callbacks, switch to using the new timer_setup() > and from_timer() to pass the timer pointer explicitly. This requires > adding a pointer back to the

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

Hi all, Please drop my patches, Qualcomm is working internally and will submit the MSI patch by themselves. Thanks. Hi Daniel, I'll try your patches tomorrow. Best regards, AceLan Kao. 2017-10-02 12:21 GMT+08:00 Daniel Drake : > Hi AceLan, > > On Thu, Sep 28, 2017 at 4:28

[PATCH] ath10k: fix sending wmi cmd during the tdls teardown

From: Anilkumar Kolli The current firmware 10.4-3.5.1-00035 on QCA9888 supports TDLS explicit mode, it expects WMI_TDLS_ENABLE_PASSIVE for tdls setup and WMI_TDLS_DISABLE for tdls teardown. Signed-off-by: Anilkumar Kolli ---

[PATCH 2/2] ath10k: block offchannel operations if TDLS session is active

From: Anilkumar Kolli Do not allow off channel operations like scans/roc when there are active TDLS sessions. The Current firmware 10.4-3.5.1-00035 on QCA9888 does not supports any offchannel operations on active TDLS sessions, either driver needs to block the

[PATCH 1/2] ath10k: move ath10k_mac_tdls_vif*() functions

From: Anilkumar Kolli To be able to use ath10k_mac_tdls_vif_stations_count() in ath10k_hw_scan() in the following patch, move the functions earlier in the file. This commit is pure code move, no functional changes. Signed-off-by: Anilkumar Kolli