[PATCH v3] mac80211: aead api to reduce redundancy

Currently, the aes_ccm.c and aes_gcm.c are almost line by line copy of each other. This patch reduce code redundancy by moving the code in these two files to crypto/aead_api.c to make it a higher level aead api. The file aes_ccm.c and aes_gcm.c are removed and all the functions there are now

Re: [PATCH] mac80211: aead api to reduce redundancy

2017-10-09 3:09 GMT-04:00 Johannes Berg : > On Sun, 2017-10-08 at 01:43 -0400, Xiang Gao wrote: >> >> By the way, I'm still struggling on how to run unit tests. It might >> take time for me to make it run on my machine. > > I can run it easily, so don't worry about it

Re: Contributing to Linux-wireless drivers.

On Tue, Oct 10, 2017 at 05:14:02PM +0530, Himanshu Jha wrote: > Hello everyone, > > Apologies for that forwarded email which I hurriedly sent without > editing here! > > I am an undergraduate student in ECE(3rd year) and wish to contribute to > linux-wireless > drivers. I am familiar with the

Re: [PATCH] rtl8xxxu: mark expected switch fall-throughs

On 10/10/2017 12:35 PM, Jes Sorensen wrote: > On 10/10/2017 03:30 PM, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. > > While this isn't harmful, to me this looks like pointless patch churn > for zero

Setting single rate in ath10k broken by "reject/clear user rate mask if not usable"

At one point, you could set a single rate using 'iw' and ath10k would convert that to a special firmware API that fixed all data traffic to a particular rate set. (Management frames and broadcast will not be affected by setting the rates when using ath10k). But, with the commit below, a command

[PATCH] rtl8xxxu: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Cc: Jes Sorensen Cc: Kalle Valo Cc: linux-wireless@vger.kernel.org Cc: net...@vger.kernel.org Signed-off-by: Gustavo A. R. Silva

Re: ath10k hang on rmmod after fw crash in 4.13.3+ hacks

On 10/10/2017 12:07 PM, Ben Greear wrote: I loaded a crashing firmware (it crashes early since it ran OOM), and then tried to rmmod it. rmmod hangs, with this stack: Looks like this is a hang related to napi, and I had a patch from an older kernel that is probably not needed anymore...maybe

Re: [PATCH] rtl8xxxu: mark expected switch fall-throughs

On 10/10/2017 03:30 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. While this isn't harmful, to me this looks like pointless patch churn for zero gain and it's just ugly. Jes Cc: Jes Sorensen

Re: What should setting rate on 'AP' interface mean?

On 10/10/2017 12:09 PM, Adrian Chadd wrote: Hi, IIRC, I think it's the drivers job to determine per-peer fixed rate. From poking at the 10.1 firmware source, seems that setting fixed RC on the vdev should over-ride all of the stations, but it did not appear to be working as expected... While

Re: What should setting rate on 'AP' interface mean?

Hi, IIRC, I think it's the drivers job to determine per-peer fixed rate. -adrian On 10 October 2017 at 11:34, Ben Greear wrote: > I was trying to use 'iw' to set rates on an AP interface, hoping it would > set tx-rates on all of the stations (peers) to the same

What should setting rate on 'AP' interface mean?

I was trying to use 'iw' to set rates on an AP interface, hoping it would set tx-rates on all of the stations (peers) to the same thing. It appears that the ath10k driver will set ratesets on all stations if we specify more than one rate, but if we specify a single rate, it does not iterate

Re: [RFC 1/3] mac80211: Add TXQ scheduling API

Johannes Berg writes: >> In particular, I'm not sure what the right thing to do in regards to >> PS wakeup is... > > Can you explain what you were _trying_ to do? > > I don't like calling this "driver_buffered" because that's already a > term for frames that are

Re: [RFC 1/3] mac80211: Add TXQ scheduling API

Johannes Berg writes: > On Tue, 2017-10-10 at 16:02 +0200, Toke Høiland-Jørgensen wrote: > >> +++ b/net/mac80211/agg-tx.c >> @@ -226,9 +226,11 @@ ieee80211_agg_start_txq(struct sta_info *sta, >> int tid, bool enable) >> clear_bit(IEEE80211_TXQ_AMPDU,

Re: [RFC 1/3] mac80211: Add TXQ scheduling API

> In particular, I'm not sure what the right thing to do in regards to > PS wakeup is... Can you explain what you were _trying_ to do? I don't like calling this "driver_buffered" because that's already a term for frames that are buffered in the driver ... :-) PS is complicated, we basically

Re: [RFC 2/3] ath9k: Move to mac80211 TXQ scheduling API

On Tue, 2017-10-10 at 16:02 +0200, Toke Høiland-Jørgensen wrote: > This removes TXQ scheduling from ath9k and changes it to use the > mac80211 TXQ scheduling API introduced in the previous patch. I can't really comment on this, but I'll note that the patches need to be all combined into a single

Re: [RFC 1/3] mac80211: Add TXQ scheduling API

On Tue, 2017-10-10 at 16:02 +0200, Toke Høiland-Jørgensen wrote: > +++ b/net/mac80211/agg-tx.c > @@ -226,9 +226,11 @@ ieee80211_agg_start_txq(struct sta_info *sta, > int tid, bool enable) > clear_bit(IEEE80211_TXQ_AMPDU, >flags); > > clear_bit(IEEE80211_TXQ_STOP, >flags); >

Re: net/wireless/ray_cs: Convert timers to use

On Tue, Oct 10, 2017 at 1:26 AM, Kalle Valo wrote: > Kees Cook wrote: > >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to pass the timer

[PATCH] staging: wilc1000: replace redundant computations with 0

From: Colin Ian King Shifting and masking strHostIfSetMulti->enabled is redundant since enabled is a bool and so all the shifted and masked values will be zero. Replace them with zero to simplify the code. Detected by CoverityScan, CID#1339458 ("Bad shift operation")

[RFC 2/3] ath9k: Move to mac80211 TXQ scheduling API

This removes TXQ scheduling from ath9k and changes it to use the mac80211 TXQ scheduling API introduced in the previous patch. Signed-off-by: Toke Høiland-Jørgensen --- drivers/net/wireless/ath/ath9k/ath9k.h | 7 +- drivers/net/wireless/ath/ath9k/channel.c | 2 -

[RFC 1/3] mac80211: Add TXQ scheduling API

This adds an API to mac80211 to handle scheduling of TXQs and changes the interface between driver and mac80211 for TXQ handling as follows: - The wake_tx_queue callback interface no longer includes the TXQ. Instead, the driver is expected to retrieve that from ieee80211_next_txq() - Two new

[RFC 3/3] ath10k: Move to mac80211 TXQ scheduling API

This removes TXQ scheduling from ath10k and changes it to use the mac80211 TXQ scheduling API introduced in the previous patch. Signed-off-by: Toke Høiland-Jørgensen --- drivers/net/wireless/ath/ath10k/core.c | 2 -- drivers/net/wireless/ath/ath10k/core.h | 3 ---

Re: [PATCH v2] mac80211: fix STA_SLOW_THRESHOLD htmldocs failure

On Tue, 2017-10-10 at 15:41 +0200, Stanislaw Gruszka wrote: > On Tue, Sep 26, 2017 at 01:48:05PM +0200, Stanislaw Gruszka wrote: > > Patch fixes htmldocs build problem: > > > > Error(.//net/mac80211/sta_info.h:416): cannot understand prototype: > > 'STA_SLOW_THRESHOLD 6000 ' > > > >

Re: [PATCH v2] mac80211: fix STA_SLOW_THRESHOLD htmldocs failure

On Tue, Sep 26, 2017 at 01:48:05PM +0200, Stanislaw Gruszka wrote: > Patch fixes htmldocs build problem: > > Error(.//net/mac80211/sta_info.h:416): cannot understand prototype: > 'STA_SLOW_THRESHOLD 6000 ' > > Signed-off-by: Stanislaw Gruszka > --- > v1 -> v2: just fix

Contributing to Linux-wireless drivers.

Hello everyone, Apologies for that forwarded email which I hurriedly sent without editing here! I am an undergraduate student in ECE(3rd year) and wish to contribute to linux-wireless drivers. I am familiar with the kernel development process and have many patches accepted in the past 2 months

Re: net/wireless/ray_cs: Convert timers to use

Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Kalle Valo > Cc:

Re: mwifiex: Random MAC address during scanning

Ganapathi Bhat wrote: > From: Karthik Ananthapadmanabha > > Driver will advertise RANDOM_MAC support only if the device > supports this feature. > > Signed-off-by: Karthik Ananthapadmanabha > Signed-off-by: Ganapathi Bhat

Re: [2/2] rtlwifi: silence underflow warning

Dan Carpenter wrote: > My static checker complains that we have an upper bound but no lower > bound. I suspect neither are really required but it doesn't hurt to add > a check for negatives. > > Signed-off-by: Dan Carpenter > > diff --git

Re: [v2] p54: don't unregister leds when they are not initialized

Andrey Konovalov wrote: > ieee80211_register_hw() in p54_register_common() may fail and leds won't > get initialized. Currently p54_unregister_common() doesn't check that and > always calls p54_unregister_leds(). The fix is to check priv->registered > flag before calling

[PATCH V5 5/5] ath10k: Fix TDLS peer TX data failure issue on encryped AP

From: Yingying Tang For WPA encryption, QCA6174 firmware(version: WLAN.RM.4.4) will unblock data when M4 was sent successfully. For other encryption which didn't need 4-way handshake firmware will unblock the data when peer authorized. Since TDLS is 3-way handshake host

[PATCH V5 3/5] ath10k: Enable TDLS peer inactivity detection

From: Yingying Tang Enable TDLS peer inactivity detetion feature. QCA6174 firmware(version: WLAN.RM.4.4) support TDLS link inactivity detecting. Set related parameters in TDLS WMI command to enable this feature. Signed-off-by: Yingying Tang

[PATCH V5 4/5] ath10k: Avoid to set WEP key for TDLS peer

From: Yingying Tang TDLS peer do not need WEP key. Setting WEP key will lead to TDLS setup failure. Add fix to avoid setting WEP key for TDLS peer. Signed-off-by: Yingying Tang --- drivers/net/wireless/ath/ath10k/mac.c |2 +- 1 file

[PATCH V5 2/5] ath10k: Enable TDLS peer buffer STA feature

From: Yingying Tang Enable TDLS peer buffer STA feature. QCA6174 firmware(version: WLAN.RM.4.4) support TDLS peer buffer STA, it reports this capability through wmi service map in wmi service ready event. Set related parameter in TDLS WMI command to enable this feature.

[PATCH V5 1/5] mac80211: Enable TDLS peer buffer STA feature

From: Yingying Tang Enable TDLS peer buffer STA feature. Set extended capability bit to enable buffer STA when driver support it. Signed-off-by: Yingying Tang --- include/net/cfg80211.h |3 +++ net/mac80211/tdls.c|5 - 2

[PATCH V5 0/5] Add TDLS feature for ath10k

From: Yingying Tang This patchset is for Rome PCIE chip, it will not affect other hardware Yingying Tang (5): mac80211: Enable TDLS peer buffer STA feature ath10k: Enable TDLS peer buffer STA feature ath10k: Enable TDLS peer inactivity detection ath10k: Avoid

[PATCH 5/5] ath10k: Fix TDLS peer TX data failure issue on encryped AP

From: Yingying Tang For WPA encryption, QCA6174 firmware(version: WLAN.RM.4.4) will unblock data when M4 was sent successfully. For other encryption which didn't need 4-way handshake firmware will unblock the data when peer authorized. Since TDLS is 3-way handshake host

[PATCH 4/5] ath10k: Avoid to set WEP key for TDLS peer

From: Yingying Tang TDLS peer do not need WEP key. Setting WEP key will lead to TDLS setup failure. Add fix to avoid setting WEP key for TDLS peer. Signed-off-by: Yingying Tang --- drivers/net/wireless/ath/ath10k/mac.c |2 +- 1 file

[PATCH 0/5] Add TDLS feature for ath10k

From: Yingying Tang This patchset is for Rome PCIE chip, it will not affect other hardware Yingying Tang (5): mac80211: Enable TDLS peer buffer STA feature ath10k: Enable TDLS peer buffer STA feature ath10k: Enable TDLS peer inactivity detection ath10k: Avoid

[PATCH] MAINTAINERS: update Johannes Berg's entries

From: Johannes Berg Update my MAINTAINERS file entries to list all the right files. Since I'm also the de-facto wireless extensions maintainer, there's little point in excluding those. Signed-off-by: Johannes Berg --- MAINTAINERS | 13

[PATCH 0/5] Add TDLS feature for ath10k

From: Yingying Tang This patchset is for Rome PCIE chip, it will not affect other hardware Yingying Tang (5): mac80211: Enable TDLS peer buffer STA feature ath10k: Enable TDLS peer buffer STA feature ath10k: Enable TDLS peer inactivity detection ath10k: Avoid

[PATCH 1/5] mac80211: Enable TDLS peer buffer STA feature

From: Yingying Tang Enable TDLS peer buffer STA feature. Set extended capability bit to enable buffer STA when driver support it. Signed-off-by: Yingying Tang --- include/net/cfg80211.h |3 +++ net/mac80211/tdls.c|5 - 2

[PATCH 2/5] ath10k: Enable TDLS peer buffer STA feature

From: Yingying Tang Enable TDLS peer buffer STA feature. QCA6174 firmware(version: WLAN.RM.4.4) support TDLS peer buffer STA, it reports this capability through wmi service map in wmi service ready event. Set related parameter in TDLS WMI command to enable this feature.

[PATCH 0/5] Add TDLS feature for ath10k

From: Yingying Tang This patchset is for Rome PCIE chip, it will not affect other hardware Yingying Tang (5): mac80211: Enable TDLS peer buffer STA feature ath10k: Enable TDLS peer buffer STA feature ath10k: Enable TDLS peer inactivity detection ath10k: Avoid

[PATCH 3/5] ath10k: Enable TDLS peer inactivity detection

From: Yingying Tang Enable TDLS peer inactivity detetion feature. QCA6174 firmware(version: WLAN.RM.4.4) support TDLS link inactivity detecting. Set related parameters in TDLS WMI command to enable this feature. Signed-off-by: Yingying Tang

Re: Contributing to Linux-wireless drivers.

On Tue, 2017-10-10 at 11:35 +0530, Himanshu Jha wrote: > > The wiki page https://wireless.wiki.kernel.org/ is not working > correctly, for every page it shows > > "This topic does not exist yet > You've followed a link to a topic that doesn't exist yet. If > permissions > allow, you may create

4.14.0-rc3 iwlwifi: Hardware became unavailable during restart

Hello, I've got this splat after a couple of suspend-resume cycles on my HP-laptop. I haven't had the time to bisect or test other rcs for now. Pasting some logs before the actual WARN_ON, as they may be relevant. Just after the splat the connection is successfully reestablished. [14293.758404]

[PATCH 2/2] ath10k: handle tdls peer events

From: Manikanta Pubbisetty Handle tdls peer events from the target. TDLS events for the peer could be discover, teardown, etc. As of now, adding the logic to handle tdls teardown events alone. Teardown due to peer traffic indication(PTR) timeout is one such teardown

[PATCH 1/2] ath10k: update tdls teardown state to target

From: Manikanta Pubbisetty It is required to update the teardown state of the peer when a tdls link with that peer is terminated. This information is useful for the target to perform some cleanups wrt the tdls peer. Without proper cleanup, target assumes that the peer

Contributing to Linux-wireless drivers.

- Forwarded message from Himanshu Jha - Date: Fri, 6 Oct 2017 02:05:39 +0530 From: Himanshu Jha To: kv...@codeaurora.org Subject: Contributing to Linux-wireless drivers. User-Agent: Mutt/1.5.24 (2015-08-30) Hi Kalle, I am an