Re: [PATCH 1/3] mwifiex: cleanup rx_pkt_lock usage in 11n_rxreorder.c

2017-11-01 Thread Brian Norris
Hi, On Tue, Oct 31, 2017 at 03:12:45PM +0530, Ganapathi Bhat wrote: > From: Karthik Ananthapadmanabha > > Fix the incorrect usage of rx_pkt_lock spinlock. Realsing the > spinlock while the element is still in process is unsafe. The > lock must be released only after the

Re: [PATCH] ath10k: fix recent bandwidth conversion bug

2017-11-01 Thread Sebastian Gottschall
a additional array bounds check would be good Am 01.11.2017 um 21:01 schrieb Christian Lamparter: The commit "cfg80211: make RATE_INFO_BW_20 the default" changed the index of RATE_INFO_BW_20, but the updates to ath10k missed the special bandwidth calculation case in

Re: [PATCH] ath10k: fix recent bandwidth conversion bug

2017-11-01 Thread Sebastian Gottschall
true. good finding. Am 01.11.2017 um 21:01 schrieb Christian Lamparter: The commit "cfg80211: make RATE_INFO_BW_20 the default" changed the index of RATE_INFO_BW_20, but the updates to ath10k missed the special bandwidth calculation case in ath10k_update_per_peer_tx_stats(). Fixes:

[PATCH] ath10k: fix recent bandwidth conversion bug

2017-11-01 Thread Christian Lamparter
The commit "cfg80211: make RATE_INFO_BW_20 the default" changed the index of RATE_INFO_BW_20, but the updates to ath10k missed the special bandwidth calculation case in ath10k_update_per_peer_tx_stats(). Fixes: 842be75c77cb ("cfg80211: make RATE_INFO_BW_20 the default") Signed-off-by: Christian

[PATCH v2 11/12] wil6210: remove suspend time statistics

2017-11-01 Thread Maya Erez
From: Lazar Alexei Currently suspend time statistics are showed through debugfs. Remove time statistics in suspend state since the timing may not be accurate in that state. Signed-off-by: Lazar Alexei Signed-off-by: Maya Erez

[PATCH v2 09/12] wil6210: get suspend reject reason and resume triggers from FW

2017-11-01 Thread Maya Erez
From: Lazar Alexei Upon receiving suspend reject, print reject reason. Upon receiving resume event, print resume triggers. Signed-off-by: Lazar Alexei Signed-off-by: Maya Erez ---

[PATCH v2 04/12] wil6210: abort properly in cfg suspend

2017-11-01 Thread Maya Erez
From: Hamad Kadmany On-going operations were not aborted properly and required locks were not taken. Signed-off-by: Hamad Kadmany Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/cfg80211.c

[PATCH v2 10/12] wil6210: fix PCIe bus mastering in case of interface down

2017-11-01 Thread Maya Erez
From: Lazar Alexei In case of interface down, radio is turned off but PCIe mastering is not cleared. This can cause unexpected PCIe access to the shutdown device. Fix this by clearing PCIe mastering also in case interface is down Signed-off-by: Lazar Alexei

[PATCH v2 01/12] wil6210: run-time PM when interface down

2017-11-01 Thread Maya Erez
From: Lazar Alexei Allow run-time suspend when interface is down, keep card alive when interface is up. If driver is in wmi only or debug_fw mode run-time PM won't suspend. Signed-off-by: Lazar Alexei Signed-off-by: Maya Erez

[PATCH v2 12/12] wil6210: update statistics for suspend

2017-11-01 Thread Maya Erez
From: Lazar Alexei Currently the statistics show how many successful/failed suspend/resume operations the system had. Update the statistics by splitting each successful/failed suspend/resume operations to radio on/off. Signed-off-by: Lazar Alexei

[PATCH v2 06/12] wil6210: add block size checks during FW load

2017-11-01 Thread Maya Erez
From: Lior David When loading FW from file add block size checks to ensure a corrupted FW file will not cause the driver to write outside the device memory. Signed-off-by: Lior David Signed-off-by: Maya Erez

[PATCH v2 08/12] wil6210: missing length check in wil_cfg80211_mgmt_tx

2017-11-01 Thread Maya Erez
From: Lior David Add a length check in wil_cfg80211_mgmt_tx to detect unsigned integer overflow. Signed-off-by: Lior David Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/cfg80211.c | 10

[PATCH v2 03/12] wil6210: refresh FW capabilities during interface up

2017-11-01 Thread Maya Erez
From: Lior David FW capabilities are currently retrieved only during module initialization, but userspace can replace the firmware while interface is down, so refresh the FW capabilities when interface is up (after FW is loaded) to ensure driver functionality matches

[PATCH v2 02/12] wil6210: print human readable names of WMI commands and events

2017-11-01 Thread Maya Erez
From: Dedy Lansky Upon sending/receiving WMI commands/events, print human readable names in addition to id for easier debugging. Signed-off-by: Dedy Lansky Signed-off-by: Maya Erez ---

[PATCH v2 00/12] wil6210 patches

2017-11-01 Thread Maya Erez
Changes from v1: - Fix static buffer allocation in "wil6210: update statistics for suspend" - Fix kbuild bot error on "wil6210: run-time PM when interface down" The following patches include: - Bug fixes - run-time PM when interface down Dedy Lansky (1): wil6210: print human readable names of

[PATCH v2 05/12] wil6210: fix length check in __wmi_send

2017-11-01 Thread Maya Erez
From: Lior David The current length check: sizeof(cmd) + len > r->entry_size will allow very large values of len (> U16_MAX - sizeof(cmd)) and can cause a buffer overflow. Fix the check to cover this case. In addition, ensure the mailbox entry_size is not too small,

[PATCH v2 07/12] wil6210: missing length check in wmi_set_ie

2017-11-01 Thread Maya Erez
From: Lior David Add a length check in wmi_set_ie to detect unsigned integer overflow. Signed-off-by: Lior David Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/wmi.c | 8 +++- 1 file

[RFC] cfg80211: Implement Multiple BSSID capability in scanning

2017-11-01 Thread Jouni Malinen
From: Peng Xu This extends cfg80211 BSS table processing to be able to parse Multiple BSSID element from Beacon and Probe Response frames and to update the BSS profiles in internal database for non-transmitted BSSs. Signed-off-by: Peng Xu

[PATCH 06/11] rtlwifi: rtl_pci: Add ID for 8822BE

2017-11-01 Thread Larry Finger
From: Ping-Ke Shih When the driver for the RTL8822BE is added, it will need an ID for further use. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu

[PATCH 09/11] rtlwifi: rtl_pci: 8822BE puts broadcast and multicast packet to HIQ

2017-11-01 Thread Larry Finger
From: Ping-Ke Shih HIQ has higher priority to transmit after TBTT or beacon. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu Cc: Shaofu

[PATCH 10/11] rtlwifi: Add beacon check mechanism to check if AP settings changed.

2017-11-01 Thread Larry Finger
From: Tsang-Shian Lin AP WiFi settings are changed(channel, bandwidth), but deauth may not received by STA. For these cases, we need to detect and handle beacon changes. Signed-off-by: Tsang-Shian Lin Signed-off-by: Ping-Ke Shih

[PATCH 03/11] rtlwifi: rtl_pci: Simplify some code be eliminating extraneous variables

2017-11-01 Thread Larry Finger
In several places, the code assigns a variable inside an "if" or "case" block, but uses it only once. The code is simplified by eliminating the extraneous variable. With this change, one level of indenting is saved. This patch does not cause any functional changes in the binary code.

[PATCH 11/11] rtlwifi: rtl_pci: Fix the bug when inactiveps is enabled.

2017-11-01 Thread Larry Finger
From: Tsang-Shian Lin Reset the driver current tx read/write index to zero when inactiveps nic off to sync with HW state. Wrong driver tx read/write index will cause Tx fail. Signed-off-by: Tsang-Shian Lin Signed-off-by: Ping-Ke Shih

[PATCH 04/11] rtlwifi: rtl_pci: Add support for 8822be TX/RX BD

2017-11-01 Thread Larry Finger
From: Ping-Ke Shih The number of TX/RX BD desc for 8822BE is 512. The TX/RX BD architecture of 8822BE is the same as 8192EE. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang

[PATCH 01/11] rtlwifi: rtl_pci: Fix formatting errors in pci.h

2017-11-01 Thread Larry Finger
Checkpatch.pl reports a number of formatting problems in this header file. None of the changes cause any functional changes in the driver. Signed-off-by: Larry Finger Cc: Ping-Ke Shih Cc: Yan-Hsuan Chuang Cc: Birming Chiu

[PATCH 05/11] rtlwifi: rtl_pci: Add fill_tx_special_desc to issue H2C data, and process TXOK in interrupt.

2017-11-01 Thread Larry Finger
From: Ping-Ke Shih With the RTL8822BE, an H2C tx queue is added to download FW and special data. This change implements the support code in rtl_pci. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang

[PATCH 07/11] rtlwifi: rtl_pci: Extend recognized interrupt parameters from two to four ISR

2017-11-01 Thread Larry Finger
From: Ping-Ke Shih 8822be checks H2CQ by int_d, so we extend to four ISR. Also, irq_mask is extended to four. Signed-off-by: Ping-Ke Shih Signed-off-by: Larry Finger Cc: Yan-Hsuan Chuang Cc: Birming Chiu

[PATCH 00/11] rtlwifi: rtl_pci: Update mini driver for RTL8822BE

2017-11-01 Thread Larry Finger
These changes are for the 4.15 stream. The modifications implement nearly all the changes needed to allow the RTL8822BE in staging to use rtl_pci in the wireless tree. The only exceptions are related to BT coexistence, which will be added once btcoex is updated. Once these patches reach

[PATCH 02/11] rtlwifi: rtl_pci: Fix formatting problems in pci.c

2017-11-01 Thread Larry Finger
Checkpatch.pl reports a number of formatting problems in this source file. None of the changes cause any functional changes in the driver. Signed-off-by: Larry Finger Cc: Ping-Ke Shih Cc: Yan-Hsuan Chuang Cc: Birming Chiu

[PATCH 08/11] rtlwifi: rtl_pci: Refactor TX/RX flow

2017-11-01 Thread Larry Finger
From: Steven Ting After this refactoring, the variables wp and rp in TX ring can only be updated in OP_TX and TX_OK respectively without protection. The other changes are listed below: 1. remove avl_desc from TX ring, because it can be calculated by wp and rp.

[PATCH 1/2] rsi: move rsi_sdio_reinit_device() out of CONFIG_PM

2017-11-01 Thread Amitkumar Karwar
From: Amitkumar Karwar This function is generic. It doesn't contain wowlan specific code. It should not be under CONFIG_PM. This patch resolves compilation errors observed when CONFIG_PM flag is disabled. Reported-by: kbuild test robot

[PATCH 2/2] rsi: fix kbuild reported build errors with CONFIG_PM off

2017-11-01 Thread Amitkumar Karwar
From: Amitkumar Karwar Some wowlan related code was outside CONFIG_PM flag which caused these build errors. They are fixed by moving that code under CONFIG_PM flag. Reported-by: kbuild test robot Fixes: ef71ed0608c ("rsi: sdio: Add WOWLAN

Re: ath: Incorrect regDomainPairs/allCountries settings

2017-11-01 Thread Kalle Valo
Sven Eckelmann writes: > I just had two inquiries from Vietnam and Singapore regarding the used CTL > limits by Atheros based chips. I've checked through the code and noticed that > regd_common.h assigns SG to APL6_WORLD and VN to NULL1_WORLD. > > * SG: APL6_WORLD

Re: [PATCH 5/6] ath10k: add memory dump support for QCA6174/QCA9377

2017-11-01 Thread Kalle Valo
Kalle Valo writes: > From: Alan Liu > > Add memory dump to the firmware crash data file which is provided to user > space > via devcoredump interface. This makes it easier for firmware engineers to > debug > firmware crashes. > > Due to

[PATCH] iwlegacy: remove redundant pointer sta_priv

2017-11-01 Thread Colin King
From: Colin Ian King Pointer sta_priv is assigned but never read, hence it is redundant and can be removed. Cleans up clang warning: drivers/net/wireless/intel/iwlegacy/4965-rs.c:2163:2: warning: Value stored to 'sta_priv' is never read Signed-off-by: Colin Ian King

Re: ath10k: Wifi slow on the XPS13 (9360) (QCA6174)

2017-11-01 Thread Kalle Valo
Thorsten Leemhuis writes: > Lo! On 29.10.2017 08:27, Kalle Valo wrote: >> Thorsten Leemhuis writes: >>> On 03.10.2017 01:40, Ryan Hsu wrote: On 10/01/2017 01:59 AM, Thorsten Leemhuis wrote: >> ath10k_pci :3a:00.0: Direct firmware load for