rtl8821ae dbi read question

2017-11-04 Thread Nik Nyby
In drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c, we have this function: static u8 _rtl8821ae_dbi_read(struct rtl_priv *rtlpriv, u16 addr) { u16 read_addr = addr & 0xfffc; u8 tmp = 0, count = 0, ret = 0; rtl_write_word(rtlpriv, REG_DBI_ADDR, read_addr);

Re: [PATCH] rtlwifi: remove redundant initialization to cfg_cmd

2017-11-04 Thread Larry Finger
On 11/04/2017 02:37 PM, Colin King wrote: From: Colin Ian King cfg_cmd is initialized to zero and this value is never read, instead it is over-written in the start of a do-while loop. Remove the redundant initialization. Cleans up clang warning:

[PATCH] rtlwifi: remove redundant initialization to cfg_cmd

2017-11-04 Thread Colin King
From: Colin Ian King cfg_cmd is initialized to zero and this value is never read, instead it is over-written in the start of a do-while loop. Remove the redundant initialization. Cleans up clang warning: drivers/net/wireless/realtek/rtlwifi/core.c:1750:22: warning:

[PATCH] brcmfmac: add support for external 32khz clock

2017-11-04 Thread Simon Shields
Some boards use an external 32khz clock for low-power mode timing. Make sure the clock is powered on while the chipset is active. Signed-off-by: Simon Shields --- .../devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 2 ++

Re: [PATCH] staging: wilc1000: Fix bssid buffer offset in Txq

2017-11-04 Thread Dan Carpenter
This driver really needs proper structs and datatypes so this doesn't happen again and so that you and Colin stop reverting each other's *pu8CurrByte++ = ((strHostIfSetMulti->enabled >> 8) & 0xFF); assignments: regards, dan carpenter