Re: [PATCH] mt76: fix debugfs_simple_attr.cocci warnings

Hi Kalle, On Thu, Dec 07, 2017 at 03:42:39PM +0200, Kalle Valo wrote: kbuild test robot writes: drivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING: fops_regval should be defined with DEFINE_DEBUGFS_ATTRIBUTE Use DEFINE_DEBUGFS_ATTRIBUTE rather than

linux-next: manual merge of the wireless-drivers-next tree with the wireless-drivers tree

Hi all, Today's linux-next merge of the wireless-drivers-next tree got a conflict in: drivers/net/wireless/intel/iwlwifi/pcie/drv.c between commit: 567deca8e72d ("iwlwifi: add new cards for 9260 and 22000 series") from the wireless-drivers tree and commit: 2f7a3863191a ("iwlwifi:

Re: Where does rtlwifi/rtl8188ee identifies interrupt type?

On 12/06/2017 11:01 PM, Farhan Khan wrote: Hi all, I am reading through the rtlwifi code, specifically rtl8188ee code. I am trying to find the driver handles interrupts, reads from the card and identifies what type of interrupt it receives. I believe it will utilize the REG_HISR and REG_HIMR

Re: [PATCH v2 4/4] ath10k: WMI: add hw params entry for wcn3990

Rakesh Pillai writes: > Add hw params entry for wcn3990 and populate various > target specific values for wcn3990. > > Signed-off-by: Rakesh Pillai > Signed-off-by: Govind Singh New warning:

Re: [PATCH v2 2/4] ath10k: WMI: Add management tx by reference support over wmi

Rakesh Pillai writes: > HL1.0 firmware branch, used in wcn3990, transmits management > frames by reference over WMI. > > Add support for management tx by reference over WMI. > > Signed-off-by: Rakesh Pillai > Signed-off-by: Govind Singh

Re: [PATCH v2 1/4] ath10k: WMI: modify svc bitmap parsing for wcn3990

Rakesh Pillai writes: > Due to the limitation of wmi tlv parsing logic, if there are > two parameters in a wmi event with same tlv tag, we can get only > the last value, as it overwrites the prev value of the same tlv tag. > > The service ready event in wcn3990 contains

Re: ath10k: Fix invalid STS_CAP_OFFSET_MASK.

Ben Greear wrote: > The 10.4 firmware defines this as a 3-bit field, as does the > mac80211 stack. The 4th bit is defined as CONF_IMPLICIT_BF > at least in the firmware header I have seen. This patch > fixes the ath10k wmi header to match the firmware. > >

Re: ath6kl: improve endianness handling

Kenneth Lu wrote: > Replace ntohs with be16_to_cpu to do endian conversions for ethhdr > h_proto assignment. > > Signed-off-by: Kenneth Lu > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks.

Re: [2/3] ath9k: move spectral scan support under a separate config symbol

Matthias Schiffer wrote: > At the moment, spectral scan support, and with it RELAY, is always enabled > with ATH9K[_HTC]_DEBUGFS. Spectral scan support is currently the only user > of RELAY in ath9k, and it unconditionally reserves a relay channel. > > Having

Re: [PATCH 1/3] ath9k: remove stray backslash in Makefile

Jakub Kicinski writes: > On Mon, 27 Nov 2017 18:56:21 +0100, Matthias Schiffer wrote: >> Signed-off-by: Matthias Schiffer >> --- >> drivers/net/wireless/ath/ath9k/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git

Re: ath10k: use 64-bit crash dump timestamps

Arnd Bergmann wrote: > The dump format uses 64-bit timestamps already, but calling > getnstimeofday() only returns a 32-bit number on 32-bit architectures, > so that will overflow in y2038. > > This changes it to use ktime_get_real_ts64() instead. > > Signed-off-by: Arnd

Re: ath6kl: remove redundant variable ies_len

Kenneth Lu wrote: > To get rid of W=1 warning: variable ‘ies_len’ set but not used. > Variable ies_len is being assigned but never read. > > Signed-off-by: Kenneth Lu > Reviewed-by: Steve deRosier > Signed-off-by: Kalle Valo

Re: pull-request: iwlwifi 2017-12-05

Luca Coelho writes: > Here is my third set of fixes for 4.15. The most important fixes are > for the new 9000 series where we were not handling some offloads > correctly and secure connections were totally broken. There is also 4 > new PCI IDs and an ROC fix on P2P. More

Re: [v1] brcmfmac: Avoid build error with make W=1

Andy Shevchenko wrote: > When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for > the first run, all next ones are okay. > > CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o >

Re: ssb: make SSB a menuconfig to ease disabling it all

Vincent Legoll wrote: > No need to get into the submenu to disable all SSB-related > config entries. > > This makes it easier to disable all SSB config options > without entering the submenu. It will also enable one > to see that en/dis-abled state from the outside

Re: [PATCH] mt76: fix returnvar.cocci warnings

kbuild test robot writes: > drivers/net/wireless/mediatek/mt76/mt76x2_main.c:86:5-8: Unneeded variable: > "ret". Return "0" on line 112 > > > Remove unneeded variable used to store return value. > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > Fixes: a5f6039c8f9c

Re: [PATCH] mt76: fix debugfs_simple_attr.cocci warnings

kbuild test robot writes: > drivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING: fops_regval > should be defined with DEFINE_DEBUGFS_ATTRIBUTE > > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: >

Re: [v8,1/3] dt-bindings: net: add mt76 wireless device binding

Felix Fietkau wrote: > Add documentation describing how device tree can be used to configure > wireless chips supported by the mt76 driver. > > Signed-off-by: Felix Fietkau 3 patches applied to wireless-drivers-next.git, thanks. 9402f8eb9bed dt-bindings: net:

Re: [v3] bcma: Adjust block comment

Ashish Kalra wrote: > use * for block comments in multiple lines according to kernel coding > style > > Reported by: checkpatch.pl > > Signed-off-by: Ashish Kalra > Reviewed-by: Himanshu Jha Patch applied to

Re: mwifiex: cfg80211: do not change virtual interface during scan processing

Xinming Hu wrote: > From: Limin Zhu > > (1) Change virtual interface operation in cfg80211 process reset and > reinitilize private data structure. > (2) Scan result event processed in main process will dereference private > data structure concurrently,

Re: [v3] mwifiex: do not support change AP interface to station mode

Xinming Hu wrote: > Firmware do not support change interface from micro-ap mode > to station mode, forbid this operation > > Signed-off-by: Cathy Luo > Signed-off-by: Xinming Hu Patch applied to wireless-drivers-next.git, thanks.

Re: rsi: fix memory leak on buf and usb_reg_buf

Colin Ian King wrote: > From: Colin Ian King > > In the cases where len is too long, the error return path fails to > kfree allocated buffers buf and usb_reg_buf. The simplest fix is to > perform the sanity check on len before the

Re: [V2] wlcore, wl1251: fix spelling: "Couldnt" -> "Couldn't" and remove error on -ENOMEM

Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in error message text. Also remove the > error message on an kzalloc failure as this is redundant. > > Signed-off-by: Colin Ian King

Re: wlcore: allow elp during wowlan suspend

"Reizer, Eyal" wrote: > when enabling wowlan and entering suspend the last write to the firmware > allowing it to go into elp mode was not completing before suspend, leaving > the firmware running in full active mode consuming high power. > Use an immediate call instead of a work

Re: wlcore: use boottime for fw time sync

Arnd Bergmann wrote: > Using getnstimeofday()/timespec_to_ns() causes an overflow on 32-bit > architectures in 2038, and may suffer from time jumps due to > settimeofday() or leap seconds. > > I don't see a reason why this needs to be UTC, so either monotonic > or boot time would

Re: [v2] mwl8k: Expand non-DFS 5G channels

Weixiao Zhang wrote: > Add non-DFS 5G upper channels (149-165) besides existed 4 lower channels > (36, 40, 44, 48). > > Signed-off-by: Weixiao Zhang Patch applied to wireless-drivers-next.git, thanks. 4628257bf300 mwl8k: Expand non-DFS 5G channels

Re: rtlwifi: rtl818x: remove redundant check for cck_power > 15

Colin Ian King wrote: > From: Colin Ian King > > cck_poweri cannot be greated than 15 as is derived from the bottom 4 bits > from riv->channels[channel - 1].hw_value & 0xf. Hence the check for it > being greater than 15 is redundant and can

Re: [1/3] rtlwifi: Reduce IO in RX interrupt to boost throughput

Ping-Ke Shih wrote: > From: Ping-Ke Shih > > Check remaining count of RX packets cost a lot of CPU time, so only update > when the counter decreases to zero. In old flow, the counter was updated > once a RX packet is received. > > Signed-off-by: Steven

Re: rtlwifi: Convert individual interrupt results to struct

Larry Finger wrote: > With the RTL8822BE and later devices, the number of interrupt vectors > has grown from 2 to 4. At this point, saving and passing those vectors > in a struct makes more sense than using individual scaler variables. > > In two of the drivers, code

Re: [01/10] brcmfmac: Fix parameter order in brcmf_sdiod_f0_writeb()

Arend Van Spriel wrote: > From: Ian Molton > > All the other IO functions are the other way round in this > driver. Make this one match. > > Signed-off-by: Ian Molton > Signed-off-by: Arend van Spriel

RE: ICT Service Desk

Dear Outlook User, We received your request to delete your Outlook email Account, We will process your request within 24 hours. All features associated with your Outlook email account will be lost. To retain your Account, kindly Cancel Request to continue using our services. CANCEL

Re: [PATCH 00/10] brcmfmac: restructuring sdio access functions

Arend van Spriel writes: > On 12/7/2017 9:49 AM, Kalle Valo wrote: >> Arend van Spriel writes: >> >>> On 11/13/2017 9:35 PM, Arend van Spriel wrote: These patches were originally submitted by Ian Molton a while ago so

Re: [PATCH] brcmsmac: use ARRAY_SIZE on rfseq_updategainu_events

On 12/7/2017 11:20 AM, Colin King wrote: From: Colin Ian King Use the ARRAY_SIZE macro on rfseq_updategainu_events to determine size of the array. Improvement suggested by coccinelle. Acked-by: Arend van Spriel Signed-off-by: Colin

RE: [EXT] Re: [PATCH 1/3] mwifiex: cleanup rx_pkt_lock usage in 11n_rxreorder.c

Hi Doug/Brian > -Original Message- > From: diand...@google.com [mailto:diand...@google.com] On Behalf Of > Doug Anderson > Sent: Wednesday, November 08, 2017 2:45 AM > To: Ganapathi Bhat > Cc: Brian Norris; linux-wireless@vger.kernel.org; Cathy Luo; Xinming Hu; > Zhiyuan Yang; James Cao;

[PATCH] brcmsmac: use ARRAY_SIZE on rfseq_updategainu_events

From: Colin Ian King Use the ARRAY_SIZE macro on rfseq_updategainu_events to determine size of the array. Improvement suggested by coccinelle. Signed-off-by: Colin Ian King --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 3

[PATCH] brcmfmac: Support 43455 save-restore (SR) feature if FW include -sr

From: Double Lo This patch will add 43455 into the save-restore(SR) capable chip list, so the SR engine will be enabled with 43455 FW which built-in the -sr function. Signed-off-by: Double Lo ---

Re: [v4 5/8] Bluetooth: btrsi: add new rsi bluetooth driver

Hi Amitkumar, > Redpine bluetooth driver is a thin driver which depends on > 'rsi_91x' driver for transmitting and receiving packets > to/from device. It creates hci interface when attach() is > called from 'rsi_91x' module. > > Signed-off-by: Prameela Rani Garnepudi >

Re: [PATCH 00/10] brcmfmac: restructuring sdio access functions

On 12/7/2017 9:49 AM, Kalle Valo wrote: Arend van Spriel writes: On 11/13/2017 9:35 PM, Arend van Spriel wrote: These patches were originally submitted by Ian Molton a while ago so decided to resubmit them. This is a first series of 10 patches. Tested using

Re: [PATCH 00/10] brcmfmac: restructuring sdio access functions

Arend van Spriel writes: > On 11/13/2017 9:35 PM, Arend van Spriel wrote: >> These patches were originally submitted by Ian Molton a while ago so decided >> to resubmit them. This is a first series of 10 patches. Tested using BCM4354 >> device which showed no

Re: [PATCH 00/10] brcmfmac: restructuring sdio access functions

On 11/13/2017 9:35 PM, Arend van Spriel wrote: These patches were originally submitted by Ian Molton a while ago so decided to resubmit them. This is a first series of 10 patches. Tested using BCM4354 device which showed no regression. It is intended for 4.16 (no rush ;-) ) and applies to the