Re: [PATCH 1/2] cfg80211/nl80211: Optional authentication offload to userspace

Hi Jouni, > This interface allows the host driver to offload the authentication to > user space. This is exclusively defined for host drivers that do not > define separate commands for authentication and association, but rely on > userspace SME (e.g., in wpa_supplicant for the

Re: [PATCH] nl80211: Introduce scan flags to emphasize requested scan behavior

Hi Jouni, > This commit defines new scan flags (LOW_SPAN, LOW_POWER, HIGH_LATENCY) > to emphasize the requested scan behavior for the driver. These flags are > optional and are mutually exclusive. Driver shall resort to default > behavior if a respective flag is not supported. The implementation

rsi_91x: Low bandwidth: sends ~100 Kbits/sec, receives ~1.5 Mbits/sec

Hi Amitkumar, Yet another observation with RS-9113 module. I managed to setup an access point on my board with RS-9113 connected either via SDIO (this one is soldered on my board) or via USB (this is your RS9113 Evaluation Board Rev 4.0). But regardless the module I use I still see the same

RE: [PATCH] nl80211: Introduce scan flags to emphasize requested scan behavior

> Can't we have some kind of capability indication that the driver supports > each of these flags or not? Otherwise we get into a situation where you just > have to try the flag and hope it works, since it doesn't look like drivers > are required to error out if they don't support the flag.

[PATCH v2 5/9] wil6210: prevent parallel suspend and dump collection

Suspend and crash dump operations can happen simultaneously in case there is a FW assert during the suspend procedure or when SSR calls all the devices crashdump callbacks. To prevent that, a new flag is added, indicating that the dumps collection is in progress, in order to allow the

[PATCH v2 4/9] wil6210: set platform features based on FW capabilities

In some cases the platform should be aware of the FW capabilities to decide which feature to enable. For example, FW can control the external REF clock for power saving. Driver should notify the platform about that, to allow platform power management optimization. Signed-off-by: Maya Erez

[PATCH v2 8/9] wil6210: remove leftover "FIXME"s

From: Dedy Lansky "FIXME: IRQ mask debug" and "FIXME: interrupts enabled - for debug" can be removed because wil6210_debug_irq_mask() is now considered production feature. "FIXME FW can transmit only ucast frames to peer" and "FIXME real ring_id instead of hard

[PATCH v2 1/9] wil6210: support Scheduled scan

From: Dedy Lansky Add support for sched_scan_start/stop by sending PNO commands to FW. Driver reports max_sched_scan_reqs and invokes cfg80211_sched_scan_results upon receiving WMI_SCHED_SCAN_RESULT_EVENTID from FW. Signed-off-by: Dedy Lansky

[PATCH v2 7/9] wil6210: configurable broadcast TX MCS

From: Lior David Add 2 module parameters that control broadcast/multicast TX packets: 1. bcast_mcs0_limit - specify the maximum packet size that will be sent with MCS 0. 2. bcast_mcs - specify the MCS index to use when sending packets larger than above limit.

[PATCH v2 6/9] wil6210: add support for headroom configuration

From: Lazar Alexei Add module parameter for configuring the headroom size in the skb allocation. Signed-off-by: Lazar Alexei Signed-off-by: Maya Erez --- drivers/net/wireless/ath/wil6210/txrx.c | 28

[PATCH v2 0/9] wil6210 patches

Changes from v1: - Fix code review comments on "wil6210: support Scheduled scan" The following patches include several wil6210 fixes. Dedy Lansky (2): wil6210: support Scheduled scan wil6210: remove leftover "FIXME"s Lazar Alexei (2): wil6210: support 40bit DMA addresses wil6210: add

Re: [PATCH] mt76x2: eeprom: fix typo in mt76x2_get_power_info_5g()

Colin Ian King writes: > On 14/12/17 10:46, Lorenzo Bianconi wrote: >> Fix typo in 5GHz power vs channel eeprom parsing >> >> Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") >> Signed-off-by: Lorenzo Bianconi >> --- >>

Re: [PATCH 2/3] rtlwifi: Add beacon check mechanism to check if AP settings changed.

On 12/14/2017 06:35 AM, Kalle Valo wrote: Larry Finger writes: From: Tsang-Shian Lin +bool rtl_check_beacon_key(struct ieee80211_hw *hw, void *data, unsigned int len) +{ + struct rtl_priv *rtlpriv = rtl_priv(hw); + struct rtl_mac

Re: [PATCH] mt76x2: eeprom: fix typo in mt76x2_get_power_info_5g()

On 14/12/17 10:46, Lorenzo Bianconi wrote: > Fix typo in 5GHz power vs channel eeprom parsing > > Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") > Signed-off-by: Lorenzo Bianconi > --- > drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c | 2 +- > 1 file

[PATCH 02/14] mt76: fix returnvar.cocci warnings

From: Fengguang Wu drivers/net/wireless/mediatek/mt76/mt76x2_main.c:86:5-8: Unneeded variable: "ret". Return "0" on line 112 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: a5f6039c8f9c ("mt76: add

[PATCH 04/14] mt76x2: fix transmission of encrypted management frames

Hardware encryption seems to break encrypted unicast mgmt tx. Unfortunately the hardware TXWI header does not have a bit to indicate that a frame is software encrypted, so sw-encrypted frames need to use a different WCID. For that to work, the CCMP PN needs to be generated in software, which makes

[PATCH 01/14] mt76: fix debugfs_simple_attr.cocci warnings

From: Fengguang Wu drivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING: fops_regval should be defined with DEFINE_DEBUGFS_ATTRIBUTE Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Semantic patch information: Rationale:

[PATCH 08/14] mt76x2: convert between per-chain tx power and combined output

Using both chains adds max. 3 dBm. A similar worst-case calculation is being used in ath9k as well to ensure that the hardware stays within regulatory limits Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/mt76x2_init.c | 3 +++

[PATCH 00/14] mt76 fixes

Felix Fietkau (10): mt76x2: remove some harmless WARN_ONs in tx status and rx path mt76x2: fix transmission of encrypted management frames mt76x2: increase OFDM SIFS time mt76x2: add channel argument to eeprom tx power functions mt76x2: initialize channel power limits at probe time

[PATCH 14/14] mt76x2: init: fix rx filter default value during init

From: Lorenzo Bianconi mt76x2_mac_start writes dev->rxfilter to the hardware. It also happens during init, before dev->rxfilter is filled with the initval register value, leading to issues like promisc mode being enabled unconditionally. Fix this by reading the

[PATCH 09/14] mt76x2: remove MAC address limitation for multi-vif setups

The hardware has a separate set of registers to configure a per-interface MAC address. Signed-off-by: Lorenzo Bianconi Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/mt76x2.h | 1 +

[PATCH 07/14] mt76x2: initialize channel power limits at probe time

This allows user space to query the real hardware limits directly Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c | 11 drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.h | 1 + drivers/net/wireless/mediatek/mt76/mt76x2_init.c | 30

[PATCH 10/14] mt76x2: clean up MAC/BSSID address initialization

Drop the use of the EEPROM address entirely, rely on interface address only Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/mt76x2_init.c | 11 --- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c | 14 ++ 2 files changed, 18 insertions(+),

[PATCH 12/14] mt76x2: init: disable APCLI by default

From: Lorenzo Bianconi It is no longer necessary for client mode operation, vif index entries 8-16 are no longer used Signed-off-by: Lorenzo Bianconi Signed-off-by: Felix Fietkau ---

[PATCH 11/14] mt76x2: drop wiphy->addresses

Now that the MAC address limitation is resolved, we no longer need a MAC address list Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/mt76x2.h | 2 -- drivers/net/wireless/mediatek/mt76/mt76x2_init.c | 16 +--- 2 files changed, 1

[PATCH 13/14] mt76x2: configure rx filter based on monitor mode setting

Due to an unrelated issue, the MT_RX_FILTR_CFG_PROMISC flag is currently unset, which means that monitor mode is unconditionally enabled. Toggle this flag based on the mac80211 monitor mode setting instead Signed-off-by: Felix Fietkau ---

[PATCH 03/14] mt76x2: remove some harmless WARN_ONs in tx status and rx path

Discard affected packets instead. Should reduce the frequency of bogus bug reports Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c | 28 - 1 file changed, 14 insertions(+), 14 deletions(-) diff --git

Re: [v3,1/4] ath10k: WMI: modify svc bitmap parsing for wcn3990

Rakesh Pillai wrote: > Due to the limitation of wmi tlv parsing logic, if there are > two parameters in a wmi event with same tlv tag, we can get only > the last value, as it overwrites the prev value of the same tlv tag. > > The service ready event in wcn3990 contains

Re: wcn36xx: Reduce spinlock in indication handler

Bjorn Andersson wrote: > The purpose of pushing indication on a list and handle these in a > separate worker is to allow the handlers to sleep. It does therefor not > make much sense to hold the queue spinlock through the entire indication > worker function. > > By

Re: ath9k_htc: Add a sanity check in ath9k_htc_ampdu_action()

Dan Carpenter wrote: > Smatch generates a warning here: > > drivers/net/wireless/ath/ath9k/htc_drv_main.c:1688 > ath9k_htc_ampdu_action() > error: buffer overflow 'ista->tid_state' 8 <= 15 > > I don't know if it's a real bug or not but the other paths through

Re: [PATCH 0/2] Fix two possible NULL pointer dereferencing issues

On 2017-12-14 13:03, Lorenzo Bianconi wrote: > Lorenzo Bianconi (2): > mt76: fix possible NULL pointer dereferencing in mt76x2_ampdu_action() > mt76: fix possible NULL pointer dereferencing in > mt76x2_mac_write_txwi() For both patches: Acked-by: Felix Fietkau

Re: [PATCH] mt76x2: eeprom: fix typo in mt76x2_get_power_info_5g()

On 2017-12-14 11:46, Lorenzo Bianconi wrote: > Fix typo in 5GHz power vs channel eeprom parsing > > Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") > Signed-off-by: Lorenzo Bianconi Acked-by: Felix Fietkau

Re: wcn36xx: Add hardware scan offload support

Loic Poulain wrote: > Current hw_scan implementation does not trigger offloaded > hardware scan and seems to only put the device in a kind of > listening mode (beacon/probe-response) for software scan. > Since no probe request are generated by the software, current >

Re: [v2, 1/2] dt: bindings: add new dt entry for ath10k calibration variant

Sven Eckelmann wrote: > The bus + bmi-chip-id + bmi-board-id is not enough to identify the correct > board data file on QCA4019 based devices. Multiple different boards share > the same values. Only the original reference designs can currently be > identified and

Re: [PATCHv2, 1/3] ath10k: remove MAC80211_DEBUGFS dependency on ath10k_sta_statistics

ako...@qti.qualcomm.com wrote: > Remove CONFIG_MAC80211_DEBUGFS dependency on ath10k_sta_statistics(). > ath10k_sta_statistics() has per sta tx/rx stats and this should not > be dependent on MAC80211_DEBUGFS. > > No changes in functionality. > > Signed-off-by: Anilkumar Kolli

Re: [v5 5/8] Bluetooth: btrsi: add new rsi bluetooth driver

On Wed, Dec 13, 2017 at 7:16 PM, Marcel Holtmann wrote: > Hi Amitkumar, > >> Redpine bluetooth driver is a thin driver which depends on >> 'rsi_91x' driver for transmitting and receiving packets >> to/from device. It creates hci interface when attach() is >> called from

[PATCH] wireless: Always rewrite generated files from scratch

ertificates have their timestamps modified between builds and thereby trigger the generation rules. Fixes: 715a12334764 ("wireless: don't write C files on failures") Signed-off-by: Thierry Reding <tred...@nvidia.com> --- Based on next-20171214 net/wireless/Makefile | 4 ++-- 1 file chang

Re: [PATCH] ath10k: fix recent bandwidth conversion bug

Christian Lamparter writes: > On Monday, November 20, 2017 11:57:21 AM CET Kalle Valo wrote: >> Christian Lamparter writes: >> >> > On Wednesday, November 1, 2017 9:37:53 PM CET Sebastian Gottschall wrote: >> >> a additional array bounds check would be

Re: regulatory.db file for ath10k

(please don't top post) "KAVITA MATHUR" writes: > I do not want to use regulatory.db. Can you please share your ath10k build > configuration? I may be missing something in configuration. If you don't want to use regulatory.db you can just ignore the warning and continue to use

Re: rt2800usb firmware rt2870.bin 0.36 not scanning

On Wed, Dec 13, 2017 at 11:24:28PM +, Craig McQueen wrote: > > Actually, I was wrong. With the 3.14.x Yocto-built kernel, this no-scan > > issue > > only happens with the Edup with the 5390 chipset, and the D-Link is fine. > > > > But further testing with the 4.4.12 Yocto-built kernel shows

Re: wlcore: fix unused function warning

Arnd Bergmann wrote: > The newly added wlcore_fw_sleep function is called conditionally, > which causes a warning without CONFIG_PM: > > drivers/net/wireless/ti/wlcore/main.c:981:12: error: 'wlcore_fw_sleep' > defined but not used [-Werror=unused-function] > > Instead of trying

Re: [1/1] rtlwifi: always initialize variables given to RT_TRACE()

Nicolas Iooss wrote: > In rtl_rx_ampdu_apply(), when rtlpriv->cfg->ops->get_btc_status() > returns false, RT_TRACE() is called with the values of variables > reject_agg and agg_size, which have not been initialized. > > Always initialize these variables in order to

Re: [PATCH v3 1/3] mac80211: Add TXQ scheduling API

On 2017-12-14 13:15, Toke Høiland-Jørgensen wrote: > Felix Fietkau writes: > >> On 2017-10-31 12:27, Toke Høiland-Jørgensen wrote: >>> This adds an API to mac80211 to handle scheduling of TXQs and changes the >>> interface between driver and mac80211 for TXQ handling as follows:

Re: [1/3] rtlwifi: rtl_pci: 8822BE puts broadcast and multicast packet to HIQ

Larry Finger wrote: > From: Ping-Ke Shih > > Making this change to HIQ, which has high priority, improves the response > time for transmission after TBTT or beacon. > > Signed-off-by: Ping-Ke Shih > Signed-off-by: Larry

Re: brcmfmac: enlarge buffer size of caps to 512 bytes

Wright Feng wrote: > The buffer size of return of cap iovar is greater than 256 bytes in some > firmwares. For instance, the return size of cap iovar is 271 bytes in 4373 > 13.10.246.79 firmare. It makes feature capability parsing failed because > caps buffer is default

Re: [01/10] brcmfmac: Split brcmf_sdiod_buffrw function up.

Arend Van Spriel wrote: > From: Ian Molton > > This function needs to be split up into separate read / write variants > for clarity. > > Signed-off-by: Ian Molton > Reviewed-by: Arend van Spriel

Re: brcmsmac: use ARRAY_SIZE on rfseq_updategainu_events

Colin Ian King wrote: > From: Colin Ian King > > Use the ARRAY_SIZE macro on rfseq_updategainu_events to determine > size of the array. Improvement suggested by coccinelle. > > Signed-off-by: Colin Ian King >

Re: brcmfmac: Support 43455 save-restore (SR) feature if FW include -sr

Wright Feng wrote: > From: Double Lo > > This patch will add 43455 into the save-restore(SR) capable chip list, so > the SR engine will be enabled with 43455 FW which built-in the -sr > function. > > Signed-off-by: Double Lo

Re: [PATCH 2/3] rtlwifi: Add beacon check mechanism to check if AP settings changed.

Larry Finger writes: > From: Tsang-Shian Lin > > AP WiFi settings are changed(channel, bandwidth), but deauth may not > received by STA. For these cases, we need to detect and handle beacon > changes. > > Signed-off-by: Tsang-Shian Lin

Re: [v4 5/8] Bluetooth: btrsi: add new rsi bluetooth driver

Marcel Holtmann writes: >> Thanks for your review. >> We have addressed these comments and submitted v5. > > minor comment from my side, but otherwise looks good to me. Due to the > dependency, I think this should go via wireless-drivers tree. > > Kalle, I think it is up to

Re: [PATCH v3 1/3] mac80211: Add TXQ scheduling API

Felix Fietkau writes: > On 2017-10-31 12:27, Toke Høiland-Jørgensen wrote: >> This adds an API to mac80211 to handle scheduling of TXQs and changes the >> interface between driver and mac80211 for TXQ handling as follows: >> >> - The wake_tx_queue callback interface no longer

[PATCH 1/2] mt76: fix possible NULL pointer dereferencing in mt76x2_ampdu_action()

Initialize mt76_txq pointer after ieee80211_txq pointer check. Remove space after the pointer cast Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x2_main.c | 4 +++- 1 file

[PATCH 0/2] Fix two possible NULL pointer dereferencing issues

Lorenzo Bianconi (2): mt76: fix possible NULL pointer dereferencing in mt76x2_ampdu_action() mt76: fix possible NULL pointer dereferencing in mt76x2_mac_write_txwi() drivers/net/wireless/mediatek/mt76/mt76x2_mac.c | 2 +- drivers/net/wireless/mediatek/mt76/mt76x2_main.c | 4 +++- 2

[PATCH 2/2] mt76: fix possible NULL pointer dereferencing in mt76x2_mac_write_txwi()

Verify wcid is not NULL before dereferencing the pointer to initialize txwi rate/power info Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x2_mac.c | 2 +- 1 file changed, 1

Re: [PATCH v3 1/3] mac80211: Add TXQ scheduling API

On 2017-10-31 12:27, Toke Høiland-Jørgensen wrote: > This adds an API to mac80211 to handle scheduling of TXQs and changes the > interface between driver and mac80211 for TXQ handling as follows: > > - The wake_tx_queue callback interface no longer includes the TXQ. Instead, > the driver is

[PATCH] mt76x2: eeprom: fix typo in mt76x2_get_power_info_5g()

Fix typo in 5GHz power vs channel eeprom parsing Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt76x2_eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] mt76: fix memcpy to potential null pointer on failed allocation

On 2017-12-14 11:13, Colin King wrote: > From: Colin Ian King > > Currently if the allocation of skb fails and returns NULL then the > call to skb_put will cause a null pointer dereference. Fix this by > checking for a null skb and returning NULL. Note that calls to >

[PATCH] mt76: fix memcpy to potential null pointer on failed allocation

From: Colin Ian King Currently if the allocation of skb fails and returns NULL then the call to skb_put will cause a null pointer dereference. Fix this by checking for a null skb and returning NULL. Note that calls to function mt76x2_mcu_msg_alloc don't directly check

Re: BCM4356 does not initalize after firmware update

On 12/13/2017 5:12 PM, Stanislaw Gruszka wrote: Hi After firmware update, this device: [0280]: Broadcom Limited BCM4356 802.11ac Wireless Network Adapter [14e4:43ec] (rev 02) no longer initialize. With the firmware update I have: [ 272.063814] brcmfmac: brcmf_fw_map_chip_to_name: using

[bug report] mt76: add driver code for MT76x2e

Hello Felix Fietkau, This is a semi-automatic email about new static checker warnings. The patch 7bc04215a66b: "mt76: add driver code for MT76x2e" from Nov 21, 2017, leads to the following Smatch complaint: drivers/net/wireless/mediatek/mt76/mt76x2_main.c:457 mt76x2_ampdu_action()

[bug report] mt76: add driver code for MT76x2e

Hello Felix Fietkau, This is a semi-automatic email about new static checker warnings. The patch 7bc04215a66b: "mt76: add driver code for MT76x2e" from Nov 21, 2017, leads to the following Smatch complaint: drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:189 mt76x2_mac_write_txwi()